danger-wcc 0.0.5 → 0.0.6
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.rubocop.yml +19 -11
- data/danger-wcc.gemspec +1 -1
- data/lib/version.rb +1 -1
- data/lib/wcc/commit_lint.rb +2 -1
- data/lib/wcc/jshint.rb +2 -2
- data/lib/wcc/plugin.rb +14 -11
- data/lib/wcc/reek.rb +2 -2
- data/lib/wcc/rubocop_exceptions.rb +13 -8
- data/lib/wcc/todos.rb +5 -4
- data/lib/wcc/utils.rb +1 -0
- data/spec/fixtures/exception_inline_disabled_rule.diff +12 -0
- data/spec/fixtures/rubocop_exception.rb +3 -0
- data/spec/wcc/commit_lint_spec.rb +5 -5
- data/spec/wcc/github_spec.rb +12 -6
- data/spec/wcc/plugin_spec.rb +17 -16
- data/spec/wcc/rubocop_exceptions_spec.rb +33 -14
- data/spec/wcc/todos_spec.rb +9 -9
- data/spec/wcc/utils_spec.rb +1 -1
- metadata +8 -6
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA1:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: a19b6ce24d61f5ff2a951f9902122eda8942c8c7
|
4
|
+
data.tar.gz: e958cfa4740a01893df04a960f902ea5eb541dfc
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 2779c8031e0b5dbcc595c07b9bec606c4daab6e94214fa1808909f80819b2f4c95358448adf93b4ec8462c5e1179c981489cfd4eb5be7f48291a4635189e62d3
|
7
|
+
data.tar.gz: 353a0fb641903e0ce67fc874114976fcd90070a5c28c9c6d81f59682926e874d1ef67236ebe0de64e75f97572353b86fa4b0398ed91155cb0254a7e8787691f4
|
data/.rubocop.yml
CHANGED
@@ -47,28 +47,36 @@ Metrics/ModuleLength:
|
|
47
47
|
- 'lib/wcc/utils.rb'
|
48
48
|
- 'spec/**/*.rb'
|
49
49
|
|
50
|
-
Naming/
|
50
|
+
Naming/MethodParameterName:
|
51
51
|
Enabled: false
|
52
52
|
|
53
53
|
Naming/MemoizedInstanceVariableName:
|
54
54
|
Enabled: false
|
55
55
|
|
56
|
-
Performance/UnfreezeString:
|
57
|
-
Exclude:
|
58
|
-
- 'spec/**/*.rb'
|
59
|
-
|
60
|
-
Style/BracesAroundHashParameters:
|
61
|
-
Enabled: false
|
62
|
-
|
63
56
|
Lint/AssignmentInCondition:
|
64
57
|
Enabled: false
|
65
58
|
|
59
|
+
Lint/RaiseException:
|
60
|
+
Enabled: true
|
61
|
+
|
62
|
+
Lint/StructNewOverride:
|
63
|
+
Enabled: true
|
64
|
+
|
66
65
|
Style/EmptyMethod:
|
67
66
|
EnforcedStyle: expanded
|
68
67
|
|
69
68
|
Style/Alias:
|
70
69
|
EnforcedStyle: prefer_alias_method
|
71
70
|
|
71
|
+
Style/HashEachMethods:
|
72
|
+
Enabled: true
|
73
|
+
|
74
|
+
Style/HashTransformKeys:
|
75
|
+
Enabled: true
|
76
|
+
|
77
|
+
Style/HashTransformValues:
|
78
|
+
Enabled: true
|
79
|
+
|
72
80
|
Style/NumericPredicate:
|
73
81
|
EnforcedStyle: comparison
|
74
82
|
|
@@ -79,13 +87,13 @@ Style/RegexpLiteral:
|
|
79
87
|
Style/SignalException:
|
80
88
|
Enabled: false
|
81
89
|
|
82
|
-
Layout/
|
90
|
+
Layout/ParameterAlignment:
|
83
91
|
EnforcedStyle: with_fixed_indentation
|
84
92
|
|
85
|
-
Layout/
|
93
|
+
Layout/FirstHashElementIndentation:
|
86
94
|
EnforcedStyle: consistent
|
87
95
|
|
88
|
-
Layout/
|
96
|
+
Layout/HashAlignment:
|
89
97
|
# allow coder to get around alignment rules by explicitly defining the hash param
|
90
98
|
EnforcedLastArgumentHashStyle: ignore_explicit
|
91
99
|
|
data/danger-wcc.gemspec
CHANGED
@@ -35,7 +35,7 @@ Gem::Specification.new do |spec|
|
|
35
35
|
spec.add_development_dependency 'webmock', '~> 3.1'
|
36
36
|
|
37
37
|
# Linting code and docs
|
38
|
-
spec.add_development_dependency 'rubocop'
|
38
|
+
spec.add_development_dependency 'rubocop', '~> 0.81'
|
39
39
|
spec.add_development_dependency 'yard'
|
40
40
|
|
41
41
|
# Makes testing easy via `bundle exec guard`
|
data/lib/version.rb
CHANGED
data/lib/wcc/commit_lint.rb
CHANGED
@@ -102,7 +102,7 @@ class Danger::DangerWCC < Danger::Plugin
|
|
102
102
|
return unless c.fail?
|
103
103
|
|
104
104
|
messaging.issue([c.message, message[:sha]].join("\n"),
|
105
|
-
|
105
|
+
severity: severity)
|
106
106
|
end
|
107
107
|
|
108
108
|
def checkers
|
@@ -141,6 +141,7 @@ class Danger::DangerWCC < Danger::Plugin
|
|
141
141
|
|
142
142
|
def warning_checks
|
143
143
|
return checks if @config[:warn] == :all
|
144
|
+
|
144
145
|
@config[:warn] || []
|
145
146
|
end
|
146
147
|
|
data/lib/wcc/jshint.rb
CHANGED
data/lib/wcc/plugin.rb
CHANGED
@@ -12,23 +12,26 @@ class Danger::DangerWCC < Danger::Plugin
|
|
12
12
|
include Utils
|
13
13
|
include Github
|
14
14
|
|
15
|
-
|
16
|
-
rubocop_exceptions
|
17
|
-
|
18
|
-
|
19
|
-
|
20
|
-
|
21
|
-
|
22
|
-
jshint
|
23
|
-
|
15
|
+
DEFAULT_OPTIONS = {
|
16
|
+
rubocop_exceptions: true,
|
17
|
+
flay: true,
|
18
|
+
todos: true,
|
19
|
+
brakeman: true,
|
20
|
+
commit_lint: false,
|
21
|
+
reek: false,
|
22
|
+
jshint: false
|
23
|
+
}.freeze
|
24
24
|
|
25
25
|
# Runs all the included checks in the plugin
|
26
26
|
def all(options = {})
|
27
|
-
|
27
|
+
options = DEFAULT_OPTIONS.merge(options)
|
28
|
+
|
29
|
+
to_run = options.keys.reject { |check_name| options[check_name] == false }
|
28
30
|
raise ArgumentError, 'No Enabled Checks' if to_run.empty?
|
29
31
|
|
30
32
|
to_run.each do |check_name|
|
31
|
-
|
33
|
+
check_options = options.fetch(check_name, {})
|
34
|
+
public_send(check_name, check_options == true ? {} : check_options)
|
32
35
|
end
|
33
36
|
end
|
34
37
|
|
data/lib/wcc/reek.rb
CHANGED
@@ -49,8 +49,8 @@ class Danger::DangerWCC < Danger::Plugin
|
|
49
49
|
|
50
50
|
line_info = with_line_number.match(/^\s*([^\:]+)\:(\d+)\:/i)
|
51
51
|
plugin.warn(format_links_as_markdown(warning.captures[0]),
|
52
|
-
|
53
|
-
|
52
|
+
file: line_info.captures[0],
|
53
|
+
line: line_info.captures[1].to_i)
|
54
54
|
end
|
55
55
|
end
|
56
56
|
end
|
@@ -6,9 +6,9 @@ class Danger::DangerWCC < Danger::Plugin
|
|
6
6
|
class RubocopExceptions
|
7
7
|
include Utils
|
8
8
|
|
9
|
-
DISABLE_REGEX = /^(?:\+\s)?.*\#\s*rubocop\:disable\s+(\S+)/i
|
10
|
-
ENABLE_REGEX = /^(?:\+\s)?\s*\#\s*rubocop\:enable\s+(\S+)/i
|
11
|
-
COMMENT_LINE_REGEX = /^(?:\+\s)?\s*\#\s*(.+)$/i
|
9
|
+
DISABLE_REGEX = /^(?:\+\s)?.*\#\s*rubocop\:disable\s+(\S+)/i.freeze
|
10
|
+
ENABLE_REGEX = /^(?:\+\s)?\s*\#\s*rubocop\:enable\s+(\S+)/i.freeze
|
11
|
+
COMMENT_LINE_REGEX = /^(?:\+\s)?\s*\#\s*(.+)$/i.freeze
|
12
12
|
|
13
13
|
def initialize(plugin, options = {})
|
14
14
|
@plugin = plugin
|
@@ -20,7 +20,7 @@ class Danger::DangerWCC < Danger::Plugin
|
|
20
20
|
message = build_message(e)
|
21
21
|
severity = message_severity(e)
|
22
22
|
issue(message,
|
23
|
-
|
23
|
+
severity: severity, file: e[:file], line: e[:disabled_at])
|
24
24
|
end
|
25
25
|
end
|
26
26
|
|
@@ -35,7 +35,7 @@ class Danger::DangerWCC < Danger::Plugin
|
|
35
35
|
else
|
36
36
|
" \nPlease provide an explanation why this rule was disabled."
|
37
37
|
end
|
38
|
-
unless e[:reenabled]
|
38
|
+
unless e[:inline] || e[:reenabled]
|
39
39
|
message += "\n\nThe rule was not reenabled!\n"\
|
40
40
|
'Please add a `rubocop:enable` comment so the rule is disabled '\
|
41
41
|
'for the minimal scope.'
|
@@ -44,7 +44,7 @@ class Danger::DangerWCC < Danger::Plugin
|
|
44
44
|
end
|
45
45
|
|
46
46
|
def message_severity(e)
|
47
|
-
if !e[:reenabled]
|
47
|
+
if !e[:inline] && !e[:reenabled]
|
48
48
|
'fail'
|
49
49
|
elsif e[:context_lines].empty?
|
50
50
|
'warn'
|
@@ -60,18 +60,23 @@ class Danger::DangerWCC < Danger::Plugin
|
|
60
60
|
end
|
61
61
|
end
|
62
62
|
|
63
|
+
# rubocop:disable Metrics/AbcSize
|
63
64
|
def make_violation(file_contents, hunk, line, rule)
|
65
|
+
is_inline_comment = !/^\s*\+?\s*\#/.match(line.content)
|
66
|
+
|
64
67
|
reenable_line_offset = find_reenable(file_contents,
|
65
|
-
|
66
|
-
|
68
|
+
line.line_number.right,
|
69
|
+
rule)
|
67
70
|
|
68
71
|
{
|
69
72
|
rule: rule,
|
70
73
|
disabled_at: line.line_number.right,
|
74
|
+
inline: is_inline_comment,
|
71
75
|
reenabled: !reenable_line_offset.nil?,
|
72
76
|
context_lines: find_context(hunk.lines.drop(hunk.lines.index(line)))
|
73
77
|
}
|
74
78
|
end
|
79
|
+
# rubocop:enable Metrics/AbcSize
|
75
80
|
|
76
81
|
def find_context(diff_lines)
|
77
82
|
# search for all non-`rubocop:` comment lines immediately
|
data/lib/wcc/todos.rb
CHANGED
@@ -6,8 +6,8 @@ class Danger::DangerWCC < Danger::Plugin
|
|
6
6
|
class Todos
|
7
7
|
include Utils
|
8
8
|
|
9
|
-
TODO_REGEX = /^\+.*\#.*TODO:?/i
|
10
|
-
LINK_REGEX = /\#.*(https?\:\/\/\S+)/i
|
9
|
+
TODO_REGEX = /^\+.*\#.*TODO:?/i.freeze
|
10
|
+
LINK_REGEX = /\#.*(https?\:\/\/\S+)/i.freeze
|
11
11
|
|
12
12
|
def initialize(plugin, options = {})
|
13
13
|
@plugin = plugin
|
@@ -26,11 +26,11 @@ class Danger::DangerWCC < Danger::Plugin
|
|
26
26
|
if result[:link]
|
27
27
|
plugin.message "TODO added in #{result[:file_link]} "\
|
28
28
|
"referencing [#{result[:link]}](#{result[:link]})",
|
29
|
-
|
29
|
+
file: result[:file], line: result[:line]
|
30
30
|
else
|
31
31
|
plugin.warn "TODO added in #{result[:file_link]} - "\
|
32
32
|
'is there a card associated with that?',
|
33
|
-
|
33
|
+
file: result[:file], line: result[:line]
|
34
34
|
end
|
35
35
|
end
|
36
36
|
|
@@ -72,6 +72,7 @@ class Danger::DangerWCC < Danger::Plugin
|
|
72
72
|
def max(a, b)
|
73
73
|
return a if b.nil?
|
74
74
|
return b if a.nil?
|
75
|
+
|
75
76
|
a > b ? a : b
|
76
77
|
end
|
77
78
|
end
|
data/lib/wcc/utils.rb
CHANGED
@@ -0,0 +1,12 @@
|
|
1
|
+
diff --git a/spec/fixtures/rubocop_exception.rb b/spec/fixtures/rubocop_exception.rb
|
2
|
+
index eee0aa0..5a0e804 100644
|
3
|
+
--- a/spec/fixtures/rubocop_exception.rb
|
4
|
+
+++ b/spec/fixtures/rubocop_exception.rb
|
5
|
+
@@ -36,4 +36,7 @@ module RubocopException
|
6
|
+
}
|
7
|
+
# rubocop:enable Layout/AlignHash
|
8
|
+
end
|
9
|
+
+
|
10
|
+
+ def some_inline_disabled_rule # rubocop:disable Rails/SomeRule
|
11
|
+
+ end
|
12
|
+
end
|
@@ -16,7 +16,7 @@ TEST_MESSAGES = {
|
|
16
16
|
'separating the subject and the body.",
|
17
17
|
all_errors: "this is a really long subject and it even ends in a period.\n'\
|
18
18
|
'Not to mention the missing empty line!",
|
19
|
-
valid:
|
19
|
+
valid: "This is a valid message\n\nYou can tell because it meets all the '\
|
20
20
|
'criteria and the linter does not complain."
|
21
21
|
}.freeze
|
22
22
|
|
@@ -130,7 +130,7 @@ module Danger
|
|
130
130
|
|
131
131
|
checks.each do |check, _|
|
132
132
|
commit = double(:commit,
|
133
|
-
|
133
|
+
message: TEST_MESSAGES[check], sha: sha)
|
134
134
|
allow(@git).to receive(:commits).and_return([commit])
|
135
135
|
|
136
136
|
commit_lint disable: [check]
|
@@ -193,7 +193,7 @@ module Danger
|
|
193
193
|
|
194
194
|
checks.each do |check, warning|
|
195
195
|
commit = double(:commit,
|
196
|
-
|
196
|
+
message: TEST_MESSAGES[check], sha: sha)
|
197
197
|
allow(@git).to receive(:commits).and_return([commit])
|
198
198
|
|
199
199
|
expect {
|
@@ -279,7 +279,7 @@ module Danger
|
|
279
279
|
|
280
280
|
checks.each do |check, warning|
|
281
281
|
commit = double(:commit,
|
282
|
-
|
282
|
+
message: TEST_MESSAGES[check], sha: sha)
|
283
283
|
allow(@git).to receive(:commits).and_return([commit])
|
284
284
|
|
285
285
|
expect {
|
@@ -367,7 +367,7 @@ module Danger
|
|
367
367
|
|
368
368
|
options.each_with_index do |(check, opts), i|
|
369
369
|
commit = double(:commit,
|
370
|
-
|
370
|
+
message: TEST_MESSAGES[:valid], sha: sha)
|
371
371
|
allow(@git).to receive(:commits).and_return([commit])
|
372
372
|
|
373
373
|
arg = {}
|
data/spec/wcc/github_spec.rb
CHANGED
@@ -37,8 +37,10 @@ module Danger
|
|
37
37
|
end
|
38
38
|
|
39
39
|
it '#add_labels adds existing labels to issue' do
|
40
|
-
stub = stub_request(
|
41
|
-
|
40
|
+
stub = stub_request(
|
41
|
+
:post,
|
42
|
+
API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels'
|
43
|
+
)
|
42
44
|
.with(body: '["backlog","bug","duplicate"]')
|
43
45
|
|
44
46
|
# act
|
@@ -49,11 +51,15 @@ module Danger
|
|
49
51
|
end
|
50
52
|
|
51
53
|
it '#add_labels creates new labels before adding to issue' do
|
52
|
-
stub = stub_request(
|
53
|
-
|
54
|
+
stub = stub_request(
|
55
|
+
:post,
|
56
|
+
API_URL + '/repos/watermarkchurch/danger-wcc/labels'
|
57
|
+
)
|
54
58
|
.with(body: '{"name":"new_label","color":"ffffff"}')
|
55
|
-
stub_request(
|
56
|
-
|
59
|
+
stub_request(
|
60
|
+
:post,
|
61
|
+
API_URL + '/repos/watermarkchurch/danger-wcc/issues/2/labels'
|
62
|
+
)
|
57
63
|
.with(body: '["backlog","new_label"]')
|
58
64
|
|
59
65
|
# act
|
data/spec/wcc/plugin_spec.rb
CHANGED
@@ -16,18 +16,21 @@ module Danger
|
|
16
16
|
end
|
17
17
|
|
18
18
|
describe 'all' do
|
19
|
-
it 'runs all
|
20
|
-
|
19
|
+
it 'runs all default and passes default options' do
|
20
|
+
%i[rubocop_exceptions flay todos brakeman].each do |check|
|
21
21
|
expect(@my_plugin).to receive(check)
|
22
22
|
.with({})
|
23
23
|
end
|
24
|
+
%i[commit_lint reek jshint].each do |check|
|
25
|
+
expect(@my_plugin).to_not receive(check)
|
26
|
+
end
|
24
27
|
|
25
28
|
# act
|
26
29
|
@my_plugin.all
|
27
30
|
end
|
28
31
|
|
29
32
|
it 'errors if all checks disabled' do
|
30
|
-
disabled = Danger::DangerWCC::
|
33
|
+
disabled = Danger::DangerWCC::DEFAULT_OPTIONS.keys
|
31
34
|
options = disabled.each_with_object({}) { |v, h| h[v] = false; }
|
32
35
|
|
33
36
|
# expect
|
@@ -42,20 +45,18 @@ module Danger
|
|
42
45
|
end
|
43
46
|
|
44
47
|
it 'runs only enabled checks' do
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
48
|
+
options = {
|
49
|
+
rubocop_exceptions: false,
|
50
|
+
todos: false,
|
51
|
+
brakeman: false,
|
52
|
+
reek: true
|
53
|
+
}
|
51
54
|
|
52
55
|
# expect
|
53
|
-
|
54
|
-
|
55
|
-
|
56
|
-
|
57
|
-
expect(@my_plugin).to_not receive(check)
|
58
|
-
end
|
56
|
+
expect(@my_plugin).to receive(:reek)
|
57
|
+
expect(@my_plugin).to receive(:flay)
|
58
|
+
expect(@my_plugin).to_not receive(:rubocop_exceptions)
|
59
|
+
expect(@my_plugin).to_not receive(:commit_lint)
|
59
60
|
|
60
61
|
# act
|
61
62
|
@my_plugin.all options
|
@@ -63,7 +64,7 @@ module Danger
|
|
63
64
|
|
64
65
|
it 'passes options' do
|
65
66
|
options =
|
66
|
-
Danger::DangerWCC::
|
67
|
+
Danger::DangerWCC::DEFAULT_OPTIONS.keys.each_with_object({}) do |v, h|
|
67
68
|
h[v] = false
|
68
69
|
end
|
69
70
|
options[:commit_lint] = { test: { options: 1 } }
|
@@ -30,9 +30,9 @@ module Danger
|
|
30
30
|
.to eq([Violation.new('Rubocop rule Rails/SomeRule disabled in '\
|
31
31
|
'<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
|
32
32
|
" \nPlease provide an explanation why this rule was disabled.",
|
33
|
-
|
34
|
-
|
35
|
-
|
33
|
+
false,
|
34
|
+
'spec/fixtures/rubocop_exception.rb',
|
35
|
+
5)])
|
36
36
|
end
|
37
37
|
|
38
38
|
it 'Errors when rubocop exception not reenabled' do
|
@@ -52,9 +52,28 @@ module Danger
|
|
52
52
|
"\n\nThe rule was not reenabled!\n"\
|
53
53
|
'Please add a `rubocop:enable` comment so the rule is disabled '\
|
54
54
|
'for the minimal scope.',
|
55
|
-
|
55
|
+
false,
|
56
|
+
'spec/fixtures/rubocop_exception.rb',
|
57
|
+
10)])
|
58
|
+
end
|
59
|
+
|
60
|
+
it 'does not require reenabling for inline comments' do
|
61
|
+
allow(@git).to receive(:diff)
|
62
|
+
.and_return([load_diff(
|
56
63
|
'spec/fixtures/rubocop_exception.rb',
|
57
|
-
|
64
|
+
'exception_inline_disabled_rule'
|
65
|
+
)])
|
66
|
+
|
67
|
+
# act
|
68
|
+
@my_plugin.rubocop_exceptions
|
69
|
+
|
70
|
+
expect(@dangerfile.violation_report[:warnings])
|
71
|
+
.to eq([Violation.new('Rubocop rule Rails/SomeRule disabled in '\
|
72
|
+
'<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
|
73
|
+
" \nPlease provide an explanation why this rule was disabled.",
|
74
|
+
false,
|
75
|
+
'spec/fixtures/rubocop_exception.rb',
|
76
|
+
40)])
|
58
77
|
end
|
59
78
|
|
60
79
|
it 'Messages when exception added with context' do
|
@@ -71,9 +90,9 @@ module Danger
|
|
71
90
|
.to eq([Violation.new('Rubocop rule Metrics/LineLength disabled in '\
|
72
91
|
'<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
|
73
92
|
" explanation:\n\t> Disabling because I want to.",
|
74
|
-
|
75
|
-
|
76
|
-
|
93
|
+
false,
|
94
|
+
'spec/fixtures/rubocop_exception.rb',
|
95
|
+
15)])
|
77
96
|
end
|
78
97
|
|
79
98
|
it 'Messages when exception added with multiline context' do
|
@@ -92,9 +111,9 @@ module Danger
|
|
92
111
|
' explanation:'\
|
93
112
|
"\n\t> I want to disable this because.."\
|
94
113
|
"\n\t> I forgot the reasons.",
|
95
|
-
|
96
|
-
|
97
|
-
|
114
|
+
false,
|
115
|
+
'spec/fixtures/rubocop_exception.rb',
|
116
|
+
30)])
|
98
117
|
end
|
99
118
|
|
100
119
|
it 'Messages when exception added in between existing comments' do
|
@@ -112,9 +131,9 @@ module Danger
|
|
112
131
|
'<a href="github_html_link">spec/fixtures/rubocop_exception.rb</a>'\
|
113
132
|
' explanation:'\
|
114
133
|
"\n\t> here is my comment why we are disabling ABC",
|
115
|
-
|
116
|
-
|
117
|
-
|
134
|
+
false,
|
135
|
+
'spec/fixtures/rubocop_exception.rb',
|
136
|
+
21)])
|
118
137
|
end
|
119
138
|
|
120
139
|
it 'Does not message when no exception added' do
|
data/spec/wcc/todos_spec.rb
CHANGED
@@ -27,9 +27,9 @@ module Danger
|
|
27
27
|
.to eq([Violation.new('TODO added in '\
|
28
28
|
'<a href="github_html_link">spec/fixtures/todo.rb</a>'\
|
29
29
|
' - is there a card associated with that?',
|
30
|
-
|
31
|
-
|
32
|
-
|
30
|
+
false,
|
31
|
+
'spec/fixtures/todo.rb',
|
32
|
+
9)])
|
33
33
|
end
|
34
34
|
|
35
35
|
it 'Does not warn when TODO removed' do
|
@@ -68,9 +68,9 @@ module Danger
|
|
68
68
|
'<a href="github_html_link">spec/fixtures/todo.rb</a> '\
|
69
69
|
'referencing [https://zube.io/watermark/asdf1234]'\
|
70
70
|
'(https://zube.io/watermark/asdf1234)',
|
71
|
-
|
72
|
-
|
73
|
-
|
71
|
+
false,
|
72
|
+
'spec/fixtures/todo.rb',
|
73
|
+
13)])
|
74
74
|
end
|
75
75
|
|
76
76
|
it 'Sends message when todo below link' do
|
@@ -87,9 +87,9 @@ module Danger
|
|
87
87
|
'<a href="github_html_link">spec/fixtures/todo.rb</a> '\
|
88
88
|
'referencing [https://www.github.com/watermarkchurch/asdf/1234]'\
|
89
89
|
'(https://www.github.com/watermarkchurch/asdf/1234)',
|
90
|
-
|
91
|
-
|
92
|
-
|
90
|
+
false,
|
91
|
+
'spec/fixtures/todo.rb',
|
92
|
+
18)])
|
93
93
|
end
|
94
94
|
end
|
95
95
|
end
|
data/spec/wcc/utils_spec.rb
CHANGED
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: danger-wcc
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 0.0.
|
4
|
+
version: 0.0.6
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Watermark Dev
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date:
|
11
|
+
date: 2020-08-10 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: brakeman
|
@@ -154,16 +154,16 @@ dependencies:
|
|
154
154
|
name: rubocop
|
155
155
|
requirement: !ruby/object:Gem::Requirement
|
156
156
|
requirements:
|
157
|
-
- - "
|
157
|
+
- - "~>"
|
158
158
|
- !ruby/object:Gem::Version
|
159
|
-
version: '0'
|
159
|
+
version: '0.81'
|
160
160
|
type: :development
|
161
161
|
prerelease: false
|
162
162
|
version_requirements: !ruby/object:Gem::Requirement
|
163
163
|
requirements:
|
164
|
-
- - "
|
164
|
+
- - "~>"
|
165
165
|
- !ruby/object:Gem::Version
|
166
|
-
version: '0'
|
166
|
+
version: '0.81'
|
167
167
|
- !ruby/object:Gem::Dependency
|
168
168
|
name: yard
|
169
169
|
requirement: !ruby/object:Gem::Requirement
|
@@ -291,6 +291,7 @@ files:
|
|
291
291
|
- spec/fixtures/brakeman/brakeman.diff
|
292
292
|
- spec/fixtures/brakeman/brakeman.out
|
293
293
|
- spec/fixtures/exception_context.diff
|
294
|
+
- spec/fixtures/exception_inline_disabled_rule.diff
|
294
295
|
- spec/fixtures/exception_insert_context.diff
|
295
296
|
- spec/fixtures/exception_misspelled.diff
|
296
297
|
- spec/fixtures/exception_multiline_context.diff
|
@@ -356,6 +357,7 @@ test_files:
|
|
356
357
|
- spec/fixtures/brakeman/brakeman.diff
|
357
358
|
- spec/fixtures/brakeman/brakeman.out
|
358
359
|
- spec/fixtures/exception_context.diff
|
360
|
+
- spec/fixtures/exception_inline_disabled_rule.diff
|
359
361
|
- spec/fixtures/exception_insert_context.diff
|
360
362
|
- spec/fixtures/exception_misspelled.diff
|
361
363
|
- spec/fixtures/exception_multiline_context.diff
|