danger-warnings_next_generation 0.0.1

data/spec/spec_helper.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require "pathname"
+ROOT = Pathname.new(File.expand_path("..", __dir__))
+$:.unshift((ROOT + "lib").to_s)
+$:.unshift((ROOT + "spec").to_s)
+
+require "bundler/setup"
+
+require "rspec"
+require "danger"
+require "mocha"
+
+require "simplecov"
+
+SimpleCov.start
+
+if `git remote -v` == ""
+  puts "You cannot run tests without setting a local git remote on this repo"
+  puts "It's a weird side-effect of Danger's internals."
+  exit(0)
+end
+
+# Use coloured output, it's the best.
+RSpec.configure do |config|
+  config.filter_gems_from_backtrace "bundler"
+  config.color = true
+  config.tty = true
+  config.mock_with :mocha
+end
+
+require "danger_plugin"
+
+# These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+# If you are expanding these files, see if it's already been done ^.
+
+# A silent version of the user interface,
+# it comes with an extra function `.string` which will
+# strip all ANSI colours from the string.
+
+# rubocop:disable Lint/NestedMethodDefinition
+def testing_ui
+  @output = StringIO.new
+  def @output.winsize
+    [20, 9999]
+  end
+
+  cork = Cork::Board.new(out: @output)
+  def cork.string
+    out.string.gsub(/\e\[([;\d]+)?m/, "")
+  end
+  cork
+end
+# rubocop:enable Lint/NestedMethodDefinition
+
+# Example environment (ENV) that would come from
+# running a PR on TravisCI
+def testing_env
+  {
+    "HAS_JOSH_K_SEAL_OF_APPROVAL" => "true",
+    "TRAVIS_PULL_REQUEST" => "800",
+    "TRAVIS_REPO_SLUG" => "artsy/eigen",
+    "TRAVIS_COMMIT_RANGE" => "759adcbd0d8f...13c4dc8bb61d",
+    "DANGER_GITHUB_API_TOKEN" => "123sbdq54erfsd3422gdfio",
+  }
+end
+
+# A stubbed out Dangerfile for use in tests
+def testing_dangerfile
+  env = Danger::EnvironmentManager.new(testing_env)
+  Danger::Dangerfile.new(env, testing_ui)
+end

data/spec/warnings_next_generation_spec.rb

@@ -0,0 +1,248 @@
+# frozen_string_literal: true
+
+require File.expand_path("spec_helper", __dir__)
+MARKDOWN_FIRST_TABLE_INDEX = 4
+JAVA_ALL_BASELINE = "/var/lib/jenkins/workspace/projectname/b2b-app-android-analyze/repository/"
+
+module Danger
+  describe Danger::DangerWarningsNextGeneration do
+    it "should be a plugin" do
+      expect(Danger::DangerWarningsNextGeneration.new(nil)).to be_a Danger::Plugin
+    end
+
+    describe "with Dangerfile" do
+      before do
+        @dangerfile = testing_dangerfile
+        @my_plugin = @dangerfile.warnings_next_generation
+      end
+
+      describe "overview_report" do
+        it "all zero displays star, zero, zero" do
+          aggregation_return("/assets/aggregation_single.json")
+          overview_return("/assets/java_zero.json")
+          @my_plugin.overview_report(include: ["java"])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 1)
+          expect(rows[MARKDOWN_FIRST_TABLE_INDEX]).to include("|:star:|0|0|")
+        end
+
+        it "new issues zero displays zero" do
+          aggregation_return("/assets/aggregation_single.json")
+          overview_return("/assets/java_zero_new.json")
+          @my_plugin.overview_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 1)
+          expect(rows[MARKDOWN_FIRST_TABLE_INDEX]).to include("|8|0|4|")
+        end
+
+        it "displays correct issue sizes" do
+          aggregation_return("/assets/aggregation_single.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 1)
+          expect(rows[MARKDOWN_FIRST_TABLE_INDEX]).to include("|3|2|1|")
+        end
+
+        it "list all entries" do
+          aggregation_return("/assets/aggregation.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 8)
+        end
+
+        it "no configuration list all entries" do
+          aggregation_return("/assets/aggregation.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 8)
+        end
+
+        it "single include adds target entry" do
+          aggregation_return("/assets/aggregation.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report(include: ["java"])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 1)
+          expect(rows[MARKDOWN_FIRST_TABLE_INDEX]).to include("Java Warnings")
+        end
+
+        it "multiple include adds valid entries" do
+          aggregation_return("/assets/aggregation.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report(include: %w(java pmd))
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 2)
+          expect(rows[MARKDOWN_FIRST_TABLE_INDEX]).to include("Java Warnings")
+          expect(rows[MARKDOWN_FIRST_TABLE_INDEX + 1]).to include("PMD Warnings")
+        end
+
+        it "empty includes add no overview" do
+          aggregation_return("/assets/aggregation.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report(include: [])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(0)
+        end
+
+        it "wrong includes add no overview" do
+          aggregation_return("/assets/aggregation.json")
+          overview_return("/assets/java.json")
+          @my_plugin.overview_report(include: ["not_existing"])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(0)
+        end
+      end
+
+      describe "tools_report" do
+        it "list all entries" do
+          aggregation_return("/assets/aggregation_single.json")
+          details_return("/assets/java_all.json")
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+
+          rows = markdowns.first.message.split("\n")
+          expect(rows.length).to be(MARKDOWN_FIRST_TABLE_INDEX + 8)
+        end
+
+        it "no configuration list all warnings reports" do
+          aggregation_return("/assets/aggregation.json")
+          details_return("/assets/java_all.json")
+          @my_plugin.tools_report
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(8)
+        end
+
+        it "single include adds table" do
+          aggregation_return("/assets/aggregation.json")
+          details_return("/assets/java_all.json")
+          @my_plugin.tools_report(include: ["java"])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(1)
+          expect(markdowns.first.message).to include("Java Warnings")
+        end
+
+        it "multiple include adds table for each" do
+          aggregation_return("/assets/aggregation.json")
+          details_return("/assets/java_all.json")
+          @my_plugin.tools_report(include: %w(java pmd))
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(2)
+
+          expect(markdowns[0].message).to include("Java Warnings")
+          expect(markdowns[1].message).to include("PMD Warnings")
+        end
+
+        it "empty includes add no overview" do
+          aggregation_return("/assets/aggregation.json")
+          details_return("/assets/java_all.json")
+          @my_plugin.tools_report(include: [])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(0)
+        end
+
+        it "wrong includes add no overview" do
+          aggregation_return("/assets/aggregation.json")
+          details_return("/assets/java_all.json")
+          @my_plugin.tools_report(include: ["not_existing"])
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(0)
+        end
+
+        it "inline missing baseline raises error" do
+          aggregation_return("/assets/aggregation_single.json")
+          details_return("/assets/java_all.json")
+          expect { @my_plugin.tools_report(inline: true) }.to raise_error(/set 'baseline'/)
+        end
+
+        it "creates inline comments" do
+          aggregation_return("/assets/aggregation_single.json")
+          details_return("/assets/java_all.json")
+          target_files_return_java_all
+          @my_plugin.tools_report(inline: true, baseline: JAVA_ALL_BASELINE)
+
+          markdowns = @dangerfile.status_report[:markdowns]
+          expect(markdowns.length).to be(0)
+
+          messages = @dangerfile.status_report[:messages]
+          expect(messages.length).to be(8)
+        end
+
+        it "inline comments remove baseline" do
+          aggregation_return("/assets/aggregation_single.json")
+          details_return("/assets/java_all.json")
+          target_files_return_java_all
+          @my_plugin.tools_report(inline: true, baseline: JAVA_ALL_BASELINE)
+
+          message = @dangerfile.violation_report[:messages].first
+          expect(message.file).not_to include(JAVA_ALL_BASELINE)
+          expect(message.file.chars.first).not_to eql("/")
+        end
+      end
+    end
+  end
+end
+
+def aggregation_return(file)
+  content = File.read(File.dirname(__FILE__) + file)
+  json = JSON.parse(content)
+  @my_plugin.stubs(:aggregation_result).returns(json)
+end
+
+def overview_return(file)
+  content = File.read(File.dirname(__FILE__) + file)
+  json = JSON.parse(content)
+  @my_plugin.stubs(:overview_result).returns(json)
+end
+
+def details_return(file)
+  content = File.read(File.dirname(__FILE__) + file)
+  json = JSON.parse(content)
+  @my_plugin.stubs(:details_result).returns(json)
+end
+
+def target_files_return_java_all
+  @my_plugin.stubs(:target_files).returns(["app/src/main/java/com/projectname/b2bshop/fragment/gallery/ImageGalleryFragment.kt",
+                                           "app/src/main/java/com/projectname/b2bshop/webservice/requestqueue/RequestQueue.java",
+                                           "app/src/main/java/com/projectname/b2bshop/webservice/requestqueue/RequestQueueImpl.java",
+                                           "app/src/main/java/com/projectname/b2bshop/fragment/ProductDetailPageFragment.kt"])
+end

metadata

@@ -0,0 +1,227 @@
+--- !ruby/object:Gem::Specification
+name: danger-warnings_next_generation
+version: !ruby/object:Gem::Version
+  version: 0.0.1
+platform: ruby
+authors:
+- Martin Schwamberger
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2019-05-16 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: danger-plugin-api
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '12.3'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: simplecov-console
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.68'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.68'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.9'
+description: Danger plugin to for Jenkins-Warnings-Next-Generation plugin.
+email:
+- kyaak.dev@gmail.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".rubocop.yml"
+- ".travis.yml"
+- Gemfile
+- LICENSE.txt
+- README.md
+- Rakefile
+- danger-warnings_next_generation.gemspec
+- lib/danger_plugin.rb
+- lib/danger_warnings_next_generation.rb
+- lib/warnings_next_generation/gem_version.rb
+- lib/warnings_next_generation/markdown_table.rb
+- lib/warnings_next_generation/plugin.rb
+- sonar-project.properties
+- spec/assets/aggregation.json
+- spec/assets/aggregation_single.json
+- spec/assets/example/aggregation.json
+- spec/assets/example/detail_android_lint.json
+- spec/assets/example/detail_detekt.json
+- spec/assets/example/detail_pmd.json
+- spec/assets/example/overview_android_lint.json
+- spec/assets/example/overview_detekt.json
+- spec/assets/example/overview_pmd.json
+- spec/assets/java.json
+- spec/assets/java_all.json
+- spec/assets/java_zero.json
+- spec/assets/java_zero_new.json
+- spec/spec_helper.rb
+- spec/warnings_next_generation_spec.rb
+homepage: https://github.com/Kyaak/danger-warnings_next_generation
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: 2.3.0
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubygems_version: 3.0.3
+signing_key: 
+specification_version: 4
+summary: Read Jenkins warnings-ng reports and comment pull request with found issues.
+test_files:
+- spec/assets/aggregation.json
+- spec/assets/aggregation_single.json
+- spec/assets/example/aggregation.json
+- spec/assets/example/detail_android_lint.json
+- spec/assets/example/detail_detekt.json
+- spec/assets/example/detail_pmd.json
+- spec/assets/example/overview_android_lint.json
+- spec/assets/example/overview_detekt.json
+- spec/assets/example/overview_pmd.json
+- spec/assets/java.json
+- spec/assets/java_all.json
+- spec/assets/java_zero.json
+- spec/assets/java_zero_new.json
+- spec/spec_helper.rb
+- spec/warnings_next_generation_spec.rb