danger-warnings 0.0.1 → 0.1.0

data/spec/warnings_spec.rb

@@ -17,11 +17,6 @@ module Danger
       before do
         @dangerfile = testing_dangerfile
         @my_plugin = @dangerfile.warnings
-
-        # mock the PR data
-        # you can then use this, eg. github.pr_author, later in the spec
-        # json = File.read(File.dirname(__FILE__) + '/support/fixtures/github_pr.json') # example json: `curl https://api.github.com/repos/danger/danger-plugin-template/pulls/18 > github_pr.json`
-        # allow(@my_plugin.github).to receive(:pr_json).and_return(json)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-warnings
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Kyaak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-21 00:00:00.000000000 Z
+date: 2019-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abstract_method
@@ -217,6 +217,7 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
+- Dangerfile
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -226,25 +227,34 @@ files:
 - lib/danger_plugin.rb
 - lib/danger_warnings.rb
 - lib/warnings/gem_version.rb
-- lib/warnings/issue.rb
-- lib/warnings/markdown_util.rb
+- lib/warnings/helper/message_util.rb
+- lib/warnings/helper/severity_util.rb
 - lib/warnings/parser/bandit_parser.rb
 - lib/warnings/parser/parser.rb
 - lib/warnings/parser/parser_factory.rb
+- lib/warnings/parser/pylint_parser.rb
+- lib/warnings/parser/rubocop_parser.rb
 - lib/warnings/plugin.rb
-- lib/warnings/reporter.rb
-- lib/warnings/severity.rb
+- lib/warnings/report/issue.rb
+- lib/warnings/report/reporter.rb
 - sonar-project.properties
-- spec/assets/assets.rb
 - spec/assets/bandit.json
 - spec/assets/bandit_empty.json
 - spec/assets/bandit_missing_results.json
-- spec/markdown_util_spec.rb
+- spec/assets/empty.txt
+- spec/assets/pylint.txt
+- spec/assets/rubocop.json
+- spec/assets/rubocop.txt
+- spec/assets/rubocop_multi_offenses.json
+- spec/helper/message_util_spec.rb
+- spec/helper/severity_util_spec.rb
 - spec/parser/bandit_parser_spec.rb
 - spec/parser/parser_factory_spec.rb
-- spec/reporter_spec.rb
-- spec/severity_spec.rb
+- spec/parser/pylint_parser_spec.rb
+- spec/parser/rubocop_parser_spec.rb
+- spec/report/reporter_spec.rb
 - spec/spec_helper.rb
+- spec/spec_helper/assets.rb
 - spec/warnings_spec.rb
 homepage: https://github.com/Kyaak/danger-warnings
 licenses:
@@ -270,14 +280,21 @@ signing_key:
 specification_version: 4
 summary: Report lint warnings of different tools.
 test_files:
-- spec/assets/assets.rb
 - spec/assets/bandit.json
 - spec/assets/bandit_empty.json
 - spec/assets/bandit_missing_results.json
-- spec/markdown_util_spec.rb
+- spec/assets/empty.txt
+- spec/assets/pylint.txt
+- spec/assets/rubocop.json
+- spec/assets/rubocop.txt
+- spec/assets/rubocop_multi_offenses.json
+- spec/helper/message_util_spec.rb
+- spec/helper/severity_util_spec.rb
 - spec/parser/bandit_parser_spec.rb
 - spec/parser/parser_factory_spec.rb
-- spec/reporter_spec.rb
-- spec/severity_spec.rb
+- spec/parser/pylint_parser_spec.rb
+- spec/parser/rubocop_parser_spec.rb
+- spec/report/reporter_spec.rb
 - spec/spec_helper.rb
+- spec/spec_helper/assets.rb
 - spec/warnings_spec.rb

data/lib/warnings/severity.rb

@@ -1,12 +0,0 @@
-module Warnings
-  # Defines severity levels and provides helper methods.
-  class Severity
-    SEVERITIES = %i(low medium high).freeze
-
-    def self.valid?(value)
-      key = value
-      key = value.to_sym if value.method_exists?(:to_sym)
-      SEVERITIES.include?(key)
-    end
-  end
-end

data/spec/assets/assets.rb

@@ -1,8 +0,0 @@
-module Warnings
-  module Assets
-    ASSETS_DIR = Pathname.new(File.expand_path('.', __dir__))
-    BANDIT_JSON = "#{ASSETS_DIR}/bandit.json".freeze
-    BANDIT_EMPTY = "#{ASSETS_DIR}/bandit_empty.json".freeze
-    BANDIT_MISSING_RESULTS = "#{ASSETS_DIR}/bandit_missing_results.json".freeze
-  end
-end

data/spec/markdown_util_spec.rb

@@ -1,65 +0,0 @@
-require_relative 'spec_helper'
-require_relative '../lib/warnings/markdown_util'
-
-module Warnings
-  describe Warnings::MarkdownUtil do
-    MARKDOWN_TEST_REPORT_NAME = 'My Report Name'.freeze
-
-    context '#generate' do
-      context 'header' do
-        it 'adds header name at first line' do
-          result = MarkdownUtil.generate(MARKDOWN_TEST_REPORT_NAME, [])
-          header_name = result.split(MarkdownUtil::LINE_SEPARATOR).first
-          expect(header_name).to eq("# #{MARKDOWN_TEST_REPORT_NAME}")
-        end
-
-        it 'adds table header at second line' do
-          result = MarkdownUtil.generate(MARKDOWN_TEST_REPORT_NAME, [])
-          table_header = result.split(MarkdownUtil::LINE_SEPARATOR)[1]
-          expect(table_header).to eq(MarkdownUtil::TABLE_HEADER)
-        end
-
-        it 'adds table separator at third line' do
-          result = MarkdownUtil.generate(MARKDOWN_TEST_REPORT_NAME, [])
-          table_header = result.split(MarkdownUtil::LINE_SEPARATOR)[2]
-          expect(table_header).to eq(MarkdownUtil::TABLE_SEPARATOR)
-        end
-      end
-
-      context 'with issues' do
-        before do
-          @issue = Issue.new
-          @issue.severity = :low
-          @issue.name = 'blacklist'
-          @issue.file_name = 'hello/test.py'
-          @issue.message = 'Consider possible security implications associated with pickle module.'
-          @issue.line = 1234
-          @issue.id = 'B403'
-
-          result = MarkdownUtil.generate(MARKDOWN_TEST_REPORT_NAME, [@issue])
-          @issue_line = result.split(MarkdownUtil::LINE_SEPARATOR)[3]
-          @issue_columns = @issue_line.split(MarkdownUtil::COLUMN_SEPARATOR)
-        end
-
-        it 'first column contains severity upcase' do
-          text = @issue_columns[0]
-          expect(text).not_to be_nil
-          expect(text).to eq(@issue.severity.to_s.capitalize)
-        end
-
-        it 'second column contains filename:line' do
-          text = @issue_columns[1]
-          expect(text).not_to be_nil
-          expect(text).to eq("#{@issue.file_name}:#{@issue.line}")
-        end
-
-        it 'third column contains [id-name]' do
-          text = @issue_columns[2]
-          expect(text).not_to be_nil
-          match = text.match(/^\[#{@issue.id}-#{@issue.name}\]/)
-          expect(match).not_to be_nil
-        end
-      end
-    end
-  end
-end

data/spec/severity_spec.rb

@@ -1,26 +0,0 @@
-require_relative 'spec_helper'
-require_relative '../lib/warnings/severity'
-
-module Warnings
-  describe Severity do
-    context 'valid severity' do
-      it 'low' do
-        expect(Severity.valid?(:low)).to be_truthy
-      end
-
-      it 'medium' do
-        expect(Severity.valid?(:medium)).to be_truthy
-      end
-
-      it 'high' do
-        expect(Severity.valid?(:high)).to be_truthy
-      end
-    end
-
-    context 'invalid severity' do
-      it 'is not valid' do
-        expect(Severity.valid?(:unknown)).not_to be_truthy
-      end
-    end
-  end
-end