danger-todoist 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 910d2aa0929cc3af3260a88dfbf1a98fe27f3435
-  data.tar.gz: 18aa2c8dafb84287ff5e97051cb7d31f2cae6b8e
+  metadata.gz: d941d9cf8a4d93953bd2fdd630461f6c40c6b900
+  data.tar.gz: f2b5c54ec7d8f496f72305e5d1aed1e12ff82b5e
 SHA512:
-  metadata.gz: c52239b8a95725323d644886222bd174f3a5cc90d57ffde7b37a0b750ef8269aada7977dc557b1bf29a3459a0b2943c7c07e1473813686ef0471b4f658f07daf
-  data.tar.gz: 5e2a73ded27db0de67804511aa9cb7d23892f6725e1f3c3f70c09d8b1210571780aaf0e6c7b9fc3ca612900acf015ace3bf072f100bc5aafdc1d10cdc0bc864e
+  metadata.gz: c48ca6ecb0f9cb8953314f1f8e80c2ba62b9e340ab7c513286849e26a17359b40e62eb681405f5b07bc9250450c8464fa5bc5f34746d5572571cc31270d31dc9
+  data.tar.gz: a93783d880b1e71d429e324490bed8b6e4fa1752ac9368a2fb9100c6ed0a3be3f137037999836fb00378382b64d662df05410ef9724ba0baa23f2bf7474282b7

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## master
 
+## 1.2.2
+
+rescue from exception in git gem - hanneskaeufler
+update documentation in readme - hanneskaeufler
+
 ## 1.2.1
 
 * fix issue #32 crash on nil - hanneskaeufler

data/README.md

@@ -45,6 +45,8 @@ todoist.todos.each { |todo| puts todo.text }</pre>
 
 `message` - Message to be shown
 
+`keywords` - Keywords to recognize as todos
+
 #### Methods
 
 `warn_for_todos` - Adds a warning if there are todos found in the modified code

data/lib/todoist/gem_version.rb

@@ -1,3 +1,3 @@
 module Todoist
-  VERSION = "1.2.1".freeze
+  VERSION = "1.2.2".freeze
 end

data/lib/todoist/plugin.rb

@@ -128,9 +128,26 @@ module Danger
     # into the files_of_interest. We have to make sure to only
     # try to look up diffs for actual filepaths (strings)
     def diffs_of_interest
-      files_of_interest
-        .select { |file| file.is_a?(String) }
-        .map { |file| git.diff_for_file(file) }
+      files_of_interest.map do |file|
+        diff = EmptyDiff.new
+        begin
+          diff = git.diff_for_file(file)
+        rescue
+          log_unable_to_find_diff(file.inspect)
+        end
+        diff
+      end
+    end
+
+    def log_unable_to_find_diff(file)
+      markdown("* danger-todoist was unable to determine diff for \"#{file}\".")
+    end
+  end
+
+  # Null object incase a diff cannot be determined
+  class EmptyDiff
+    def patch
+      ""
     end
   end
 end

data/spec/todoist_spec.rb

@@ -131,12 +131,21 @@ PATCH
         expect(markdowns).to be_empty
       end
 
-      it "does not raise when git returns nil" do
+      it "does not raise when git raises, but warns" do
         invalid = [nil, 0, false]
         allow(@dangerfile.git).to receive(:modified_files).and_return(invalid)
         allow(@dangerfile.git).to receive(:added_files).and_return(invalid)
 
         expect { @todoist.warn_for_todos }.to_not raise_error
+        expect(markdowns).to include(
+          "* danger-todoist was unable to determine diff for \"nil\"."
+        )
+        expect(markdowns).to include(
+          "* danger-todoist was unable to determine diff for \"0\"."
+        )
+        expect(markdowns).to include(
+          "* danger-todoist was unable to determine diff for \"false\"."
+        )
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-todoist
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Hannes Käufler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-27 00:00:00.000000000 Z
+date: 2017-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api