danger-todoist 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd9c28016359b27e3cc65bfee31b76086743db32
-  data.tar.gz: 6f24675207d0aef9ce0ef092fca5b8431d91327c
+  metadata.gz: f1e9980c94b66c3424c2c4229d33003af8ac52e4
+  data.tar.gz: 59d1fb67dfdfdcf71d4fd6dafdc3650f09e8e686
 SHA512:
-  metadata.gz: d67dc9615ec24a7e81100f9855194a0d07c97ff6fbae3cf9f4a4582486a310c7e86ece35d497a31f9dbe9d0d445bfe3c77c79b3c6ff880a6defeeda2f8a4e697
-  data.tar.gz: 82c158c181261b48cdefa2d5918aa999be4514ec4ca5f3edadfc0c0014b773855818b66e0187e3dc3764defa80e0140565e90c9800fc3ab05ac0b6022d81175d
+  metadata.gz: 3fc3677d54b4ea66ea5b34a3d07fe0dd619ec6883279a6db30b06a5f3b6aec96000fae6d3109e477184e418c789f4967923015ab16e3064f3c2d3fd600ce00c0
+  data.tar.gz: 17317745f04f1c8afc2747d2f2c671e6a5ce86d9614d973daba9a755bdd77d0f0d566dd8fddfb0123f99ee8625f8e872ad4c1cb7b7eb84315836771163d9b659

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## master
 
+## 1.0.1
+
+* fix bug where `+ TODO` would be identified as todo - hanneskaeufler
+
 ## 1.0.0
 
 * group todos by file - hanneskaeufler

data/lib/todoist/diff_todo_finder.rb

@@ -4,7 +4,7 @@ module Danger
     TODO_REGEXP = /
       ^\+                 # we only look at additions, marked by + in diffs
       \s*                 # followed by optional space
-      [^a-z0-9\+]*        # anything looking like a comment indicator, not a +
+      [^a-z0-9\+\s]+      # anything looking like a comment indicator
       \s+                 # followed by at least one space
       (TODO|FIXME)        # our todo indicator
       [\s:]{1}            # followed by a space or colon

data/lib/todoist/gem_version.rb

@@ -1,3 +1,3 @@
 module Todoist
-  VERSION = "1.0.0".freeze
+  VERSION = "1.0.1".freeze
 end

data/spec/diff_todo_finder_spec.rb

@@ -21,7 +21,8 @@ module Danger
         end
       end
 
-      %w(# {{ -- //).each do |comment|
+      # those comment indicators are ripped off https://github.com/pgilad/leasot
+      %w(# {{ -- // /* <!-- <%# % / -# {{! {{!-- {# <%--).each do |comment|
         it "identifies todos in languages with '#{comment}' as comments" do
           diffs = [
             Git::Diff::DiffFile.new(
@@ -59,7 +60,10 @@ module Danger
         "+ * this looks like a todo but isnt",
         "+ TODO_REGEXP = /",
         "+          todos = subject.find_diffs_containing_todos(diffs)",
-        "++ # FIXME: with you the force is"
+        "++ # FIXME: with you the force is",
+        "+ TODO: foo",
+        "+ TODO",
+        "+   TODO: something"
       ].each do |patch|
         it "does not identify occurences in '#{patch}'" do
           diffs = [
@@ -112,6 +116,26 @@ PATCH
         expect(todos.map(&:text))
           .to eql(["practice you must", "with you the force is"])
       end
+
+      it "finds todos in multiline comments" do
+        patch = <<PATCH
++ /*
++  TODO: something
++ */
+PATCH
+
+        diffs = [
+          Git::Diff::DiffFile.new(
+            "base",
+            path:  "some/file.rb",
+            patch: patch
+          )
+        ]
+
+        todos = subject.find_diffs_containing_todos(diffs)
+
+        expect(todos.map(&:text)).to eql(["something"])
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-todoist
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Hannes Käufler