danger-the_coding_love 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 23aeb56cda3b0073c6f179ed2af2f688b7c4518f
-  data.tar.gz: 5eda7adf073dc0e3b02772b62090f5dec4ad0f22
+SHA256:
+  metadata.gz: c000079295312c28efe06f6198dee7fd9df969a91778f9df8698e9fccec97a97
+  data.tar.gz: 431605a4ad0757b66bc70dc2d07f5bb0645a5aa10ed6969def96b525ba8c8e0d
 SHA512:
-  metadata.gz: c27cff9c34bceffc61c176a6d9dfdb0870ace4aed2711e68569a1e271bf3c87576943203efc520f723465e4d9932c37bbdd15251d1e3f7905c3ec56f5cebf37e
-  data.tar.gz: ad73778a67959a6719e9a23afec2146a14ae5b26d11c7b86d156a88a85e99018f9784de177726971748ff376625492cb82091ed3e97680ed61245ff180664e78
+  metadata.gz: ce85980c614cd0ef9f41264aa0471e6aeb84f2735496b04fdfad839e0cb21bfd1deab4cf55e34c65e9895af6650404b70e04c0e48a823609d7533358cc1c397e
+  data.tar.gz: ac9bccae7b2ef6e2d4797070187ed58751faf11db8c23899cd18da7db53846e7be39e91b23eae74bf6ac09edae9b47b453dd014545fa113149b9f14c0d5c3900

data/.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 pkg
 .idea/
+.yardoc/

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-the_coding_love (0.0.5)
+    danger-the_coding_love (0.0.6)
       danger-plugin-api (~> 1.0)
       nokogiri
 

data/danger-the_coding_love.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
-  spec.add_runtime_dependency 'nokogiri'
+  spec.add_runtime_dependency 'nokogiri', '>= 1.8.5'
 
   # General ruby development
   spec.add_development_dependency 'bundler', '~> 1.3'
@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.4'
 
   # Linting code and docs
-  spec.add_development_dependency "yard", "~> 0.8"
+  spec.add_development_dependency "yard", ">= 0.9.11"
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'

data/lib/the_coding_love/gem_version.rb

@@ -1,3 +1,3 @@
 module TheCodingLove
-  VERSION = "0.0.5".freeze
+  VERSION = "0.0.6".freeze
 end

data/lib/the_coding_love/plugin.rb

@@ -18,22 +18,37 @@ module Danger
       require 'open-uri'
       require 'nokogiri'
 
-      @main_page_doc = Nokogiri::HTML(open("https://thecodinglove.com"))
-      random_gif_page_url = @main_page_doc.at_xpath("//a[@class='nav-link']/@href").to_s
-      
-      @doc = Nokogiri::HTML(open(random_gif_page_url))
-      @doc = @doc.at_xpath("//div[@class='blog-post']")
+      @main_page_doc = Nokogiri::HTML(open('https://thecodinglove.com'))
+      random_love_page_url = @main_page_doc.at_xpath("//a[@class='nav-link']/@href").to_s
 
-      text = @doc.at_xpath("//h1").text
-      image_url = @doc.at_xpath("//div[@class='blog-post-content']/p/img/@src").to_s
+      text, image_url = atUrl(random_love_page_url)
 
       markdown("------\n#{text}\n--\n![alt text](#{image_url} \"thecodinglove.com\")")
 
-      return text, image_url
+      [text, image_url]
+    end
+
+    # Returns text and url containing given post from thecodinglove.com url
+    #
+    # @return  [text, image_url]
+    #
+    def atUrl(love_page_url)
+      @doc = Nokogiri::HTML(open(love_page_url))
+      @doc = @doc.at_xpath("//div[@class='blog-post']")
+
+      text = @doc.at_xpath('//h1').text
+      image_url = @doc.at_xpath("//div[@class='blog-post-content']/p/img/@src").to_s
+      video_gif_url = @doc.at_xpath("//div[@class='blog-post-content']/p/video//object[@type='image/gif']/@data").to_s
+
+      if image_url.empty?
+        return [text, video_gif_url]
+      else
+        return [text, image_url]
+      end
     end
 
     def self.instance_name
-      to_s.gsub("Danger", "").danger_underscore.split("/").last
+      to_s.gsub('Danger', '').danger_underscore.split('/').last
     end
   end
 end

data/spec/the_coding_love_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerTheCodingLove do
@@ -12,11 +12,29 @@ module Danger
         @the_coding_love = @dangerfile.the_coding_love
       end
 
-      it "prints a random post" do
+      it 'prints a random post' do
         post = @the_coding_love.random
 
-        expect(post[0]).not_to be_nil
-        expect(post[1]).not_to be_nil
+        expect(post[0]).not_to be_empty
+        expect(post[1]).not_to be_empty
+        expect(@dangerfile.status_report[:markdowns]).not_to be_nil
+      end
+
+      it 'prints an image post' do
+        post = @the_coding_love.atUrl('https://thecodinglove.com/ai-in-cars-is-getting-better')
+
+        expect(post[0]).not_to be_empty
+        expect(post[1]).not_to be_empty
+        expect(File.extname(post[1]).strip.downcase).to eq '.jpg'
+        expect(@dangerfile.status_report[:markdowns]).not_to be_nil
+      end
+
+      it 'prints a gif post' do
+        post = @the_coding_love.atUrl('https://thecodinglove.com/when-i-commit-push-right-after-someone-has')
+
+        expect(post[0]).not_to be_empty
+        expect(post[1]).not_to be_empty
+        expect(File.extname(post[1]).strip.downcase).to eq '.gif'
         expect(@dangerfile.status_report[:markdowns]).not_to be_nil
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-the_coding_love
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Valerio Mazzeo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-31 00:00:00.000000000 Z
+date: 2019-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.8.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.8.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -84,16 +84,16 @@ dependencies:
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Prints markdown containing a random post from thecodinglove.com.