danger-textlint 1.1.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2382053d93e9c0e1eed4097159796a353a3bd9276fa9a44e4d2d407712e6045
-  data.tar.gz: 8d9bbb9847bdb36c5adda08c680deb2eaf48c9a64886a834bb1fed0ee33b207a
+  metadata.gz: ccf323fb77d25bc1bade56d96fc8dc3456fee206c12ba5267fb56409bf134844
+  data.tar.gz: 331557efb9c25959b393c29206bfc6b57e8d72425dc7a67b391b774e409e5c2f
 SHA512:
-  metadata.gz: 19e222aa434bd619b2362c147607ffd6cbd84ca4485358596eba26df6e7331e1f232a8109b800b8931cefa8a7ed79987e6c5e04cf85827fb52fa21bfa0db9698
-  data.tar.gz: 4a34ed18e8280a83de8b755b1ace97cf5ee9fff674f9e2cd8f059ac88dea0341482b5f98755efec0bcd5bc59a69768704b4fbf11eb12905b3560c3662d232e20
+  metadata.gz: 10c90d66a45ef436816d8df8d2f8fa38ee42a14d6065309d08ec8a7514b06bcb19b964204b5d14418d4b7572c6b748f1c52b12edcf872b91aa7b41800291f419
+  data.tar.gz: 4d2265bf02c94c8a19e47a12b48fcc28813c8d50a5d145a59041dc59e59525d39cdce2c9eb6afc00e73a531c0b7c1b796491a44f359b405f3ae4c3787525e9c4

data/.dependabot/config.yml

@@ -0,0 +1,18 @@
+version: 1
+
+update_configs:
+  - package_manager: "ruby:bundler"
+    directory: "/"
+    update_schedule: "monthly"
+
+    allowed_updates:
+      - match:
+          update_type: "security"
+    automerged_updates:
+      - match:
+          dependency_type: "all"
+          update_type: "security:patch"
+      - match:
+          dependency_type: "development"
+          update_type: "semver:minor"
+    version_requirement_updates: "off"

data/.devcontainer/Dockerfile

@@ -0,0 +1,18 @@
+# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.134.1/containers/ruby/.devcontainer/base.Dockerfile
+ARG VARIANT="2"
+FROM mcr.microsoft.com/vscode/devcontainers/ruby:0-${VARIANT}
+
+# [Optional] Install a version of Node.js using nvm for front end dev
+ARG INSTALL_NODE="true"
+ARG NODE_VERSION="lts/*"
+RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "source /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
+
+# [Optional] Uncomment this section to install additional OS packages.
+RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
+    && apt-get -y install --no-install-recommends git vim
+
+# [Optional] Uncomment this line to install additional gems.
+# RUN gem install <your-gem-names-here>
+
+# [Optional] Uncomment this line to install global node packages.
+# RUN su vscode -c "source /usr/local/share/nvm/nvm.sh && npm install -g <your-package-here>" 2>&1

data/.devcontainer/devcontainer.json

@@ -0,0 +1,35 @@
+// For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
+// https://github.com/microsoft/vscode-dev-containers/tree/v0.134.1/containers/ruby
+{
+	"name": "Ruby",
+	"build": {
+		"dockerfile": "Dockerfile",
+		"args": { 
+			// Update 'VARIANT' to pick a Ruby version: 2, 2.7, 2.6, 2.5
+			"VARIANT": "2.7",
+			// Options
+			"INSTALL_NODE": "true",
+			"NODE_VERSION": "lts/*"
+		}
+	},
+
+	// Set *default* container specific settings.json values on container create.
+	"settings": { 
+		"terminal.integrated.shell.linux": "/bin/bash"
+	},
+
+	// Add the IDs of extensions you want installed when the container is created.
+	"extensions": [
+		"rebornix.Ruby"
+	]
+	
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	// "postCreateCommand": "ruby --version",
+
+	// Uncomment to connect as a non-root user. See https://aka.ms/vscode-remote/containers/non-root.
+	// "remoteUser": "vscode"
+
+}

data/.github/dependabot.yml

@@ -0,0 +1,12 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "bundler" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "monthly"
+      timezone: "Asia/Tokyo"

data/.github/workflows/ci.yml

@@ -0,0 +1,29 @@
+name: CI
+on: [push]
+
+jobs:
+  test:
+    name: Test
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        image: [ 'ruby:2.5', 'ruby:2.6', 'ruby:2.7' ]
+    container:
+      image: ${{ matrix.image }}
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Setup bundler
+      run: gem install bundler
+    
+    - name: bundle install
+      run: bundle install --jobs=4 --retry=3 --path=./vendor
+      
+    - name: Show versions
+      run: |
+        ruby --version
+        bundle --version
+
+    - name: test
+      run: bundle exec rake spec

data/.rubocop.yml

@@ -3,7 +3,8 @@
 # If you don't like these settings, just delete this file :)
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.7
+  NewCops: disable
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
@@ -13,20 +14,16 @@ Style/StringLiterals:
 Style/ClassCheck:
   EnforcedStyle: kind_of?
 
-# It's better to be more explicit about the type
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 # specs sometimes have useless assignments, which is fine
 Lint/UselessAssignment:
   Exclude:
     - '**/spec/**/*'
 
 # We could potentially enable the 2 below:
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 # HoundCI doesn't like this rule
@@ -130,7 +127,7 @@ Style/MixinGrouping:
 Naming/FileName:
   Enabled: false
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 Style/SpecialGlobalVars:
@@ -153,3 +150,6 @@ Security/YAMLLoad:
 
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false

data/Gemfile.lock

@@ -1,47 +1,50 @@
 PATH
   remote: .
   specs:
-    danger-textlint (1.1.0)
+    danger-textlint (2.0.1)
       danger-plugin-api (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
-    ast (2.4.0)
-    claide (1.0.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.1)
+    bump (0.9.0)
+    claide (1.0.3)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.2)
+    coderay (1.1.3)
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.5.10)
+    danger (8.0.5)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
-      faraday (~> 0.9)
-      faraday-http-cache (~> 1.0)
-      git (~> 1)
-      kramdown (~> 1.5)
+      faraday (>= 0.9.0, < 2.0)
+      faraday-http-cache (~> 2.0)
+      git (~> 1.7)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
       octokit (~> 4.7)
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.3)
-    faraday (0.14.0)
+    faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    faraday-http-cache (1.3.1)
-      faraday (~> 0.8)
-    ffi (1.9.21)
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    ffi (1.13.1)
     formatador (0.2.5)
-    git (1.3.0)
-    guard (2.14.2)
+    git (1.7.0)
+      rchardet (~> 1.8)
+    guard (2.16.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -55,80 +58,91 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.16.2)
-    listen (3.0.7)
-      rb-fsevent (>= 0.9.3)
-      rb-inotify (>= 0.9.7)
-    lumberjack (1.0.12)
-    method_source (0.9.0)
-    multipart-post (2.0.0)
+    kramdown (2.3.0)
+      rexml
+    kramdown-parser-gfm (1.1.0)
+      kramdown (~> 2.0)
+    listen (3.2.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.5)
+    method_source (1.0.0)
+    multipart-post (2.1.1)
     nap (1.1.0)
     nenv (0.3.0)
     no_proxy_fix (0.1.2)
-    notiffany (0.1.1)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.8.0)
+    octokit (4.18.0)
+      faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
-    parallel (1.12.1)
-    parser (2.4.0.2)
-      ast (~> 2.3)
-    powerpack (0.1.1)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    public_suffix (3.0.2)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    public_suffix (4.0.6)
     rainbow (3.0.0)
-    rake (10.5.0)
-    rb-fsevent (0.10.2)
-    rb-inotify (0.9.10)
-      ffi (>= 0.5.0, < 2)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rake (13.0.1)
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    rchardet (1.8.0)
+    regexp_parser (1.7.1)
+    rexml (3.2.4)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    rubocop (0.52.1)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.90.0)
       parallel (~> 1.10)
-      parser (>= 2.4.0.2, < 3.0)
-      powerpack (~> 0.1)
+      parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
+      rexml
+      rubocop-ast (>= 0.3.0, < 1.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
-    sawyer (0.8.1)
-      addressable (>= 2.3.5, < 2.6)
-      faraday (~> 0.8, < 1.0)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.3.0)
+      parser (>= 2.7.1.4)
+    ruby-progressbar (1.10.1)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
     shellany (0.0.1)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
-    thor (0.20.0)
-    unicode-display_width (1.3.0)
-    yard (0.9.12)
+    thor (1.0.1)
+    unicode-display_width (1.6.0)
+    yard (0.9.25)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.3)
+  bump (~> 0.9.0)
+  bundler (~> 2.0)
   danger-textlint!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
-  listen (= 3.0.7)
+  listen (= 3.2.1)
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
   rspec (~> 3.4)
   rubocop
   yard
 
 BUNDLED WITH
-   1.16.1
+   2.1.4

data/README.md

@@ -1,6 +1,6 @@
 # danger-textlint
 [![Gem Version](https://badge.fury.io/rb/danger-textlint.svg)](https://badge.fury.io/rb/danger-textlint)
-[![Build Status](https://travis-ci.org/Kesin11/danger-textlint.svg?branch=master)](https://travis-ci.org/Kesin11/danger-textlint)
+[![](https://github.com/Kesin11/danger-textlint/workflows/CI/badge.svg)](https://github.com/Kesin11/danger-textlint/actions)
 
 
 [Danger](http://danger.systems/ruby/) plugin for [textlint](https://textlint.github.io/).

data/danger-textlint.gemspec

@@ -21,8 +21,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
 
   # General ruby development
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
 
   # Testing support
   spec.add_development_dependency 'rspec', '~> 3.4'
@@ -36,7 +36,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
 
   # If you want to work on older builds of ruby
-  spec.add_development_dependency 'listen', '3.0.7'
+  spec.add_development_dependency 'listen', '3.2.1'
+
+  # Help gem version up when release new version
+  spec.add_development_dependency 'bump', '~> 0.9.0'
 
   # This gives you the chance to run a REPL inside your tests
   # via:

data/lib/textlint/gem_version.rb

@@ -1,3 +1,3 @@
 module Textlint
-  VERSION = "1.1.0".freeze
+  VERSION = "2.0.1".freeze
 end

data/lib/textlint/plugin.rb

@@ -14,6 +14,11 @@ module Danger
   #          textlint.max_severity = "warn"
   #          textlint.lint
   #
+  # @example Max inline comment number. If you want disable this feature, please set nil. Default: nil
+  #
+  #          textlint.max_comment_num = 5
+  #          textlint.lint
+  #
   # @see  Kesin11/danger-textlint
   # @tags lint, textlint
   #
@@ -27,9 +32,16 @@ module Danger
     # @return [String]
     attr_accessor :max_severity
 
+    # Set max danger reporting comment number
+    # choice: nil or integer
+    # @return [String]
+    attr_accessor :max_comment_num
+
     # Execute textlint and send comment
     # @return [void]
     def lint
+      return if target_files.empty?
+
       bin = textlint_path
       result_json = run_textlint(bin, target_files)
       errors = parse(result_json)
@@ -47,6 +59,7 @@ module Danger
 
       # File.exist?(local) ? local : find_executable("textlint")
       raise "textlint not found in ./node_modules/.bin/textlint" unless File.exist?(local)
+
       local
     end
 
@@ -88,7 +101,13 @@ module Danger
     end
 
     def send_comment(errors)
-      errors.each do |error|
+      limited_errors = errors
+      if max_comment_num && limited_errors.size > max_comment_num
+        limited_errors = limited_errors.first(max_comment_num)
+        send("warn", "Textlint reported more than #{max_comment_num} problems, but danger-textlint doesn't to display all problems. Please run textlint in your machine and check all problems.")
+      end
+
+      limited_errors.each do |error|
         send(error[:severity], error[:message], file: error[:file_path], line: error[:line])
       end
     end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 require "pathname"
-ROOT = Pathname.new(File.expand_path("../../", __FILE__))
+ROOT = Pathname.new(File.expand_path("..", __dir__))
 $:.unshift((ROOT + "lib").to_s)
 $:.unshift((ROOT + "spec").to_s)
 

data/spec/textlint_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path("../spec_helper", __FILE__)
+require File.expand_path("spec_helper", __dir__)
 
 module Danger
   describe "with Dangerfile" do
@@ -15,7 +15,7 @@ module Danger
     end
 
     let(:fixture) do
-      fixture_path = File.expand_path("../fixtures/textlint_result.json", __FILE__)
+      fixture_path = File.expand_path("fixtures/textlint_result.json", __dir__)
       File.read(fixture_path)
     end
 
@@ -62,7 +62,10 @@ module Danger
       end
 
       # stub for simulate to run textlint
-      before { allow(@textlint).to receive(:run_textlint).and_return fixture }
+      before do
+        allow(@textlint).to receive(:run_textlint).and_return fixture
+        allow(@textlint).to receive(:target_files).and_return [""]
+      end
 
       context "with default max_severity" do
         before { @textlint.lint }
@@ -100,6 +103,33 @@ module Danger
           )
         end
       end
+
+      context "with .max_comment_num = 5" do
+        let(:max_comment_num) { 5 }
+        before do
+          @textlint.max_comment_num = max_comment_num
+          @textlint.lint
+        end
+
+        it "status_report" do
+          status_report = @textlint.status_report
+          expect(status_report[:errors].size).to eq(max_comment_num)
+        end
+
+        it "violation_report" do
+          violation_report = @textlint.violation_report
+          expect(violation_report[:errors].size).to eq(max_comment_num)
+        end
+
+        it "danger comment" do
+          # find not inline comment
+          comment = @textlint.violation_report[:warnings].find do |warning|
+            warning.message.match(/Textlint reported more than/)
+          end
+
+          expect(comment).not_to be_nil
+        end
+      end
     end
 
     describe ".target_files" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-textlint
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Kesin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-22 00:00:00.000000000 Z
+date: 2020-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +128,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.7
+        version: 3.2.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.7
+        version: 3.2.1
+- !ruby/object:Gem::Dependency
+  name: bump
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -157,9 +171,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".dependabot/config.yml"
+- ".devcontainer/Dockerfile"
+- ".devcontainer/devcontainer.json"
+- ".github/dependabot.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -193,8 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.5
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Danger plugin for textlint.

data/.travis.yml

@@ -1,14 +0,0 @@
-language: ruby
-cache:
-  directories:
-    - bundle
-
-rvm:
-  - 2.1
-  - 2.2
-  - 2.3
-  - 2.4
-  - 2.5
-
-script:
-    - bundle exec rake spec