danger-swiftlint 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb6c93186c9141189a2be976b2728381f983bc5e
-  data.tar.gz: d100191c3a3ab38801ec23ba87f79294e4a7d26b
+  metadata.gz: 96a0feb085a87d9319afbbd67f7e1e0dda30961f
+  data.tar.gz: c4d45699850bad5c113e0f49cd371dec1076bac4
 SHA512:
-  metadata.gz: e4469183c1e4b05686ae048cbeda886eaa25e96bb9197e12473bb63a1a1cd6e228245503dcc66266fae698641f8fb4dd62c21f4de1334d888a803804848de24e
-  data.tar.gz: 467441b08eef27d8415ecaa4302412a087c93848cf298c17afa2624375bfdaa6de59534d56438d9798924c21fec195280fc3e98cdada21723f190760c0b4b921
+  metadata.gz: 284ee20ec49d083e571926ecfd67a027f468daa0c115ee841064fe58f20ac5319359c4b2592bc6c53b19cca3c013ff5806cf582e324ed7694fdc80ea2a5bb938
+  data.tar.gz: a646d759dccf4a08e9cb0cf8f109d0cf3388f52029ef6c1633ba6f5da4911df468f53042f9d4b929ade419858397c5c764de8f63c5a53b7eb955aca84a2fb477

data/Changelog.md

@@ -4,6 +4,10 @@
 
 - Nothing yet!
 
+## 0.2.1
+
+- Adds support for specifying a directory in which to run SwiftLint. See [#19](https://github.com/ashfurrow/danger-swiftlint/pull/19).
+
 ## 0.1.2
 
 - Adds support for files with spaces in their names. See [#9](https://github.com/ashfurrow/danger-swiftlint/issues/9).

data/lib/danger_plugin.rb

@@ -18,6 +18,9 @@ module Danger
     # Allows you to specify a config file location for swiftlint.
     attr_accessor :config_file
 
+    # Allows you to specify a directory from where swiftlint will be run. 
+    attr_accessor :directory
+
     # Lints Swift files. Will fail if `swiftlint` cannot be installed correctly.
     # Generates a `markdown` list of warnings for the prose in a corpus of .markdown and .md files. 
     #
@@ -36,11 +39,13 @@ module Danger
         return
       end
 
-      swiftlint_command = "swiftlint lint --quiet --reporter json"
+      swiftlint_command = ""
+      swiftlint_command += "cd #{directory} && " if directory
+      swiftlint_command += "swiftlint lint --quiet --reporter json"
       swiftlint_command += " --config #{config_file}" if config_file
 
       require 'json'
-      result_json = JSON.parse(`#{swiftlint_command}`).flatten
+      result_json = JSON.parse(`(#{swiftlint_command})`).flatten
 
       # Convert to swiftlint results
       warnings = result_json.select do |results| 

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerSwiftlint
-  VERSION = "0.2.0".freeze
+  VERSION = "0.2.1".freeze
 end

data/spec/danger_plugin_spec.rb

@@ -42,7 +42,7 @@ module Danger
         end
 
         it 'handles a known SwiftLint report' do
-          allow(@swiftlint).to receive(:`).with('swiftlint lint --quiet --reporter json').and_return(@swiftlint_response)
+          allow(@swiftlint).to receive(:`).with('(swiftlint lint --quiet --reporter json)').and_return(@swiftlint_response)
 
           # Do it
           @swiftlint.lint_files
@@ -58,7 +58,7 @@ module Danger
         end
 
         it 'handles no files' do
-          allow(@swiftlint).to receive(:`).with('swiftlint lint --quiet --reporter json').and_return(@swiftlint_response)
+          allow(@swiftlint).to receive(:`).with('(swiftlint lint --quiet --reporter json)').and_return(@swiftlint_response)
 
           @swiftlint.lint_files
 
@@ -67,13 +67,21 @@ module Danger
 
         it 'uses a config file' do
           @swiftlint.config_file = 'some_config.yml'
-          allow(@swiftlint).to receive(:`).with('swiftlint lint --quiet --reporter json --config some_config.yml').and_return(@swiftlint_response)
+          allow(@swiftlint).to receive(:`).with('(swiftlint lint --quiet --reporter json --config some_config.yml)').and_return(@swiftlint_response)
 
           @swiftlint.lint_files
 
           expect(@swiftlint.status_report[:markdowns].first).to_not be_empty
         end
 
+        it 'uses a custom directory' do
+          @swiftlint.directory = 'some_dir'
+          allow(@swiftlint).to receive(:`).with('(cd some_dir && swiftlint lint --quiet --reporter json)').and_return(@swiftlint_response)
+
+          @swiftlint.lint_files
+
+          expect(@swiftlint.status_report[:markdowns].first).to_not be_empty
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-swiftlint
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Ash Furrow
@@ -10,90 +10,90 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-24 00:00:00.000000000 Z
+date: 2016-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.4'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.7'
 - !ruby/object:Gem::Dependency
@@ -114,14 +114,14 @@ dependencies:
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A Danger plugin for linting Swift with SwiftLint.
@@ -133,8 +133,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .ruby-version
+- ".gitignore"
+- ".ruby-version"
 - Changelog.md
 - Gemfile
 - Gemfile.lock
@@ -158,17 +158,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A Danger plugin for linting Swift with SwiftLint.