danger-swiftlint 0.2.0 → 0.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (6) hide show
  1. checksums.yaml +4 -4
  2. data/Changelog.md +4 -0
  3. data/lib/danger_plugin.rb +7 -2
  4. data/lib/version.rb +1 -1
  5. data/spec/danger_plugin_spec.rb +11 -3
  6. metadata +21 -21
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: eb6c93186c9141189a2be976b2728381f983bc5e
4
- data.tar.gz: d100191c3a3ab38801ec23ba87f79294e4a7d26b
3
+ metadata.gz: 96a0feb085a87d9319afbbd67f7e1e0dda30961f
4
+ data.tar.gz: c4d45699850bad5c113e0f49cd371dec1076bac4
5
5
  SHA512:
6
- metadata.gz: e4469183c1e4b05686ae048cbeda886eaa25e96bb9197e12473bb63a1a1cd6e228245503dcc66266fae698641f8fb4dd62c21f4de1334d888a803804848de24e
7
- data.tar.gz: 467441b08eef27d8415ecaa4302412a087c93848cf298c17afa2624375bfdaa6de59534d56438d9798924c21fec195280fc3e98cdada21723f190760c0b4b921
6
+ metadata.gz: 284ee20ec49d083e571926ecfd67a027f468daa0c115ee841064fe58f20ac5319359c4b2592bc6c53b19cca3c013ff5806cf582e324ed7694fdc80ea2a5bb938
7
+ data.tar.gz: a646d759dccf4a08e9cb0cf8f109d0cf3388f52029ef6c1633ba6f5da4911df468f53042f9d4b929ade419858397c5c764de8f63c5a53b7eb955aca84a2fb477
data/Changelog.md CHANGED
@@ -4,6 +4,10 @@
4
4
 
5
5
  - Nothing yet!
6
6
 
7
+ ## 0.2.1
8
+
9
+ - Adds support for specifying a directory in which to run SwiftLint. See [#19](https://github.com/ashfurrow/danger-swiftlint/pull/19).
10
+
7
11
  ## 0.1.2
8
12
 
9
13
  - Adds support for files with spaces in their names. See [#9](https://github.com/ashfurrow/danger-swiftlint/issues/9).
data/lib/danger_plugin.rb CHANGED
@@ -18,6 +18,9 @@ module Danger
18
18
  # Allows you to specify a config file location for swiftlint.
19
19
  attr_accessor :config_file
20
20
 
21
+ # Allows you to specify a directory from where swiftlint will be run.
22
+ attr_accessor :directory
23
+
21
24
  # Lints Swift files. Will fail if `swiftlint` cannot be installed correctly.
22
25
  # Generates a `markdown` list of warnings for the prose in a corpus of .markdown and .md files.
23
26
  #
@@ -36,11 +39,13 @@ module Danger
36
39
  return
37
40
  end
38
41
 
39
- swiftlint_command = "swiftlint lint --quiet --reporter json"
42
+ swiftlint_command = ""
43
+ swiftlint_command += "cd #{directory} && " if directory
44
+ swiftlint_command += "swiftlint lint --quiet --reporter json"
40
45
  swiftlint_command += " --config #{config_file}" if config_file
41
46
 
42
47
  require 'json'
43
- result_json = JSON.parse(`#{swiftlint_command}`).flatten
48
+ result_json = JSON.parse(`(#{swiftlint_command})`).flatten
44
49
 
45
50
  # Convert to swiftlint results
46
51
  warnings = result_json.select do |results|
data/lib/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module DangerSwiftlint
2
- VERSION = "0.2.0".freeze
2
+ VERSION = "0.2.1".freeze
3
3
  end
data/spec/danger_plugin_spec.rb CHANGED
@@ -42,7 +42,7 @@ module Danger
42
42
  end
43
43
 
44
44
  it 'handles a known SwiftLint report' do
45
- allow(@swiftlint).to receive(:`).with('swiftlint lint --quiet --reporter json').and_return(@swiftlint_response)
45
+ allow(@swiftlint).to receive(:`).with('(swiftlint lint --quiet --reporter json)').and_return(@swiftlint_response)
46
46
 
47
47
  # Do it
48
48
  @swiftlint.lint_files
@@ -58,7 +58,7 @@ module Danger
58
58
  end
59
59
 
60
60
  it 'handles no files' do
61
- allow(@swiftlint).to receive(:`).with('swiftlint lint --quiet --reporter json').and_return(@swiftlint_response)
61
+ allow(@swiftlint).to receive(:`).with('(swiftlint lint --quiet --reporter json)').and_return(@swiftlint_response)
62
62
 
63
63
  @swiftlint.lint_files
64
64
 
@@ -67,13 +67,21 @@ module Danger
67
67
 
68
68
  it 'uses a config file' do
69
69
  @swiftlint.config_file = 'some_config.yml'
70
- allow(@swiftlint).to receive(:`).with('swiftlint lint --quiet --reporter json --config some_config.yml').and_return(@swiftlint_response)
70
+ allow(@swiftlint).to receive(:`).with('(swiftlint lint --quiet --reporter json --config some_config.yml)').and_return(@swiftlint_response)
71
71
 
72
72
  @swiftlint.lint_files
73
73
 
74
74
  expect(@swiftlint.status_report[:markdowns].first).to_not be_empty
75
75
  end
76
76
 
77
+ it 'uses a custom directory' do
78
+ @swiftlint.directory = 'some_dir'
79
+ allow(@swiftlint).to receive(:`).with('(cd some_dir && swiftlint lint --quiet --reporter json)').and_return(@swiftlint_response)
80
+
81
+ @swiftlint.lint_files
82
+
83
+ expect(@swiftlint.status_report[:markdowns].first).to_not be_empty
84
+ end
77
85
  end
78
86
  end
79
87
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: danger-swiftlint
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.2.0
4
+ version: 0.2.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Ash Furrow
@@ -10,90 +10,90 @@ authors:
10
10
  autorequire:
11
11
  bindir: bin
12
12
  cert_chain: []
13
- date: 2016-07-24 00:00:00.000000000 Z
13
+ date: 2016-08-23 00:00:00.000000000 Z
14
14
  dependencies:
15
15
  - !ruby/object:Gem::Dependency
16
16
  name: danger
17
17
  requirement: !ruby/object:Gem::Requirement
18
18
  requirements:
19
- - - '>='
19
+ - - ">="
20
20
  - !ruby/object:Gem::Version
21
21
  version: '0'
22
22
  type: :runtime
23
23
  prerelease: false
24
24
  version_requirements: !ruby/object:Gem::Requirement
25
25
  requirements:
26
- - - '>='
26
+ - - ">="
27
27
  - !ruby/object:Gem::Version
28
28
  version: '0'
29
29
  - !ruby/object:Gem::Dependency
30
30
  name: bundler
31
31
  requirement: !ruby/object:Gem::Requirement
32
32
  requirements:
33
- - - ~>
33
+ - - "~>"
34
34
  - !ruby/object:Gem::Version
35
35
  version: '1.3'
36
36
  type: :development
37
37
  prerelease: false
38
38
  version_requirements: !ruby/object:Gem::Requirement
39
39
  requirements:
40
- - - ~>
40
+ - - "~>"
41
41
  - !ruby/object:Gem::Version
42
42
  version: '1.3'
43
43
  - !ruby/object:Gem::Dependency
44
44
  name: rake
45
45
  requirement: !ruby/object:Gem::Requirement
46
46
  requirements:
47
- - - ~>
47
+ - - "~>"
48
48
  - !ruby/object:Gem::Version
49
49
  version: '10.0'
50
50
  type: :development
51
51
  prerelease: false
52
52
  version_requirements: !ruby/object:Gem::Requirement
53
53
  requirements:
54
- - - ~>
54
+ - - "~>"
55
55
  - !ruby/object:Gem::Version
56
56
  version: '10.0'
57
57
  - !ruby/object:Gem::Dependency
58
58
  name: rspec
59
59
  requirement: !ruby/object:Gem::Requirement
60
60
  requirements:
61
- - - ~>
61
+ - - "~>"
62
62
  - !ruby/object:Gem::Version
63
63
  version: '3.4'
64
64
  type: :development
65
65
  prerelease: false
66
66
  version_requirements: !ruby/object:Gem::Requirement
67
67
  requirements:
68
- - - ~>
68
+ - - "~>"
69
69
  - !ruby/object:Gem::Version
70
70
  version: '3.4'
71
71
  - !ruby/object:Gem::Dependency
72
72
  name: guard
73
73
  requirement: !ruby/object:Gem::Requirement
74
74
  requirements:
75
- - - ~>
75
+ - - "~>"
76
76
  - !ruby/object:Gem::Version
77
77
  version: '2.14'
78
78
  type: :development
79
79
  prerelease: false
80
80
  version_requirements: !ruby/object:Gem::Requirement
81
81
  requirements:
82
- - - ~>
82
+ - - "~>"
83
83
  - !ruby/object:Gem::Version
84
84
  version: '2.14'
85
85
  - !ruby/object:Gem::Dependency
86
86
  name: guard-rspec
87
87
  requirement: !ruby/object:Gem::Requirement
88
88
  requirements:
89
- - - ~>
89
+ - - "~>"
90
90
  - !ruby/object:Gem::Version
91
91
  version: '4.7'
92
92
  type: :development
93
93
  prerelease: false
94
94
  version_requirements: !ruby/object:Gem::Requirement
95
95
  requirements:
96
- - - ~>
96
+ - - "~>"
97
97
  - !ruby/object:Gem::Version
98
98
  version: '4.7'
99
99
  - !ruby/object:Gem::Dependency
@@ -114,14 +114,14 @@ dependencies:
114
114
  name: pry
115
115
  requirement: !ruby/object:Gem::Requirement
116
116
  requirements:
117
- - - '>='
117
+ - - ">="
118
118
  - !ruby/object:Gem::Version
119
119
  version: '0'
120
120
  type: :development
121
121
  prerelease: false
122
122
  version_requirements: !ruby/object:Gem::Requirement
123
123
  requirements:
124
- - - '>='
124
+ - - ">="
125
125
  - !ruby/object:Gem::Version
126
126
  version: '0'
127
127
  description: A Danger plugin for linting Swift with SwiftLint.
@@ -133,8 +133,8 @@ executables: []
133
133
  extensions: []
134
134
  extra_rdoc_files: []
135
135
  files:
136
- - .gitignore
137
- - .ruby-version
136
+ - ".gitignore"
137
+ - ".ruby-version"
138
138
  - Changelog.md
139
139
  - Gemfile
140
140
  - Gemfile.lock
@@ -158,17 +158,17 @@ require_paths:
158
158
  - lib
159
159
  required_ruby_version: !ruby/object:Gem::Requirement
160
160
  requirements:
161
- - - '>='
161
+ - - ">="
162
162
  - !ruby/object:Gem::Version
163
163
  version: '0'
164
164
  required_rubygems_version: !ruby/object:Gem::Requirement
165
165
  requirements:
166
- - - '>='
166
+ - - ">="
167
167
  - !ruby/object:Gem::Version
168
168
  version: '0'
169
169
  requirements: []
170
170
  rubyforge_project:
171
- rubygems_version: 2.4.8
171
+ rubygems_version: 2.4.5.1
172
172
  signing_key:
173
173
  specification_version: 4
174
174
  summary: A Danger plugin for linting Swift with SwiftLint.