danger-static_analyzer_comments 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ce7ad11872af2cc93486068c15ec7b9f4cde3d5
-  data.tar.gz: 45c3abedd75501ab6ca3a07ec8f2875b25f5032d
+  metadata.gz: 9ca60892fd8da20ab1a3ffa4488c95f7b85b4e51
+  data.tar.gz: ff433712c0ec41d165baae60bebc07c37f05e465
 SHA512:
-  metadata.gz: a603b0877bfe0a5f0e018edf7720f410d600e0ce262049da373408875eb44b9caedd205a2ac623569dc5f82c2e2358fa385f1427023b53078d6ac98b66342531
-  data.tar.gz: edb94a98543bc9d4e41207acda0dc8689a53035ac3d3dff14597bd6b8fd33a8f7c44a64c2da2db0be9a49086e95f59de5489daaf8da93067f09002a29e30001a
+  metadata.gz: 603d9b7a049624d9dfce083875ce5ca62173253546e924dc47dc6eb1a9fce761a93dc179039b10b1574a3abeca6d6f70b6d70681870618169e317b535d1575dc
+  data.tar.gz: 964aee52512b13fb046d191f49db060db9588a11f102de742db8cd691004b35ac46fdb5cf6d6a41c9ef04e94472cd74c0f03bfbfe2ea72d0a25c255d548de18e

data/.gitignore

@@ -0,0 +1,80 @@
+# read http://stackoverflow.com/a/8527650/1852422
+# https://stackoverflow.com/questions/11968531/what-to-gitignore-from-the-idea-folder
+
+# generated files
+bin/
+build/
+*.ap_
+
+# Local configuration file (sdk path, etc.)
+local.properties
+
+# Java class files
+*.class
+
+# User-specific (aka high-churn) files
+**/.idea/workspace.xml
+**/.idea/tasks.xml
+**/.idea/dictionaries
+**/.idea/vcs.xml
+**/.idea/shelf
+**/.idea/runConfigurations/
+**/.idea/runConfigurations.xml
+**/.idea/jsLibraryMappings.xml
+**/.idea/caches/
+*.iml
+.navigation
+**/.idea/assetWizardSettings.xml
+**/.idea/misc.xml
+
+# Statistic plugin
+**/.idea/statistic.xml
+
+# Gradle:
+**/.idea/gradle.xml
+**/.idea/libraries
+.gradle
+
+# Sensitive or high-churn files
+**/.idea/dataSources.ids
+**/.idea/dataSources.xml
+**/.idea/dataSources.local.xml
+**/.idea/sqlDataSources.xml
+**/.idea/dynamic.xml
+**/.idea/uiDesigner.xml
+
+# File-based project format
+*.iws
+
+# IntelliJ
+/out/
+
+.externalNativeBuild
+
+# AS' Layout Inspector files
+*/captures
+
+# OS X junk
+.DS_Store
+
+# files for the dex VM
+*.dex
+
+# woof woof!
+doge.jp[e]g
+
+## Ruby environment normalization
+/.bundle/
+/vendor/bundle
+/lib/bundler/man/
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/
+
+## Environment normalization:
+/.bundle/
+/vendor/bundle
+/lib/bundler/man/

data/.idea/inspectionProfiles/Project_Default.xml

@@ -0,0 +1,6 @@
+<component name="InspectionProjectProfileManager">
+  <profile version="1.0">
+    <option name="myName" value="Project Default" />
+    <inspection_tool class="Rubocop" enabled="false" level="WARNING" enabled_by_default="false" />
+  </profile>
+</component>

data/lib/danger_plugin.rb

@@ -2,46 +2,72 @@ require 'oga'
 
 module Danger
 
-  # A Danger plugin which turns static analyzers' output into inline Github comments
   class DangerStaticAnalyzerComments < Plugin
     LINT_SEVERITY_LEVELS = ["Warning", "Error", "Fatal"]
+    CHECKSTYLE_SEVERITY_LEVELS = ["ignore", "info", "warning", "error"]
 
-    attr_accessor :lint_report_file
+    attr_accessor :android_lint_report_file
+    attr_accessor :checkstyle_report_file
 
     def run
-      lint()
+      android_lint
+      checkstyle
     end
 
-    def lint
-      unless File.exists?(@lint_report_file)
-        fail("Lint report not found at `#{@lint_report_file}`.")
+    def android_lint
+      unless File.exists?(@android_lint_report_file)
+        fail("Lint report not found at `#{@android_lint_report_file}`.")
       end
 
-      file = File.open(@lint_report_file)
+      file = File.open(@android_lint_report_file)
       report = Oga.parse_xml(file)
       issues = report.xpath('//issue')
-      send_lint_inline_comment(issues)
+      send_android_lint_inline_comment(issues)
     end
 
+    def checkstyle
+      unless File.exists?(checkstyle_report_file)
+        fail("Checkstyle report not found at `#{checkstyle_report_file}`.")
+      end
+
+      file = File.open(checkstyle_report_file)
+      report = Oga.parse_xml(file)
+      files = report.xpath('/checkstyle/file')
+      send_checkstyle_inline_comment(files)
+    end
 
-    # Send inline comment with danger's warn or fail method
-    def send_lint_inline_comment(issues)
-      target_files = (git.modified_files - git.deleted_files) + git.added_files
-      print target_files.to_a
-      dir = "#{Dir.pwd}/"
+    def send_checkstyle_inline_comment(files)
+      files.each do |file|
+        filename = file.get('name').gsub(current_dir, "")
+        errors = file.xpath('error')
+        errors.each do |error|
+          next unless (target_files.include? filename)
+          line = (error.get('line') || "0").to_i
+          warn(error.get('message'), file: filename, line: line)
+        end
+      end
+    end
+
+    def send_android_lint_inline_comment(issues)
       LINT_SEVERITY_LEVELS.reverse.each do |level|
         filtered = issues.select {|issue| issue.get("severity") == level}
         next if filtered.empty?
         filtered.each do |r|
           location = r.xpath('location').first
-          filename = location.get('file').gsub(dir, "")
-          print "location: #{location}, file: #{location.get('file')}, filename: #{filename}"
+          filename = location.get('file').gsub(current_dir, "")
           next unless (target_files.include? filename)
-          print "target_files includes #{filename}"
           line = (location.get('line') || "0").to_i
           send(level === "Warning" ? "warn" : "fail", r.get('message'), file: filename, line: line)
         end
       end
     end
+
+    def target_files
+      (git.modified_files - git.deleted_files) + git.added_files
+    end
+
+    def current_dir
+      "#{Dir.pwd}/"
+    end
   end
 end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerStaticAnalyzerComments
-  VERSION = "0.0.1".freeze
+  VERSION = "0.0.2".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-static_analyzer_comments
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Vibin Reddy
@@ -172,6 +172,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gitignore"
+- ".idea/inspectionProfiles/Project_Default.xml"
 - ".idea/misc.xml"
 - ".idea/modules.xml"
 - Gemfile