danger-spotbugs 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8813e879ca3e2f0574b73b106872369a3b341d46e1b08ec7ac0ee9c89b8ff73d
-  data.tar.gz: b4b6566b2234e34cca5950cae9a8dada5398a7f4ef3627abe9871ac611f6f3bd
+  metadata.gz: 703a32ef1e4e92cc32381f904f7956aa557f26f7b698d364680bf8e27f20c2e7
+  data.tar.gz: 4c920a3822f89c99a1694886657e18acdd88d742dcab98e83e906f66d52f5d48
 SHA512:
-  metadata.gz: 195edf7c7eaaed5c3efefe7327b8c453ccbc7a3e78dce6b52986d52a8f83c40a259ce38cc71d68af358b4e139e992abd85d29724231105d2b4b7fc35ea5d7e17
-  data.tar.gz: f849b2ae5af1fb6bb44395a0b9cd773df30f47d74bea2288c00fa2eadf0d01487e1a7fe6eefcd8b9bbfbef78dceb5c42feda8ee914497a051234d82085c3cd56
+  metadata.gz: 3c1063d298ebbf8d3a49466a6aeb16f9fa2c1fc272edb30b87662f8df5a8d633596413e8a7e2a97243d5e612d379d31b0be7fa51b4c67c74c7d45370a58e3639
+  data.tar.gz: 1cafc111f92c6c613a92fe2af927687188b56267f569f885049762484c253c5e6f0fd2c50674b7cc0415a60cccb7055b3a9406b37ea00c3c9a5da550d8a4a169

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-spotbugs (0.0.3)
+    danger-spotbugs (0.0.4)
       danger-plugin-api (~> 1.0)
       oga (~> 2.15)
 

data/lib/spotbugs/entity/bug_instance.rb

@@ -26,7 +26,7 @@ class BugInstance
   end
 
   def line
-    @line ||= bug_instance.xpath('SourceLine').attribute('start').compact.first.value.to_i
+    @line ||= get_value_safely(bug_instance.xpath('SourceLine').attribute('start'), 0).to_i
   end
 
   def description
@@ -36,7 +36,7 @@ class BugInstance
   private
 
   def get_source_path(bug_instance)
-    bug_instance.xpath('SourceLine').attribute('sourcepath').compact.first.value.to_s
+    get_value_safely(bug_instance.xpath('SourceLine').attribute('sourcepath'), '').to_s
   end
 
   def get_absolute_path(source_path)
@@ -56,4 +56,8 @@ class BugInstance
   def file_separator
     File::ALT_SEPARATOR || File::SEPARATOR
   end
+
+  def get_value_safely(array, default_value)
+    array.compact.empty? ? default_value : array.compact.first.value
+  end
 end

data/lib/spotbugs/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Spotbugs
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/entity/bug_instance_spec.rb

@@ -62,6 +62,54 @@ module Spotbugs
         xml.xpath('//BugInstance')[1]
       )
 
+      expect(bug_instance.rank).to eq(6)
+      expect(bug_instance.line).to eq(45)
+      expect(bug_instance.type).to eq(:warn)
+      expect(bug_instance.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+      expect(bug_instance.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+      expect(bug_instance.description).to eq('com.github.sample.model.Message.getProperties() may return null, but is declared @Nonnull')
+    end
+
+    it 'should initialize with third bug instance' do
+      xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
+      bug_instance = BugInstance.new(
+        '/Users/developer/project/sample/',
+        xml.xpath('//BugCollection//SrcDir').map(&:text),
+        xml.xpath('//BugInstance')[2]
+      )
+
+      expect(bug_instance.rank).to eq(14)
+      expect(bug_instance.line).to eq(0)
+      expect(bug_instance.type).to eq(:warn)
+      expect(bug_instance.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+      expect(bug_instance.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+      expect(bug_instance.description).to eq('Class com.github.sample.model.Message defines non-transient non-serializable instance field conversation')
+    end
+
+    it 'should initialize with fourth bug instance' do
+      xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
+      bug_instance = BugInstance.new(
+        '/Users/developer/project/sample/',
+        xml.xpath('//BugCollection//SrcDir').map(&:text),
+        xml.xpath('//BugInstance')[3]
+      )
+
+      expect(bug_instance.rank).to eq(14)
+      expect(bug_instance.line).to eq(0)
+      expect(bug_instance.type).to eq(:warn)
+      expect(bug_instance.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+      expect(bug_instance.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+      expect(bug_instance.description).to eq('Class com.github.sample.model.Message defines non-transient non-serializable instance field sender')
+    end
+
+    it 'should initialize with fifth bug instance' do
+      xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
+      bug_instance = BugInstance.new(
+        '/Users/developer/project/sample/',
+        xml.xpath('//BugCollection//SrcDir').map(&:text),
+        xml.xpath('//BugInstance')[4]
+      )
+
       expect(bug_instance.rank).to eq(6)
       expect(bug_instance.line).to eq(31)
       expect(bug_instance.type).to eq(:warn)
@@ -70,12 +118,12 @@ module Spotbugs
       expect(bug_instance.description).to eq('Possible null pointer dereference of Tools$Helper.string in com.github.sample.tools.Tools$Helper.setText(TextView)')
     end
 
-    it 'should initialize with third bug instance' do
+    it 'should initialize with sixth bug instance' do
       xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
       bug_instance = BugInstance.new(
         '/Users/developer/project/sample/',
         xml.xpath('//BugCollection//SrcDir').map(&:text),
-        xml.xpath('//BugInstance')[2]
+        xml.xpath('//BugInstance')[5]
       )
 
       expect(bug_instance.rank).to eq(8)
@@ -86,12 +134,12 @@ module Spotbugs
       expect(bug_instance.description).to eq('Read of unwritten field title in com.github.sample.tools.Tools$Helper.setText(TextView)')
     end
 
-    it 'should initialize with fourth bug instance' do
+    it 'should initialize with seventh bug instance' do
       xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
       bug_instance = BugInstance.new(
         '/Users/developer/project/sample/',
         xml.xpath('//BugCollection//SrcDir').map(&:text),
-        xml.xpath('//BugInstance')[3]
+        xml.xpath('//BugInstance')[6]
       )
 
       expect(bug_instance.rank).to eq(18)
@@ -102,12 +150,12 @@ module Spotbugs
       expect(bug_instance.description).to eq('Should com.github.sample.tools.Tools$Helper be a _static_ inner class?')
     end
 
-    it 'should initialize with fifth bug instance' do
+    it 'should initialize with eight bug instance' do
       xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
       bug_instance = BugInstance.new(
         '/Users/developer/project/sample/',
         xml.xpath('//BugCollection//SrcDir').map(&:text),
-        xml.xpath('//BugInstance')[4]
+        xml.xpath('//BugInstance')[7]
       )
 
       expect(bug_instance.rank).to eq(12)
@@ -118,12 +166,12 @@ module Spotbugs
       expect(bug_instance.description).to eq('Unwritten field: com.github.sample.tools.Tools$Helper.title')
     end
 
-    it 'should initialize with sixth bug instance' do
+    it 'should initialize with nine bug instance' do
       xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
       bug_instance = BugInstance.new(
         '/Users/developer/project/sample/',
         xml.xpath('//BugCollection//SrcDir').map(&:text),
-        xml.xpath('//BugInstance')[5]
+        xml.xpath('//BugInstance')[8]
       )
 
       expect(bug_instance.rank).to eq(18)
@@ -134,12 +182,12 @@ module Spotbugs
       expect(bug_instance.description).to eq('Should com.github.sample.tools.Tools$Other be a _static_ inner class?')
     end
 
-    it 'should initialize with seventh bug instance' do
+    it 'should initialize with ten bug instance' do
       xml = Oga.parse_xml(File.open('spec/fixtures/spotbugs_report.xml'))
       bug_instance = BugInstance.new(
         '/Users/developer/project/sample/',
         xml.xpath('//BugCollection//SrcDir').map(&:text),
-        xml.xpath('//BugInstance')[6]
+        xml.xpath('//BugInstance')[9]
       )
 
       expect(bug_instance.rank).to eq(5)

data/spec/fixtures/spotbugs_report.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<BugCollection version="4.1.1" sequence="0" timestamp="1616453271149" analysisTimestamp="1616453271213" release="unspecified">
+<BugCollection version="4.1.1" sequence="0" timestamp="1620641501525" analysisTimestamp="1620641501684" release="unspecified">
   <Project projectName="app (spotbugsRelease)">
     <Jar>/Users/developer/project/sample/app/build/intermediates/javac/release/classes/com/github/sample/MainActivity.class</Jar>
     <Jar>/Users/developer/project/sample/app/build/intermediates/javac/release/classes/com/github/sample/tools/Tools$Helper.class</Jar>
@@ -93,6 +93,82 @@
       <Message>Known null at MainActivity.java:[line 29]</Message>
     </SourceLine>
   </BugInstance>
+  <BugInstance type="NP_NONNULL_RETURN_VIOLATION" priority="1" rank="6" abbrev="NP" category="CORRECTNESS" instanceHash="3fed666a46df9026e83022b1d37620b0" instanceOccurrenceNum="0" instanceOccurrenceMax="0" cweid="476">
+    <ShortMessage>Method may return null, but is declared @Nonnull</ShortMessage>
+    <LongMessage>com.github.sample.model.Message.getProperties() may return null, but is declared @Nonnull</LongMessage>
+    <Class classname="com.github.sample.model.Message" primary="true">
+      <SourceLine classname="com.github.sample.model.Message" start="20" end="50" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java">
+        <Message>At Message.java:[lines 20-50]</Message>
+      </SourceLine>
+      <Message>In class com.github.sample.model.Message</Message>
+    </Class>
+    <Method classname="com.github.sample.model.Message" name="getProperties" signature="()Ljava/lang/String;" isStatic="false" primary="true">
+      <SourceLine classname="com.github.sample.model.Message" start="45" end="45" startBytecode="0" endBytecode="46" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java"/>
+      <Message>In method com.github.sample.model.Message.getProperties()</Message>
+    </Method>
+    <Field classname="com.github.sample.model.Message" name="properties" signature="Ljava/lang/String;" isStatic="false" primary="true" role="FIELD_CONTAINS_VALUE">
+      <SourceLine classname="com.github.sample.model.Message" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java">
+        <Message>In Message.java</Message>
+      </SourceLine>
+      <Message>Value contained in com.github.sample.model.Message.properties</Message>
+    </Field>
+    <SourceLine classname="com.github.sample.model.Message" primary="true" start="45" end="45" startBytecode="4" endBytecode="4" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java" role="SOURCE_LINE_RETURNED">
+      <Message>Returned at Message.java:[line 45]</Message>
+    </SourceLine>
+    <SourceLine classname="com.github.sample.model.Message" start="45" end="45" startBytecode="4" endBytecode="4" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java" role="SOURCE_LINE_KNOWN_NULL">
+      <Message>Known null at Message.java:[line 45]</Message>
+    </SourceLine>
+  </BugInstance>
+  <BugInstance type="SE_BAD_FIELD" priority="1" rank="14" abbrev="Se" category="BAD_PRACTICE" instanceHash="44742cc905f428a65c6dd14ac2daae78" instanceOccurrenceNum="0" instanceOccurrenceMax="0">
+    <ShortMessage>Non-transient non-serializable instance field in serializable class</ShortMessage>
+    <LongMessage>Class com.github.sample.model.Message defines non-transient non-serializable instance field conversation</LongMessage>
+    <Class classname="com.github.sample.model.Message" primary="true">
+      <SourceLine classname="com.github.sample.model.Message" start="20" end="50" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java">
+        <Message>At Message.java:[lines 20-50]</Message>
+      </SourceLine>
+      <Message>In class com.github.sample.model.Message</Message>
+    </Class>
+    <Field classname="com.github.sample.model.Message" name="conversation" signature="Lcom/github/sample/model/Conversation;" isStatic="false" primary="true">
+      <SourceLine classname="com.github.sample.model.Message" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java">
+        <Message>In Message.java</Message>
+      </SourceLine>
+      <Message>Field com.github.sample.model.Message.conversation</Message>
+    </Field>
+    <Type descriptor="Lcom/github/sample/model/Conversation;" role="TYPE_FOUND">
+      <SourceLine classname="com.github.sample.model.Conversation" start="11" end="26" sourcefile="Conversation.java" sourcepath="com/github/sample/model/Conversation.java">
+        <Message>At Conversation.java:[lines 11-26]</Message>
+      </SourceLine>
+      <Message>Actual type com.github.sample.model.Conversation</Message>
+    </Type>
+    <SourceLine classname="com.github.sample.model.Message" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java" synthetic="true">
+      <Message>In Message.java</Message>
+    </SourceLine>
+  </BugInstance>
+  <BugInstance type="SE_BAD_FIELD" priority="1" rank="14" abbrev="Se" category="BAD_PRACTICE" instanceHash="5c07870442e74a0a719c0059c999090e" instanceOccurrenceNum="0" instanceOccurrenceMax="0">
+    <ShortMessage>Non-transient non-serializable instance field in serializable class</ShortMessage>
+    <LongMessage>Class com.github.sample.model.Message defines non-transient non-serializable instance field sender</LongMessage>
+    <Class classname="com.github.sample.model.Message" primary="true">
+      <SourceLine classname="com.github.sample.model.Message" start="20" end="50" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java">
+        <Message>At Message.java:[lines 20-50]</Message>
+      </SourceLine>
+      <Message>In class com.github.sample.model.Message</Message>
+    </Class>
+    <Field classname="com.github.sample.model.Message" name="sender" signature="Lcom/github/sample/model/User;" isStatic="false" primary="true">
+      <SourceLine classname="com.github.sample.model.Message" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java">
+        <Message>In Message.java</Message>
+      </SourceLine>
+      <Message>Field com.github.sample.model.Message.sender</Message>
+    </Field>
+    <Type descriptor="Lcom/github/sample/model/User;" role="TYPE_FOUND">
+      <SourceLine classname="com.github.sample.model.User" start="11" end="26" sourcefile="User.java" sourcepath="com/github/sample/model/User.java">
+        <Message>At User.java:[lines 11-26]</Message>
+      </SourceLine>
+      <Message>Actual type com.github.sample.model.User</Message>
+    </Type>
+    <SourceLine classname="com.github.sample.model.Message" sourcefile="Message.java" sourcepath="com/github/sample/model/Message.java" synthetic="true">
+      <Message>In Message.java</Message>
+    </SourceLine>
+  </BugInstance>
   <BugInstance type="NP_NULL_ON_SOME_PATH" priority="1" rank="6" abbrev="NP" category="CORRECTNESS" instanceHash="36d97a1af3badcca6f42173c474917a6" instanceOccurrenceNum="0" instanceOccurrenceMax="0" cweid="476">
     <ShortMessage>Possible null pointer dereference</ShortMessage>
     <LongMessage>Possible null pointer dereference of Tools$Helper.string in com.github.sample.tools.Tools$Helper.setText(TextView)</LongMessage>
@@ -204,13 +280,16 @@
       <Message>Value -1</Message>
     </Int>
     <Method classname="java.util.ArrayList" name="size" signature="()I" isStatic="false" role="METHOD_RETURN_VALUE_OF">
-      <SourceLine classname="java.util.ArrayList" start="282" end="282" startBytecode="0" endBytecode="28" sourcefile="ArrayList.java" sourcepath="java/util/ArrayList.java"/>
+      <SourceLine classname="java.util.ArrayList" start="285" end="285" startBytecode="0" endBytecode="64" sourcefile="ArrayList.java" sourcepath="java/util/ArrayList.java"/>
       <Message>Return value of java.util.ArrayList.size() of type int</Message>
     </Method>
     <SourceLine classname="com.github.sample.view.ConversationAdapter" primary="true" start="32" end="32" startBytecode="5" endBytecode="5" sourcefile="ConversationAdapter.java" sourcepath="com/github/sample/view/ConversationAdapter.java">
       <Message>At ConversationAdapter.java:[line 32]</Message>
     </SourceLine>
   </BugInstance>
+  <BugCategory category="BAD_PRACTICE">
+    <Description>Bad practice</Description>
+  </BugCategory>
   <BugCategory category="CORRECTNESS">
     <Description>Correctness</Description>
   </BugCategory>
@@ -230,6 +309,17 @@ the null pointer exception can't ever be executed; deciding that is beyond the a
 
     ]]></Details>
   </BugPattern>
+  <BugPattern type="NP_NONNULL_RETURN_VIOLATION" abbrev="NP" category="CORRECTNESS">
+    <ShortDescription>Method may return null, but is declared @Nonnull</ShortDescription>
+    <Details><![CDATA[
+      
+      <p>
+      This method may return a null value, but the method (or a superclass method
+      which it overrides) is declared to return @Nonnull.
+      </p>
+      
+   ]]></Details>
+  </BugPattern>
   <BugPattern type="UWF_UNWRITTEN_FIELD" abbrev="UwF" category="CORRECTNESS">
     <ShortDescription>Unwritten field</ShortDescription>
     <Details><![CDATA[
@@ -263,6 +353,19 @@ dereferencing this value will generate a null pointer exception.
 
     ]]></Details>
   </BugPattern>
+  <BugPattern type="SE_BAD_FIELD" abbrev="Se" category="BAD_PRACTICE">
+    <ShortDescription>Non-transient non-serializable instance field in serializable class</ShortDescription>
+    <Details><![CDATA[
+
+<p> This Serializable class defines a non-primitive instance field which is neither transient,
+Serializable, or <code>java.lang.Object</code>, and does not appear to implement
+the <code>Externalizable</code> interface or the
+<code>readObject()</code> and <code>writeObject()</code> methods.&nbsp;
+Objects of this class will not be deserialized correctly if a non-Serializable
+object is stored in this field.</p>
+
+    ]]></Details>
+  </BugPattern>
   <BugPattern type="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE" abbrev="INT" category="CORRECTNESS">
     <ShortDescription>Bad comparison of nonnegative value with negative constant or zero</ShortDescription>
     <Details><![CDATA[
@@ -275,6 +378,9 @@ dereferencing this value will generate a null pointer exception.
   <BugCode abbrev="NP" cweid="476">
     <Description>Null pointer dereference</Description>
   </BugCode>
+  <BugCode abbrev="Se">
+    <Description>Incorrect definition of Serializable class</Description>
+  </BugCode>
   <BugCode abbrev="UwF">
     <Description>Unwritten field</Description>
   </BugCode>
@@ -290,11 +396,11 @@ dereferencing this value will generate a null pointer exception.
     <MissingClass>android.view.View</MissingClass>
     <MissingClass>android.widget.TextView</MissingClass>
   </Errors>
-  <FindBugsSummary timestamp="Mon, 22 Mar 2021 23:47:51 +0100" total_classes="14" referenced_classes="231" total_bugs="7" total_size="172" num_packages="4" java_version="1.8.0_242-release" vm_version="25.242-b3-6915495" cpu_seconds="22.84" clock_seconds="2.65" peak_mbytes="224.15" alloc_mbytes="455.50" gc_seconds="0.14" priority_2="4" priority_1="3">
-    <FileStats path="com/github/sample/BuildConfig.java" bugCount="0" size="10"/>
+  <FindBugsSummary timestamp="Mon, 10 May 2021 12:11:41 +0200" total_classes="14" referenced_classes="232" total_bugs="10" total_size="176" num_packages="4" java_version="11.0.10" vm_version="11.0.10+9" cpu_seconds="7.96" clock_seconds="3.13" peak_mbytes="245.68" alloc_mbytes="512.00" gc_seconds="0.03" priority_2="4" priority_1="6">
+    <FileStats path="com/github/sample/BuildConfig.java" bugCount="0" size="8"/>
     <FileStats path="com/github/sample/MainActivity.java" bugCount="1" size="23" bugHash="3d4de8c5d2e5bc77cb5db28779c6c525"/>
     <FileStats path="com/github/sample/model/Conversation.java" bugCount="0" size="16"/>
-    <FileStats path="com/github/sample/model/Message.java" bugCount="0" size="20"/>
+    <FileStats path="com/github/sample/model/Message.java" bugCount="3" size="26" bugHash="d95b4d13e0ff01bd6f699166cd212709"/>
     <FileStats path="com/github/sample/model/Type.java" bugCount="0" size="11"/>
     <FileStats path="com/github/sample/model/User.java" bugCount="0" size="16"/>
     <FileStats path="com/github/sample/tools/Tools.java" bugCount="5" size="25" bugHash="f4054acc9c26c5455b8a4dbd032c7b07"/>
@@ -302,14 +408,14 @@ dereferencing this value will generate a null pointer exception.
     <FileStats path="com/github/sample/view/ConversationClickListener.java" bugCount="0" size="2"/>
     <FileStats path="com/github/sample/view/ConversationViewHolder.java" bugCount="0" size="15"/>
     <FileStats path="com/github/sample/view/MainViewModel.java" bugCount="0" size="15"/>
-    <PackageStats package="com.github.sample" total_bugs="1" total_types="3" total_size="33" priority_1="1">
-      <ClassStats class="com.github.sample.BuildConfig" sourceFile="BuildConfig.java" interface="false" size="10" bugs="0"/>
+    <PackageStats package="com.github.sample" total_bugs="1" total_types="3" total_size="31" priority_1="1">
+      <ClassStats class="com.github.sample.BuildConfig" sourceFile="BuildConfig.java" interface="false" size="8" bugs="0"/>
       <ClassStats class="com.github.sample.MainActivity" sourceFile="MainActivity.java" interface="false" size="16" bugs="1" priority_1="1"/>
       <ClassStats class="com.github.sample.MainActivity$1" sourceFile="MainActivity.java" interface="false" size="7" bugs="0"/>
     </PackageStats>
-    <PackageStats package="com.github.sample.model" total_bugs="0" total_types="4" total_size="63">
+    <PackageStats package="com.github.sample.model" total_bugs="3" total_types="4" total_size="69" priority_1="3">
       <ClassStats class="com.github.sample.model.Conversation" sourceFile="Conversation.java" interface="false" size="16" bugs="0"/>
-      <ClassStats class="com.github.sample.model.Message" sourceFile="Message.java" interface="false" size="20" bugs="0"/>
+      <ClassStats class="com.github.sample.model.Message" sourceFile="Message.java" interface="false" size="26" bugs="3" priority_1="3"/>
       <ClassStats class="com.github.sample.model.Type" sourceFile="Type.java" interface="false" size="11" bugs="0"/>
       <ClassStats class="com.github.sample.model.User" sourceFile="User.java" interface="false" size="16" bugs="0"/>
     </PackageStats>
@@ -325,20 +431,17 @@ dereferencing this value will generate a null pointer exception.
       <ClassStats class="com.github.sample.view.MainViewModel" sourceFile="MainViewModel.java" interface="false" size="15" bugs="0"/>
     </PackageStats>
     <FindBugsProfile>
-      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine" totalMilliseconds="315" invocations="1076" avgMicrosecondsPerInvocation="293" maxMicrosecondsPerInvocation="20284" standardDeviationMicrosecondsPerInvocation="1002"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.FindNoSideEffectMethods" totalMilliseconds="228" invocations="231" avgMicrosecondsPerInvocation="990" maxMicrosecondsPerInvocation="17010" standardDeviationMicrosecondsPerInvocation="2209"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.FieldItemSummary" totalMilliseconds="208" invocations="231" avgMicrosecondsPerInvocation="902" maxMicrosecondsPerInvocation="14783" standardDeviationMicrosecondsPerInvocation="1877"/>
-      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.bcel.MethodGenFactory" totalMilliseconds="164" invocations="43" avgMicrosecondsPerInvocation="3828" maxMicrosecondsPerInvocation="158335" standardDeviationMicrosecondsPerInvocation="23841"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.EqualsOperandShouldHaveClassCompatibleWithThis" totalMilliseconds="131" invocations="231" avgMicrosecondsPerInvocation="570" maxMicrosecondsPerInvocation="109141" standardDeviationMicrosecondsPerInvocation="7163"/>
-      <ClassProfile name="edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory" totalMilliseconds="107" invocations="362" avgMicrosecondsPerInvocation="296" maxMicrosecondsPerInvocation="4988" standardDeviationMicrosecondsPerInvocation="423"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.NoteDirectlyRelevantTypeQualifiers" totalMilliseconds="78" invocations="231" avgMicrosecondsPerInvocation="340" maxMicrosecondsPerInvocation="6802" standardDeviationMicrosecondsPerInvocation="765"/>
-      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.ClassDataAnalysisEngine" totalMilliseconds="70" invocations="1080" avgMicrosecondsPerInvocation="65" maxMicrosecondsPerInvocation="1086" standardDeviationMicrosecondsPerInvocation="60"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.CalledMethods" totalMilliseconds="66" invocations="231" avgMicrosecondsPerInvocation="289" maxMicrosecondsPerInvocation="7028" standardDeviationMicrosecondsPerInvocation="763"/>
-      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.bcel.JavaClassAnalysisEngine" totalMilliseconds="66" invocations="293" avgMicrosecondsPerInvocation="225" maxMicrosecondsPerInvocation="16463" standardDeviationMicrosecondsPerInvocation="1003"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.BuildObligationPolicyDatabase" totalMilliseconds="54" invocations="231" avgMicrosecondsPerInvocation="236" maxMicrosecondsPerInvocation="4381" standardDeviationMicrosecondsPerInvocation="456"/>
-      <ClassProfile name="edu.umd.cs.findbugs.util.TopologicalSort" totalMilliseconds="46" invocations="903" avgMicrosecondsPerInvocation="51" maxMicrosecondsPerInvocation="1384" standardDeviationMicrosecondsPerInvocation="108"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.FunctionsThatMightBeMistakenForProcedures" totalMilliseconds="39" invocations="231" avgMicrosecondsPerInvocation="172" maxMicrosecondsPerInvocation="3428" standardDeviationMicrosecondsPerInvocation="398"/>
-      <ClassProfile name="edu.umd.cs.findbugs.detect.OverridingEqualsNotSymmetrical" totalMilliseconds="38" invocations="231" avgMicrosecondsPerInvocation="167" maxMicrosecondsPerInvocation="9114" standardDeviationMicrosecondsPerInvocation="640"/>
+      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine" totalMilliseconds="626" invocations="1115" avgMicrosecondsPerInvocation="562" maxMicrosecondsPerInvocation="20203" standardDeviationMicrosecondsPerInvocation="1376"/>
+      <ClassProfile name="edu.umd.cs.findbugs.detect.FieldItemSummary" totalMilliseconds="257" invocations="232" avgMicrosecondsPerInvocation="1110" maxMicrosecondsPerInvocation="14526" standardDeviationMicrosecondsPerInvocation="2404"/>
+      <ClassProfile name="edu.umd.cs.findbugs.detect.FindNoSideEffectMethods" totalMilliseconds="248" invocations="232" avgMicrosecondsPerInvocation="1072" maxMicrosecondsPerInvocation="17254" standardDeviationMicrosecondsPerInvocation="2383"/>
+      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.ClassDataAnalysisEngine" totalMilliseconds="160" invocations="1120" avgMicrosecondsPerInvocation="143" maxMicrosecondsPerInvocation="6404" standardDeviationMicrosecondsPerInvocation="278"/>
+      <ClassProfile name="edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory" totalMilliseconds="123" invocations="365" avgMicrosecondsPerInvocation="339" maxMicrosecondsPerInvocation="5431" standardDeviationMicrosecondsPerInvocation="526"/>
+      <ClassProfile name="edu.umd.cs.findbugs.detect.NoteDirectlyRelevantTypeQualifiers" totalMilliseconds="108" invocations="232" avgMicrosecondsPerInvocation="469" maxMicrosecondsPerInvocation="8119" standardDeviationMicrosecondsPerInvocation="1064"/>
+      <ClassProfile name="edu.umd.cs.findbugs.detect.CalledMethods" totalMilliseconds="96" invocations="232" avgMicrosecondsPerInvocation="417" maxMicrosecondsPerInvocation="9079" standardDeviationMicrosecondsPerInvocation="1138"/>
+      <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.bcel.JavaClassAnalysisEngine" totalMilliseconds="81" invocations="294" avgMicrosecondsPerInvocation="278" maxMicrosecondsPerInvocation="19521" standardDeviationMicrosecondsPerInvocation="1327"/>
+      <ClassProfile name="edu.umd.cs.findbugs.detect.FunctionsThatMightBeMistakenForProcedures" totalMilliseconds="70" invocations="232" avgMicrosecondsPerInvocation="305" maxMicrosecondsPerInvocation="16789" standardDeviationMicrosecondsPerInvocation="1224"/>
+      <ClassProfile name="edu.umd.cs.findbugs.util.TopologicalSort" totalMilliseconds="70" invocations="940" avgMicrosecondsPerInvocation="75" maxMicrosecondsPerInvocation="2091" standardDeviationMicrosecondsPerInvocation="156"/>
+      <ClassProfile name="edu.umd.cs.findbugs.detect.BuildObligationPolicyDatabase" totalMilliseconds="56" invocations="232" avgMicrosecondsPerInvocation="244" maxMicrosecondsPerInvocation="4025" standardDeviationMicrosecondsPerInvocation="446"/>
     </FindBugsProfile>
   </FindBugsSummary>
   <ClassFeatures></ClassFeatures>

data/spec/spotbugs_spec.rb

@@ -58,7 +58,7 @@ module Danger
 
         spotbugs_issues = @spotbugs.report
         expect(spotbugs_issues).not_to be_nil
-        expect(spotbugs_issues.length).to be(7)
+        expect(spotbugs_issues.length).to be(10)
 
         spotbugs_issue1 = spotbugs_issues[0]
         expect(spotbugs_issue1.rank).to eq(6)
@@ -70,51 +70,75 @@ module Danger
 
         spotbugs_issue2 = spotbugs_issues[1]
         expect(spotbugs_issue2.rank).to eq(6)
-        expect(spotbugs_issue2.line).to eq(31)
+        expect(spotbugs_issue2.line).to eq(45)
         expect(spotbugs_issue2.type).to eq(:warn)
-        expect(spotbugs_issue2.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue2.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue2.description).to eq('Possible null pointer dereference of Tools$Helper.string in com.github.sample.tools.Tools$Helper.setText(TextView)')
+        expect(spotbugs_issue2.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue2.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue2.description).to eq('com.github.sample.model.Message.getProperties() may return null, but is declared @Nonnull')
 
         spotbugs_issue3 = spotbugs_issues[2]
-        expect(spotbugs_issue3.rank).to eq(8)
-        expect(spotbugs_issue3.line).to eq(32)
+        expect(spotbugs_issue3.rank).to eq(14)
+        expect(spotbugs_issue3.line).to eq(0)
         expect(spotbugs_issue3.type).to eq(:warn)
-        expect(spotbugs_issue3.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue3.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue3.description).to eq('Read of unwritten field title in com.github.sample.tools.Tools$Helper.setText(TextView)')
+        expect(spotbugs_issue3.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue3.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue3.description).to eq('Class com.github.sample.model.Message defines non-transient non-serializable instance field conversation')
 
         spotbugs_issue4 = spotbugs_issues[3]
-        expect(spotbugs_issue4.rank).to eq(18)
-        expect(spotbugs_issue4.line).to eq(23)
+        expect(spotbugs_issue4.rank).to eq(14)
+        expect(spotbugs_issue4.line).to eq(0)
         expect(spotbugs_issue4.type).to eq(:warn)
-        expect(spotbugs_issue4.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue4.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue4.description).to eq('Should com.github.sample.tools.Tools$Helper be a _static_ inner class?')
+        expect(spotbugs_issue4.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue4.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue4.description).to eq('Class com.github.sample.model.Message defines non-transient non-serializable instance field sender')
 
         spotbugs_issue5 = spotbugs_issues[4]
-        expect(spotbugs_issue5.rank).to eq(12)
-        expect(spotbugs_issue5.line).to eq(32)
+        expect(spotbugs_issue5.rank).to eq(6)
+        expect(spotbugs_issue5.line).to eq(31)
         expect(spotbugs_issue5.type).to eq(:warn)
         expect(spotbugs_issue5.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
         expect(spotbugs_issue5.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue5.description).to eq('Unwritten field: com.github.sample.tools.Tools$Helper.title')
+        expect(spotbugs_issue5.description).to eq('Possible null pointer dereference of Tools$Helper.string in com.github.sample.tools.Tools$Helper.setText(TextView)')
 
         spotbugs_issue6 = spotbugs_issues[5]
-        expect(spotbugs_issue6.rank).to eq(18)
-        expect(spotbugs_issue6.line).to eq(15)
+        expect(spotbugs_issue6.rank).to eq(8)
+        expect(spotbugs_issue6.line).to eq(32)
         expect(spotbugs_issue6.type).to eq(:warn)
         expect(spotbugs_issue6.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
         expect(spotbugs_issue6.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
-        expect(spotbugs_issue6.description).to eq('Should com.github.sample.tools.Tools$Other be a _static_ inner class?')
+        expect(spotbugs_issue6.description).to eq('Read of unwritten field title in com.github.sample.tools.Tools$Helper.setText(TextView)')
 
         spotbugs_issue7 = spotbugs_issues[6]
-        expect(spotbugs_issue7.rank).to eq(5)
-        expect(spotbugs_issue7.line).to eq(32)
+        expect(spotbugs_issue7.rank).to eq(18)
+        expect(spotbugs_issue7.line).to eq(23)
         expect(spotbugs_issue7.type).to eq(:warn)
-        expect(spotbugs_issue7.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/view/ConversationAdapter.java')
-        expect(spotbugs_issue7.relative_path).to eq('app/src/main/java/com/github/sample/view/ConversationAdapter.java')
-        expect(spotbugs_issue7.description).to eq('Bad comparison of nonnegative value with -1 in com.github.sample.view.ConversationAdapter.setConversations(ArrayList)')
+        expect(spotbugs_issue7.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
+        expect(spotbugs_issue7.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
+        expect(spotbugs_issue7.description).to eq('Should com.github.sample.tools.Tools$Helper be a _static_ inner class?')
+
+        spotbugs_issue8 = spotbugs_issues[7]
+        expect(spotbugs_issue8.rank).to eq(12)
+        expect(spotbugs_issue8.line).to eq(32)
+        expect(spotbugs_issue8.type).to eq(:warn)
+        expect(spotbugs_issue8.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
+        expect(spotbugs_issue8.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
+        expect(spotbugs_issue8.description).to eq('Unwritten field: com.github.sample.tools.Tools$Helper.title')
+
+        spotbugs_issue9 = spotbugs_issues[8]
+        expect(spotbugs_issue9.rank).to eq(18)
+        expect(spotbugs_issue9.line).to eq(15)
+        expect(spotbugs_issue9.type).to eq(:warn)
+        expect(spotbugs_issue9.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/tools/Tools.java')
+        expect(spotbugs_issue9.relative_path).to eq('app/src/main/java/com/github/sample/tools/Tools.java')
+        expect(spotbugs_issue9.description).to eq('Should com.github.sample.tools.Tools$Other be a _static_ inner class?')
+
+        spotbugs_issue10 = spotbugs_issues[9]
+        expect(spotbugs_issue10.rank).to eq(5)
+        expect(spotbugs_issue10.line).to eq(32)
+        expect(spotbugs_issue10.type).to eq(:warn)
+        expect(spotbugs_issue10.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/view/ConversationAdapter.java')
+        expect(spotbugs_issue10.relative_path).to eq('app/src/main/java/com/github/sample/view/ConversationAdapter.java')
+        expect(spotbugs_issue10.description).to eq('Bad comparison of nonnegative value with -1 in com.github.sample.view.ConversationAdapter.setConversations(ArrayList)')
       end
 
       it 'Report with report file not in target files' do
@@ -133,7 +157,7 @@ module Danger
 
         spotbugs_issues = @spotbugs.report
         expect(spotbugs_issues).not_to be_nil
-        expect(spotbugs_issues.length).to be(2)
+        expect(spotbugs_issues.length).to be(5)
 
         spotbugs_issue1 = spotbugs_issues[0]
         expect(spotbugs_issue1.rank).to eq(6)
@@ -144,12 +168,36 @@ module Danger
         expect(spotbugs_issue1.description).to eq('Possible null pointer dereference of MainActivity.conversationAdapter in com.github.sample.MainActivity.onCreate(Bundle)')
 
         spotbugs_issue2 = spotbugs_issues[1]
-        expect(spotbugs_issue2.rank).to eq(5)
-        expect(spotbugs_issue2.line).to eq(32)
+        expect(spotbugs_issue2.rank).to eq(6)
+        expect(spotbugs_issue2.line).to eq(45)
         expect(spotbugs_issue2.type).to eq(:warn)
-        expect(spotbugs_issue2.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/view/ConversationAdapter.java')
-        expect(spotbugs_issue2.relative_path).to eq('app/src/main/java/com/github/sample/view/ConversationAdapter.java')
-        expect(spotbugs_issue2.description).to eq('Bad comparison of nonnegative value with -1 in com.github.sample.view.ConversationAdapter.setConversations(ArrayList)')
+        expect(spotbugs_issue2.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue2.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue2.description).to eq('com.github.sample.model.Message.getProperties() may return null, but is declared @Nonnull')
+
+        spotbugs_issue3 = spotbugs_issues[2]
+        expect(spotbugs_issue3.rank).to eq(14)
+        expect(spotbugs_issue3.line).to eq(0)
+        expect(spotbugs_issue3.type).to eq(:warn)
+        expect(spotbugs_issue3.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue3.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue3.description).to eq('Class com.github.sample.model.Message defines non-transient non-serializable instance field conversation')
+
+        spotbugs_issue4 = spotbugs_issues[3]
+        expect(spotbugs_issue4.rank).to eq(14)
+        expect(spotbugs_issue4.line).to eq(0)
+        expect(spotbugs_issue4.type).to eq(:warn)
+        expect(spotbugs_issue4.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue4.relative_path).to eq('app/src/main/java/com/github/sample/model/Message.java')
+        expect(spotbugs_issue4.description).to eq('Class com.github.sample.model.Message defines non-transient non-serializable instance field sender')
+
+        spotbugs_issue5 = spotbugs_issues[4]
+        expect(spotbugs_issue5.rank).to eq(5)
+        expect(spotbugs_issue5.line).to eq(32)
+        expect(spotbugs_issue5.type).to eq(:warn)
+        expect(spotbugs_issue5.absolute_path).to eq('/Users/developer/project/sample/app/src/main/java/com/github/sample/view/ConversationAdapter.java')
+        expect(spotbugs_issue5.relative_path).to eq('app/src/main/java/com/github/sample/view/ConversationAdapter.java')
+        expect(spotbugs_issue5.description).to eq('Bad comparison of nonnegative value with -1 in com.github.sample.view.ConversationAdapter.setConversations(ArrayList)')
       end
 
       it 'Report without Gradle' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-spotbugs
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Mathieu Rul
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-06 00:00:00.000000000 Z
+date: 2021-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api