danger-spm_version_updates 0.0.4 → 0.1.1

data/README.md

@@ -2,21 +2,23 @@
 
 [![CI](https://github.com/hbmartin/danger-spm_version_updates/actions/workflows/lint_and_test.yml/badge.svg)](https://github.com/hbmartin/danger-spm_version_updates/actions/workflows/lint_and_test.yml)
 [![CodeFactor](https://www.codefactor.io/repository/github/hbmartin/danger-spm_version_updates/badge/main)](https://www.codefactor.io/repository/github/hbmartin/danger-spm_version_updates/overview/main)
-[![Gem Version](https://badge.fury.io/rb/danger-spm_version_updates.svg)](https://badge.fury.io/rb/danger-spm_version_updates)
-
+[![Gem Version](https://img.shields.io/gem/v/danger-spm_version_updates?color=D86149)](https://rubygems.org/gems/danger-spm_version_updates)
+[![codecov](https://codecov.io/gh/hbmartin/danger-spm_version_updates/graph/badge.svg?token=eXgUoWlvP7)](https://codecov.io/gh/hbmartin/danger-spm_version_updates)
+[![Documentation](https://img.shields.io/badge/Docs-3d3d41?logo=RubyGems)](https://hbmartin.github.io/danger-spm_version_updates/Danger/DangerSpmVersionUpdates.html)
+[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
 A [Danger](https://danger.systems/ruby/) plugin to detect if there are any updates to your Swift Package Manager dependencies.
 
-It is lightweight and does not require swift to be installed on the CI where it is run. 
+It's fast, lightweight, and does not require swift to be installed on the CI where it is run.
 
+Note that version 0.1.0 is the last version to support Ruby 2.7
 
 ## Installation
 
-    $ gem install danger-spm_version_updates
+`gem install danger-spm_version_updates`
 
 or add the following to your Gemfile:
 
-
 ```ruby
 gem "danger-spm_version_updates"
 ```
@@ -35,11 +37,14 @@ You can also configure custom behaviors:
 # Whether to check when dependencies are exact versions or commits, default false
 spm_version_updates.check_when_exact = true
 
-# Whether to ignore version above the maximum version range, default true
-spm_version_updates.quiet_above_maximum = false
+# Whether to report versions above the maximum version range, default false
+spm_version_updates.report_above_maximum = true
+
+# Whether to report pre-release versions, default false
+spm_version_updates.report_pre_releases = true
 
 # A list of repositories to ignore entirely, must exactly match the URL as configured in the Xcode project
-spm_version_updates.ignore_repositories = ["https://github.com/pointfreeco/swift-snapshot-testing"]
+spm_version_updates.ignore_repos = ["https://github.com/pointfreeco/swift-snapshot-testing"]
 ```
 
 ## Development
@@ -50,7 +55,33 @@ spm_version_updates.ignore_repositories = ["https://github.com/pointfreeco/swift
 4. Use `bundle exec guard` to automatically have tests run as you make changes.
 5. Make your changes.
 
-
 ## Authors
 
-* [Harold Martin](https://www.linkedin.com/in/harold-martin-98526971/) - harold.martin at gmail
+- [Harold Martin](https://www.linkedin.com/in/harold-martin-98526971/) - harold.martin at gmail
+
+## Legal
+
+Swift and the Swift logo are trademarks of Apple Inc.
+
+Copyright (c) 2023 Harold Martin <harold.martin@gmail.com>
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/Rakefile

@@ -9,6 +9,7 @@ RSpec::Core::RakeTask.new(:specs)
 
 task default: :specs
 
+desc "Run all test and lint tasks"
 task :spec do
   Rake::Task["specs"].invoke
   Rake::Task["rubocop"].invoke
@@ -19,6 +20,7 @@ desc "Run RuboCop on the lib/specs directory"
 RuboCop::RakeTask.new(:rubocop) { |task|
   task.requires << "rubocop-rspec"
   task.requires << "rubocop-rake"
+  task.requires << "rubocop-performance"
   task.patterns = ["lib/**/*.rb", "spec/**/*.rb"]
 }
 

data/danger-spm_version_updates.gemspec

@@ -13,34 +13,38 @@ Gem::Specification.new do |spec|
   spec.summary       = "A Danger plugin to detect if there are any updates to your Swift Package Manager dependencies."
   spec.homepage      = "https://github.com/hbmartin/danger-spm_version_updates"
   spec.license       = "MIT"
-  spec.required_ruby_version = ">= 2.7"
+  spec.required_ruby_version = ">= 3.0"
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.add_runtime_dependency("danger-plugin-api", "~> 1.0")
   spec.add_runtime_dependency("semantic", "~> 1.6")
-  spec.add_runtime_dependency("xcodeproj", "~> 1.23")
+  spec.add_runtime_dependency("xcodeproj", "~> 1.24")
 
   # General ruby development
   spec.add_development_dependency("bundler", "~> 2.0")
   spec.add_development_dependency("rake", "~> 13.0")
 
   # Testing support
-  spec.add_development_dependency("rspec", "~> 3.4")
+  spec.add_development_dependency("rspec", "~> 3.9")
+  spec.add_development_dependency("simplecov", "~> 0.22")
+  spec.add_development_dependency("simplecov-cobertura", "~> 2.1")
 
   # Linting code and docs
   spec.add_development_dependency("reek")
-  spec.add_development_dependency("rubocop")
+  spec.add_development_dependency("rubocop", "~> 1.62")
+  spec.add_development_dependency("rubocop-performance")
   spec.add_development_dependency("rubocop-rake")
   spec.add_development_dependency("rubocop-rspec")
-  spec.add_development_dependency("yard")
+  spec.add_development_dependency("yard", "~> 0.9.36")
 
   # Makes testing easy via `bundle exec guard`
-  spec.add_development_dependency("guard", "~> 2.14")
+  spec.add_development_dependency("guard", "~> 2.16")
   spec.add_development_dependency("guard-rspec", "~> 4.7")
+  spec.add_development_dependency("guard-rubocop", "~> 1.2")
 
   # If you want to work on older builds of ruby
   spec.add_development_dependency("listen", "3.0.7")

data/lib/spm_version_updates/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SpmVersionUpdates
-  VERSION = "0.0.4"
+  VERSION = "0.1.1"
 end

data/lib/spm_version_updates/plugin.rb

@@ -6,7 +6,7 @@ require "xcodeproj"
 module Danger
   # A plugin for checking if there are versions upgrades available for SPM packages
   #
-  # @example Ensure people are well warned about merging on Mondays
+  # @example Check if MyApp's SPM dependencies are up to date
   #
   #          spm_version_updates.check_for_updates("MyApp.xcodeproj")
   #
@@ -18,9 +18,9 @@ module Danger
     # @return   [Boolean]
     attr_accessor :check_when_exact
 
-    # Whether to ignore versions above the maximum version range, default true
+    # Whether to report versions above the maximum version range, default false
     # @return   [Boolean]
-    attr_accessor :quiet_above_maximum
+    attr_accessor :report_above_maximum
 
     # Whether to report pre-release versions, default false
     # @return   [Boolean]
@@ -35,16 +35,8 @@ module Danger
     #          The path to your Xcode project
     # @return   [void]
     def check_for_updates(xcodeproj_path)
-      raise(XcodeprojPathMustBeSet) if xcodeproj_path.nil?
-
-      project = Xcodeproj::Project.open(xcodeproj_path)
-      remote_packages = filter_remote_packages(project)
-
-      resolved_path = find_packages_resolved(xcodeproj_path)
-      raise(CouldNotFindResolvedFile) unless File.exist?(resolved_path)
-
-      resolved_versions = JSON.load_file!(resolved_path)["pins"]
-        .to_h { |pin| [pin["location"], pin["state"]["version"] || pin["state"]["revision"]] }
+      remote_packages = get_remote_package(xcodeproj_path)
+      resolved_versions = get_resolved_versions(xcodeproj_path)
 
       remote_packages.each { |repository_url, requirement|
         next if ignore_repos&.include?(repository_url)
@@ -55,9 +47,10 @@ module Danger
 
         # kind can be major, minor, range, exact, branch, or commit
 
-        if kind == "branch" && check_when_exact
-          last_commit = git_branch_last_commit(repository_url, requirement["branch"])
-          warn("Newer commit available for #{name}: #{last_commit}") unless last_commit == resolved_version
+        if kind == "branch"
+          branch = requirement["branch"]
+          last_commit = git_branch_last_commit(repository_url, branch)
+          warn("Newer commit available for #{name} (#{branch}): #{last_commit}") unless last_commit == resolved_version
           next
         end
 
@@ -65,24 +58,39 @@ module Danger
         next if available_versions.first.to_s == resolved_version
 
         if kind == "exactVersion" && @check_when_exact
-          newestVersion = available_versions.find { |version|
-            report_pre_releases ? true : version.pre.nil?
-          }
-          warn(
-            <<-TEXT
-Newer version of #{name}: #{newestVersion} (but this package is set to exact version #{resolved_version})
-            TEXT
-          ) unless newestVersion.to_s == resolved_version
+          warn_for_new_versions_exact(available_versions, name, resolved_version)
         elsif kind == "upToNextMajorVersion"
           warn_for_new_versions(:major, available_versions, name, resolved_version)
         elsif kind == "upToNextMinorVersion"
           warn_for_new_versions(:minor, available_versions, name, resolved_version)
-        elsif kind == "range"
+        elsif kind == "versionRange"
           warn_for_new_versions_range(available_versions, name, requirement, resolved_version)
         end
       }
     end
 
+    # Extracts remote packages from an Xcode project
+    # @param   [String] xcodeproj_path
+    #          The path to your Xcode project
+    # @return [Hash<String, Hash>]
+    def get_remote_package(xcodeproj_path)
+      raise(XcodeprojPathMustBeSet) if xcodeproj_path.nil?
+
+      filter_remote_packages(Xcodeproj::Project.open(xcodeproj_path))
+    end
+
+    # Extracts resolved versions from Package.resolved relative to an Xcode project
+    # @param   [String] xcodeproj_path
+    #          The path to your Xcode project
+    # @return [Hash<String, String>]
+    def get_resolved_versions(xcodeproj_path)
+      resolved_path = find_packages_resolved_file(xcodeproj_path)
+      raise(CouldNotFindResolvedFile) unless File.exist?(resolved_path)
+
+      JSON.load_file!(resolved_path)["pins"]
+        .to_h { |pin| [pin["location"], pin["state"]["version"] || pin["state"]["revision"]] }
+    end
+
     # Extract a readable name for the repo given the url, generally org/repo
     # @return [String]
     def repo_name(repo_url)
@@ -107,7 +115,7 @@ Newer version of #{name}: #{newestVersion} (but this package is set to exact ver
 
     # Find the Packages.resolved file
     # @return [String]
-    def find_packages_resolved(xcodeproj_path)
+    def find_packages_resolved_file(xcodeproj_path)
       if Dir.exist?(xcodeproj_path.sub("xcodeproj", "xcworkspace"))
         File.join(xcodeproj_path.sub("xcodeproj", "xcworkspace"), "xcshareddata", "swiftpm", "Package.resolved")
       else
@@ -117,44 +125,57 @@ Newer version of #{name}: #{newestVersion} (but this package is set to exact ver
 
     private
 
+    def warn_for_new_versions_exact(available_versions, name, resolved_version)
+      newest_version = available_versions.find { |version|
+        report_pre_releases ? true : version.pre.nil?
+      }
+      warn(
+        <<-TEXT
+Newer version of #{name}: #{newest_version} (but this package is set to exact version #{resolved_version})
+        TEXT
+      ) unless newest_version.to_s == resolved_version
+    end
+
     def warn_for_new_versions_range(available_versions, name, requirement, resolved_version)
       max_version = Semantic::Version.new(requirement["maximumVersion"])
       if available_versions.first < max_version
         warn("Newer version of #{name}: #{available_versions.first}")
       else
         newest_meeting_reqs = available_versions.find { |version|
-          version < max_version && report_pre_releases ? true : version.pre.nil?
+          version < max_version && (report_pre_releases ? true : version.pre.nil?)
         }
-        warn("Newer version of #{name}: #{newest_meeting_reqs} ") unless newest_meeting_reqs.to_s == resolved_version
+        warn("Newer version of #{name}: #{newest_meeting_reqs}") unless newest_meeting_reqs.to_s == resolved_version
         warn(
           <<-TEXT
 Newest version of #{name}: #{available_versions.first} (but this package is configured up to the next #{max_version} version)
           TEXT
-        ) unless quiet_above_maximum
+        ) if report_above_maximum
       end
     end
 
     def warn_for_new_versions(major_or_minor, available_versions, name, resolved_version_string)
       resolved_version = Semantic::Version.new(resolved_version_string)
-      if available_versions.first.send(major_or_minor) == resolved_version.send(major_or_minor)
-        warn("Newer version of #{name}: #{available_versions.first}")
-      else
-        newest_meeting_reqs = available_versions.find { |version|
-          puts version
-          puts version.pre.nil?
-          version.send(major_or_minor) == resolved_version.send(major_or_minor) && report_pre_releases ? true : version.pre.nil?
-        }
-        warn("Newer version of #{name}: #{newest_meeting_reqs}") unless newest_meeting_reqs == resolved_version
-        warn(
-          <<-TEXT
+      newest_meeting_reqs = available_versions.find { |version|
+        (version.send(major_or_minor) == resolved_version.send(major_or_minor)) && (report_pre_releases ? true : version.pre.nil?)
+      }
+
+      warn("Newer version of #{name}: #{newest_meeting_reqs}") unless newest_meeting_reqs == resolved_version
+      return unless report_above_maximum
+
+      newest_above_reqs = available_versions.find { |version|
+        report_pre_releases ? true : version.pre.nil?
+      }
+      warn(
+        <<-TEXT
 Newest version of #{name}: #{available_versions.first} (but this package is configured up to the next #{major_or_minor} version)
-          TEXT
-        ) unless quiet_above_maximum
-      end
+        TEXT
+      ) unless newest_above_reqs == newest_meeting_reqs || newest_meeting_reqs.to_s == resolved_version
     end
 
+    # Remove git call to list tags
+    # @return [Array<Semantic::Version>]
     def git_versions(repo_url)
-      `git ls-remote -t #{repo_url}`
+      versions = `git ls-remote -t #{repo_url}`
         .split("\n")
         .map { |line| line.split("/tags/").last }
         .filter_map { |line|
@@ -164,8 +185,9 @@ Newest version of #{name}: #{available_versions.first} (but this package is conf
             nil
           end
         }
-        .sort
-        .reverse
+      versions.sort!
+      versions.reverse!
+      versions
     end
 
     def git_branch_last_commit(repo_url, branch_name)

data/spec/spec_helper.rb

@@ -11,12 +11,6 @@ require "pry"
 require "danger"
 require "rspec"
 
-if `git remote -v` == ""
-  puts "You cannot run tests without setting a local git remote on this repo"
-  puts "It's a weird side-effect of Danger's internals."
-  exit(0)
-end
-
 # Use coloured output, it's the best.
 RSpec.configure do |config|
   config.filter_gems_from_backtrace("bundler")

data/spec/spm_version_updates_spec.rb

@@ -1,5 +1,11 @@
 # frozen_string_literal: true
 
+require "simplecov"
+SimpleCov.start
+
+require "simplecov-cobertura"
+SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter
+
 require File.expand_path("spec_helper", __dir__)
 
 module Danger
@@ -8,9 +14,6 @@ module Danger
       expect(described_class.new(nil)).to be_a Danger::Plugin
     end
 
-    #
-    # You should test your custom attributes and methods here
-    #
     describe "with Dangerfile" do
       before do
         @dangerfile = testing_dangerfile
@@ -22,55 +25,47 @@ module Danger
         allow(@my_plugin.github).to receive(:pr_json).and_return(json)
       end
 
-      it "Reports none without exact version matching" do
-        allow(@my_plugin).to receive(:git_versions).and_return false
+      it "Does not report pre-release versions by default" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.2.0-beta.1"),
+            Semantic::Version.new("12.2.0-beta.2"),
+          ].sort.reverse
 
-        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/Example.xcodeproj")
+        @my_plugin.check_when_exact = true
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/ExactVersion.xcodeproj")
 
         expect(@dangerfile.status_report[:warnings]).to eq([])
       end
 
-      it "Reports some with exact version matching" do
-        # TODO: mock git calls
-        allow(@my_plugin).to receive(:git_versions).and_return false
+      it "Does report new versions for exact versions when configured" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.1.7"),
+          ].sort.reverse
 
         @my_plugin.check_when_exact = true
-        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/Example.xcodeproj")
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/ExactVersion.xcodeproj")
 
         expect(@dangerfile.status_report[:warnings]).to eq(
           [
-            "Newer version of pointfreeco/swift-snapshot-testing: 1.14.2 (but this package is set to exact version 1.13.0)\n",
-            "Newer version of kean/Nuke: 12.2.0-beta.2 (but this package is set to exact version 12.1.6)\n",
-            "Newer version of pointfreeco/swiftui-navigation: 1.0.3 (but this package is set to exact version 1.0.2)\n",
-            "Newer version of getsentry/sentry-cocoa: 8.15.0 (but this package is set to exact version 8.12.0)\n",
-            "Newer version of firebase/firebase-ios-sdk: 10.17.0 (but this package is set to exact version 10.15.0)\n",
+            "Newer version of kean/Nuke: 12.1.7 (but this package is set to exact version 12.1.6)\n",
           ]
         )
       end
 
-      it "Does not report pre-release versions by default" do
-        allow(@my_plugin).to receive(:git_versions).and_return [
-Semantic::Version.new("12.0.0"),
-Semantic::Version.new("12.0.0-beta.1"),
-Semantic::Version.new("12.0.0-beta.2"),
-Semantic::Version.new("12.0.0-beta.3"),
-Semantic::Version.new("12.0.0-beta.4"),
-Semantic::Version.new("12.0.0-beta.5"),
-Semantic::Version.new("12.0.0-rc.1"),
-Semantic::Version.new("12.1.0"),
-Semantic::Version.new("12.1.1"),
-Semantic::Version.new("12.1.2"),
-Semantic::Version.new("12.1.3"),
-Semantic::Version.new("12.1.4"),
-Semantic::Version.new("12.1.5"),
-Semantic::Version.new("12.1.6"),
-Semantic::Version.new("12.2.0-beta.1"),
-Semantic::Version.new("12.2.0-beta.2"),
-]
-                                                                 .sort
-                                                                 .reverse
+      it "Does report pre-release versions for exact versions when configured" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.2.0-beta.2"),
+          ].sort.reverse
+
         @my_plugin.check_when_exact = true
-        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/HasPreRelease.xcodeproj")
+        @my_plugin.report_pre_releases = true
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/ExactVersion.xcodeproj")
 
         expect(@dangerfile.status_report[:warnings]).to eq(
           [
@@ -78,6 +73,108 @@ Semantic::Version.new("12.2.0-beta.2"),
           ]
         )
       end
+
+      it "Does report new versions for up to next major" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.1.7"),
+          ].sort.reverse
+
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/UpToNextMajor.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq(
+          [
+            "Newer version of kean/Nuke: 12.1.7",
+          ]
+        )
+      end
+
+      it "Reports pre-release versions for up to next major when configured" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.2.0-beta.2"),
+          ].sort.reverse
+
+        @my_plugin.check_when_exact = true
+        @my_plugin.report_pre_releases = true
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/UpToNextMajor.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq(
+          [
+            "Newer version of kean/Nuke: 12.2.0-beta.2",
+          ]
+        )
+      end
+
+      it "Does not report pre-release versions for up to next major" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.2.0-beta.2"),
+            Semantic::Version.new("13.0.0"),
+          ].sort.reverse
+
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/UpToNextMajor.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq([])
+      end
+
+      it "Does not report new versions for up to next major when next version is major" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("13.0.0"),
+          ].sort.reverse
+
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/UpToNextMajor.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq([])
+      end
+
+      it "Does report new versions for up to next major when next version is major and configured" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("13.0.0"),
+          ].sort.reverse
+
+        @my_plugin.report_above_maximum = true
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/UpToNextMajor.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq(["Newest version of kean/Nuke: 13.0.0 (but this package is configured up to the next major version)\n"])
+      end
+
+      it "Does report new versions for ranges" do
+        allow(@my_plugin).to receive(:git_versions)
+          .and_return [
+            Semantic::Version.new("13.0.0"),
+            Semantic::Version.new("12.1.6"),
+            Semantic::Version.new("12.1.7"),
+          ].sort.reverse
+
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/VersionRange.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq(
+          [
+            "Newer version of kean/Nuke: 12.1.7",
+          ]
+        )
+      end
+
+      it "Does report new versions for branches" do
+        allow(@my_plugin).to receive(:git_branch_last_commit)
+          .and_return "d658f302f56abfd7a163e3b5f44de39b780a64c2"
+
+        @my_plugin.check_for_updates("#{File.dirname(__FILE__)}/support/fixtures/Branch.xcodeproj")
+
+        expect(@dangerfile.status_report[:warnings]).to eq(
+          [
+            "Newer commit available for kean/Nuke (main): d658f302f56abfd7a163e3b5f44de39b780a64c2",
+          ]
+        )
+      end
     end
   end
 end

data/spec/support/fixtures/Branch.xcodeproj/project.pbxproj

@@ -0,0 +1,80 @@
+// !$*UTF8*$!
+{
+	archiveVersion = 1;
+	classes = {
+	};
+	objectVersion = 54;
+	objects = {
+/* Begin PBXGroup section */
+		F1465EF423AA94BF0055F7C3 = {
+			isa = PBXGroup;
+			children = (
+				F1465EFF23AA94BF0055F7C3 /* Demo */,
+			);
+			sourceTree = "<group>";
+		};
+		F1465EFF23AA94BF0055F7C3 /* Demo */ = {
+			isa = PBXGroup;
+			children = ();
+			path = Demo;
+			sourceTree = "<group>";
+		};
+/* End PBXGroup section */
+
+/* Begin PBXProject section */
+		F1465EF523AA94BF0055F7C3 /* Project object */ = {
+			isa = PBXProject;
+			attributes = {
+				BuildIndependentTargetsInParallel = YES;
+				LastSwiftUpdateCheck = 1420;
+				LastUpgradeCheck = 1420;
+				TargetAttributes = {
+					F1465EFC23AA94BF0055F7C3 = {
+						CreatedOnToolsVersion = 11.2.1;
+					};
+				};
+			};
+			buildConfigurationList = F1465EF823AA94BF0055F7C3 /* Build configuration list for PBXProject "Demo" */;
+			compatibilityVersion = "Xcode 9.3";
+			developmentRegion = en;
+			hasScannedForEncodings = 0;
+			knownRegions = (
+				en,
+				Base,
+				es,
+				"zh-Hans",
+				fr,
+			);
+			mainGroup = F1465EF423AA94BF0055F7C3;
+			packageReferences = (
+				11BBD37629C1571400F7A968 /* XCRemoteSwiftPackageReference "Nuke" */,
+			);
+			productRefGroup = F1465EFE23AA94BF0055F7C3 /* Products */;
+			projectDirPath = "";
+			projectRoot = "";
+			targets = ();
+		};
+/* End PBXProject section */
+
+/* Begin XCConfigurationList section */
+		F1465EF823AA94BF0055F7C3 /* Build configuration list for PBXNativeTarget "Demo" */ = {
+			isa = XCConfigurationList;
+			buildConfigurations = ();
+			defaultConfigurationIsVisible = 0;
+			defaultConfigurationName = Release;
+		};
+/* End XCConfigurationList section */
+
+/* Begin XCRemoteSwiftPackageReference section */
+		11BBD37629C1571400F7A968 /* XCRemoteSwiftPackageReference "Nuke" */ = {
+			isa = XCRemoteSwiftPackageReference;
+			repositoryURL = "https://github.com/kean/Nuke";
+			requirement = {
+				branch = main;
+				kind = branch;
+			};
+		};
+/* End XCRemoteSwiftPackageReference section */
+	};
+	rootObject = F1465EF523AA94BF0055F7C3 /* Project object */;
+}