danger-spec_postfix 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15c7d8c52818ceb68184f56d5cd1ec453d54b074d31b002861ec124fc2bf09d0
-  data.tar.gz: be8b28379ac2001acc446ca49481c70ea3e812aba5dc0c1bb3213cfe7f863ec4
+  metadata.gz: 7e736b77f25af05815d0056f34d6f08cf661b778d2eff55666bdec6aa3609943
+  data.tar.gz: 91597c48664c538ff8610390155d172013a6fe49f00016a8fed348e12b72312e
 SHA512:
-  metadata.gz: e8129452944e17e50dd6821a47ec71adf77b9796cd896c5a9eb86540838dcb37586c0dd80961a5bf7a7cb95632a31799b0d393c6d996a9b89e1813d6114372a8
-  data.tar.gz: 2ba88f4ccc36da3eff3902f2e0c85bb72899b331ca5dbf4d9d88b74518a41679cbf2f4071bc6395f348a558c957723e46e0ef412bdcfcc10cc697a9641a82ae1
+  metadata.gz: 99ea9aed38ed6d1439fdcd1abb4bfa18a83a5ee04a049a94c6286d7e6f7b45a0a11a0fbc51e24ffe3182aedd5e1d9e190eccd4394e875cbbbad469ccaf91e36b
+  data.tar.gz: 073f9ad0dabe33fc140126b7091d8caf63695235e8ba5125bc6f867e6d073d6a7bcd4371d4352fba7d986a790c6dd48b3c8ba0c7c89392b9fcaa758956491fbf

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-spec_postfix (0.0.1)
+    danger-spec_postfix (0.0.2)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -96,7 +96,7 @@ GEM
       rb-inotify (>= 0.9.7)
     lumberjack (1.2.8)
     method_source (1.0.0)
-    minitest (5.16.3)
+    minitest (5.17.0)
     multipart-post (2.2.3)
     nap (1.1.0)
     nenv (0.3.0)
@@ -132,7 +132,7 @@ GEM
     rspec-expectations (3.12.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.2)
+    rspec-mocks (3.12.3)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)

data/danger-spec_postfix.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/rambler-digital-solutions/danger-spec_postfix'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']

data/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SpecPostfix
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/lib/spec_postfix/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SpecPostfix
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/lib/spec_postfix/plugin.rb

@@ -2,37 +2,39 @@
 
 require 'active_support/configurable'
 
+# Adding plugin
 module Danger
-  # Check that all test files in spec/ folder have `_spec` postfix.
-  # Results are passed out as a string with warning.
-  #
-  # @example Running linter
-  #
-  #          # Runs a linter
-  #          spec_postfix.lint
-  #
-  class DangerSpecPostfix < Plugin
-    # Lints the test files. Will fail if any has no '_spec' postfix.
-    # Generates a `string` with warning.
-    #
-    # @param   [String] files
-    #          A globbed string which should return the files that you want to lint, defaults to nil.
-    #          if nil, modified and added files from the diff will be used.
-    # @return  [void]
-    #
-    def self.configuration
-      @configuration ||= Configuration.new
-    end
+  def self.configuration
+    @configuration ||= Configuration.new
+  end
+
+  def self.configure
+    yield configuration
+  end
+
+  # Adding opportunity to maintain exceptions list for plugin.
+  class Configuration
+    include ::ActiveSupport::Configurable
 
-    def self.configure
-      yield configuration
+    config_accessor(:spec_postfix_exceptions) do
+      ['spec/shared_examples/', 'spec/factories/', 'spec/support/', 'spec/rails_helper.rb', 'spec/spec_helper.rb']
     end
+  end
 
+  # Lints the test files. Will fail if any has no '_spec' postfix.
+  # Generates a `string` with warning.
+  #
+  # @param   [String] files
+  #          A globbed string which should return the files that you want to lint, defaults to nil.
+  #          if nil, modified and added files from the diff will be used.
+  # @return  [void]
+  #
+  class DangerSpecPostfix < Plugin
     def lint
       changed_files.select { |f| f.match?(%r{^spec/.*rb$}) }
-        .reject { |f| f.end_with?('_spec.rb') }
-        .reject { |f| DangerSpecPostfix.configuration.exceptions.any? { |e| f.start_with?(e) } }
-        .each   { |f| warn(warning_generator(f)) }
+                   .reject { |f| f.end_with?('_spec.rb') }
+                   .reject { |f| Danger.configuration.spec_postfix_exceptions.any? { |e| f.start_with?(e) } }
+                   .each   { |f| warn(warning_generator(f)) }
     end
 
     private
@@ -45,10 +47,4 @@ module Danger
       "Tests should have `_spec` postfix: #{file}"
     end
   end
-
-  class DangerSpecPostfix::Configuration
-    include ::ActiveSupport::Configurable
-
-    config_accessor(:exceptions) { ['spec/shared_examples/', 'spec/factories/', 'spec/support/', 'spec/rails_helper.rb', 'spec/spec_helper.rb'] }
-  end
 end

data/plugin.rb

@@ -30,9 +30,9 @@ module Danger
 
     def lint
       changed_files.select { |f| f.match?(%r{^spec/.*rb$}) }
-        .reject { |f| f.end_with?('_spec.rb') }
-        .reject { |f| DangerSpecPostfix.configuration.exceptions.any? { |e| f.start_with?(e) } }
-        .each   { |f| warn(warning_generator(f)) }
+                   .reject { |f| f.end_with?('_spec.rb') }
+                   .reject { |f| DangerSpecPostfix.configuration.exceptions.any? { |e| f.start_with?(e) } }
+                   .each   { |f| warn(warning_generator(f)) }
     end
 
     private
@@ -46,9 +46,13 @@ module Danger
     end
   end
 
-  class DangerSpecPostfix::Configuration
-    include ::ActiveSupport::Configurable
+  class DangerSpecPostfix
+    class Configuration
+      include ::ActiveSupport::Configurable
 
-    config_accessor(:exceptions) { ['spec/shared_examples/', 'spec/factories/', 'spec/support/', 'spec/rails_helper.rb', 'spec/spec_helper.rb'] }
+      config_accessor(:exceptions) do
+        ['spec/shared_examples/', 'spec/factories/', 'spec/support/', 'spec/rails_helper.rb', 'spec/spec_helper.rb']
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -2,8 +2,8 @@
 
 require 'pathname'
 ROOT = Pathname.new(File.expand_path('..', __dir__))
-$:.unshift("#{ROOT}lib")
-$:.unshift("#{ROOT}spec")
+$LOAD_PATH.unshift("#{ROOT}lib")
+$LOAD_PATH.unshift("#{ROOT}spec")
 
 require 'bundler/setup'
 require 'pry'

data/spec/spec_postfix_spec.rb

@@ -37,8 +37,8 @@ module Danger
 
       context 'when is irrelevant (exceptions)' do
         before do
-          described_class.configure do |config|
-            config.exceptions = 'not_tests/'
+          Danger.configure do |config|
+            config.spec_postfix_exceptions = 'not_tests/'
           end
         end
 

data/spec_helper.rb

@@ -2,8 +2,8 @@
 
 require 'pathname'
 ROOT = Pathname.new(File.expand_path('..', __dir__))
-$:.unshift("#{ROOT}lib")
-$:.unshift("#{ROOT}spec")
+$LOAD_PATH.unshift("#{ROOT}lib")
+$LOAD_PATH.unshift("#{ROOT}spec")
 
 require 'bundler/setup'
 require 'pry'

data/spec_postfix/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SpecPostfix
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/spec_postfix/plugin.rb

@@ -30,9 +30,9 @@ module Danger
 
     def lint
       changed_files.select { |f| f.match?(%r{^spec/.*rb$}) }
-        .reject { |f| f.end_with?('_spec.rb') }
-        .reject { |f| DangerSpecPostfix.configuration.exceptions.any? { |e| f.start_with?(e) } }
-        .each   { |f| warn(warning_generator(f)) }
+                   .reject { |f| f.end_with?('_spec.rb') }
+                   .reject { |f| DangerSpecPostfix.configuration.exceptions.any? { |e| f.start_with?(e) } }
+                   .each   { |f| warn(warning_generator(f)) }
     end
 
     private
@@ -46,9 +46,13 @@ module Danger
     end
   end
 
-  class DangerSpecPostfix::Configuration
-    include ::ActiveSupport::Configurable
+  class DangerSpecPostfix
+    class Configuration
+      include ::ActiveSupport::Configurable
 
-    config_accessor(:exceptions) { ['spec/shared_examples/', 'spec/factories/', 'spec/support/', 'spec/rails_helper.rb', 'spec/spec_helper.rb'] }
+      config_accessor(:exceptions) do
+        ['spec/shared_examples/', 'spec/factories/', 'spec/support/', 'spec/rails_helper.rb', 'spec/spec_helper.rb']
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-spec_postfix
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Igor Udalov