danger-samsao 0.2.0 → 0.3.0

data/spec/samsao_feature_jira_issue_number_spec.rb

@@ -0,0 +1,72 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'check feature branch jira issue number' do
+        it 'continues on trivial change' do
+          allow(@plugin).to receive(:trivial_change?).and_return(true)
+
+          @plugin.check_feature_jira_issue_number
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues on fix branch' do
+          allow(@plugin).to receive(:trivial_change?).and_return(false)
+          allow(@plugin).to receive(:feature_branch?).and_return(false)
+
+          @plugin.check_feature_jira_issue_number
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails on missing jira project key' do
+          allow(@plugin).to receive(:trivial_change?).and_return(false)
+          allow(@plugin).to receive(:feature_branch?).and_return(true)
+
+          @plugin.check_feature_jira_issue_number
+
+          expect(@dangerfile).to have_error('Your Danger config is missing a `jira_project_key` value.')
+        end
+
+        it 'continue on branch with issue number' do
+          jira_project_key = 'VER'
+
+          @plugin.config do
+            jira_project_key jira_project_key
+          end
+
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.github).to receive(:pr_title).and_return("[#{jira_project_key}-123] Title")
+
+          @plugin.check_feature_jira_issue_number
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails on branch with no issue number' do
+          jira_project_key = 'VER'
+          message = 'The PR must starts with JIRA issue number between square brackets'\
+                    " (i.e. [#{jira_project_key}-XXX])."
+
+          @plugin.config do
+            jira_project_key jira_project_key
+          end
+
+          allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
+          allow(@plugin.github).to receive(:pr_title).and_return('Title')
+
+          @plugin.check_feature_jira_issue_number
+
+          expect(@dangerfile).to have_error(message)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_feature_single_commit_spec.rb

@@ -14,7 +14,7 @@ module Danger
           allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
           allow(@plugin.git).to receive(:commits).and_return(['sha1'])
 
-          @plugin.fail_when_non_single_commit_feature
+          @plugin.check_non_single_commit_feature
 
           expect(@dangerfile).to have_no_error
         end
@@ -23,7 +23,7 @@ module Danger
           allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
           allow(@plugin.git).to receive(:commits).and_return(['sha1', 'sha2'])
 
-          @plugin.fail_when_non_single_commit_feature
+          @plugin.check_non_single_commit_feature
 
           expect(@dangerfile).to have_no_error
         end
@@ -32,7 +32,7 @@ module Danger
           allow(@plugin.github).to receive(:branch_for_head).and_return('feature/a')
           allow(@plugin.git).to receive(:commits).and_return(['sha1', 'sha2'])
 
-          @plugin.fail_when_non_single_commit_feature
+          @plugin.check_non_single_commit_feature
 
           expect(@dangerfile).to have_error(@must_have_single_commit)
         end

data/spec/samsao_fix_jira_issue_number_spec.rb

@@ -0,0 +1,82 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'check fix branch jira issue number' do
+        it 'continues on trivial change' do
+          allow(@plugin).to receive(:trivial_change?).and_return(true)
+
+          @plugin.check_fix_jira_issue_number
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'continues on feature branch' do
+          allow(@plugin).to receive(:trivial_change?).and_return(false)
+          allow(@plugin).to receive(:fix_branch?).and_return(false)
+
+          @plugin.check_fix_jira_issue_number
+
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails on missing jira project key' do
+          allow(@plugin).to receive(:trivial_change?).and_return(false)
+          allow(@plugin).to receive(:fix_branch?).and_return(true)
+
+          @plugin.check_fix_jira_issue_number
+
+          expect(@dangerfile).to have_error('Your Danger config is missing a `jira_project_key` value.')
+        end
+
+        it 'fails on commit with no issue number' do
+          jira_project_key = 'VER'
+          commit_message = 'Bad message'
+          commit_sha = '48ffffb'
+          commit_id = "#{commit_sha} ('#{commit_message}')"
+
+          @plugin.config do
+            jira_project_key jira_project_key
+          end
+
+          allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
+          allow(@plugin.github).to receive(:pr_title).and_return('Title')
+          allow(@plugin.git).to receive(:commits).and_return([commit(commit_message, commit_sha)])
+
+          @plugin.check_fix_jira_issue_number
+
+          message = "The commit #{commit_id} should contain JIRA issue number between square brackets"\
+                    " (i.e. [#{jira_project_key}-XXX]), multiple allowed (i.e. [#{jira_project_key}-XXX,"\
+                    " #{jira_project_key}-YYY, #{jira_project_key}-ZZZ])"
+
+          expect(@dangerfile).to have_warning(message)
+        end
+
+        it 'continue on multiple commits with issue number' do
+          jira_project_key = 'VER'
+
+          first_commit = commit("[#{jira_project_key}-123]", '48ffffb')
+          second_commit = commit("[#{jira_project_key}-124, #{jira_project_key}-125]", '48ffffb')
+
+          @plugin.config do
+            jira_project_key jira_project_key
+          end
+
+          allow(@plugin.github).to receive(:branch_for_head).and_return('fix/a')
+          allow(@plugin.github).to receive(:pr_title).and_return('Title')
+          allow(@plugin.git).to receive(:commits).and_return([first_commit, second_commit])
+
+          @plugin.check_fix_jira_issue_number
+
+          expect(@dangerfile).to have_no_warning
+        end
+      end
+    end
+  end
+end

data/spec/samsao_jira_project_key_spec.rb

@@ -0,0 +1,37 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'jira_project_key? helper' do
+        it "doesn't have project key" do
+          expect(@plugin.jira_project_key?).to eq(false)
+        end
+
+        it 'has jira project key' do
+          jira_project_key = 'VER'
+
+          @plugin.config do
+            jira_project_key jira_project_key
+          end
+
+          expect(@plugin.jira_project_key?).to eq(true)
+        end
+
+        it 'has invalid jira project key' do
+          jira_project_key = '123'
+          message = "Jira project key '#{jira_project_key}' is invalid, must be uppercase and"\
+                    ' between 1 and 10 characters'
+
+          expect { @plugin.config { jira_project_key jira_project_key } }.to raise_error(message)
+          expect(@plugin.jira_project_key?).to eq(false)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_label_pr_spec.rb

@@ -0,0 +1,51 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @message = 'The PR should have at least one label added to it.'
+      end
+
+      describe 'check labels PR' do
+        it 'continues if pr has labels' do
+          allow(@plugin.github).to receive(:pr_labels).and_return(['web', 'mobile', 'backend'])
+
+          @plugin.check_label_pr
+
+          expect(@dangerfile).to have_no_warning
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails if labels missing' do
+          allow(@plugin.github).to receive(:pr_labels).and_return([])
+
+          @plugin.check_label_pr
+
+          expect(@dangerfile).to have_error(@message)
+          expect(@dangerfile).to have_no_warning
+        end
+
+        it 'warns if report level specified' do
+          allow(@plugin.github).to receive(:pr_labels).and_return([])
+
+          @plugin.check_label_pr :warn
+
+          expect(@dangerfile).to have_warning(@message)
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'fails if labels is nil' do
+          allow(@plugin.github).to receive(:pr_labels).and_return(nil)
+
+          @plugin.check_label_pr
+
+          expect(@dangerfile).to have_error(@message)
+          expect(@dangerfile).to have_no_warning
+        end
+      end
+    end
+  end
+end

data/spec/samsao_merge_commit_detected_spec.rb

@@ -15,7 +15,7 @@ module Danger
         it 'continues when no commits' do
           allow(@plugin.git).to receive(:commits).and_return([])
 
-          @plugin.fail_when_merge_commit_detected
+          @plugin.check_merge_commit_detected
 
           expect(@dangerfile).to have_no_error
         end
@@ -26,7 +26,7 @@ module Danger
             commit('two'),
           ])
 
-          @plugin.fail_when_merge_commit_detected
+          @plugin.check_merge_commit_detected
 
           expect(@dangerfile).to have_no_error
         end
@@ -37,7 +37,7 @@ module Danger
             commit("Merge branch 'develop'"),
           ])
 
-          @plugin.fail_when_merge_commit_detected
+          @plugin.check_merge_commit_detected
 
           expect(@dangerfile).to have_error(@merge_commits_detected)
         end
@@ -48,7 +48,7 @@ module Danger
             commit("Merge branch 'develop'"),
           ])
 
-          @plugin.fail_when_merge_commit_detected
+          @plugin.check_merge_commit_detected
 
           expect(@dangerfile).to have_error(@merge_commits_detected)
         end
@@ -59,23 +59,11 @@ module Danger
             commit("Merge branch 'test'"),
           ])
 
-          @plugin.fail_when_merge_commit_detected
+          @plugin.check_merge_commit_detected
 
           expect(@dangerfile).to have_error(@merge_commits_detected)
         end
       end
-
-      def commit(message)
-        Commit.new(message)
-      end
-
-      class Commit
-        attr_reader :message
-
-        def initialize(message)
-          @message = message
-        end
-      end
     end
   end
 end

data/spec/samsao_report_spec.rb

@@ -0,0 +1,45 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+        @content = 'Message'
+      end
+
+      describe 'report' do
+        it 'send fail' do
+          @plugin.report(:fail, @content)
+          expect(@dangerfile).to have_error(@content)
+          expect(@dangerfile).to have_no_warning
+          expect(@dangerfile).to have_no_message
+        end
+
+        it 'send warn' do
+          @plugin.report(:warn, @content)
+          expect(@dangerfile).to have_warning(@content)
+          expect(@dangerfile).to have_no_error
+          expect(@dangerfile).to have_no_message
+        end
+
+        it 'send message' do
+          @plugin.report(:message, @content)
+          expect(@dangerfile).to have_message(@content)
+          expect(@dangerfile).to have_no_warning
+          expect(@dangerfile).to have_no_error
+        end
+
+        it 'send unknown level' do
+          level = 'unknown'
+          error = "Report level '#{level}' is invalid."
+          expect { @plugin.report(level, @content) }.to raise_error(error)
+          expect(@dangerfile).to have_no_warning
+          expect(@dangerfile).to have_no_error
+          expect(@dangerfile).to have_no_message
+        end
+      end
+    end
+  end
+end

data/spec/samsao_shorten_sha_spec.rb

@@ -0,0 +1,26 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'shorten sha helper' do
+        it 'shorten short string' do
+          expect(@plugin.shorten_sha('1234')).to eq('1234')
+        end
+
+        it 'shorten long string' do
+          expect(@plugin.shorten_sha('1234567890')).to eq('12345678')
+        end
+
+        it 'shorten nil string' do
+          expect(@plugin.shorten_sha(nil)).to eq(nil)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_truncate_spec.rb

@@ -0,0 +1,36 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerSamsao do
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @plugin = @dangerfile.samsao
+      end
+
+      describe 'truncate helper' do
+        it 'truncate short string' do
+          expect(@plugin.truncate('1234')).to eq('1234')
+        end
+
+        it 'truncate long string' do
+          actual = 'abcdefghijklmnopqrstuvwxyz1234567890'
+          expected = 'abcdefghijklmnopqrstuvwxyz1234'
+
+          expect(@plugin.truncate(actual)).to eq(expected)
+        end
+
+        it 'truncate nil string' do
+          expect(@plugin.truncate(nil)).to eq(nil)
+        end
+
+        it 'truncate custom length string' do
+          actual = 'abcdefghijklmnopqrstuvwxyz1234567890'
+          expected = 'abcde'
+
+          expect(@plugin.truncate(actual, 5)).to eq(expected)
+        end
+      end
+    end
+  end
+end

data/spec/samsao_work_in_progress_pr_spec.rb

@@ -16,7 +16,7 @@ module Danger
         it 'warns when PR title contains [WIP] at the end' do
           allow(@plugin.github).to receive(:pr_title).and_return('Marker at the end [WIP]')
 
-          @plugin.warn_when_work_in_progess_pr
+          @plugin.check_work_in_progess_pr
 
           expect(@dangerfile).to have_warning(@work_in_progress)
         end
@@ -24,7 +24,7 @@ module Danger
         it 'warns when PR title contains [WIP] at the start' do
           allow(@plugin.github).to receive(:pr_title).and_return('[WIP] Marker at start')
 
-          @plugin.warn_when_work_in_progess_pr
+          @plugin.check_work_in_progess_pr
 
           expect(@dangerfile).to have_warning(@work_in_progress)
         end
@@ -32,7 +32,7 @@ module Danger
         it 'warns when PR title contains [WIP] in the middle' do
           allow(@plugin.github).to receive(:pr_title).and_return('Marker in [WIP] the middle')
 
-          @plugin.warn_when_work_in_progess_pr
+          @plugin.check_work_in_progess_pr
 
           expect(@dangerfile).to have_warning(@work_in_progress)
         end
@@ -40,7 +40,7 @@ module Danger
         it 'continues when PR title does not contain [WIP] marker' do
           allow(@plugin.github).to receive(:pr_title).and_return('A WIP PR')
 
-          @plugin.warn_when_work_in_progess_pr
+          @plugin.check_work_in_progess_pr
 
           expect(@dangerfile).to have_no_warning
         end

data/spec/spec_helper.rb

@@ -54,3 +54,18 @@ def testing_dangerfile
 
   Danger::Dangerfile.new(env, testing_ui)
 end
+
+# A commit class to create test
+def commit(message, sha = nil)
+  Commit.new(message, sha)
+end
+
+class Commit
+  attr_reader :message
+  attr_reader :sha
+
+  def initialize(message, sha)
+    @message = message
+    @sha = sha
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-samsao
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Samsao Development Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-09 00:00:00.000000000 Z
+date: 2017-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -161,6 +161,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- ".travis/danger.sh"
 - CHANGELOG.md
 - Dangerfile
 - Gemfile
@@ -169,8 +170,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bitrise.wrapper.yml
-- bitrise.yml
 - danger-samsao.gemspec
 - lib/danger_plugin.rb
 - lib/danger_samsao.rb
@@ -181,20 +180,30 @@ files:
 - lib/samsao/plugin.rb
 - lib/samsao/regexp.rb
 - spec/matchers/have_error.rb
+- spec/matchers/have_message.rb
 - spec/matchers/have_no_error.rb
+- spec/matchers/have_no_message.rb
 - spec/matchers/have_no_warning.rb
 - spec/matchers/have_warning.rb
+- spec/samsao_acceptance_criteria_spec.rb
 - spec/samsao_branch_helper_spec.rb
 - spec/samsao_branching_model_spec.rb
 - spec/samsao_changelog_modified_spec.rb
 - spec/samsao_changelog_updated_spec.rb
 - spec/samsao_config_spec.rb
+- spec/samsao_feature_jira_issue_number_spec.rb
 - spec/samsao_feature_single_commit_spec.rb
+- spec/samsao_fix_jira_issue_number_spec.rb
 - spec/samsao_has_app_changes_spec.rb
+- spec/samsao_jira_project_key_spec.rb
+- spec/samsao_label_pr_spec.rb
 - spec/samsao_merge_commit_detected_spec.rb
 - spec/samsao_regexp_spec.rb
+- spec/samsao_report_spec.rb
+- spec/samsao_shorten_sha_spec.rb
 - spec/samsao_spec.rb
 - spec/samsao_trivial_change_spec.rb
+- spec/samsao_truncate_spec.rb
 - spec/samsao_work_in_progress_pr_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/samsao/danger-samsao
@@ -217,25 +226,35 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A longer description of danger-samsao.
 test_files:
 - spec/matchers/have_error.rb
+- spec/matchers/have_message.rb
 - spec/matchers/have_no_error.rb
+- spec/matchers/have_no_message.rb
 - spec/matchers/have_no_warning.rb
 - spec/matchers/have_warning.rb
+- spec/samsao_acceptance_criteria_spec.rb
 - spec/samsao_branch_helper_spec.rb
 - spec/samsao_branching_model_spec.rb
 - spec/samsao_changelog_modified_spec.rb
 - spec/samsao_changelog_updated_spec.rb
 - spec/samsao_config_spec.rb
+- spec/samsao_feature_jira_issue_number_spec.rb
 - spec/samsao_feature_single_commit_spec.rb
+- spec/samsao_fix_jira_issue_number_spec.rb
 - spec/samsao_has_app_changes_spec.rb
+- spec/samsao_jira_project_key_spec.rb
+- spec/samsao_label_pr_spec.rb
 - spec/samsao_merge_commit_detected_spec.rb
 - spec/samsao_regexp_spec.rb
+- spec/samsao_report_spec.rb
+- spec/samsao_shorten_sha_spec.rb
 - spec/samsao_spec.rb
 - spec/samsao_trivial_change_spec.rb
+- spec/samsao_truncate_spec.rb
 - spec/samsao_work_in_progress_pr_spec.rb
 - spec/spec_helper.rb

data/bitrise.wrapper.yml

@@ -1,51 +0,0 @@
----
-format_version: 1.4.0
-default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git
-description: |-
-  This wrapper is configure in bitrise.io editor as the script to run. What it
-  does mainly is to simply clone the repository and forward the execution of the
-  workflow to the real build file (bitrise.yml) which is hosted in this repository.
-
-  To work, main workflow here must also be present in bitrise.yml, so main workflows
-  must be kept synchronized between the two.
-
-  Also, any change made to this file must be **manually** added to bitrise.io editor.
-  Simply copy/paste the content of this file into the web editor and press save.
-
-  To test locally using bitrise CLI, while at project root directory, simply do:
-
-    bitrise run <workflow> -c bitrise.wrapper.yml
-
-  See http://devcenter.bitrise.io/tips-and-tricks/use-bitrise-yml-from-repository/
-  for details on the technique.
-
-trigger_map:
-  - push_branch: "develop"
-    workflow: "develop"
-  - pull_request_target_branch: "*"
-    pull_request_source_branch: "*"
-    workflow: "pr"
-
-workflows:
-  _run_from_repo:
-    steps:
-    - activate-ssh-key@3.1.1:
-        title: Activate SSH credentials
-        run_if: '{{getenv "SSH_RSA_PRIVATE_KEY" | ne ""}}'
-    - git-clone@3.4.2:
-        title: Clone repository
-    - script@1.1.3:
-        title: Continue using repository bitrise.yml
-        inputs:
-        - content: |-
-            #!/bin/bash
-            set -ex
-            bitrise run "${BITRISE_TRIGGERED_WORKFLOW_ID}"
-
-  develop:
-    after_run:
-    - _run_from_repo
-
-  pr:
-    after_run:
-    - _run_from_repo