danger-rubocop 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 123e71c280e842bce2f03b4b6057a4e838a5337b
-  data.tar.gz: 896db4ec175e20179a7b4b23d6be8b2d01426953
+  metadata.gz: c59cd45d4ce8230e467669d6b3a3ffdfe3c1e7f9
+  data.tar.gz: f151f971948bba931f159166bc01cc4ad00d21c6
 SHA512:
-  metadata.gz: 3ee6a09ae722401c210e4cbf2c3d5ba825bfbcd16bcf533ab8c596d752d983ae9ffe2067cb04605fcaf361b7d3576563b60880cb8d09844b4fb87fe34999fa7f
-  data.tar.gz: 8248e12f7f623e3382807fd69210f14833f0e9878196fca099101c21dc93fb63d4f074f47c579090626d70add350a24d10d08149f740303786b0ee4c3fc33268
+  metadata.gz: e10b05bfaf61a28f2d36208ca1bd1136fcad1106b8114586fc8cfc6e5a2282782fe9a30a07e962a12df3856791bdab2eb340a818e5689b1a372fedc468c35b5e
+  data.tar.gz: f742ec5a40f95ad439a01d9026216ca14643fd3ffec8b2f836c792f7e83da7939fbf3c10e0aca42f83cf08f46a8622b4041b493815066d0293752db21c5c1feb

data/README.md

@@ -43,6 +43,7 @@ The following keys are supported:
 * `files`: array of file names or glob patterns to determine files to lint
 * `force_exclusion`: pass `true` to pass `--force-exclusion` argument to Rubocop.
 * `inline_comment`: pass `true` to comment inline of the diffs.
+* `report_danger`: pass true to report errors to Danger, and break CI.
   
   (this option will instruct rubocop to ignore the files that your rubocop config ignores,
   despite the plugin providing the list of files explicitely)

data/lib/danger_plugin.rb

@@ -30,18 +30,22 @@ module Danger
       config = config.is_a?(Hash) ? config : { files: config }
       files = config[:files]
       force_exclusion = config[:force_exclusion] || false
+
+      report_danger = config[:report_danger] || false
       inline_comment = config[:inline_comment] || false
 
       files_to_lint = fetch_files_to_lint(files)
       files_to_report = rubocop(files_to_lint, force_exclusion)
 
       return if files_to_report.empty?
+      return report_failures files_to_report if report_danger
 
       if inline_comment
         warn_each_line(files_to_report)
       else
         markdown offenses_message(files_to_report)
       end
+
     end
 
     private
@@ -52,6 +56,8 @@ module Danger
 
       rubocop_output = `#{'bundle exec ' if File.exist?('Gemfile')}#{base_command} #{files_to_lint}`
 
+      return [] if rubocop_output.empty?
+
       JSON.parse(rubocop_output)['files']
         .select { |f| f['offenses'].any? }
     end
@@ -72,6 +78,14 @@ module Danger
       message + table.split("\n")[1..-2].join("\n")
     end
 
+    def report_failures(offending_files)
+      offending_files.each do |file|
+        file['offenses'].each do |offense|
+          fail "#{file['path']} | #{offense['location']['line']} | #{offense['message']}"
+        end
+      end
+    end
+
     def warn_each_line(offending_files)
       offending_files.flat_map do |file|
         file['offenses'].map do |offense|

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerRubocop
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/spec/danger_plugin_spec.rb

@@ -127,6 +127,7 @@ module Danger
 | spec/fixtures/ruby_file.rb | 13   | Don't do that! |
 EOS
           expect(@rubocop.status_report[:markdowns].first.message).to eq(formatted_table.chomp)
+          expect(@rubocop).not_to receive(:fail)
         end
 
         it 'is reported as line by line' do
@@ -157,6 +158,21 @@ EOS
             expect { @rubocop.lint }.not_to raise_error
           end
         end
+
+        describe 'report to danger' do
+          let(:fail_msg) { %{spec/fixtures/ruby_file.rb | 13 | Don't do that!} }
+          it 'reports to danger' do
+            allow(@rubocop.git).to receive(:modified_files)
+              .and_return(['spec/fixtures/ruby_file.rb'])
+            allow(@rubocop.git).to receive(:added_files).and_return([])
+            allow(@rubocop).to receive(:`)
+              .with('bundle exec rubocop -f json spec/fixtures/ruby_file.rb')
+              .and_return(response_ruby_file)
+
+            expect(@rubocop).to receive(:fail).with(fail_msg)
+            @rubocop.lint(report_danger: true)
+          end
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Ash Furrow
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-15 00:00:00.000000000 Z
+date: 2017-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger