danger-rubocop 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2a006c7c8dafc7fa51b8fe5aff38764b20502b4c
-  data.tar.gz: be9b290a729911dc21cc8a947ac75f22c739f800
+  metadata.gz: 123e71c280e842bce2f03b4b6057a4e838a5337b
+  data.tar.gz: 896db4ec175e20179a7b4b23d6be8b2d01426953
 SHA512:
-  metadata.gz: cba8556356a8f29cf276cd88a0ce8e4ddd31870b0a6056bab8e0295a84a922e174b40fb636c2bd7381baf742f6111e46fc5cb2f7d4821d38dceff8db5bc6756c
-  data.tar.gz: 2e691ab029fa2145137dd7bdde399595ae8a2f6c7fde332f1d028cc1ad71c4b24cb84409e2d378a2401e30fced437c803dbb9fcecfaeba61f2963e16f848c510
+  metadata.gz: 3ee6a09ae722401c210e4cbf2c3d5ba825bfbcd16bcf533ab8c596d752d983ae9ffe2067cb04605fcaf361b7d3576563b60880cb8d09844b4fb87fe34999fa7f
+  data.tar.gz: 8248e12f7f623e3382807fd69210f14833f0e9878196fca099101c21dc93fb63d4f074f47c579090626d70add350a24d10d08149f740303786b0ee4c3fc33268

data/README.md

@@ -33,12 +33,21 @@ rubocop.lint public_files
 
 #### Methods
 
+`lint(config: Hash)`
 
-`lint(files: String)`
+Runs Ruby files through Rubocop. Generates a `markdown` list of warnings.
 
- Runs Ruby files through Rubocop. Generates a `markdown` list of warnings.
+This method accepts configuration hash.
+The following keys are supported:
 
+* `files`: array of file names or glob patterns to determine files to lint
+* `force_exclusion`: pass `true` to pass `--force-exclusion` argument to Rubocop.
+* `inline_comment`: pass `true` to comment inline of the diffs.
+  
+  (this option will instruct rubocop to ignore the files that your rubocop config ignores,
+  despite the plugin providing the list of files explicitely)
 
+Passing `files` as only argument is also supported for backward compatibility.
 
 ## License
 

data/lib/danger_plugin.rb

@@ -30,13 +30,18 @@ module Danger
       config = config.is_a?(Hash) ? config : { files: config }
       files = config[:files]
       force_exclusion = config[:force_exclusion] || false
+      inline_comment = config[:inline_comment] || false
 
       files_to_lint = fetch_files_to_lint(files)
       files_to_report = rubocop(files_to_lint, force_exclusion)
 
       return if files_to_report.empty?
 
-      markdown offenses_message(files_to_report)
+      if inline_comment
+        warn_each_line(files_to_report)
+      else
+        markdown offenses_message(files_to_report)
+      end
     end
 
     private
@@ -67,6 +72,14 @@ module Danger
       message + table.split("\n")[1..-2].join("\n")
     end
 
+    def warn_each_line(offending_files)
+      offending_files.flat_map do |file|
+        file['offenses'].map do |offense|
+          warn(offense['message'], file: file['path'], line: offense['location']['line'])
+        end
+      end
+    end
+
     def fetch_files_to_lint(files = nil)
       to_lint = (files ? Dir.glob(files) : (git.modified_files + git.added_files))
       Shellwords.join(to_lint)

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerRubocop
-  VERSION = '0.4.1'.freeze
+  VERSION = '0.5.0'.freeze
 end

data/spec/danger_plugin_spec.rb

@@ -129,6 +129,20 @@ EOS
           expect(@rubocop.status_report[:markdowns].first.message).to eq(formatted_table.chomp)
         end
 
+        it 'is reported as line by line' do
+          allow(@rubocop.git).to receive(:modified_files)
+            .and_return(['spec/fixtures/ruby_file.rb'])
+          allow(@rubocop.git).to receive(:added_files).and_return([])
+          allow(@rubocop).to receive(:`)
+            .with('bundle exec rubocop -f json spec/fixtures/ruby_file.rb')
+            .and_return(response_ruby_file)
+
+          @rubocop.lint(inline_comment: true)
+
+          expect(@rubocop.violation_report[:warnings].first.to_s)
+            .to eq("Violation Don't do that! { sticky: false, file: spec/fixtures/ruby_file.rb, line: 13 }")
+        end
+
         describe 'a filename with special characters' do
           it 'is shell escaped' do
             modified_files = [

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Ash Furrow
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-19 00:00:00.000000000 Z
+date: 2017-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger