danger-rubocop 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e91901b79a6155f5d70feebbbd301fad023ea8a8fd4a37e8f04fe413d3859326
-  data.tar.gz: 469efcdadad9b126197d88d0d0aeaa51497a3542f1e6bb0d66977d8d195facde
+  metadata.gz: 7a25805f10b9265549f39e7efb812f9b940d317727b031a8546aaa34e87a6f57
+  data.tar.gz: 553e742ad2d0780f441a0bb443bcc24b18afd2d26a78fec7cb92b9f7b5abafe1
 SHA512:
-  metadata.gz: d40eb3980c2456134e43cd12c0bb2dc7c0c2fce9739e8585a489c6db364f1c38a08e1576b16359a1da71e628ffe308b70b98ae58e5a2fbff38e2f679fff53cc5
-  data.tar.gz: a4d1dd07e6fa2f08498675ae3d1bef2faca730506cdbeb895b3c2586e8f28fb638bff4af95b2816faff68d7086a8f9da08abaebf743302588480e2e6ec9f881f
+  metadata.gz: df8c319c5b617f7ee5e2698e0db2d2610eeac3007dc3b5d183261295608aaba1805ae496f3b70897a7570bc79f222ed8be6f1af6859d3a0b5d2f6090377a297c
+  data.tar.gz: 8611653f86ad51b236dd4f4b7104e4776c8748d30cfdbc47f70bad2e82580aff9e46b8b8726ccfd1261f48e719ac3459b123871864ca0ddda5ff87e86d5a06d2

data/Gemfile.lock

@@ -8,8 +8,8 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.7.0)
-      public_suffix (>= 2.0.2, < 5.0)
+    addressable (2.8.1)
+      public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
     bacon (1.2.0)
     claide (1.0.3)
@@ -99,7 +99,7 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.6)
+    public_suffix (5.0.0)
     rainbow (3.0.0)
     rake (13.0.3)
     rb-fsevent (0.10.4)

data/README.md

@@ -58,6 +58,7 @@ The following keys are supported:
   despite the plugin providing the list of files explicitly)
 * `inline_comment`: pass `true` to comment inline of the diffs.
 * `fail_on_inline_comment`: pass `true` to use `fail` instead of `warn` on inline comment.
+* `report_severity`: pass `true` to use `fail` or `warn` based on Rubocop severity.
 * `report_danger`: pass true to report errors to Danger, and break CI.
 * `config`: path to the `.rubocop.yml` file.
 * `only_report_new_offenses`: pass `true` to only report offenses that are in current user's scope.

data/lib/danger_plugin.rb

@@ -35,6 +35,7 @@ module Danger
       only_report_new_offenses = config[:only_report_new_offenses] || false
       inline_comment = config[:inline_comment] || false
       fail_on_inline_comment = config[:fail_on_inline_comment] || false
+      report_severity = config[:report_severity] || false
       include_cop_names = config[:include_cop_names] || false
       rubocop_cmd = config[:rubocop_cmd] || 'rubocop'
 
@@ -45,7 +46,7 @@ module Danger
       return report_failures files_to_report if report_danger
 
       if inline_comment
-        add_violation_for_each_line(files_to_report, fail_on_inline_comment, include_cop_names: include_cop_names)
+        add_violation_for_each_line(files_to_report, fail_on_inline_comment, report_severity, include_cop_names: include_cop_names)
       else
         markdown offenses_message(files_to_report, include_cop_names: include_cop_names)
       end
@@ -124,7 +125,7 @@ module Danger
       end
     end
 
-    def add_violation_for_each_line(offending_files, fail_on_inline_comment, include_cop_names: false)
+    def add_violation_for_each_line(offending_files, fail_on_inline_comment, report_severity, include_cop_names: false)
       offending_files.flat_map do |file|
         file['offenses'].map do |offense|
           offense_message = offense['message']
@@ -135,6 +136,8 @@ module Danger
           }
           if fail_on_inline_comment
             fail(offense_message, **kargs)
+          elsif report_severity && %w[error fatal].include?(offense['severity'])
+            fail(offense_message, **kargs)
           else
             warn(offense_message, **kargs)
           end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module DangerRubocop
-  VERSION = '0.10.0'.freeze
+  VERSION = '0.11.0'.freeze
 end

data/spec/danger_plugin_spec.rb

@@ -149,6 +149,7 @@ module Danger
                   {
                     'cop_name' => 'Syntax/WhetherYouShouldDoThat',
                     'message' => "Don't do that!",
+                    'severity' => 'warning',
                     'location' => { 'line' => 13 }
                   }
                 ]
@@ -166,6 +167,7 @@ module Danger
                   {
                     'cop_name' => 'Syntax/WhetherYouShouldDoThat',
                     'message' => "Don't do that!",
+                    'severity' => 'error',
                     'location' => { 'line' => 23 }
                   }
                 ]
@@ -313,6 +315,44 @@ EOS
             end
           end
 
+          context 'with report_severity option' do
+            context 'file with error' do
+              it 'reports violations by rubocop severity' do
+                allow(@rubocop.git).to receive(:added_files).and_return([])
+                allow(@rubocop.git).to receive(:modified_files)
+                  .and_return(["spec/fixtures/another_ruby_file.rb"])
+                allow(@rubocop.git).to receive(:renamed_files).and_return([])
+
+                allow(@rubocop).to receive(:`)
+                  .with('bundle exec rubocop -f json --only-recognized-file-types spec/fixtures/another_ruby_file.rb')
+                  .and_return(response_another_ruby_file)
+
+                @rubocop.lint(report_severity: true, inline_comment: true)
+
+                expect(@rubocop.violation_report[:errors].first.to_s)
+                  .to eq("Violation Don't do that! { sticky: false, file: spec/fixtures/another_ruby_file.rb, line: 23, type: error }")
+              end
+            end
+
+            context 'file with warning' do
+              it 'reports violations by rubocop severity' do
+                allow(@rubocop.git).to receive(:added_files).and_return([])
+                allow(@rubocop.git).to receive(:modified_files)
+                  .and_return(["spec/fixtures/ruby_file.rb"])
+                allow(@rubocop.git).to receive(:renamed_files).and_return([])
+
+                allow(@rubocop).to receive(:`)
+                  .with('bundle exec rubocop -f json --only-recognized-file-types spec/fixtures/ruby_file.rb')
+                  .and_return(response_ruby_file)
+
+                @rubocop.lint(report_severity: true, inline_comment: true)
+
+                expect(@rubocop.violation_report[:warnings].first.to_s)
+                  .to eq("Violation Don't do that! { sticky: false, file: spec/fixtures/ruby_file.rb, line: 13, type: warning }")
+              end
+            end
+          end
+
           context 'using standardrb cmd' do
             it 'executes using the standardrb cmd' do
               allow(@rubocop).to receive(:`)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Ash Furrow
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-08 00:00:00.000000000 Z
+date: 2023-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -192,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.1
+rubygems_version: 3.3.13
 signing_key:
 specification_version: 4
 summary: A Danger plugin for running Ruby files through Rubocop.