danger-rubocop 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 1515e5372954585820a9828937bbe1e1a8ca0470
+  data.tar.gz: 6f22b296591432eb9c56b6b051b79a562be4be14
+SHA512:
+  metadata.gz: 4de4b1c3f7c5a1c9251f0df992510fceecfbe7aba0488ba47d8b4a714ca7bf9b58a4f97ec83f7b283619dada7975ba8ec2939cdea5e6d4b8c3d91a51198d6e87
+  data.tar.gz: 9d3bd307bbefd545498b37b8cacae97427b55a6b7e90e09d8d46c451bebc4fd813cca090e8682e4adbcb8cfca5157357f99c5b674c3eafea98a80cff0eb9570a

data/.gitignore

@@ -0,0 +1,50 @@
+*.gem
+*.rbc
+/.config
+/coverage/
+/InstalledFiles
+/pkg/
+/spec/reports/
+/spec/examples.txt
+/test/tmp/
+/test/version_tmp/
+/tmp/
+
+# Used by dotenv library to load environment variables.
+# .env
+
+## Specific to RubyMotion:
+.dat*
+.repl_history
+build/
+*.bridgesupport
+build-iPhoneOS/
+build-iPhoneSimulator/
+
+## Specific to RubyMotion (use of CocoaPods):
+#
+# We recommend against adding the Pods directory to your .gitignore. However
+# you should judge for yourself, the pros and cons are mentioned at:
+# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
+#
+# vendor/Pods/
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/
+
+## Environment normalization:
+/.bundle/
+/vendor/bundle
+/lib/bundler/man/
+
+# for a library or gem, you might want to ignore these files since the code is
+# intended to run in multiple environments; otherwise, check them in:
+# Gemfile.lock
+# .ruby-version
+# .ruby-gemset
+
+# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
+.rvmrc

data/Gemfile

@@ -0,0 +1,12 @@
+source 'https://rubygems.org'
+
+ruby '2.2.5'
+
+gemspec
+
+group :development do
+  gem 'mocha'
+  gem 'bacon'
+  gem 'mocha-on-bacon'
+  gem 'prettybacon'
+end

data/Gemfile.lock

@@ -0,0 +1,127 @@
+PATH
+  remote: .
+  specs:
+    danger-rubocop (0.0.1)
+      danger
+      rubocop
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.4.0)
+    ast (2.3.0)
+    bacon (1.2.0)
+    claide (1.0.0)
+    coderay (1.1.1)
+    colored (1.2)
+    cork (0.1.0)
+      colored (~> 1.2)
+    danger (0.8.3)
+      claide (~> 1.0)
+      colored (~> 1.2)
+      cork (~> 0.1)
+      faraday (~> 0)
+      git (~> 1)
+      octokit (~> 4.2)
+      redcarpet (~> 3.3)
+      terminal-table (~> 1)
+    diff-lcs (1.2.5)
+    faraday (0.9.2)
+      multipart-post (>= 1.2, < 3)
+    ffi (1.9.10)
+    formatador (0.2.5)
+    git (1.3.0)
+    guard (2.14.0)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.2)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    listen (3.0.7)
+      rb-fsevent (>= 0.9.3)
+      rb-inotify (>= 0.9.7)
+    lumberjack (1.0.10)
+    metaclass (0.0.4)
+    method_source (0.8.2)
+    mocha (1.1.0)
+      metaclass (~> 0.0.1)
+    mocha-on-bacon (0.2.2)
+      mocha (>= 0.13.0)
+    multipart-post (2.0.0)
+    nenv (0.3.0)
+    notiffany (0.1.0)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    octokit (4.3.0)
+      sawyer (~> 0.7.0, >= 0.5.3)
+    parser (2.3.1.2)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    prettybacon (0.0.2)
+      bacon (~> 1.2)
+    pry (0.10.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rainbow (2.1.0)
+    rake (10.5.0)
+    rb-fsevent (0.9.7)
+    rb-inotify (0.9.7)
+      ffi (>= 0.5.0)
+    redcarpet (3.3.4)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.4)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    rubocop (0.41.1)
+      parser (>= 2.3.1.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    sawyer (0.7.0)
+      addressable (>= 2.3.5, < 2.5)
+      faraday (~> 0.8, < 0.10)
+    shellany (0.0.1)
+    slop (3.6.0)
+    terminal-table (1.6.0)
+    thor (0.19.1)
+    unicode-display_width (1.1.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bacon
+  bundler (~> 1.3)
+  danger-rubocop!
+  guard (~> 2.14)
+  guard-rspec (~> 4.7)
+  listen (= 3.0.7)
+  mocha
+  mocha-on-bacon
+  prettybacon
+  pry
+  rake (~> 10.0)
+  rspec (~> 3.4)
+
+BUNDLED WITH
+   1.12.5

data/Guardfile

@@ -0,0 +1,21 @@
+# A guardfile for making Danger Plugins
+# For more info see https://github.com/guard/guard#readme
+
+# To run, use `bundle exec guard`.
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/LICENSE

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2016 Ash Furrow
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -0,0 +1,36 @@
+[![CircleCI](https://circleci.com/gh/ashfurrow/danger-rubocop.svg?style=svg)](https://circleci.com/gh/ashfurrow/danger-rubocop)
+
+# Danger Rubocop
+
+A [Danger](https://github.com/danger/danger) plugin for [Rubocop](https://github.com/bbatsov/rubocop).
+
+## Installation
+
+Add this line to your Gemfile:
+
+```rb
+gem 'danger-rubocop'
+```
+
+## Usage
+
+The easiest way to use is just add this to your Dangerfile:
+
+```rb
+rubocop.run
+```
+
+That will lint any changed or added Ruby files in the PR.
+
+You can also provide a list of files manually:
+
+```rb
+# Look through all changed Markdown files
+rb_files = (modified_files + added_files).select { |f| f.end_with?(".rb") }
+
+rubocop.run rb_files
+```
+
+## License
+
+MIT

data/Rakefile

@@ -0,0 +1,13 @@
+require 'bundler/gem_tasks'
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec
+
+task :spec do
+  Rake::Task['specs'].invoke
+end
+
+task :default => :spec
+

data/danger-rubocop.gemspec

@@ -0,0 +1,43 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'version'
+
+Gem::Specification.new do |spec|
+  spec.name          = 'danger-rubocop'
+  spec.version       = DangerRubocop::VERSION
+  spec.authors       = ['Ash Furrow']
+  spec.email         = ['ash@ashfurrow.com']
+  spec.description   = %q{A Danger plugin for running Ruby files through Rubocop.}
+  spec.summary       = %q{A Danger plugin for running Ruby files through Rubocop.}
+  spec.homepage      = 'https://github.com/ashfurrow/danger-rubocop'
+  spec.license       = 'MIT'
+
+  spec.files         = `git ls-files`.split($/)
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ['lib']
+
+  spec.add_dependency 'danger'
+  spec.add_dependency 'rubocop'
+
+  # General ruby development
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake', '~> 10.0'
+
+  #  Testing support
+  spec.add_development_dependency "rspec", '~> 3.4'
+
+  # Makes testing easy via `bundle exec guard`
+  spec.add_development_dependency "guard", '~> 2.14'
+  spec.add_development_dependency "guard-rspec", '~> 4.7'
+  
+  # If you want to work on older builds of ruby
+  spec.add_development_dependency "listen", '3.0.7'
+
+  # This gives you the chance to run a REPL inside your test
+  # via 
+  #    binding.pry
+  # This will stop test execution and let you inspect the results
+  spec.add_development_dependency "pry"
+
+end

data/lib/danger_plugin.rb

@@ -0,0 +1,44 @@
+module Danger
+
+  # Run Ruby files through Rubocop.
+  # Results are passed out as a table in markdown.
+  #
+  # @example Specifying custom config file.
+  #
+  #          rubocop.run
+  #
+  # @see  Moya/Aeryn
+  # @tags ruby, rubocop, linter
+  #
+  class DangerRubocop < Plugin
+
+    # Runs Ruby files through Rubocop. Generates a `markdown` list of warnings. 
+    #
+    # @param   [String] files
+    #          A globbed string which should return the files that you want to 
+    #          run through, defaults to nil. If nil, modified and added files 
+    #          from the diff will be used.
+    # @return  [void]
+    #
+    def run(files=nil)
+      files_to_lint = files ? Dir.glob(files) : (modified_files + added_files)
+      files_to_lint.select! { |f| f.end_with? 'rb' }
+      rubocop_results = files_to_lint.map { |f| JSON.parse(`bundle exec rubocop -f json #{f}`)['files'] }.flatten
+      offending_files = rubocop_results.select { |f| f['offenses'].count > 0 }
+
+      return if offending_files.empty?
+
+      message = '### Rubocop violations'
+      message << 'File | Line | Reason |\n'
+      message << '| --- | ----- | ----- |\n'  
+
+      offending_files.each do |f|
+        f['offenses'].each do |o|
+          message << "#{f['path']} | #{o['location']['line']} | #{o['message']} \n"
+        end
+      end
+
+      markdown message
+    end
+  end
+end

data/lib/version.rb

@@ -0,0 +1,3 @@
+module DangerRubocop
+  VERSION = "0.1.0".freeze
+end

data/spec/danger_plugin_spec.rb

@@ -0,0 +1,62 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe DangerRubocop do
+    it 'is a plugin' do
+      expect(Danger::DangerRubocop < Danger::Plugin).to be_truthy
+    end
+    
+    describe 'with Dangerfile' do
+      before do
+        @dangerfile = testing_dangerfile
+        @rubocop = testing_dangerfile.rubocop
+      end
+
+      describe :lint_files do
+        before do
+          # Set up our stubbed JSON response
+          response = {
+            "files" => [
+              {
+                "path": "ruby_file.rb",
+                "offenses" => [
+                  {
+                    "message" => "Don't do that!",
+                    "location" => {"line": 13}
+                  }
+                ]
+              }
+            ]
+          }
+          @rubocop_response = response.to_json
+        end
+
+        it 'handles a known rubocop report' do
+          allow(@rubocop).to receive(:`).with('bundle exec rubocop -f json spec/fixtures/ruby_file.rb').and_return(@rubocop_response)
+
+          # Do it
+          @rubocop.run("spec/fixtures/*.rb")
+
+          output = @rubocop.status_report[:markdowns].first
+
+          expect(output).to_not be_empty
+
+          # A title
+          expect(output).to include("Rubocop violations")
+          # A warning
+          expect(output).to include("ruby_file.rb | 13 | Don't do that!")
+        end
+
+        it 'handles no files' do
+          allow(@rubocop).to receive(:modified_files).and_return(['spec/fixtures/ruby_file.rb'])
+          allow(@rubocop).to receive(:added_files).and_return([])          
+          allow(@rubocop).to receive(:`).with('bundle exec rubocop -f json spec/fixtures/ruby_file.rb').and_return(@rubocop_response)
+
+          @rubocop.run
+
+          expect(@rubocop.status_report[:markdowns].first).to_not be_empty
+        end
+      end
+    end
+  end
+end

data/spec/fixtures/ruby_file.rb

@@ -0,0 +1 @@
+# This file intentional left blank-ish.

data/spec/spec_helper.rb

@@ -0,0 +1,44 @@
+require 'pathname'
+
+ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+$:.unshift((ROOT + 'lib').to_s)
+$:.unshift((ROOT + 'spec').to_s)
+
+RSpec.configure do |config|
+ # Use color in STDOUT
+  config.color = true
+end
+
+require 'bundler/setup'
+require 'pry'
+
+require 'danger'
+require 'cork'
+require 'danger_plugin'
+require 'json'
+
+# These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+# If you are expanding these files, see if it's already been done ^.
+
+# A silent version of the user interface
+def testing_ui
+  Cork::Board.new(silent: true)
+end
+
+# Example environment (ENV) that would come from
+# running a PR on TravisCI
+def testing_env
+  {
+    "HAS_JOSH_K_SEAL_OF_APPROVAL" => "true",
+    "TRAVIS_PULL_REQUEST" => "800",
+    "TRAVIS_REPO_SLUG" => "artsy/eigen",
+    "TRAVIS_COMMIT_RANGE" => "759adcbd0d8f...13c4dc8bb61d",
+    "DANGER_GITHUB_API_TOKEN" => "123sbdq54erfsd3422gdfio"
+  }
+end
+
+# A stubbed out Dangerfile for use in tests
+def testing_dangerfile
+  env = Danger::EnvironmentManager.new(testing_env)
+  Danger::Dangerfile.new(env, testing_ui)
+end

metadata

@@ -0,0 +1,186 @@
+--- !ruby/object:Gem::Specification
+name: danger-rubocop
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Ash Furrow
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2016-07-05 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: danger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: listen
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: A Danger plugin for running Ruby files through Rubocop.
+email:
+- ash@ashfurrow.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- Gemfile
+- Gemfile.lock
+- Guardfile
+- LICENSE
+- README.md
+- Rakefile
+- danger-rubocop.gemspec
+- lib/danger_plugin.rb
+- lib/version.rb
+- spec/danger_plugin_spec.rb
+- spec/fixtures/ruby_file.rb
+- spec/spec_helper.rb
+homepage: https://github.com/ashfurrow/danger-rubocop
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.4.8
+signing_key: 
+specification_version: 4
+summary: A Danger plugin for running Ruby files through Rubocop.
+test_files:
+- spec/danger_plugin_spec.rb
+- spec/fixtures/ruby_file.rb
+- spec/spec_helper.rb