danger-pr_reviewers 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: adedda6f14b9ffb2b09b6a915abcae35273e2522
+  data.tar.gz: ee567f93c881ffb077b1d01a7bd04ffb5a0b14ff
+SHA512:
+  metadata.gz: bed27210f7b7982dbf5df2bd4d8141c256e2477a21a87373abb6acc72a26fe59e2ea8846d202f939cf4e3040c3758b90783638652a30d3d56237883bb01e7264
+  data.tar.gz: 9f1d6405f37cc321d2a3b6d34cab898e26bb7306570e64450c62b0524216481bd6746ed2228cd2a6f84a16ab886ceae79b8b4a38ef690cfa2c319e7baa9ffc25

data/.gitignore

@@ -0,0 +1,4 @@
+.DS_Store
+pkg
+.idea/
+.yardoc

data/.rubocop.yml

@@ -0,0 +1,13 @@
+AllCops:
+  Include:
+    - Rakefile
+  Exclude:
+    - vendor/**/*
+
+Metrics/BlockLength:
+  Exclude:
+    - 'Rakefile'
+    - '**/*.rake'
+    - 'spec/**/*.rb'
+
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,75 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-03-28 20:55:23 +0200 using RuboCop version 0.48.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Metrics/AbcSize:
+  Max: 22
+
+# Offense count: 109
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 254
+
+# Offense count: 3
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 14
+
+# Offense count: 3
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/changelog/config.rb'
+    - 'lib/changelog/plugin.rb'
+
+# Offense count: 3
+Style/DoubleNegation:
+  Exclude:
+    - 'lib/changelog/changelog_file.rb'
+
+# Offense count: 4
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Style/FileName:
+  Exclude:
+    - 'Dangerfile'
+    - 'Gemfile'
+    - 'Guardfile'
+    - 'danger-changelog.gemspec'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
+Style/IndentHeredoc:
+  Exclude:
+    - 'lib/changelog/plugin.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: module_function, extend_self
+Style/ModuleFunction:
+  Exclude:
+    - 'lib/changelog/config.rb'
+
+# Offense count: 2
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/changelog/plugin.rb'
+
+Style/FileName:
+  Include:
+    - 'lib/**/*'
+    - 'spec/**/*'

data/.travis.yml

@@ -0,0 +1,12 @@
+language: ruby
+cache:
+  directories:
+    - bundle
+
+rvm:
+  - 2.0
+  - 2.1.3
+  - 2.3.1
+
+script:
+    - bundle exec rake spec

data/CHANGELOG.md

@@ -0,0 +1,6 @@
+## Changelog
+
+
+### 0.1.0 (27/06/2017)
+
+* [#1](https://github.com/conichiGMBH/danger-pr_reviewers/pull/1): Add gem documentation - [@antondomashnev](https://github.com/antondomashnev).

data/Dangerfile

@@ -0,0 +1 @@
+changelog.check

data/Gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+gemspec
+
+gem 'danger-changelog', '~> 0.1'
+gem 'danger', '~> 5.0'

data/Gemfile.lock

@@ -0,0 +1,139 @@
+PATH
+  remote: .
+  specs:
+    danger-pr_reviewers (0.1.0)
+      danger-plugin-api (~> 1.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.5.1)
+      public_suffix (~> 2.0, >= 2.0.2)
+    ast (2.3.0)
+    claide (1.0.2)
+    claide-plugins (0.9.2)
+      cork
+      nap
+      open4 (~> 1.3)
+    coderay (1.1.1)
+    colored2 (3.1.2)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (5.3.1)
+      claide (~> 1.0)
+      claide-plugins (>= 0.9.2)
+      colored2 (~> 3.1)
+      cork (~> 0.1)
+      faraday (~> 0.9)
+      faraday-http-cache (~> 1.0)
+      git (~> 1)
+      kramdown (~> 1.5)
+      octokit (~> 4.2)
+      terminal-table (~> 1)
+    danger-changelog (0.2.0)
+      danger-plugin-api (~> 1.0)
+    danger-plugin-api (1.0.0)
+      danger (> 2.0)
+    diff-lcs (1.3)
+    faraday (0.12.1)
+      multipart-post (>= 1.2, < 3)
+    faraday-http-cache (1.3.1)
+      faraday (~> 0.8)
+    ffi (1.9.18)
+    formatador (0.2.5)
+    git (1.3.0)
+    guard (2.14.1)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    kramdown (1.13.2)
+    listen (3.0.7)
+      rb-fsevent (>= 0.9.3)
+      rb-inotify (>= 0.9.7)
+    lumberjack (1.0.12)
+    method_source (0.8.2)
+    multipart-post (2.0.0)
+    nap (1.1.0)
+    nenv (0.3.0)
+    notiffany (0.1.1)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    octokit (4.7.0)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    open4 (1.3.4)
+    parallel (1.11.2)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    pry (0.10.4)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    public_suffix (2.0.5)
+    rainbow (2.2.2)
+      rake
+    rake (10.5.0)
+    rb-fsevent (0.9.8)
+    rb-inotify (0.9.10)
+      ffi (>= 0.5.0, < 2)
+    rspec (3.6.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
+    rubocop (0.49.1)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.8.1)
+    sawyer (0.8.1)
+      addressable (>= 2.3.5, < 2.6)
+      faraday (~> 0.8, < 1.0)
+    shellany (0.0.1)
+    slop (3.6.0)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
+    thor (0.19.4)
+    unicode-display_width (1.3.0)
+    yard (0.9.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler (~> 1.3)
+  danger (~> 5.0)
+  danger-changelog (~> 0.1)
+  danger-pr_reviewers!
+  guard (~> 2.14)
+  guard-rspec (~> 4.7)
+  listen (= 3.0.7)
+  pry
+  rake (~> 10.0)
+  rspec (~> 3.4)
+  rubocop (~> 0.41)
+  yard (~> 0.8)
+
+BUNDLED WITH
+   1.13.7

data/Guardfile

@@ -0,0 +1,19 @@
+# A guardfile for making Danger Plugins
+# For more info see https://github.com/guard/guard#readme
+
+# To run, use `bundle exec guard`.
+
+guard :rspec, cmd: 'bundle exec rspec' do
+  require 'guard/rspec/dsl'
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2017 Conichi
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2017 Anton Domashnev <antondomashnev@gmail.com>
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,33 @@
+[![Build Status](https://travis-ci.org/conichiGMBH/danger-pr_reviewers.svg?branch=master)](https://travis-ci.org/conichiGMBH/danger-pr_reviewers)
+
+# danger-pr_reviewers
+
+The plugin deals with the PRs on the GitHub innregards to reviews. Based on the given parameters
+it automatically assigns the developer to review the PRs. In [ios team](https://github.com/conichiGMBH/ios-team) we have [rules](https://github.com/conichiGMBH/ios-team/blob/master/docs/pr_protocol.md#creating-the-pr) to ask our designers to review the UI changed in PR, by checkin the attached image or gif. The `pr_reviewers` can also ask for review based on that rule.
+
+## Installation
+
+```
+$ gem install danger-pr_reviewers
+```
+
+## Usage
+
+```ruby
+developers_usernames = ["Superman", "Batman", "Iron-Man"]
+number_of_developers_required_for_review = 1
+designers_usernames = ["Pablo-Picasso", "Salvador-Dali"]
+number_of_designers_required_for_review = 1
+pr_reviewers.run(developers_usernames,
+                 designers_usernames,
+                 number_of_developers_required_for_review,
+                 number_of_designers_required_for_review)
+```
+
+## Development
+
+1. Clone this repo
+2. Run `bundle install` to setup dependencies.
+3. Run `bundle exec rake spec` to run the tests.
+4. Use `bundle exec guard` to automatically have tests run as you make changes.
+5. Make your changes.

data/RELEASING.md

@@ -0,0 +1,67 @@
+# Releasing Danger-PR-Reviewers
+
+There're no hard rules about when to release `danger-pr_reviewers`. Release bug fixes frequently, features not so frequently and breaking API changes rarely.
+
+### Release
+
+Install bundle, run tests, check that all tests succeed locally.
+
+```
+bundle install
+rake
+```
+
+Check that the last build succeeded in [Travis CI](https://travis-ci.org/conichiGMBH/danger-pr_reviewers) for all supported platforms.
+
+Increment the version, modify [lib/pr_reviewers/gem_version.rb](lib/pr_reviewers/gem_version.rb).
+
+Following the [Semantic Versioning](http://semver.org/):
+*  Increment the third number if the release has bug fixes and/or very minor features with backward compatibility, only (eg. change `0.2.1` to `0.2.2`).
+*  Increment the second number if the release contains major features or breaking API changes (eg. change `0.2.1` to `0.3.0`).
+
+Create a new version and mark it as Next in [CHANGELOG.md](CHANGELOG.md).
+
+```
+### 0.2.2 (12/03/2016)
+```
+
+Remove the line with "* Your contribution here.", since there will be no more contributions to this release.
+
+Commit your changes.
+
+```
+git add CHANGELOG.md lib/pr_reviewers/gem_version.rb
+git commit -m "Preparing for release 0.2.2."
+git push origin master
+```
+
+Release.
+
+```
+$ rake release
+
+danger-pr_reviewers 0.2.2 built to pkg/danger-pr_reviewers-0.2.2.gem.
+Tagged v0.2.2.
+Pushed git commits and tags.
+Pushed danger-pr_reviewers 0.2.2 to rubygems.org.
+```
+
+### Prepare for the Next Version
+
+Add the next release to [CHANGELOG.md](CHANGELOG.md).
+
+```
+### 0.2.3 (Next)
+
+* Your contribution here.
+```
+
+Increment the third version number in [lib/pr_reviewers/gem_version.rb](lib/pr_reviewers/gem_version.rb).
+
+Commit your changes.
+
+```
+git add CHANGELOG.md lib/pr_reviewers/version.rb
+git commit -m "Preparing for next development iteration, 0.2.3."
+git push origin master
+```

data/Rakefile

@@ -0,0 +1,23 @@
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
+
+RSpec::Core::RakeTask.new(:specs)
+
+task default: :specs
+
+task :spec do
+  Rake::Task['specs'].invoke
+  Rake::Task['rubocop'].invoke
+  Rake::Task['spec_docs'].invoke
+end
+
+desc 'Run RuboCop on the lib/specs directory'
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.patterns = ['lib/**/*.rb', 'spec/**/*.rb']
+end
+
+desc 'Ensure that the plugin passes `danger plugins lint`'
+task :spec_docs do
+  sh 'bundle exec danger plugins lint'
+end

data/danger-pr_reviewers.gemspec

@@ -0,0 +1,51 @@
+# coding: utf-8
+
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'pr_reviewers/gem_version.rb'
+
+Gem::Specification.new do |spec|
+  spec.name          = 'danger-pr_reviewers'
+  spec.version       = PrReviewers::VERSION
+  spec.authors       = ['Anton Domashnev']
+  spec.email         = ['anton.domashnev@conichi.com']
+  spec.description   = 'Picks the reviewers for the your PRs.'
+  spec.summary       = "It's literally the simplest version of a mention plugin already
+    existed in Danger ecosystem."
+  spec.homepage      = 'https://github.com/conichiGMBH/danger-pr_reviewers'
+  spec.license       = 'MIT'
+
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.require_paths = ['lib']
+
+  spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
+
+  # General ruby development
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake', '~> 10.0'
+
+  # Testing support
+  spec.add_development_dependency 'rspec', '~> 3.4'
+
+  # Linting code and docs
+  spec.add_development_dependency 'rubocop', '~> 0.41'
+  spec.add_development_dependency 'yard', '~> 0.8'
+
+  # Makes testing easy via `bundle exec guard`
+  spec.add_development_dependency 'guard', '~> 2.14'
+  spec.add_development_dependency 'guard-rspec', '~> 4.7'
+
+  # If you want to work on older builds of ruby
+  spec.add_development_dependency 'listen', '3.0.7'
+
+  # This gives you the chance to run a REPL inside your tests
+  # via:
+  #
+  #    require 'pry'
+  #    binding.pry
+  #
+  # This will stop test execution and let you inspect the results
+  spec.add_development_dependency 'pry'
+end

data/lib/danger_plugin.rb

@@ -0,0 +1 @@
+require 'pr_reviewers/plugin'

data/lib/danger_pr_reviewers.rb

@@ -0,0 +1 @@
+require 'pr_reviewers/gem_version'

data/lib/pr_reviewers/gem_version.rb

@@ -0,0 +1,3 @@
+module PrReviewers
+  VERSION = '0.1.0'.freeze
+end

data/lib/pr_reviewers/plugin.rb

@@ -0,0 +1,63 @@
+module Danger
+  #
+  # The idea of the plugin is to let the machine rules the PR reviewers decision =)
+  # * It will assign a random %n developers from the given Array to review the code
+  # * It will assign a random %n designers from the given Array to
+  #   review the UI if there is an image attached to the PR body
+  #
+  # @example Assigns reviewers for the PR
+  #
+  #          pr_reviewers.run
+  #
+  # @see  conichiGMBH/danger-pr_reviewers
+  # @tags github, review, mention
+  #
+  class DangerPrReviewers < Plugin
+    # Request a review from potential reviewers.
+    #
+    # @param   [Integer] number_of_code_reviewers
+    #          Maximum number of developers to request a review from, default is 1.
+    # @param   [Integer] number_of_design_reviewers
+    #          Maximum number of designers to request a review from, default is 1.
+    # @param   [Array<String>] developers
+    #          List of developers GitHub's usernames.
+    # @param   [Array<String>] designers
+    #          List of designers GitHub's usernames.
+    # @return  [void]
+    #
+    def run(developers, designers, number_of_code_reviewers = 1, number_of_design_reviewers = 1)
+      unless @dangerfile.github.pr_author.nil?
+        developers -= [@dangerfile.github.pr_author]
+        designers -= [@dangerfile.github.pr_author]
+      end
+      reviewers = find_developers(number_of_code_reviewers, developers)
+      reviewers += find_designers(number_of_design_reviewers, designers) if need_design_review?
+      request_review(reviewers)
+      message("Danger has assigned @#{reviewers.join(' @')} to review the PR", sticky: true)
+    end
+
+    private
+
+    def find_developers(number_of_code_reviewers, developers)
+      developers.sample([number_of_code_reviewers, developers.count].min)
+    end
+
+    def find_designers(number_of_design_reviewers, designers)
+      designers.sample([number_of_design_reviewers, designers.count].min)
+    end
+
+    def need_design_review?
+      pr_body = @dangerfile.github.pr_body
+      return true if pr_body =~ /<img([\w\W]+?)>/
+      return true if pr_body =~ %r{\[.*\]\((https|http):\/\/.*\.(PNG|png|jpeg|jpg)\)}
+      false
+    end
+
+    def request_review(reviewers)
+      github = @dangerfile.env.request_source
+      pr_id = @dangerfile.env.ci_source.pull_request_id
+      repo = @dangerfile.env.ci_source.repo_slug
+      github.client.request_pull_request_review(repo, pr_id, reviewers)
+    end
+  end
+end

data/spec/pr_reviewers_spec.rb

@@ -0,0 +1,110 @@
+require File.expand_path('../spec_helper', __FILE__)
+
+module Danger
+  describe Danger::DangerPrReviewers do
+    it 'should be a plugin' do
+      expect(Danger::DangerPrReviewers.new(nil)).to be_a Danger::Plugin
+    end
+  end
+
+  context 'with dangerfile' do
+    let(:pr_id) { testing_env['TRAVIS_PULL_REQUEST'] }
+    let(:repo_slug) { testing_env['TRAVIS_REPO_SLUG'] }
+    let(:dangerfile) { testing_dangerfile }
+    let(:developers) { ['Antondomashnev', 'Mourad-Aly', 'David-Henner', 'Superman'] }
+    let(:designers) { ['denis-sharypin', 'johnny'] }
+    let(:pr_reviewers) { dangerfile.pr_reviewers }
+    let(:client) { double(Octokit::Client) }
+    let(:github) { dangerfile.github }
+
+    context 'in a PR' do
+      before do
+        allow(client).to receive(:request_pull_request_review).with(anything, anything, anything)
+        allow(dangerfile.env.request_source).to receive(:client).and_return(client)
+      end
+
+      context 'with the pr author as a deloper' do
+        let(:pr_author) { 'Antondomashnev' }
+
+        before do
+          allow(github).to receive(:pr_author).and_return(pr_author)
+          allow(github).to receive(:pr_body).and_return('Hey! Here is a snapshot of ![simulator screen shot 23 jun 2017 14 19 41](https://user-images.githubusercontent.com/6436181/27482218-d972c1c2-5820-11e7-9806-9006500952de.png)')
+        end
+
+        it 'excludes author from potential reviewer' do
+          expect(client).to_not receive(:request_pull_request_review).with(repo_slug, pr_id, array_including(pr_author))
+          pr_reviewers.run(developers, designers, 4, 2)
+        end
+      end
+
+      context 'with the pr author as a designer' do
+        let(:pr_author) { 'johnny' }
+
+        before do
+          allow(github).to receive(:pr_author).and_return(pr_author)
+          allow(github).to receive(:pr_body).and_return('Hey! Here is a snapshot of ![simulator screen shot 23 jun 2017 14 19 41](https://user-images.githubusercontent.com/6436181/27482218-d972c1c2-5820-11e7-9806-9006500952de.png)')
+        end
+
+        it 'excludes author from potential reviewer' do
+          expect(client).to_not receive(:request_pull_request_review).with(repo_slug, pr_id, array_including(pr_author))
+          pr_reviewers.run(developers, designers, 4, 2)
+        end
+      end
+
+      context 'with image' do
+        before do
+          allow(github).to receive(:pr_author).and_return('Foo')
+        end
+
+        context 'inserted as markdown link' do
+          before do
+            allow(github).to receive(:pr_body).and_return('Hey! Here is a snapshot of ![simulator screen shot 23 jun 2017 14 19 41](https://user-images.githubusercontent.com/6436181/27482218-d972c1c2-5820-11e7-9806-9006500952de.png)')
+          end
+
+          it 'asks designer for review' do
+            expect(client).to receive(:request_pull_request_review).with(repo_slug, pr_id, array_including_sample_of(designers, 2))
+            pr_reviewers.run(developers, designers, 3, 2)
+          end
+
+          it 'asks developer for review' do
+            expect(client).to receive(:request_pull_request_review).with(repo_slug, pr_id, array_including_sample_of(developers, 3))
+            pr_reviewers.run(developers, designers, 3, 2)
+          end
+        end
+
+        context 'inserted as html tag' do
+          before do
+            allow(github).to receive(:pr_body).and_return('Please check only what inside the red rectangle 😄 <img src="https://monosnap.com/file/DF8OnfmdHRbJ3UH4e6phCVf8blJln4.png" width=640>')
+          end
+
+          it 'asks designer for review' do
+            expect(client).to receive(:request_pull_request_review).with(repo_slug, pr_id, array_including_sample_of(designers, 2))
+            pr_reviewers.run(developers, designers, 3, 2)
+          end
+
+          it 'asks developer for review' do
+            expect(client).to receive(:request_pull_request_review).with(repo_slug, pr_id, array_including_sample_of(developers, 3))
+            pr_reviewers.run(developers, designers, 3, 2)
+          end
+        end
+      end
+
+      context 'without image' do
+        before do
+          allow(github).to receive(:pr_author).and_return('Foo')
+          allow(github).to receive(:pr_body).and_return('This is my amazing PR without images')
+        end
+
+        it 'doesnt ask designer for review' do
+          expect(client).to_not receive(:request_pull_request_review).with(repo_slug, pr_id, array_including_sample_of(designers, 2))
+          pr_reviewers.run(developers, designers, 3, 2)
+        end
+
+        it 'asks developer for review' do
+          expect(client).to receive(:request_pull_request_review).with(repo_slug, pr_id, array_including_sample_of(developers, 3))
+          pr_reviewers.run(developers, designers, 3, 2)
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,69 @@
+require 'pathname'
+ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+$LOAD_PATH.unshift((ROOT + 'lib').to_s)
+$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+
+require 'bundler/setup'
+require 'pry'
+
+require 'rspec'
+require 'danger'
+
+# Use coloured output, it's the best.
+RSpec.configure do |config|
+  config.filter_gems_from_backtrace 'bundler'
+  config.color = true
+  config.tty = true
+end
+
+require 'danger_plugin'
+
+# These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb
+# If you are expanding these files, see if it's already been done ^.
+
+# A silent version of the user interface,
+# it comes with an extra function `.string` which will
+# strip all ANSI colours from the string.
+
+# rubocop:disable Lint/NestedMethodDefinition
+def testing_ui
+  @output = StringIO.new
+  def @output.winsize
+    [20, 9999]
+  end
+
+  cork = Cork::Board.new(out: @output)
+  def cork.string
+    out.string.gsub(/\e\[([;\d]+)?m/, '')
+  end
+  cork
+end
+# rubocop:enable Lint/NestedMethodDefinition
+
+# Example environment (ENV) that would come from
+# running a PR on TravisCI
+def testing_env
+  {
+    'HAS_JOSH_K_SEAL_OF_APPROVAL' => 'true',
+    'TRAVIS_PULL_REQUEST' => '800',
+    'TRAVIS_REPO_SLUG' => 'artsy/eigen',
+    'TRAVIS_COMMIT_RANGE' => '759adcbd0d8f...13c4dc8bb61d',
+    'DANGER_GITHUB_API_TOKEN' => '123sbdq54erfsd3422gdfio'
+  }
+end
+
+# A stubbed out Dangerfile for use in tests
+def testing_dangerfile
+  env = Danger::EnvironmentManager.new(testing_env)
+  Danger::Dangerfile.new(env, testing_ui)
+end
+
+RSpec::Matchers.define :array_including_sample_of do |*attributes|
+  match do |actual|
+    contained_elements_count = 0
+    attributes[0].each do |element|
+      contained_elements_count += 1 if actual.include? element
+    end
+    contained_elements_count == attributes[1]
+  end
+end

metadata

@@ -0,0 +1,208 @@
+--- !ruby/object:Gem::Specification
+name: danger-pr_reviewers
+version: !ruby/object:Gem::Version
+  version: 0.1.0
+platform: ruby
+authors:
+- Anton Domashnev
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2017-06-27 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: danger-plugin-api
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.41'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.41'
+- !ruby/object:Gem::Dependency
+  name: yard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
+- !ruby/object:Gem::Dependency
+  name: listen
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.0.7
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Picks the reviewers for the your PRs.
+email:
+- anton.domashnev@conichi.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".travis.yml"
+- CHANGELOG.md
+- Dangerfile
+- Gemfile
+- Gemfile.lock
+- Guardfile
+- LICENSE
+- LICENSE.txt
+- README.md
+- RELEASING.md
+- Rakefile
+- danger-pr_reviewers.gemspec
+- lib/danger_plugin.rb
+- lib/danger_pr_reviewers.rb
+- lib/pr_reviewers/gem_version.rb
+- lib/pr_reviewers/plugin.rb
+- spec/pr_reviewers_spec.rb
+- spec/spec_helper.rb
+homepage: https://github.com/conichiGMBH/danger-pr_reviewers
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.5.1
+signing_key: 
+specification_version: 4
+summary: It's literally the simplest version of a mention plugin already existed in
+  Danger ecosystem.
+test_files:
+- spec/pr_reviewers_spec.rb
+- spec/spec_helper.rb