danger-pmd 0.4.0 → 1.0.5

data/lib/danger_plugin.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require "pmd/plugin"
+require 'pmd/plugin'

data/lib/danger_pmd.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require "pmd/gem_version"
+require 'pmd/gem_version'

data/lib/pmd/entity/pmd_file.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
+# Represent a PMD file.
 class PmdFile
-  require_relative "./pmd_violation"
+  require_relative './pmd_violation'
 
   attr_accessor :file
 
@@ -17,23 +18,18 @@ class PmdFile
 
   def initialize(prefix, file)
     @file = file
-    @absolute_path = file.attribute("name").value.to_s
-
-    if prefix.end_with?(file_separator)
-      @prefix = prefix
-    else
-      @prefix = prefix + file_separator
-    end
-
-    if @absolute_path.start_with?(@prefix)
-      @relative_path = @absolute_path[@prefix.length, @absolute_path.length - @prefix.length]
-    else
-      @relative_path = @absolute_path
-    end
+    @absolute_path = file.attribute('name').value.to_s
+
+    prefix += (prefix.end_with?(file_separator) ? '' : file_separator)
+    @relative_path = if @absolute_path.start_with?(prefix)
+                       @absolute_path[prefix.length, @absolute_path.length - prefix.length]
+                     else
+                       @absolute_path
+                     end
   end
 
   def violations
-    @violations ||= file.xpath("violation").map do |pmd_violation|
+    @violations ||= file.xpath('violation').map do |pmd_violation|
       PmdViolation.new(pmd_violation)
     end
   end

data/lib/pmd/entity/pmd_violation.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Represent a PMD violation.
 class PmdViolation
   PRIORITY_ERROR_THRESHOLD = 4
   attr_accessor :violation
@@ -9,7 +10,7 @@ class PmdViolation
   end
 
   def priority
-    @priority ||= violation.attribute("priority").value.to_i
+    @priority ||= violation.attribute('priority').value.to_i
   end
 
   def type
@@ -17,10 +18,10 @@ class PmdViolation
   end
 
   def line
-    @line ||= violation.attribute("beginline").value.to_i
+    @line ||= violation.attribute('beginline').value.to_i
   end
 
   def description
-    @description ||= violation.text.gsub("\n", "")
+    @description ||= violation.text.gsub("\n", '')
   end
 end

data/lib/pmd/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pmd
-  VERSION = "0.4.0"
+  VERSION = '1.0.5'
 end

data/lib/pmd/plugin.rb

@@ -11,50 +11,57 @@ module Danger
   #
   # @example Running PMD with a specific Gradle task or report file (glob accepted)
   #
-  #          pmd.gradle_task = 'app:pmd' #defalut: pmd
-  #          pmd.report_file = "module/build/reports/pmd/pmd.xml" #defalut: app/build/reports/pmd/pmd.xml
+  #          pmd.gradle_task = 'module:pmd' # default: 'pmd'
+  #          pmd.report_file = 'module/build/reports/pmd/pmd.xml' # default: 'app/build/reports/pmd/pmd.xml'
   #          pmd.report
   #
   # @example Running PMD with a specific root path
   #
-  #          pmd.root_path = '/Users/developer/project
+  #          pmd.root_path = '/Users/developer/project' # default: result of `git rev-parse --show-toplevel`
   #          pmd.report
   #
   # @example Running PMD with an array of report files (glob accepted)
   #
-  #          pmd.report_files = ["modules/**/build/reports/pmd/pmd.xml", "app/build/reports/pmd/pmd.xml"]
+  #          pmd.report_files = ['modules/**/build/reports/pmd/pmd.xml', 'app/build/reports/pmd/pmd.xml']
   #          pmd.report
   #
   # @example Running PMD without running a Gradle task
   #
-  #          pmd.skip_gradle_task = true
+  #          pmd.skip_gradle_task = true # default: false
   #          pmd.report
   #
+  # @example Running PMD without inline comment
+  #
+  #          pmd.report(inline_mode: false) # default: true
+  #
   # @see mathroule/danger-pmd
   # @tags java, android, pmd
-
   class DangerPmd < Plugin
-    require_relative "./entity/pmd_file"
+    require_relative './entity/pmd_file'
 
     # Custom Gradle task to run.
     # This is useful when your project has different flavors.
-    # Defaults to "pmd".
+    # Defaults to 'pmd'.
+    #
     # @return [String]
     attr_writer :gradle_task
 
-    # A getter for `gradle_task`, returning "pmd" if value is nil.
+    # A getter for `gradle_task`, returning 'pmd' if value is nil.
+    #
     # @return [String]
     def gradle_task
-      @gradle_task ||= "pmd"
+      @gradle_task ||= 'pmd'
     end
 
     # Skip Gradle task.
     # If you skip Gradle task, for example project does not manage Gradle.
     # Defaults to `false`.
-    # @return [Bool]
+    #
+    # @return [Boolean]
     attr_writer :skip_gradle_task
 
     # A getter for `skip_gradle_task`, returning false if value is nil.
+    #
     # @return [Boolean]
     def skip_gradle_task
       @skip_gradle_task ||= false
@@ -62,35 +69,41 @@ module Danger
 
     # An absolute path to a root.
     # To comment errors to VCS, this needs to know relative path of files from the root.
-    # Defaults to result of "git rev-parse --show-toplevel".
-    # @return [String] the root path of git repository by default.
+    # Defaults to result of 'git rev-parse --show-toplevel'.
+    #
+    # @return [String]
     attr_writer :root_path
 
-    # A getter for `root_path`, returning result of "git rev-parse --show-toplevel" if value is nil.
+    # A getter for `root_path`, returning result of `git rev-parse --show-toplevel` if value is nil.
+    #
     # @return [String]
     def root_path
       @root_path ||= `git rev-parse --show-toplevel`.chomp
     end
 
     # Location of report file.
-    # If your pmd task outputs to a different location, you can specify it here.
-    # Defaults to "app/build/reports/pmd/pmd.xml".
+    # If your PMD task task outputs to a different location, you can specify it here.
+    # Defaults to 'app/build/reports/pmd/pmd.xml'.
+    #
     # @return [String]
     attr_writer :report_file
 
-    # A getter for `report_file`, returning "app/build/reports/pmd/pmd.xml" if value is nil.
+    # A getter for `report_file`, returning 'app/build/reports/pmd/pmd.xml' if value is nil.
+    #
     # @return [String]
     def report_file
-      @report_file ||= "app/build/reports/pmd/pmd.xml"
+      @report_file ||= 'app/build/reports/pmd/pmd.xml'
     end
 
     # Location of report files.
-    # If your pmd task outputs to a different location, you can specify it here.
-    # Defaults to ["app/build/reports/pmd/pmd.xml"].
+    # If your PMD task outputs to a different location, you can specify it here.
+    # Defaults to ['app/build/reports/pmd/pmd.xml'].
+    #
     # @return [Array[String]]
     attr_writer :report_files
 
-    # A getter for `report_files`, returning ["app/build/reports/pmd/pmd.xml"] if value is nil.
+    # A getter for `report_files`, returning ['app/build/reports/pmd/pmd.xml'] if value is nil.
+    #
     # @return [Array[String]]
     def report_files
       @report_files ||= [report_file]
@@ -100,16 +113,19 @@ module Danger
     # It fails if `gradlew` cannot be found inside current directory.
     # It fails if `report_file` cannot be found inside current directory.
     # It fails if `report_files` is empty.
+    #
+    # @param [Boolean] inline_mode Report as inline comment, defaults to [true].
+    #
     # @return [Array[PmdFile]]
-    def report(inline_mode = true)
+    def report(inline_mode: true)
       unless skip_gradle_task
-        return fail("Could not find `gradlew` inside current directory") unless gradlew_exists?
+        raise('Could not find `gradlew` inside current directory') unless gradlew_exists?
 
         exec_gradle_task
       end
 
       report_files_expanded = Dir.glob(report_files).sort
-      return fail("Could not find matching PMD report files for #{report_files} inside current directory") if report_files_expanded.empty?
+      raise("Could not find matching PMD report files for #{report_files} inside current directory") if report_files_expanded.empty?
 
       do_comment(report_files_expanded, inline_mode)
     end
@@ -117,47 +133,53 @@ module Danger
     private
 
     # Check gradlew file exists in current directory.
-    # @return [Bool]
+    #
+    # @return [Boolean]
     def gradlew_exists?
       !`ls gradlew`.strip.empty?
     end
 
     # Run Gradle task.
+    #
     # @return [void]
     def exec_gradle_task
       system "./gradlew #{gradle_task}"
     end
 
-    # Check report_file exists in current directory.
-    # @return [Bool]
-    def report_file_exist?(report_file)
-      File.exist?(report_file)
-    end
-
     # A getter for `pmd_report`, returning PMD report.
+    #
+    # @param [String] report_file The report file.
+    #
     # @return [Oga::XML::Document]
     def pmd_report(report_file)
-      require "oga"
+      require 'oga'
       Oga.parse_xml(File.open(report_file))
     end
 
     # A getter for PMD issues, returning PMD issues.
+    #
+    # @param [String] report_file The report file.
+    #
     # @return [Array[PmdFile]]
     def pmd_issues(report_file)
-      pmd_report(report_file).xpath("//file").map do |pmd_file|
+      pmd_report(report_file).xpath('//file').map do |pmd_file|
         PmdFile.new(root_path, pmd_file)
       end
     end
 
     # A getter for current updated files.
+    #
     # @return [Array[String]]
     def target_files
       @target_files ||= (git.modified_files - git.deleted_files) + git.added_files
     end
 
     # Generate report and send inline comment with Danger's warn or fail method.
+    #
+    # @param [Boolean] inline_mode Report as inline comment, defaults to [true].
+    #
     # @return [Array[PmdFile]]
-    def do_comment(report_files, inline_mode = true)
+    def do_comment(report_files, inline_mode)
       pmd_issues = []
 
       report_files.each do |report_file|
@@ -166,17 +188,21 @@ module Danger
 
           pmd_issues.push(pmd_file)
 
-          pmd_file.violations.each do |pmd_violation|
-            if inline_mode
-              send(pmd_violation.type, pmd_violation.description, file: pmd_file.relative_path, line: pmd_violation.line)
-            else
-              send(pmd_violation.type, "#{pmd_file.relative_path} : #{pmd_violation.description} at #{pmd_violation.line}")
-            end
-          end
+          send_comment(pmd_file, inline_mode)
         end
       end
 
       pmd_issues
     end
+
+    def send_comment(pmd_file, inline_mode)
+      pmd_file.violations.each do |pmd_violation|
+        if inline_mode
+          send(pmd_violation.type, pmd_violation.description, file: pmd_file.relative_path, line: pmd_violation.line)
+        else
+          send(pmd_violation.type, "#{pmd_file.relative_path} : #{pmd_violation.description} at #{pmd_violation.line}")
+        end
+      end
+    end
   end
 end

data/spec/entity/pmd_file_spec.rb

@@ -3,15 +3,15 @@
 require_relative "../spec_helper"
 
 module Pmd
-  require "oga"
+  require 'oga'
 
   describe PmdFile do
-    it "should initialize relative path ending with file separator" do
-      xml = Oga.parse_xml(File.open("spec/fixtures/pmd_report.xml"))
-      pmd_file = PmdFile.new("/Users/developer/sample/", xml.xpath("//file").first)
+    it 'should initialize relative path ending with file separator' do
+      xml = Oga.parse_xml(File.open('spec/fixtures/pmd_report.xml'))
+      pmd_file = PmdFile.new('/Users/developer/sample/', xml.xpath('//file').first)
 
-      expect(pmd_file.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-      expect(pmd_file.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
+      expect(pmd_file.relative_path).to eq('app/src/main/java/com/android/sample/Tools.java')
       expect(pmd_file.violations).not_to be_nil
       expect(pmd_file.violations.length).to eq(1)
       expect(pmd_file.violations.first).not_to be_nil
@@ -19,12 +19,12 @@ module Pmd
       expect(pmd_file.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
     end
 
-    it "should initialize relative path not ending with file separator" do
-      xml = Oga.parse_xml(File.open("spec/fixtures/pmd_report.xml"))
-      pmd_file = PmdFile.new("/Users/developer/sample", xml.xpath("//file").first)
+    it 'should initialize relative path not ending with file separator' do
+      xml = Oga.parse_xml(File.open('spec/fixtures/pmd_report.xml'))
+      pmd_file = PmdFile.new('/Users/developer/sample', xml.xpath('//file').first)
 
-      expect(pmd_file.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-      expect(pmd_file.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
+      expect(pmd_file.relative_path).to eq('app/src/main/java/com/android/sample/Tools.java')
       expect(pmd_file.violations).not_to be_nil
       expect(pmd_file.violations.length).to eq(1)
       expect(pmd_file.violations.first).not_to be_nil
@@ -32,12 +32,12 @@ module Pmd
       expect(pmd_file.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
     end
 
-    it "should initialize relative path not prefixed" do
-      xml = Oga.parse_xml(File.open("spec/fixtures/pmd_report.xml"))
-      pmd_file = PmdFile.new("/Users/developer/something", xml.xpath("//file").first)
+    it 'should initialize relative path not prefixed' do
+      xml = Oga.parse_xml(File.open('spec/fixtures/pmd_report.xml'))
+      pmd_file = PmdFile.new('/Users/developer/something', xml.xpath('//file').first)
 
-      expect(pmd_file.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-      expect(pmd_file.relative_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
+      expect(pmd_file.relative_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
       expect(pmd_file.violations).not_to be_nil
       expect(pmd_file.violations.length).to eq(1)
       expect(pmd_file.violations.first).not_to be_nil

data/spec/pmd_spec.rb

@@ -1,80 +1,85 @@
 # frozen_string_literal: true
 
-require File.expand_path("spec_helper", __dir__)
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerPmd do
-    it "should be a plugin" do
+    it 'should be a plugin' do
       expect(Danger::DangerPmd.new(nil)).to be_a Danger::Plugin
     end
 
-    describe "with Dangerfile" do
+    describe 'with Dangerfile' do
       before do
         @dangerfile = testing_dangerfile
         @pmd = @dangerfile.pmd
       end
 
-      it "Check default Gradle task" do
-        expect(@pmd.gradle_task).to eq("pmd")
+      it 'Check default Gradle task' do
+        expect(@pmd.gradle_task).to eq('pmd')
       end
 
-      it "Set custom Gradle task" do
-        custom_task = "pmdStagingDebug"
-        @pmd.gradle_task = custom_task
-        expect(@pmd.gradle_task).to eq(custom_task)
+      it 'Set custom Gradle task' do
+        @pmd.gradle_task = 'pmdStagingDebug'
+        expect(@pmd.gradle_task).to eq('pmdStagingDebug')
       end
 
-      it "Check default skip Gradle task" do
-        expect(@pmd.skip_gradle_task).to eq(false)
+      it 'Check default skip Gradle task' do
+        expect(@pmd.skip_gradle_task).to be_falsey
       end
 
-      it "Set custom skip Gradle task" do
-        skip_gradle_task = true
-        @pmd.skip_gradle_task = skip_gradle_task
-        expect(@pmd.skip_gradle_task).to eq(skip_gradle_task)
+      it 'Set custom skip Gradle task' do
+        @pmd.skip_gradle_task = true
+        expect(@pmd.skip_gradle_task).to be_truthy
+      end
+
+      it 'Check default root path' do
+        expect(@pmd.root_path).to eq(Dir.pwd)
+      end
+
+      it 'Set custom root path' do
+        @pmd.root_path = '/Users/developer/project'
+        expect(@pmd.root_path).to eq('/Users/developer/project')
       end
 
-      it "Check default report file path" do
-        expect(@pmd.report_file).to eq("app/build/reports/pmd/pmd.xml")
+      it 'Check default report file path' do
+        expect(@pmd.report_file).to eq('app/build/reports/pmd/pmd.xml')
       end
 
-      it "Set custom report file path" do
-        custom_report_path = "custom-path/pmd_sub_report.xml"
-        @pmd.report_file = custom_report_path
-        expect(@pmd.report_file).to eq(custom_report_path)
+      it 'Set custom report file path' do
+        @pmd.report_file = 'custom-path/pmd_sub_report.xml'
+        expect(@pmd.report_file).to eq('custom-path/pmd_sub_report.xml')
       end
 
-      it "Check default report files paths" do
-        expect(@pmd.report_files).to eq(["app/build/reports/pmd/pmd.xml"])
+      it 'Check default report files paths' do
+        expect(@pmd.report_files).to contain_exactly('app/build/reports/pmd/pmd.xml')
       end
 
-      it "Set custom report files paths" do
-        custom_report_paths = ["custom-path/pmd_report_1.xml", "custom-path/pmd_report_2.xml"]
-        @pmd.report_files = custom_report_paths
-        expect(@pmd.report_files).to eq(custom_report_paths)
+      it 'Set custom report files paths' do
+        @pmd.report_files = %w[custom-path/pmd_report_1.xml custom-path/pmd_report_2.xml]
+        expect(@pmd.report_files).to contain_exactly('custom-path/pmd_report_1.xml', 'custom-path/pmd_report_2.xml')
       end
 
-      it "Check default root path" do
+      it 'Check default root path' do
         expect(@pmd.root_path).to eq(Dir.pwd)
       end
 
-      it "Set custom root path" do
-        root_path = "/Users/developer/sample/"
-        @pmd.root_path = root_path
-        expect(@pmd.root_path).to eq(root_path)
+      it 'Set custom root path' do
+        @pmd.root_path = '/Users/developer/sample/'
+        expect(@pmd.root_path).to eq('/Users/developer/sample/')
       end
 
-      it "Report with report file" do
+      it 'Report with report file' do
+        # noinspection RubyLiteralArrayInspection
         target_files = [
-          "app/src/main/java/com/android/sample/MainActivity.java",
-          "app/src/main/java/com/android/sample/Tools.java",
-          "app/src/test/java/com/android/sample/ExampleUnitTest.java",
-          "app/src/test/java/com/android/sample/ToolsTest.java"
+          'app/src/main/java/com/android/sample/MainActivity.java',
+          'app/src/main/java/com/android/sample/Tools.java',
+          'app/src/test/java/com/android/sample/ExampleUnitTest.java',
+          'app/src/test/java/com/android/sample/ToolsTest.java'
         ]
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
 
-        @pmd.report_file = "spec/fixtures/pmd_report.xml"
-        @pmd.root_path = "/Users/developer/sample/"
+        @pmd.report_file = 'spec/fixtures/pmd_report.xml'
+        @pmd.root_path = '/Users/developer/sample/'
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report
@@ -83,8 +88,8 @@ module Danger
 
         pmd_issue1 = pmd_issues[0]
         expect(pmd_issue1).not_to be_nil
-        expect(pmd_issue1.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-        expect(pmd_issue1.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
+        expect(pmd_issue1.relative_path).to eq('app/src/main/java/com/android/sample/Tools.java')
         expect(pmd_issue1.violations).not_to be_nil
         expect(pmd_issue1.violations.length).to eq(1)
         expect(pmd_issue1.violations.first).not_to be_nil
@@ -93,8 +98,8 @@ module Danger
 
         pmd_issue2 = pmd_issues[1]
         expect(pmd_issue2).not_to be_nil
-        expect(pmd_issue2.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java")
-        expect(pmd_issue2.relative_path).to eq("app/src/main/java/com/android/sample/MainActivity.java")
+        expect(pmd_issue2.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java')
+        expect(pmd_issue2.relative_path).to eq('app/src/main/java/com/android/sample/MainActivity.java')
         expect(pmd_issue2.violations).not_to be_nil
         expect(pmd_issue2.violations.length).to eq(1)
         expect(pmd_issue2.violations.first).not_to be_nil
@@ -103,8 +108,8 @@ module Danger
 
         pmd_issue3 = pmd_issues[2]
         expect(pmd_issue3).not_to be_nil
-        expect(pmd_issue3.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java")
-        expect(pmd_issue3.relative_path).to eq("app/src/test/java/com/android/sample/ExampleUnitTest.java")
+        expect(pmd_issue3.absolute_path).to eq('/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java')
+        expect(pmd_issue3.relative_path).to eq('app/src/test/java/com/android/sample/ExampleUnitTest.java')
         expect(pmd_issue3.violations).not_to be_nil
         expect(pmd_issue3.violations.length).to eq(1)
         expect(pmd_issue3.violations.first).not_to be_nil
@@ -113,8 +118,8 @@ module Danger
 
         pmd_issue4 = pmd_issues[3]
         expect(pmd_issue4).not_to be_nil
-        expect(pmd_issue4.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
-        expect(pmd_issue4.relative_path).to eq("app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue4.absolute_path).to eq('/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java')
+        expect(pmd_issue4.relative_path).to eq('app/src/test/java/com/android/sample/ToolsTest.java')
         expect(pmd_issue4.violations).not_to be_nil
         expect(pmd_issue4.violations.length).to eq(2)
         expect(pmd_issue4.violations[0]).not_to be_nil
@@ -125,15 +130,16 @@ module Danger
         expect(pmd_issue4.violations[1].description).to eq("The JUnit 4 test method name 'getLabel_2' doesn't match '[a-z][a-zA-Z0-9]*'")
       end
 
-      it "Report with report file not in target files" do
+      it 'Report with report file not in target files' do
+        # noinspection RubyLiteralArrayInspection
         target_files = [
-          "app/src/main/java/com/android/sample/Tools.java",
-          "app/src/test/java/com/android/sample/ToolsTest.java"
+          'app/src/main/java/com/android/sample/Tools.java',
+          'app/src/test/java/com/android/sample/ToolsTest.java'
         ]
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
 
-        @pmd.report_file = "spec/fixtures/pmd_report.xml"
-        @pmd.root_path = "/Users/developer/sample/"
+        @pmd.report_file = 'spec/fixtures/pmd_report.xml'
+        @pmd.root_path = '/Users/developer/sample/'
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report
@@ -142,8 +148,8 @@ module Danger
 
         pmd_issue1 = pmd_issues[0]
         expect(pmd_issue1).not_to be_nil
-        expect(pmd_issue1.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-        expect(pmd_issue1.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
+        expect(pmd_issue1.relative_path).to eq('app/src/main/java/com/android/sample/Tools.java')
         expect(pmd_issue1.violations).not_to be_nil
         expect(pmd_issue1.violations.length).to eq(1)
         expect(pmd_issue1.violations.first).not_to be_nil
@@ -152,8 +158,8 @@ module Danger
 
         pmd_issue2 = pmd_issues[1]
         expect(pmd_issue2).not_to be_nil
-        expect(pmd_issue2.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
-        expect(pmd_issue2.relative_path).to eq("app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue2.absolute_path).to eq('/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java')
+        expect(pmd_issue2.relative_path).to eq('app/src/test/java/com/android/sample/ToolsTest.java')
         expect(pmd_issue2.violations).not_to be_nil
         expect(pmd_issue2.violations.length).to eq(2)
         expect(pmd_issue2.violations[0]).not_to be_nil
@@ -164,19 +170,20 @@ module Danger
         expect(pmd_issue2.violations[1].description).to eq("The JUnit 4 test method name 'getLabel_2' doesn't match '[a-z][a-zA-Z0-9]*'")
       end
 
-      it "Report with report files" do
+      it 'Report with report files' do
+        # noinspection RubyLiteralArrayInspection
         target_files = [
-          "app/src/main/java/com/android/sample/Application.java",
-          "app/src/main/java/com/android/sample/MainActivity.java",
-          "app/src/main/java/com/android/sample/Tools.java",
-          "app/src/main/java/com/android/sample/Utils.java",
-          "app/src/test/java/com/android/sample/ExampleUnitTest.java",
-          "app/src/test/java/com/android/sample/ToolsTest.java"
+          'app/src/main/java/com/android/sample/Application.java',
+          'app/src/main/java/com/android/sample/MainActivity.java',
+          'app/src/main/java/com/android/sample/Tools.java',
+          'app/src/main/java/com/android/sample/Utils.java',
+          'app/src/test/java/com/android/sample/ExampleUnitTest.java',
+          'app/src/test/java/com/android/sample/ToolsTest.java'
         ]
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
 
-        @pmd.report_files = ["spec/fixtures/pmd_report.xml", "spec/fixtures/**/pmd_sub_report.xml"]
-        @pmd.root_path = "/Users/developer/sample/"
+        @pmd.report_files = %w[spec/fixtures/pmd_report.xml spec/fixtures/**/pmd_sub_report.xml]
+        @pmd.root_path = '/Users/developer/sample/'
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report
@@ -185,8 +192,8 @@ module Danger
 
         pmd_issue1 = pmd_issues[0]
         expect(pmd_issue1).not_to be_nil
-        expect(pmd_issue1.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-        expect(pmd_issue1.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java')
+        expect(pmd_issue1.relative_path).to eq('app/src/main/java/com/android/sample/Tools.java')
         expect(pmd_issue1.violations).not_to be_nil
         expect(pmd_issue1.violations.length).to eq(1)
         expect(pmd_issue1.violations.first).not_to be_nil
@@ -195,8 +202,8 @@ module Danger
 
         pmd_issue2 = pmd_issues[1]
         expect(pmd_issue2).not_to be_nil
-        expect(pmd_issue2.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java")
-        expect(pmd_issue2.relative_path).to eq("app/src/main/java/com/android/sample/MainActivity.java")
+        expect(pmd_issue2.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java')
+        expect(pmd_issue2.relative_path).to eq('app/src/main/java/com/android/sample/MainActivity.java')
         expect(pmd_issue2.violations).not_to be_nil
         expect(pmd_issue2.violations.length).to eq(1)
         expect(pmd_issue2.violations.first).not_to be_nil
@@ -205,8 +212,8 @@ module Danger
 
         pmd_issue3 = pmd_issues[2]
         expect(pmd_issue3).not_to be_nil
-        expect(pmd_issue3.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java")
-        expect(pmd_issue3.relative_path).to eq("app/src/test/java/com/android/sample/ExampleUnitTest.java")
+        expect(pmd_issue3.absolute_path).to eq('/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java')
+        expect(pmd_issue3.relative_path).to eq('app/src/test/java/com/android/sample/ExampleUnitTest.java')
         expect(pmd_issue3.violations).not_to be_nil
         expect(pmd_issue3.violations.length).to eq(1)
         expect(pmd_issue3.violations.first).not_to be_nil
@@ -215,8 +222,8 @@ module Danger
 
         pmd_issue4 = pmd_issues[3]
         expect(pmd_issue4).not_to be_nil
-        expect(pmd_issue4.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
-        expect(pmd_issue4.relative_path).to eq("app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue4.absolute_path).to eq('/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java')
+        expect(pmd_issue4.relative_path).to eq('app/src/test/java/com/android/sample/ToolsTest.java')
         expect(pmd_issue4.violations).not_to be_nil
         expect(pmd_issue4.violations.length).to eq(2)
         expect(pmd_issue4.violations[0]).not_to be_nil
@@ -228,50 +235,44 @@ module Danger
 
         pmd_issue5 = pmd_issues[4]
         expect(pmd_issue5).not_to be_nil
-        expect(pmd_issue5.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Utils.java")
-        expect(pmd_issue5.relative_path).to eq("app/src/main/java/com/android/sample/Utils.java")
+        expect(pmd_issue5.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Utils.java')
+        expect(pmd_issue5.relative_path).to eq('app/src/main/java/com/android/sample/Utils.java')
         expect(pmd_issue5.violations).not_to be_nil
         expect(pmd_issue5.violations.length).to eq(2)
         expect(pmd_issue5.violations[0]).not_to be_nil
         expect(pmd_issue5.violations[0].line).to eq(23)
-        expect(pmd_issue5.violations[0].description).to eq("These nested if statements could be combined")
+        expect(pmd_issue5.violations[0].description).to eq('These nested if statements could be combined')
         expect(pmd_issue5.violations[1]).not_to be_nil
         expect(pmd_issue5.violations[1].line).to eq(45)
-        expect(pmd_issue5.violations[1].description).to eq("The String literal \"unused\" appears 4 times in this file; the first occurrence is on line 45")
+        expect(pmd_issue5.violations[1].description).to eq('The String literal "unused" appears 4 times in this file; the first occurrence is on line 45')
 
         pmd_issue6 = pmd_issues[5]
         expect(pmd_issue6).not_to be_nil
-        expect(pmd_issue6.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Application.java")
-        expect(pmd_issue6.relative_path).to eq("app/src/main/java/com/android/sample/Application.java")
+        expect(pmd_issue6.absolute_path).to eq('/Users/developer/sample/app/src/main/java/com/android/sample/Application.java')
+        expect(pmd_issue6.relative_path).to eq('app/src/main/java/com/android/sample/Application.java')
         expect(pmd_issue6.violations).not_to be_nil
         expect(pmd_issue6.violations.length).to eq(1)
         expect(pmd_issue6.violations[0]).not_to be_nil
         expect(pmd_issue6.violations[0].line).to eq(135)
-        expect(pmd_issue6.violations[0].description).to eq("The String literal \"label\" appears 5 times in this file; the first occurrence is on line 135")
+        expect(pmd_issue6.violations[0].description).to eq('The String literal "label" appears 5 times in this file; the first occurrence is on line 135')
       end
 
-      it "Report without Gradle" do
+      it 'Report without Gradle' do
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return([])
 
-        @pmd.report_file = "spec/fixtures/pmd_report.xml"
+        @pmd.report_file = 'spec/fixtures/pmd_report.xml'
         @pmd.skip_gradle_task = false
 
-        pmd_issues = @pmd.report
-        expect(pmd_issues).not_to be_nil
-        expect(pmd_issues.length).to be(1)
-        expect(pmd_issues[0]).to be("Could not find `gradlew` inside current directory")
+        expect { @pmd.report }.to raise_error('Could not find `gradlew` inside current directory')
       end
 
-      it "Report without existing report file" do
+      it 'Report without existing report file' do
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return([])
 
-        @pmd.report_file = "spec/fixtures/custom/pmd_report.xml"
+        @pmd.report_file = 'spec/fixtures/custom/pmd_report.xml'
         @pmd.skip_gradle_task = true
 
-        pmd_issues = @pmd.report
-        expect(pmd_issues).not_to be_nil
-        expect(pmd_issues.length).to be(1)
-        expect(pmd_issues[0]).to eq("Could not find matching PMD report files for [\"spec/fixtures/custom/pmd_report.xml\"] inside current directory")
+        expect { @pmd.report }.to raise_error('Could not find matching PMD report files for ["spec/fixtures/custom/pmd_report.xml"] inside current directory')
       end
     end
   end