danger-pmd 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a2d9f880fd61118eab5f466d22fa9a63d90e642cf3f3bec0f1afeb3365a7c84
-  data.tar.gz: '0840aa8e767568221ffe52c5e8842900dce15cc8828255d0fa567752bb6d5c30'
+  metadata.gz: a1891cd48c4d313436dc6a38d0fe0bf26fd21dbd79555633777609fc6755c0f4
+  data.tar.gz: f6f2058ea738fa34b78a53af6376eb9d93ad4887fd803a8f535b58eaed5bd568
 SHA512:
-  metadata.gz: 8986e2a6b8dfb31b5725e63477022c14d72aecfe9d28ed3754a08ad3d747b575e7263b1367fa8b0ed95f38cf5030f0bccfd268c56737180db2996e40ec1e6d43
-  data.tar.gz: ba13a09f7402bcabdce873fae2047d81ee49fdfae3bba44d3c954bddfe2f5cc6115453eda265cf5969f1bb9a8a8fb79ef0ba5878be357a920c17e23d1e19fe90
+  metadata.gz: 75d23626c4d10bd650f4ac2bf6c5b210efaec64f49b86400de2b3cf89ff40c61384032567a9ceb7c02d67afeb3e13ade638c55d08affca736d4094317926825d
+  data.tar.gz: 5d270e5700d22cdd523fe41c0bac67ed0603fc82158000706f35ae7fc358af7cce5971f040dd3babb33dbde6e7c751e1ecfc27932517b6f3775b98d8186bdc07

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-pmd (0.2.1)
+    danger-pmd (0.2.2)
       danger-plugin-api (~> 1.0)
       oga (~> 2.10)
 

data/lib/pmd/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pmd
-  VERSION = "0.2.2"
+  VERSION = "0.3.0"
 end

data/lib/pmd/plugin.rb

@@ -34,7 +34,7 @@ module Danger
   # @tags java, android, pmd
 
   class DangerPmd < Plugin
-    require_relative "./pmd_file"
+    require_relative "./entity/pmd_file"
 
     # Custom Gradle task to run.
     # This is useful when your project has different flavors.

data/spec/entity/pmd_file_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require_relative "../spec_helper"
+
+module Pmd
+  require "oga"
+
+  describe PmdFile do
+    it "should initialize relative path ending with file separator" do
+      xml = Oga.parse_xml(File.open("spec/fixtures/pmd_report.xml"))
+      pmd_file = PmdFile.new("/Users/developer/sample/", xml.xpath("//file").first)
+
+      expect(pmd_file.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.violations).not_to be_nil
+      expect(pmd_file.violations.length).to eq(1)
+      expect(pmd_file.violations.first).not_to be_nil
+      expect(pmd_file.violations.first.line).to eq(5)
+      expect(pmd_file.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
+    end
+
+    it "should initialize relative path not ending with file separator" do
+      xml = Oga.parse_xml(File.open("spec/fixtures/pmd_report.xml"))
+      pmd_file = PmdFile.new("/Users/developer/sample", xml.xpath("//file").first)
+
+      expect(pmd_file.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.relative_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.violations).not_to be_nil
+      expect(pmd_file.violations.length).to eq(1)
+      expect(pmd_file.violations.first).not_to be_nil
+      expect(pmd_file.violations.first.line).to eq(5)
+      expect(pmd_file.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
+    end
+
+    it "should initialize relative path not prefixed" do
+      xml = Oga.parse_xml(File.open("spec/fixtures/pmd_report.xml"))
+      pmd_file = PmdFile.new("/Users/developer/something", xml.xpath("//file").first)
+
+      expect(pmd_file.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.relative_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+      expect(pmd_file.violations).not_to be_nil
+      expect(pmd_file.violations.length).to eq(1)
+      expect(pmd_file.violations.first).not_to be_nil
+      expect(pmd_file.violations.first.line).to eq(5)
+      expect(pmd_file.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
+    end
+  end
+end

data/spec/pmd_spec.rb

@@ -176,7 +176,7 @@ module Danger
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
 
         @pmd.report_files = ["spec/fixtures/pmd_report.xml", "spec/fixtures/**/pmd_sub_report.xml"]
-        @pmd.root_path = "/Users/developer/sample"
+        @pmd.root_path = "/Users/developer/sample/"
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-pmd
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - Mathieu Rul
@@ -183,10 +183,11 @@ files:
 - danger-pmd.gemspec
 - lib/danger_plugin.rb
 - lib/danger_pmd.rb
+- lib/pmd/entity/pmd_file.rb
+- lib/pmd/entity/pmd_violation.rb
 - lib/pmd/gem_version.rb
 - lib/pmd/plugin.rb
-- lib/pmd/pmd_file.rb
-- lib/pmd/pmd_violation.rb
+- spec/entity/pmd_file_spec.rb
 - spec/fixtures/pmd_report.xml
 - spec/fixtures/report_1/pmd_sub_report.xml
 - spec/fixtures/report_2/pmd_sub_report.xml
@@ -216,6 +217,7 @@ signing_key:
 specification_version: 4
 summary: A Danger plugin for PMD (Programming Mistake Detector), see https://pmd.github.io.
 test_files:
+- spec/entity/pmd_file_spec.rb
 - spec/fixtures/pmd_report.xml
 - spec/fixtures/report_1/pmd_sub_report.xml
 - spec/fixtures/report_2/pmd_sub_report.xml