danger-pmd 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a2697bcfe2820d4c84823070dffd3ea0062a1aa743c55d1265613eb78865508
-  data.tar.gz: 61412ff7cae4072811742d730ab19667b0c23584bee3a92cd5ad5241700db2b3
+  metadata.gz: 8d44fdbb62edb14a8de5ece8c8340f4746c300e8c54fae34a72436dd42ae5ec1
+  data.tar.gz: 60d66c53e9495fee4e5238625504458168b3c4bf68fb08f1188fbfa26560a483
 SHA512:
-  metadata.gz: a34d67327b69424a7ac177fd80358881c01159592711d79b62ffc45c3293144692b3549e394c71e287a7471c61a5e58c989259a952f79d51a4181a59a4d73d35
-  data.tar.gz: 916683f3ed4821208a84f0af44a6d2b33fb13c2769a03b3655d35e6a7ef8d5fd11ef6f913f3a0e4f3ee261be01be08d2a13cf8f8ea4058aa45afe2f2dd997360
+  metadata.gz: ec9f06385c7419e7b671e941bc89cce31e909220aab39f84a1837f5a5a680d3e571f8653b86b4b43b999e6f6495be4f7740d252592baeb3efad5713d1a7dd165
+  data.tar.gz: 7512fe083ce53ced178c0a92b23ce8e02ba7d8b411533ef18fa92165b6bf876b963ebfdd0905e7bfdb1f0d7e231c742c2fed05c2835c39101bd21cae9f7847b8

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-pmd (0.1.0)
+    danger-pmd (0.1.1)
       danger-plugin-api (~> 1.0)
       oga (~> 2.10)
 

data/lib/pmd/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pmd
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/pmd/plugin.rb

@@ -9,13 +9,13 @@ module Danger
   #
   #          pmd.report
   #
-  # @example Running PMD with a specific Gradle task or report file
+  # @example Running PMD with a specific Gradle task or report file (glob accepted)
   #
   #          pmd.gradle_task = 'app:pmd' #defalut: pmd
-  #          pmd.report_file = "app/build/reports/pmd/pmd.xml"
+  #          pmd.report_file = "module/build/reports/pmd/pmd.xml" #defalut: app/build/reports/pmd/pmd.xml
   #          pmd.report
   #
-  # @example Running PMD with an array of report files
+  # @example Running PMD with an array of report files (glob accepted)
   #
   #          pmd.report_files = ["modules/**/build/reports/pmd/pmd.xml", "app/build/reports/pmd/pmd.xml"]
   #          pmd.report
@@ -69,7 +69,7 @@ module Danger
 
     # Location of report files.
     # If your pmd task outputs to a different location, you can specify it here.
-    # Defaults to "app/build/reports/pmd/pmd.xml".
+    # Defaults to ["app/build/reports/pmd/pmd.xml"].
     # @return [Array[String]]
     attr_writer :report_files
 
@@ -91,16 +91,10 @@ module Danger
         exec_gradle_task
       end
 
-      report_files_flatten = []
-      report_files.each do |report_file|
-        Dir.glob(report_file).sort.each do |report_file_glob|
-          return fail("PMD report file not found #{report_file_glob}") unless report_file_exist?(report_file_glob)
-
-          report_files_flatten.push(report_file_glob)
-        end
-      end
+      report_files_expanded = Dir.glob(report_files).sort
+      return fail("Could not find matching PMD report files for #{report_files} inside current directory") if report_files_expanded.empty?
 
-      report_and_send_inline_comment(report_files_flatten, inline_mode)
+      report_and_send_inline_comment(report_files_expanded, inline_mode)
     end
 
     private

data/spec/pmd_spec.rb

@@ -29,7 +29,7 @@ module Danger
       end
 
       it "Set custom report files paths" do
-        custom_report_paths = %w(custom-path/pmd_report_1.xml custom-path/pmd_report_2.xml)
+        custom_report_paths = ["custom-path/pmd_report_1.xml", "custom-path/pmd_report_2.xml"]
         @pmd.report_files = custom_report_paths
         expect(@pmd.report_files).to eq(custom_report_paths)
       end
@@ -44,16 +44,16 @@ module Danger
         expect(@pmd.gradle_task).to eq(custom_task)
       end
 
+      it "Check default skip Gradle task" do
+        expect(@pmd.skip_gradle_task).to eq(false)
+      end
+
       it "Skip Gradle task" do
         skip_gradle_task = true
         @pmd.skip_gradle_task = skip_gradle_task
         expect(@pmd.skip_gradle_task).to eq(skip_gradle_task)
       end
 
-      it "Check default skip Gradle task" do
-        expect(@pmd.skip_gradle_task).to eq(false)
-      end
-
       it "Report with report file" do
         target_files = [
           "/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java",
@@ -163,7 +163,7 @@ module Danger
         ]
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
 
-        @pmd.report_files = %w(spec/fixtures/pmd_report.xml spec/fixtures/**/pmd_sub_report.xml)
+        @pmd.report_files = ["spec/fixtures/pmd_report.xml", "spec/fixtures/**/pmd_sub_report.xml"]
         @pmd.skip_gradle_task = true
 
         pmd_issues = @pmd.report
@@ -257,7 +257,8 @@ module Danger
 
         pmd_issues = @pmd.report
         expect(pmd_issues).not_to be_nil
-        expect(pmd_issues.length).to be(0)
+        expect(pmd_issues.length).to be(1)
+        expect(pmd_issues[0]).to eq("Could not find matching PMD report files for [\"spec/fixtures/custom/pmd_report.xml\"] inside current directory")
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-pmd
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Mathieu Rul