danger-pmd 0.0.5 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53cc82c8c415625b6288cbe5723362dc833f633d2fbe9ccb0b51e410aa83d989
-  data.tar.gz: bb9a5b9e8658e72cc8092b0623cd0aa645f6d8fb634e0312b8c113b0f7057234
+  metadata.gz: 9a2697bcfe2820d4c84823070dffd3ea0062a1aa743c55d1265613eb78865508
+  data.tar.gz: 61412ff7cae4072811742d730ab19667b0c23584bee3a92cd5ad5241700db2b3
 SHA512:
-  metadata.gz: 1de03c38720bb5f06dfca0ff63c3589d95e6237596e6ce80bd09f87050ef34f4281bda05367f272c1dbf5dae23fbc3c4084b55938c52559e0e97c29967a7fa48
-  data.tar.gz: f18e9d01bf1b6c5c4210226f571637a735575d089b6da85cb37742277e7651ca787f22bc782d498f96cc9605a27343f1058aaa49c04aaadd8022211d4ce4717a
+  metadata.gz: a34d67327b69424a7ac177fd80358881c01159592711d79b62ffc45c3293144692b3549e394c71e287a7471c61a5e58c989259a952f79d51a4181a59a4d73d35
+  data.tar.gz: 916683f3ed4821208a84f0af44a6d2b33fb13c2769a03b3655d35e6a7ef8d5fd11ef6f913f3a0e4f3ee261be01be08d2a13cf8f8ea4058aa45afe2f2dd997360

data/.rubocop.yml

@@ -23,10 +23,10 @@ Lint/UselessAssignment:
     - '**/spec/**/*'
 
 # We could potentially enable the 2 below:
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   Enabled: false
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: false
 
 # HoundCI doesn't like this rule
@@ -124,13 +124,18 @@ Metrics/BlockLength:
   Exclude:
     - "**/*_spec.rb"
 
+Metrics/ModuleLength:
+  Max: 100
+  Exclude:
+    - "**/*_spec.rb"
+
 Style/MixinGrouping:
   Enabled: false
 
 Style/FileName:
   Enabled: false
 
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   Enabled: false
 
 Style/SpecialGlobalVars:

data/.travis.yml

@@ -4,7 +4,7 @@ cache:
     - bundle
 
 rvm:
-  - 2.3.1
+  - 2.3.8
 
 script:
-    - bundle exec rake spec
+    - bundle exec rake spec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-pmd (0.0.4)
+    danger-pmd (0.1.0)
       danger-plugin-api (~> 1.0)
       oga (~> 2.10)
 
@@ -37,14 +37,14 @@ GEM
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.3)
-    faraday (0.16.2)
+    faraday (0.17.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (2.0.0)
       faraday (~> 0.8)
-    ffi (1.11.1)
+    ffi (1.11.3)
     formatador (0.2.5)
     git (1.5.0)
-    guard (2.15.1)
+    guard (2.16.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -58,7 +58,7 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    jaro_winkler (1.5.3)
+    jaro_winkler (1.5.4)
     kramdown (2.1.0)
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
@@ -80,7 +80,7 @@ GEM
       ast
       ruby-ll (~> 2.1)
     open4 (1.3.4)
-    parallel (1.17.0)
+    parallel (1.19.1)
     parser (2.6.5.0)
       ast (~> 2.4.0)
     pry (0.12.2)
@@ -90,22 +90,22 @@ GEM
     rainbow (3.0.0)
     rake (10.5.0)
     rb-fsevent (0.10.3)
-    rb-inotify (0.10.0)
+    rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.5)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.0)
+      rspec-support (~> 3.9.0)
+    rspec-expectations (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.2)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.3)
-    rubocop (0.75.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.0)
+    rubocop (0.78.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.6)
@@ -122,7 +122,7 @@ GEM
     shellany (0.0.1)
     terminal-table (1.8.0)
       unicode-display_width (~> 1.1, >= 1.1.1)
-    thor (0.20.3)
+    thor (1.0.1)
     unicode-display_width (1.6.0)
     yard (0.9.20)
 
@@ -142,4 +142,4 @@ DEPENDENCIES
   yard (~> 0.9.20)
 
 BUNDLED WITH
-   1.17.2
+   1.17.3

data/README.md

@@ -25,44 +25,50 @@ pmd.report
 </pre>
 </blockquote>
 
-#### Attributes
+<blockquote>Running PMD with an array of report files
+<pre>
+pmd.report_files = ["modules/**/build/reports/pmd/pmd.xml", "app/build/reports/pmd/pmd.xml"]
+pmd.report
+</pre>
+</blockquote>
 
-`gradle_module` - Custom Gradle module to run.
-This is useful when your project has different flavors.
-Defaults to "app".
+<blockquote>Running PMD without running a Gradle task
+<pre>
+pmd.skip_gradle_task = true
+pmd.report
+</pre>
+</blockquote>
+
+#### Attributes
 
 `gradle_task` - Custom Gradle task to run.
 This is useful when your project has different flavors.
 Defaults to "pmd".
 
+`skip_gradle_task` - Skip Gradle task.
+If you skip Gradle task, for example project does not manage Gradle.
+
 `report_file` - Location of report file
 If your pmd task outputs to a different location, you can specify it here.
 Defaults to "app/build/reports/pmd/pmd.xml".
 
-`skip_gradle_task` - Skip Gradle task.
-If you skip Gradle task, for example project does not manage Gradle.
+`report_files` - Location of report files
+If your pmd task outputs to a different location, you can specify it here.
+Defaults to ["app/build/reports/pmd/pmd.xml]".
 
 #### Methods
 
-`report` - Calls pmd task of your Gradle project.
+`report` - Calls PMD task of your Gradle project, send comment and return PMD issues.
 It fails if `gradlew` cannot be found inside current directory.
-It fails if `report_file` cannot be found inside current directory.
+It fails if `report_file` or `report_files` cannot be found inside current directory.
 
-`target_files` - A getter for current updated files.
+`gradle_task` - A getter for `gradle_task`, returning Gradle task report.
 
-`exec_gradle_task` - Run Gradle task.
+`skip_gradle_task` - A getter for `skip_gradle_task`.
 
-`gradlew_exists?` - Check gradlew file exists in current directory.
+`report_file` - A getter for `report_file`.
 
-`report_file_exist?` - Check report_file exists in current directory.
-
-`pmd_report` - A getter for `pmd_report`, returning PMD report.
-
-`pmd_issues` - A getter for PMD issues, returning PMD issues.
-
-`send_inline_comment` - Send inline comment with danger's warn or fail method.
-
-`skip_gradle_task` - Skip Gradle task.
+`report_files` - A getter for `report_files`.
 
 ## Development
 

data/lib/pmd/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pmd
-  VERSION = "0.0.5"
+  VERSION = "0.1.0"
 end

data/lib/pmd/plugin.rb

@@ -15,6 +15,11 @@ module Danger
   #          pmd.report_file = "app/build/reports/pmd/pmd.xml"
   #          pmd.report
   #
+  # @example Running PMD with an array of report files
+  #
+  #          pmd.report_files = ["modules/**/build/reports/pmd/pmd.xml", "app/build/reports/pmd/pmd.xml"]
+  #          pmd.report
+  #
   # @example Running PMD without running a Gradle task
   #
   #          pmd.skip_gradle_task = true
@@ -26,123 +31,139 @@ module Danger
   class DangerPmd < Plugin
     require_relative "./pmd_file"
 
-    # Custom Gradle module to run.
-    # This is useful when your project has different flavors.
-    # Defaults to "app".
-    # @return [String]
-    attr_writer :gradle_module
-
     # Custom Gradle task to run.
     # This is useful when your project has different flavors.
     # Defaults to "pmd".
     # @return [String]
     attr_writer :gradle_task
 
-    # Location of report file
-    # If your pmd task outputs to a different location, you can specify it here.
-    # Defaults to "build/reports/pmd/pmd.xml".
+    # A getter for `gradle_task`, returning "pmd" if value is nil.
     # @return [String]
-    attr_writer :report_file
+    def gradle_task
+      @gradle_task ||= "pmd"
+    end
 
-    # Skip Gradle task
+    # Skip Gradle task.
     # If you skip Gradle task, for example project does not manage Gradle.
+    # Defaults to `false`.
     # @return [Bool]
     attr_writer :skip_gradle_task
 
-    GRADLEW_NOT_FOUND = "Could not find `gradlew` inside current directory"
-    REPORT_FILE_NOT_FOUND = "PMD report not found"
+    # A getter for `skip_gradle_task`, returning false if value is nil.
+    # @return [Boolean]
+    def skip_gradle_task
+      @skip_gradle_task ||= false
+    end
+
+    # Location of report file.
+    # If your pmd task outputs to a different location, you can specify it here.
+    # Defaults to "app/build/reports/pmd/pmd.xml".
+    # @return [String]
+    attr_writer :report_file
+
+    # A getter for `report_file`, returning "app/build/reports/pmd/pmd.xml" if value is nil.
+    # @return [String]
+    def report_file
+      @report_file ||= "app/build/reports/pmd/pmd.xml"
+    end
+
+    # Location of report files.
+    # If your pmd task outputs to a different location, you can specify it here.
+    # Defaults to "app/build/reports/pmd/pmd.xml".
+    # @return [Array[String]]
+    attr_writer :report_files
+
+    # A getter for `report_files`, returning ["app/build/reports/pmd/pmd.xml"] if value is nil.
+    # @return [Array[String]]
+    def report_files
+      @report_files ||= [report_file]
+    end
 
     # Calls PMD task of your Gradle project.
     # It fails if `gradlew` cannot be found inside current directory.
     # It fails if `report_file` cannot be found inside current directory.
-    # @return [void]
+    # It fails if `report_files` is empty.
+    # @return [Array[PmdFile]]
     def report(inline_mode = true)
       unless skip_gradle_task
-        return fail(GRADLEW_NOT_FOUND) unless gradlew_exists?
+        return fail("Could not find `gradlew` inside current directory") unless gradlew_exists?
 
         exec_gradle_task
       end
 
-      return fail(REPORT_FILE_NOT_FOUND) unless report_file_exist?
+      report_files_flatten = []
+      report_files.each do |report_file|
+        Dir.glob(report_file).sort.each do |report_file_glob|
+          return fail("PMD report file not found #{report_file_glob}") unless report_file_exist?(report_file_glob)
 
-      if inline_mode
-        send_inline_comment
+          report_files_flatten.push(report_file_glob)
+        end
       end
-    end
 
-    # A getter for `gradle_module`, returning "app" if value is nil.
-    # @return [String]
-    def gradle_module
-      @gradle_module ||= "app"
+      report_and_send_inline_comment(report_files_flatten, inline_mode)
     end
 
-    # A getter for `gradle_task`, returning "pmd" if value is nil.
-    # @return [String]
-    def gradle_task
-      @gradle_task ||= "pmd"
-    end
-
-    # A getter for `skip_gradle_task`, returning false if value is nil.
-    # @return [Boolean]
-    def skip_gradle_task
-      @skip_gradle_task ||= false
-    end
+    private
 
-    # A getter for `report_file`, returning "app/build/reports/pmd/pmd.xml" if value is nil.
-    # @return [String]
-    def report_file
-      @report_file ||= "app/build/reports/pmd/pmd.xml"
-    end
-
-    # A getter for current updated files
-    # @return [Array[String]]
-    def target_files
-      @target_files ||= (git.modified_files - git.deleted_files) + git.added_files
+    # Check gradlew file exists in current directory.
+    # @return [Bool]
+    def gradlew_exists?
+      !`ls gradlew`.strip.empty?
     end
 
-    # Run Gradle task
+    # Run Gradle task.
     # @return [void]
     def exec_gradle_task
       system "./gradlew #{gradle_task}"
     end
 
-    # Check gradlew file exists in current directory
-    # @return [Bool]
-    def gradlew_exists?
-      !`ls gradlew`.strip.empty?
-    end
-
-    # Check report_file exists in current directory
+    # Check report_file exists in current directory.
     # @return [Bool]
-    def report_file_exist?
+    def report_file_exist?(report_file)
       File.exist?(report_file)
     end
 
     # A getter for `pmd_report`, returning PMD report.
     # @return [Oga::XML::Document]
-    def pmd_report
+    def pmd_report(report_file)
       require "oga"
-      @pmd_report ||= Oga.parse_xml(File.open(report_file))
+      Oga.parse_xml(File.open(report_file))
     end
 
     # A getter for PMD issues, returning PMD issues.
     # @return [Array[PmdFile]]
-    def pmd_issues
-      @pmd_issues ||= pmd_report.xpath("//file").map do |pmd_file|
-        PmdFile.new(gradle_module, pmd_file)
+    def pmd_issues(report_file)
+      pmd_report(report_file).xpath("//file").map do |pmd_file|
+        PmdFile.new(pmd_file)
       end
     end
 
-    # Send inline comment with Danger's warn or fail method
-    # @return [void]
-    def send_inline_comment
-      pmd_issues.each do |pmd_file|
-        next unless target_files.include? pmd_file.absolute_path
+    # A getter for current updated files.
+    # @return [Array[String]]
+    def target_files
+      @target_files ||= (git.modified_files - git.deleted_files) + git.added_files
+    end
+
+    # Generate report and send inline comment with Danger's warn or fail method.
+    # @return [Array[PmdFile]]
+    def report_and_send_inline_comment(report_files, inline_mode = true)
+      pmd_issues = []
 
-        pmd_file.violations.each do |pmd_violation|
-          send(pmd_violation.type, pmd_violation.description, file: pmd_file.absolute_path, line: pmd_violation.line)
+      report_files.each do |report_file|
+        pmd_issues(report_file).each do |pmd_file|
+          next unless target_files.include? pmd_file.absolute_path
+
+          pmd_issues.push(pmd_file)
+
+          next if inline_mode
+
+          pmd_file.violations.each do |pmd_violation|
+            send(pmd_violation.type, pmd_violation.description, file: pmd_file.absolute_path, line: pmd_violation.line)
+          end
         end
       end
+
+      pmd_issues
     end
   end
 end

data/lib/pmd/pmd_file.rb

@@ -2,11 +2,9 @@
 
 class PmdFile
   require_relative "./pmd_violation"
-  attr_accessor :module_name
   attr_accessor :file
 
-  def initialize(module_name, file)
-    @module_name = module_name
+  def initialize(file)
     @file = file
   end
 
@@ -15,12 +13,19 @@ class PmdFile
   end
 
   def absolute_path
-    @absolute_path ||= Pathname.new(source_path[source_path.index(module_name), source_path.length]).to_s
+    dirname = File.basename(Dir.getwd)
+    if source_path.index(dirname)
+      index_start = source_path.index(dirname) + dirname.length + 1
+    else
+      index_start = 0
+    end
+    index_end = source_path.length
+    @absolute_path ||= Pathname.new(source_path[index_start, index_end]).to_s
   end
 
   def violations
     @violations ||= file.xpath("violation").map do |pmd_violation|
-      PmdViolation.new(module_name, pmd_violation)
+      PmdViolation.new(pmd_violation)
     end
   end
 end

data/lib/pmd/pmd_violation.rb

@@ -2,11 +2,9 @@
 
 class PmdViolation
   PRIORITY_ERROR_THRESHOLD = 2
-  attr_accessor :module_name
   attr_accessor :violation
 
-  def initialize(module_name, violation)
-    @module_name = module_name
+  def initialize(violation)
     @violation = violation
   end
 

data/spec/fixtures/report_1/pmd_sub_report.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<pmd xmlns="http://pmd.sourceforge.net/report/2.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://pmd.sourceforge.net/report/2.0.0 http://pmd.sourceforge.net/report_2_0_0.xsd"
+    version="6.8.0" timestamp="2019-10-03T20:34:18.074">
+<file name="/Users/developer/sample/app/src/main/java/com/android/sample/Utils.java">
+<violation beginline="23" endline="23" begincolumn="21" endcolumn="21" rule="CollapsibleIfStatements" ruleset="Design" package="com.android.sample" class="Utils" method="doSomething" externalInfoUrl="https://pmd.github.io/pmd-6.15.0/pmd_rules_java_design.html#collapsibleifstatements" priority="3">
+These nested if statements could be combined
+</violation>
+<violation beginline="45" endline="45" begincolumn="23" endcolumn="30" rule="AvoidDuplicateLiterals" ruleset="Error Prone" package="com.android.sample" class="Utils" externalInfoUrl="https://pmd.github.io/pmd-6.15.0/pmd_rules_java_errorprone.html#avoidduplicateliterals" priority="3">
+The String literal &quot;unused&quot; appears 4 times in this file; the first occurrence is on line 45
+</violation>
+</file>
+</pmd>

data/spec/fixtures/report_2/pmd_sub_report.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<pmd xmlns="http://pmd.sourceforge.net/report/2.0.0"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://pmd.sourceforge.net/report/2.0.0 http://pmd.sourceforge.net/report_2_0_0.xsd"
+    version="6.8.0" timestamp="2019-10-03T20:34:18.074">
+<file name="/Users/developer/sample/app/src/main/java/com/android/sample/Application.java">
+<violation beginline="135" endline="135" begincolumn="27" endcolumn="33" rule="AvoidDuplicateLiterals" ruleset="Error Prone" package="com.android.sample" class="Application" method="start" externalInfoUrl="https://pmd.github.io/pmd-6.15.0/pmd_rules_java_errorprone.html#avoidduplicateliterals" priority="3">
+The String literal &quot;label&quot; appears 5 times in this file; the first occurrence is on line 135
+</violation>
+</file>
+</pmd>

data/spec/pmd_spec.rb

@@ -11,59 +11,69 @@ module Danger
     describe "with Dangerfile" do
       before do
         @dangerfile = testing_dangerfile
-        @my_plugin = @dangerfile.pmd
+        @pmd = @dangerfile.pmd
       end
 
       it "Check default report file path" do
-        expect(@my_plugin.report_file).to eq("app/build/reports/pmd/pmd.xml")
+        expect(@pmd.report_file).to eq("app/build/reports/pmd/pmd.xml")
       end
 
       it "Set custom report file path" do
-        custom_report_path = "custom/pmd_report.xml"
-        @my_plugin.report_file = custom_report_path
-        expect(@my_plugin.report_file).to eq(custom_report_path)
+        custom_report_path = "custom-path/pmd_sub_report.xml"
+        @pmd.report_file = custom_report_path
+        expect(@pmd.report_file).to eq(custom_report_path)
       end
 
-      it "Check default Gradle module" do
-        expect(@my_plugin.gradle_module).to eq("app")
+      it "Check default report files paths" do
+        expect(@pmd.report_files).to eq(["app/build/reports/pmd/pmd.xml"])
       end
 
-      it "Set custom Gradle module" do
-        my_module = "custom_module"
-        @my_plugin.gradle_module = my_module
-        expect(@my_plugin.gradle_module).to eq(my_module)
+      it "Set custom report files paths" do
+        custom_report_paths = %w(custom-path/pmd_report_1.xml custom-path/pmd_report_2.xml)
+        @pmd.report_files = custom_report_paths
+        expect(@pmd.report_files).to eq(custom_report_paths)
       end
 
       it "Check default Gradle task" do
-        expect(@my_plugin.gradle_task).to eq("pmd")
+        expect(@pmd.gradle_task).to eq("pmd")
       end
 
       it "Set custom Gradle task" do
         custom_task = "pmdStagingDebug"
-        @my_plugin.gradle_task = custom_task
-        expect(@my_plugin.gradle_task).to eq(custom_task)
+        @pmd.gradle_task = custom_task
+        expect(@pmd.gradle_task).to eq(custom_task)
       end
 
       it "Skip Gradle task" do
         skip_gradle_task = true
-        @my_plugin.skip_gradle_task = skip_gradle_task
-        expect(@my_plugin.skip_gradle_task).to eq(skip_gradle_task)
+        @pmd.skip_gradle_task = skip_gradle_task
+        expect(@pmd.skip_gradle_task).to eq(skip_gradle_task)
       end
 
       it "Check default skip Gradle task" do
-        expect(@my_plugin.skip_gradle_task).to eq(false)
+        expect(@pmd.skip_gradle_task).to eq(false)
       end
 
-      it "Create files" do
-        custom_report_path = "spec/fixtures/pmd_report.xml"
-        @my_plugin.report_file = custom_report_path
-        pmd_issues = @my_plugin.pmd_issues
+      it "Report with report file" do
+        target_files = [
+          "/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java",
+          "/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java",
+          "/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java",
+          "/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java"
+        ]
+        allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
+
+        @pmd.report_file = "spec/fixtures/pmd_report.xml"
+        @pmd.skip_gradle_task = true
+
+        pmd_issues = @pmd.report
         expect(pmd_issues).not_to be_nil
+        expect(pmd_issues.length).to be(4)
 
         pmd_issue1 = pmd_issues[0]
         expect(pmd_issue1).not_to be_nil
         expect(pmd_issue1.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
-        expect(pmd_issue1.absolute_path).to eq("app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
         expect(pmd_issue1.violations).not_to be_nil
         expect(pmd_issue1.violations.length).to eq(1)
         expect(pmd_issue1.violations.first).not_to be_nil
@@ -73,7 +83,7 @@ module Danger
         pmd_issue2 = pmd_issues[1]
         expect(pmd_issue2).not_to be_nil
         expect(pmd_issue2.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java")
-        expect(pmd_issue2.absolute_path).to eq("app/src/main/java/com/android/sample/MainActivity.java")
+        expect(pmd_issue2.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java")
         expect(pmd_issue2.violations).not_to be_nil
         expect(pmd_issue2.violations.length).to eq(1)
         expect(pmd_issue2.violations.first).not_to be_nil
@@ -83,7 +93,7 @@ module Danger
         pmd_issue3 = pmd_issues[2]
         expect(pmd_issue3).not_to be_nil
         expect(pmd_issue3.source_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java")
-        expect(pmd_issue3.absolute_path).to eq("app/src/test/java/com/android/sample/ExampleUnitTest.java")
+        expect(pmd_issue3.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java")
         expect(pmd_issue3.violations).not_to be_nil
         expect(pmd_issue3.violations.length).to eq(1)
         expect(pmd_issue3.violations.first).not_to be_nil
@@ -93,7 +103,7 @@ module Danger
         pmd_issue4 = pmd_issues[3]
         expect(pmd_issue4).not_to be_nil
         expect(pmd_issue4.source_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
-        expect(pmd_issue4.absolute_path).to eq("app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue4.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
         expect(pmd_issue4.violations).not_to be_nil
         expect(pmd_issue4.violations.length).to eq(2)
         expect(pmd_issue4.violations[0]).not_to be_nil
@@ -104,11 +114,150 @@ module Danger
         expect(pmd_issue4.violations[1].description).to eq("The JUnit 4 test method name 'getLabel_2' doesn't match '[a-z][a-zA-Z0-9]*'")
       end
 
-      it "Send inline comments" do
+      it "Report with report file not in target files" do
+        target_files = [
+          "/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java",
+          "/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java"
+        ]
+        allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
+
+        @pmd.report_file = "spec/fixtures/pmd_report.xml"
+        @pmd.skip_gradle_task = true
+
+        pmd_issues = @pmd.report
+        expect(pmd_issues).not_to be_nil
+        expect(pmd_issues.length).to be(2)
+
+        pmd_issue1 = pmd_issues[0]
+        expect(pmd_issue1).not_to be_nil
+        expect(pmd_issue1.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.violations).not_to be_nil
+        expect(pmd_issue1.violations.length).to eq(1)
+        expect(pmd_issue1.violations.first).not_to be_nil
+        expect(pmd_issue1.violations.first.line).to eq(5)
+        expect(pmd_issue1.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
+
+        pmd_issue2 = pmd_issues[1]
+        expect(pmd_issue2).not_to be_nil
+        expect(pmd_issue2.source_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue2.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue2.violations).not_to be_nil
+        expect(pmd_issue2.violations.length).to eq(2)
+        expect(pmd_issue2.violations[0]).not_to be_nil
+        expect(pmd_issue2.violations[0].line).to eq(12)
+        expect(pmd_issue2.violations[0].description).to eq("The JUnit 4 test method name 'getLabel_1' doesn't match '[a-z][a-zA-Z0-9]*'")
+        expect(pmd_issue2.violations[1]).not_to be_nil
+        expect(pmd_issue2.violations[1].line).to eq(18)
+        expect(pmd_issue2.violations[1].description).to eq("The JUnit 4 test method name 'getLabel_2' doesn't match '[a-z][a-zA-Z0-9]*'")
+      end
+
+      it "Report with report files" do
+        target_files = [
+          "/Users/developer/sample/app/src/main/java/com/android/sample/Application.java",
+          "/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java",
+          "/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java",
+          "/Users/developer/sample/app/src/main/java/com/android/sample/Utils.java",
+          "/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java",
+          "/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java"
+        ]
+        allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return(target_files)
+
+        @pmd.report_files = %w(spec/fixtures/pmd_report.xml spec/fixtures/**/pmd_sub_report.xml)
+        @pmd.skip_gradle_task = true
+
+        pmd_issues = @pmd.report
+        expect(pmd_issues).not_to be_nil
+        expect(pmd_issues.length).to be(6)
+
+        pmd_issue1 = pmd_issues[0]
+        expect(pmd_issue1).not_to be_nil
+        expect(pmd_issue1.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Tools.java")
+        expect(pmd_issue1.violations).not_to be_nil
+        expect(pmd_issue1.violations.length).to eq(1)
+        expect(pmd_issue1.violations.first).not_to be_nil
+        expect(pmd_issue1.violations.first.line).to eq(5)
+        expect(pmd_issue1.violations.first.description).to eq("The utility class name 'Tools' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper)'")
+
+        pmd_issue2 = pmd_issues[1]
+        expect(pmd_issue2).not_to be_nil
+        expect(pmd_issue2.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java")
+        expect(pmd_issue2.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/MainActivity.java")
+        expect(pmd_issue2.violations).not_to be_nil
+        expect(pmd_issue2.violations.length).to eq(1)
+        expect(pmd_issue2.violations.first).not_to be_nil
+        expect(pmd_issue2.violations.first.line).to eq(39)
+        expect(pmd_issue2.violations.first.description).to eq("Use equals() to compare strings instead of '==' or '!='")
+
+        pmd_issue3 = pmd_issues[2]
+        expect(pmd_issue3).not_to be_nil
+        expect(pmd_issue3.source_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java")
+        expect(pmd_issue3.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ExampleUnitTest.java")
+        expect(pmd_issue3.violations).not_to be_nil
+        expect(pmd_issue3.violations.length).to eq(1)
+        expect(pmd_issue3.violations.first).not_to be_nil
+        expect(pmd_issue3.violations.first.line).to eq(15)
+        expect(pmd_issue3.violations.first.description).to eq("The JUnit 4 test method name 'addition_isCorrect' doesn't match '[a-z][a-zA-Z0-9]*'")
+
+        pmd_issue4 = pmd_issues[3]
+        expect(pmd_issue4).not_to be_nil
+        expect(pmd_issue4.source_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue4.absolute_path).to eq("/Users/developer/sample/app/src/test/java/com/android/sample/ToolsTest.java")
+        expect(pmd_issue4.violations).not_to be_nil
+        expect(pmd_issue4.violations.length).to eq(2)
+        expect(pmd_issue4.violations[0]).not_to be_nil
+        expect(pmd_issue4.violations[0].line).to eq(12)
+        expect(pmd_issue4.violations[0].description).to eq("The JUnit 4 test method name 'getLabel_1' doesn't match '[a-z][a-zA-Z0-9]*'")
+        expect(pmd_issue4.violations[1]).not_to be_nil
+        expect(pmd_issue4.violations[1].line).to eq(18)
+        expect(pmd_issue4.violations[1].description).to eq("The JUnit 4 test method name 'getLabel_2' doesn't match '[a-z][a-zA-Z0-9]*'")
+
+        pmd_issue5 = pmd_issues[4]
+        expect(pmd_issue5).not_to be_nil
+        expect(pmd_issue5.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Utils.java")
+        expect(pmd_issue5.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Utils.java")
+        expect(pmd_issue5.violations).not_to be_nil
+        expect(pmd_issue5.violations.length).to eq(2)
+        expect(pmd_issue5.violations[0]).not_to be_nil
+        expect(pmd_issue5.violations[0].line).to eq(23)
+        expect(pmd_issue5.violations[0].description).to eq("These nested if statements could be combined")
+        expect(pmd_issue5.violations[1]).not_to be_nil
+        expect(pmd_issue5.violations[1].line).to eq(45)
+        expect(pmd_issue5.violations[1].description).to eq("The String literal \"unused\" appears 4 times in this file; the first occurrence is on line 45")
+
+        pmd_issue6 = pmd_issues[5]
+        expect(pmd_issue6).not_to be_nil
+        expect(pmd_issue6.source_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Application.java")
+        expect(pmd_issue6.absolute_path).to eq("/Users/developer/sample/app/src/main/java/com/android/sample/Application.java")
+        expect(pmd_issue6.violations).not_to be_nil
+        expect(pmd_issue6.violations.length).to eq(1)
+        expect(pmd_issue6.violations[0]).not_to be_nil
+        expect(pmd_issue6.violations[0].line).to eq(135)
+        expect(pmd_issue6.violations[0].description).to eq("The String literal \"label\" appears 5 times in this file; the first occurrence is on line 135")
+      end
+
+      it "Report without Gradle" do
         allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return([])
-        custom_report_path = "spec/fixtures/pmd_report.xml"
-        @my_plugin.report_file = custom_report_path
-        expect(@my_plugin.send_inline_comment).not_to be_nil
+
+        @pmd.report_file = "spec/fixtures/pmd_report.xml"
+        @pmd.skip_gradle_task = false
+
+        pmd_issues = @pmd.report
+        expect(pmd_issues).not_to be_nil
+        expect(pmd_issues.length).to be(1)
+        expect(pmd_issues[0]).to be("Could not find `gradlew` inside current directory")
+      end
+
+      it "Report without existing report file" do
+        allow_any_instance_of(Danger::DangerPmd).to receive(:target_files).and_return([])
+
+        @pmd.report_file = "spec/fixtures/custom/pmd_report.xml"
+        @pmd.skip_gradle_task = true
+
+        pmd_issues = @pmd.report
+        expect(pmd_issues).not_to be_nil
+        expect(pmd_issues.length).to be(0)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-pmd
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors:
 - Mathieu Rul
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-05 00:00:00.000000000 Z
+date: 2019-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -188,6 +188,8 @@ files:
 - lib/pmd/pmd_file.rb
 - lib/pmd/pmd_violation.rb
 - spec/fixtures/pmd_report.xml
+- spec/fixtures/report_1/pmd_sub_report.xml
+- spec/fixtures/report_2/pmd_sub_report.xml
 - spec/pmd_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/mathroule/danger-pmd
@@ -209,11 +211,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: A Danger plugin for PMD (Programming Mistake Detector), see https://pmd.github.io.
 test_files:
 - spec/fixtures/pmd_report.xml
+- spec/fixtures/report_1/pmd_sub_report.xml
+- spec/fixtures/report_2/pmd_sub_report.xml
 - spec/pmd_spec.rb
 - spec/spec_helper.rb