danger-pmd 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f91b0cf54fc49b0992f18c475b335ea2694aabd799f126f243f76b7cc690e020
-  data.tar.gz: 20225632d9983c23d2c2f315e5ce33df7af5eb6f53179b0d6ef8fea8f699c683
+  metadata.gz: 53cc82c8c415625b6288cbe5723362dc833f633d2fbe9ccb0b51e410aa83d989
+  data.tar.gz: bb9a5b9e8658e72cc8092b0623cd0aa645f6d8fb634e0312b8c113b0f7057234
 SHA512:
-  metadata.gz: 5c00d8d5d00123ce2df89a64deabb717e12d09552801ff45cb025a87c6e105acc2918426e93eec5afbbd545cda1cb7212ecff453a962164f37a1ff1a4f1b09e5
-  data.tar.gz: 74e87c0a51aae474ef9f744e5ff0ecfd6b17832d8913a4e33aacf9e6ee652b258e3185d83e120816027d272ddbf6dfd773ca64d0540a2e162b4312e8141e49a1
+  metadata.gz: 1de03c38720bb5f06dfca0ff63c3589d95e6237596e6ce80bd09f87050ef34f4281bda05367f272c1dbf5dae23fbc3c4084b55938c52559e0e97c29967a7fa48
+  data.tar.gz: f18e9d01bf1b6c5c4210226f571637a735575d089b6da85cb37742277e7651ca787f22bc782d498f96cc9605a27343f1058aaa49c04aaadd8022211d4ce4717a

data/README.md

@@ -39,25 +39,30 @@ Defaults to "pmd".
 If your pmd task outputs to a different location, you can specify it here.
 Defaults to "app/build/reports/pmd/pmd.xml".
 
+`skip_gradle_task` - Skip Gradle task.
+If you skip Gradle task, for example project does not manage Gradle.
+
 #### Methods
 
 `report` - Calls pmd task of your Gradle project.
 It fails if `gradlew` cannot be found inside current directory.
 It fails if `report_file` cannot be found inside current directory.
 
-`target_files` - A getter for current updated files
+`target_files` - A getter for current updated files.
 
-`exec_gradle_task` - Run Gradle task
+`exec_gradle_task` - Run Gradle task.
 
-`gradlew_exists?` - Check gradlew file exists in current directory
+`gradlew_exists?` - Check gradlew file exists in current directory.
 
-`report_file_exist?` - Check report_file exists in current directory
+`report_file_exist?` - Check report_file exists in current directory.
 
 `pmd_report` - A getter for `pmd_report`, returning PMD report.
 
 `pmd_issues` - A getter for PMD issues, returning PMD issues.
 
-`send_inline_comment` - Send inline comment with danger's warn or fail method
+`send_inline_comment` - Send inline comment with danger's warn or fail method.
+
+`skip_gradle_task` - Skip Gradle task.
 
 ## Development
 

data/lib/pmd/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pmd
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/pmd/plugin.rb

@@ -15,6 +15,11 @@ module Danger
   #          pmd.report_file = "app/build/reports/pmd/pmd.xml"
   #          pmd.report
   #
+  # @example Running PMD without running a Gradle task
+  #
+  #          pmd.skip_gradle_task = true
+  #          pmd.report
+  #
   # @see mathroule/danger-pmd
   # @tags java, android, pmd
 
@@ -39,6 +44,11 @@ module Danger
     # @return [String]
     attr_writer :report_file
 
+    # Skip Gradle task
+    # If you skip Gradle task, for example project does not manage Gradle.
+    # @return [Bool]
+    attr_writer :skip_gradle_task
+
     GRADLEW_NOT_FOUND = "Could not find `gradlew` inside current directory"
     REPORT_FILE_NOT_FOUND = "PMD report not found"
 
@@ -47,9 +57,12 @@ module Danger
     # It fails if `report_file` cannot be found inside current directory.
     # @return [void]
     def report(inline_mode = true)
-      return fail(GRADLEW_NOT_FOUND) unless gradlew_exists?
+      unless skip_gradle_task
+        return fail(GRADLEW_NOT_FOUND) unless gradlew_exists?
+
+        exec_gradle_task
+      end
 
-      exec_gradle_task
       return fail(REPORT_FILE_NOT_FOUND) unless report_file_exist?
 
       if inline_mode
@@ -69,6 +82,12 @@ module Danger
       @gradle_task ||= "pmd"
     end
 
+    # A getter for `skip_gradle_task`, returning false if value is nil.
+    # @return [Boolean]
+    def skip_gradle_task
+      @skip_gradle_task ||= false
+    end
+
     # A getter for `report_file`, returning "app/build/reports/pmd/pmd.xml" if value is nil.
     # @return [String]
     def report_file

data/spec/pmd_spec.rb

@@ -44,6 +44,16 @@ module Danger
         expect(@my_plugin.gradle_task).to eq(custom_task)
       end
 
+      it "Skip Gradle task" do
+        skip_gradle_task = true
+        @my_plugin.skip_gradle_task = skip_gradle_task
+        expect(@my_plugin.skip_gradle_task).to eq(skip_gradle_task)
+      end
+
+      it "Check default skip Gradle task" do
+        expect(@my_plugin.skip_gradle_task).to eq(false)
+      end
+
       it "Create files" do
         custom_report_path = "spec/fixtures/pmd_report.xml"
         @my_plugin.report_file = custom_report_path

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-pmd
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Mathieu Rul
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-03 00:00:00.000000000 Z
+date: 2019-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api