danger-periphery 0.3.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 12b5d90e78c9ce9ffe21444e0f89723c36287b74f6cec8047185e6c6266f179e
-  data.tar.gz: 533cd4b72da33e99be395e41a9c81e764f99ec6f149b6695df90b59ef25cbe77
+  metadata.gz: 9006201540562aff46abee569a0fb7d437e5d88d57a469db159f587e8183f3e7
+  data.tar.gz: 6c1d7515560909bcfa30ff03ebdbeffc57d11f713ddd33625441fd67560c4e7c
 SHA512:
-  metadata.gz: 545d4b1bf8b95ed580a7267f937548efa47ca8b3835bb646aa55270f4016796be8de5e9309631c51cf42c6804e2f1356758efb2d063a05542edc2a16d38d997a
-  data.tar.gz: a0aca8766ed747d3a0dde0c2fb919dde6bf4c79048a95805063d7df35d535447cd5f7e1a569b66a28ee867918cd1c340c4432b656c72c421ecfa45aec22b4ebe
+  metadata.gz: 0c72323b652e535bc893165125fdd441989130e5426311d14a4842d61534bfad42838c5f5c2c08258c8087d41ab657e416544f912abad76e5ee8a6a7603549ca
+  data.tar.gz: d24d10f5730367a3461c663d70d1ca45516d17d3b979a63063bf006011aaff928a55b6f0e56f88cb7e10093e4325f816cfd3c9b7b5e6fea7e82f3d5674fa6d55

data/lib/danger/danger_periphery.rb

@@ -35,6 +35,16 @@ module Danger
     #                   By default +false+ is set.
     attr_accessor :warning_as_error
 
+    # A flag to enable verbose output.
+    # @return [Boolean] +true+ if this plugin prints all outputs from Periphery.
+    #                   Otherwise returns +false+ and prints only errors.
+    #                   Defaults to +false+.
+    #                   Note that regardless of this value, this plugin always overrides certain options,
+    #                   such as +--disable-update-check+, +--format+ and +--quiet+.
+    # @see OPTION_OVERRIDES
+    # @see format=
+    attr_accessor :verbose
+
     # For internal use only.
     #
     # @return [Symbol]
@@ -46,7 +56,7 @@ module Danger
     }.freeze
 
     def initialize(dangerfile)
-      super(dangerfile)
+      super
       @format = :checkstyle
       @warning_as_error = false
     end
@@ -86,6 +96,13 @@ module Danger
       end
     end
 
+    # The version of underlying Periphery executable.
+    #
+    # @return [string]
+    def version
+      Periphery::Runner.new(binary_path).version
+    end
+
     # Download and install Periphery executable binary.
     #
     # @param [String, Symbol] version The version of Periphery you want to install.

data/lib/danger_periphery/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DangerPeriphery
-  VERSION = '0.3.1'
+  VERSION = '0.5.0'
 end

data/lib/periphery/runner.rb

@@ -2,48 +2,94 @@
 
 require 'open3'
 require 'rubygems/version'
+require 'stringio'
 
 module Periphery
   class Runner # :nodoc:
-    attr_reader :binary_path
+    attr_reader :binary_path, :verbose
 
-    def initialize(binary_path)
+    def initialize(binary_path, on_spawn: nil, verbose: false)
       @binary_path = binary_path || 'periphery'
+      @on_spawn = on_spawn
+      @verbose = verbose
     end
 
     def scan(options)
       arguments = [binary_path, 'scan'] + scan_arguments(options)
-      stdout, stderr, status = Open3.capture3(*arguments)
-      raise "error: #{arguments} exited with status code #{status.exitstatus}. #{stderr}" unless status.success?
+      stdout, stderr, status = capture_output(arguments)
+      validate_subprocess_status!(arguments, status, stderr)
 
-      stdout
+      stdout.string
     end
 
     def scan_arguments(options)
-      options.each_with_object([]) do |(key, value), new_options|
+      args = []
+      options.each do |key, value|
         next unless value
 
+        next if key == :build_args
+
         value = nil if value.is_a?(TrueClass)
+        args << "--#{key.to_s.tr('_', '-')}"
         if value.is_a?(Array)
           if Gem::Version.new(version) >= Gem::Version.new('2.18.0')
-            new_options << "--#{key.to_s.tr('_', '-')}"
-            new_options.push(*value.map(&:to_s))
-            next
+            args.push(*value.map(&:to_s))
           else
-            value = value.join(',')
+            args << value.join(',')
           end
+        elsif value
+          args << value&.to_s
         end
-        new_options << "--#{key.to_s.tr('_', '-')}"
-        new_options << value&.to_s if value
       end
+      args += ['--', options[:build_args]] if options[:build_args]
+      args
     end
 
     def version
       arguments = [binary_path, 'version']
-      stdout, stderr, status = Open3.capture3(*arguments)
-      raise "error: #{arguments} existed with status code #{status.exitstatus}. #{stderr}" unless status.success?
+      stdout, stderr, status = capture_output(arguments)
+      validate_subprocess_status!(arguments, status, stderr)
+
+      stdout.string.strip
+    end
+
+    private
 
-      stdout.strip
+    def capture_output(arguments)
+      out = StringIO.new
+      err = StringIO.new
+      status = Open3.popen3(*arguments, in: :close) do |_, stdout, stderr, wait_thread|
+        @on_spawn&.call(wait_thread.pid)
+        threads = []
+        begin
+          threads << tee(stdout, verbose ? [out, $stdout] : [out])
+          threads << tee(stderr, verbose ? [err, $stderr] : [err])
+          status = wait_thread.value
+          threads.each(&:join)
+          status
+        ensure
+          threads.each(&:kill)
+        end
+      end
+      [out, err, status]
+    end
+
+    def validate_subprocess_status!(arguments, status, stderr)
+      case status.success?
+      when false
+        raise "error: #{arguments} exited with status code #{status.exitstatus}. #{stderr.string}"
+      when nil
+        raise "error: #{arguments} was terminated by SIG#{Signal.signame(status.termsig)}"
+      end
+    end
+
+    def tee(in_io, out_ios)
+      Thread.new do
+        until in_io.eof?
+          data = in_io.readpartial(1024)
+          out_ios.each { |io| io.write(data) }
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-periphery
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Ryosuke Ito
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-26 00:00:00.000000000 Z
+date: 2025-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -38,7 +38,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-description: A Danger plugin to detect unused codes.
+description: |
+  This project is a plugin for Danger, which is a tool for monitoring the quality of the codebase.
+  This plugin detects unused codes in your Swift project using Periphery.
 email:
 - rito.0305@gmail.com
 executables: []
@@ -58,6 +60,10 @@ homepage: https://github.com/manicmaniac/danger-periphery
 licenses:
 - MIT
 metadata:
+  bug_tracker_uri: https://github.com/manicmaniac/danger-periphery/issues
+  changelog_uri: https://raw.githubusercontent.com/manicmaniac/danger-periphery/refs/heads/0.5.0/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/danger-periphery/0.5.0
+  homepage_uri: https://github.com/manicmaniac/danger-periphery
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
@@ -74,7 +80,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: A Danger plugin to detect unused codes.