danger-packwerk 0.7.1 → 0.9.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/README.md +47 -32
- data/lib/danger-packwerk/basic_reference_offense.rb +19 -19
- data/lib/danger-packwerk/check/default_formatter.rb +110 -0
- data/lib/danger-packwerk/check/offenses_formatter.rb +23 -0
- data/lib/danger-packwerk/{danger_deprecated_references_yml_changes.rb → danger_package_todo_yml_changes.rb} +32 -30
- data/lib/danger-packwerk/danger_packwerk.rb +7 -5
- data/lib/danger-packwerk/packwerk_wrapper.rb +10 -0
- data/lib/danger-packwerk/private/ownership_information.rb +60 -0
- data/lib/danger-packwerk/private/{deprecated_references.rb → package_todo.rb} +8 -8
- data/lib/danger-packwerk/private.rb +2 -2
- data/lib/danger-packwerk/update/default_formatter.rb +67 -0
- data/lib/danger-packwerk/update/offenses_formatter.rb +23 -0
- data/lib/danger-packwerk/version.rb +1 -1
- data/lib/danger-packwerk.rb +8 -2
- data/sorbet/rbi/gems/code_ownership@1.29.1.rbi +336 -0
- data/sorbet/rbi/gems/code_teams@1.0.0.rbi +120 -0
- data/sorbet/rbi/gems/{packwerk@2.2.1.rbi → packwerk@2.2.1-7e8e7a50705833b41fe40c201eadb85ff9a1a422.rbi} +852 -231
- metadata +28 -9
- data/lib/danger-packwerk/private/default_offenses_formatter.rb +0 -37
- data/sorbet/rbi/gems/json@2.6.2.rbi +0 -1418
metadata
CHANGED
@@ -1,15 +1,29 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: danger-packwerk
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 0.
|
4
|
+
version: 0.9.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Gusto Engineers
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2022-
|
11
|
+
date: 2022-12-14 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
|
+
- !ruby/object:Gem::Dependency
|
14
|
+
name: code_ownership
|
15
|
+
requirement: !ruby/object:Gem::Requirement
|
16
|
+
requirements:
|
17
|
+
- - ">="
|
18
|
+
- !ruby/object:Gem::Version
|
19
|
+
version: '0'
|
20
|
+
type: :runtime
|
21
|
+
prerelease: false
|
22
|
+
version_requirements: !ruby/object:Gem::Requirement
|
23
|
+
requirements:
|
24
|
+
- - ">="
|
25
|
+
- !ruby/object:Gem::Version
|
26
|
+
version: '0'
|
13
27
|
- !ruby/object:Gem::Dependency
|
14
28
|
name: danger-plugin-api
|
15
29
|
requirement: !ruby/object:Gem::Requirement
|
@@ -30,14 +44,14 @@ dependencies:
|
|
30
44
|
requirements:
|
31
45
|
- - ">="
|
32
46
|
- !ruby/object:Gem::Version
|
33
|
-
version:
|
47
|
+
version: '0'
|
34
48
|
type: :runtime
|
35
49
|
prerelease: false
|
36
50
|
version_requirements: !ruby/object:Gem::Requirement
|
37
51
|
requirements:
|
38
52
|
- - ">="
|
39
53
|
- !ruby/object:Gem::Version
|
40
|
-
version:
|
54
|
+
version: '0'
|
41
55
|
- !ruby/object:Gem::Dependency
|
42
56
|
name: parse_packwerk
|
43
57
|
requirement: !ruby/object:Gem::Requirement
|
@@ -188,12 +202,16 @@ files:
|
|
188
202
|
- README.md
|
189
203
|
- lib/danger-packwerk.rb
|
190
204
|
- lib/danger-packwerk/basic_reference_offense.rb
|
191
|
-
- lib/danger-packwerk/
|
205
|
+
- lib/danger-packwerk/check/default_formatter.rb
|
206
|
+
- lib/danger-packwerk/check/offenses_formatter.rb
|
207
|
+
- lib/danger-packwerk/danger_package_todo_yml_changes.rb
|
192
208
|
- lib/danger-packwerk/danger_packwerk.rb
|
193
209
|
- lib/danger-packwerk/packwerk_wrapper.rb
|
194
210
|
- lib/danger-packwerk/private.rb
|
195
|
-
- lib/danger-packwerk/private/
|
196
|
-
- lib/danger-packwerk/private/
|
211
|
+
- lib/danger-packwerk/private/ownership_information.rb
|
212
|
+
- lib/danger-packwerk/private/package_todo.rb
|
213
|
+
- lib/danger-packwerk/update/default_formatter.rb
|
214
|
+
- lib/danger-packwerk/update/offenses_formatter.rb
|
197
215
|
- lib/danger-packwerk/version.rb
|
198
216
|
- lib/danger-packwerk/violation_diff.rb
|
199
217
|
- lib/danger_plugin.rb
|
@@ -206,6 +224,8 @@ files:
|
|
206
224
|
- sorbet/rbi/gems/builder@3.2.4.rbi
|
207
225
|
- sorbet/rbi/gems/claide-plugins@0.9.2.rbi
|
208
226
|
- sorbet/rbi/gems/claide@1.1.0.rbi
|
227
|
+
- sorbet/rbi/gems/code_ownership@1.29.1.rbi
|
228
|
+
- sorbet/rbi/gems/code_teams@1.0.0.rbi
|
209
229
|
- sorbet/rbi/gems/coderay@1.1.3.rbi
|
210
230
|
- sorbet/rbi/gems/colored2@3.1.2.rbi
|
211
231
|
- sorbet/rbi/gems/concurrent-ruby@1.1.10.rbi
|
@@ -230,7 +250,6 @@ files:
|
|
230
250
|
- sorbet/rbi/gems/faraday@1.10.2.rbi
|
231
251
|
- sorbet/rbi/gems/git@1.12.0.rbi
|
232
252
|
- sorbet/rbi/gems/i18n@1.12.0.rbi
|
233
|
-
- sorbet/rbi/gems/json@2.6.2.rbi
|
234
253
|
- sorbet/rbi/gems/kramdown-parser-gfm@1.1.0.rbi
|
235
254
|
- sorbet/rbi/gems/kramdown@2.4.0.rbi
|
236
255
|
- sorbet/rbi/gems/loofah@2.19.0.rbi
|
@@ -242,7 +261,7 @@ files:
|
|
242
261
|
- sorbet/rbi/gems/nokogiri@1.13.8.rbi
|
243
262
|
- sorbet/rbi/gems/octokit@5.6.1.rbi
|
244
263
|
- sorbet/rbi/gems/open4@1.3.4.rbi
|
245
|
-
- sorbet/rbi/gems/packwerk@2.2.1.rbi
|
264
|
+
- sorbet/rbi/gems/packwerk@2.2.1-7e8e7a50705833b41fe40c201eadb85ff9a1a422.rbi
|
246
265
|
- sorbet/rbi/gems/parallel@1.22.1.rbi
|
247
266
|
- sorbet/rbi/gems/parse_packwerk@0.12.1.rbi
|
248
267
|
- sorbet/rbi/gems/parser@3.1.2.1.rbi
|
@@ -1,37 +0,0 @@
|
|
1
|
-
# typed: strict
|
2
|
-
|
3
|
-
module DangerPackwerk
|
4
|
-
module Private
|
5
|
-
class DefaultAddedOffensesFormatter
|
6
|
-
extend T::Sig
|
7
|
-
|
8
|
-
sig { params(violations: T::Array[BasicReferenceOffense]).returns(String) }
|
9
|
-
def self.format(violations)
|
10
|
-
violation = T.must(violations.first)
|
11
|
-
# We remove leading double colons as they feel like an implementation detail of packwerk.
|
12
|
-
constant_name = violation.class_name.gsub(/\A::/, '')
|
13
|
-
link_to_docs = '[the docs](https://github.com/Shopify/packwerk/blob/b647594f93c8922c038255a7aaca125d391a1fbf/docs/new_violation_flow_chart.pdf)'
|
14
|
-
disclaimer = "We noticed you ran `bin/packwerk update-deprecations`. Make sure to read through #{link_to_docs} for other ways to resolve. "
|
15
|
-
pluralized_violation = violations.count > 1 ? 'these violations' : 'this violation'
|
16
|
-
request_to_add_context = "Could you add some context as a reply here about why we needed to add #{pluralized_violation}?"
|
17
|
-
|
18
|
-
if violations.any?(&:dependency?) && violations.any?(&:privacy?)
|
19
|
-
<<~MESSAGE
|
20
|
-
Hi! It looks like the pack defining `#{constant_name}` considers this private API, and it's also not in the referencing pack's list of dependencies.
|
21
|
-
#{disclaimer}#{request_to_add_context}
|
22
|
-
MESSAGE
|
23
|
-
elsif violations.any?(&:dependency?)
|
24
|
-
<<~MESSAGE
|
25
|
-
Hi! It looks like the pack defining `#{constant_name}` is not in the referencing pack's list of dependencies.
|
26
|
-
#{disclaimer}#{request_to_add_context}
|
27
|
-
MESSAGE
|
28
|
-
else # violations.any?(&:privacy?)
|
29
|
-
<<~MESSAGE
|
30
|
-
Hi! It looks like the pack defining `#{constant_name}` considers this private API.
|
31
|
-
#{disclaimer}#{request_to_add_context}
|
32
|
-
MESSAGE
|
33
|
-
end
|
34
|
-
end
|
35
|
-
end
|
36
|
-
end
|
37
|
-
end
|