danger-packwerk 0.6.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3338a7622d64fc169f9ef273873bc11002ff56ba3d66b225189f0dc1bd6b6cf9
-  data.tar.gz: 58cb63b3956cf29245575e8be453280c33041b3ce15579c2102d07819c836c26
+  metadata.gz: 51e9864c6b966cd4b115e469a1f9fc2c2e316fd634590d43eea1e5030b353f0c
+  data.tar.gz: fbe8f70cb7c3d79017ea379ba7d8ec6fae2961fba98bb254f6b9ff99b1fa30be
 SHA512:
-  metadata.gz: 31aab3fcdb5c3bb7837214ac46fae8807fcfa9727d9a3d21a4d371c8c8de4db688c13ff486e7e9660ec552f7aa39cbd1c622338e8b88ae087f226362804e8097
-  data.tar.gz: fba5ddd5b2d9ed86b3173b1aca8562ba523dcd74c974d45570edc07853ac5c4819bf3c64956ca10a037b800db056853cb38097ce422fa79eb2983ab297ea9890
+  metadata.gz: 8cff9b5c28a2357e3c910cfa3c4ee0fd502267950165422ad95c74a07fd0f01f57c613e092670cc41de4d57921a9d88308b02d6de516b481b92a36bfa9fff19c
+  data.tar.gz: fee7d3f4a94bed71d61ebcd878a63c8ad89bd60c9a44e4e18c4d2040442d2ede40483f28eb3ea66cefa69f3f0d5ecabadf3f3b4dc6b766b8b5d4e6ab2810fc4e

data/lib/danger-packwerk/danger_deprecated_references_yml_changes.rb

@@ -78,16 +78,21 @@ module DangerPackwerk
         removed_violations += deleted_violations
       end
 
+      # The format for git.renamed_files is a T::Array[{after: "some/path/new", before: "some/path/old"}]
+      renamed_files_before = git.renamed_files.map { |before_after_file| before_after_file[:before] }
+      renamed_files_after = git.renamed_files.map { |before_after_file| before_after_file[:after] }
+
       git.modified_files.grep(DEPRECATED_REFERENCES_PATTERN).each do |modified_deprecated_references_yml_file|
+        # We skip over modified files if one of the modified files is a renamed `deprecated_references.yml` file.
+        # This allows us to rename packs while ignoring "new violations" in those renamed packs.
+        next if renamed_files_before.include?(modified_deprecated_references_yml_file)
+
         head_commit_violations = BasicReferenceOffense.from(modified_deprecated_references_yml_file)
         base_commit_violations = get_violations_before_patch_for(modified_deprecated_references_yml_file)
         added_violations += head_commit_violations - base_commit_violations
         removed_violations += base_commit_violations - head_commit_violations
       end
 
-      # The format for git.renamed_files is a T::Array[{after: "some/path/new", before: "some/path/old"}]
-      renamed_files = git.renamed_files.map { |before_after_file| before_after_file[:after] }
-
       #
       # This implementation creates some false negatives:
       # That is – it doesn't capture some cases:
@@ -106,11 +111,11 @@ module DangerPackwerk
 
       added_violations.each do |violation|
         filepath_that_defines_this_constant = Private.constant_resolver.resolve(violation.class_name)&.location
-        renamed_constants << violation.class_name if renamed_files.include?(filepath_that_defines_this_constant)
+        renamed_constants << violation.class_name if renamed_files_after.include?(filepath_that_defines_this_constant)
       end
 
       relevant_added_violations = added_violations.reject do |violation|
-        renamed_files.include?(violation.file) || renamed_constants.include?(violation.class_name)
+        renamed_files_after.include?(violation.file) || renamed_constants.include?(violation.class_name)
       end
 
       ViolationDiff.new(

data/lib/danger-packwerk/packwerk_wrapper.rb

@@ -56,8 +56,8 @@ module DangerPackwerk
         ''
       end
 
-      sig { override.params(offense_collection: Packwerk::OffenseCollection).returns(String) }
-      def show_stale_violations(offense_collection)
+      sig { override.params(offense_collection: Packwerk::OffenseCollection, for_files: T::Set[String]).returns(String) }
+      def show_stale_violations(offense_collection, for_files)
         ''
       end
     end

data/lib/danger-packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module DangerPackwerk
-  VERSION = '0.6.0'
+  VERSION = '0.7.1'
 end

data/sorbet/config

@@ -1,3 +1,4 @@
 --dir
 .
 --enable-experimental-requires-ancestor
+--ignore=/vendor/bundle