danger-packwerk 0.14.2 → 0.14.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11de71d95ae9ff78daff3f87835d184e206d6088ecece8608e03d7e42eaa0424
-  data.tar.gz: 9386a9c42dbc1ef0fface734b0c6e1b9aa031629c46d3961364a37b1afda1b36
+  metadata.gz: f9961bce735a4a3e2ffd6e2f67719059652d08bcadcd06c8ab349b27452137e5
+  data.tar.gz: 3eca02e4593c388f7170036cc78fde2b4efa4b2fe616b3d1591acb68ecffe610
 SHA512:
-  metadata.gz: 0114bf7aa642b184bd8ba990764eff04925bafd7defc7c3c77af8b4edcef5c576c8412471d5ab31e3150df4298582774b5f1943ad3106c04b3b0fa02c619fae6
-  data.tar.gz: 05ec9637958c0f80a2f2ec0cd3d25578081fc015d98b9f1a7a5b296ef3a8c8e2304319ed6af8c3b4ceffb5a4e5e5f421596f92593ed1002690f60cbb465bd5f3
+  metadata.gz: 7167772693389751363dfd0c8e9956b30d7e2a237265d625f54de748453a3585a40b5e165e18bc6672d241344da08f216fd3614c031e9eea12b0e6eecca08c07
+  data.tar.gz: 0a8df0931b48669d9cb3d779824c6391622666c7614ca4fffa1cf03e83d1ba63ac891a7b621f736b1ddeeec0044694fc93c2ea15dbee4d633acd9cec52e1621c

data/lib/danger-packwerk/basic_reference_offense.rb

@@ -88,8 +88,13 @@ module DangerPackwerk
           # the constant and only the constant.
           # Right now `packwerk` `package_todo.yml` files typically use double quotes, but sometimes folks linters change this to single quotes.
           # To be defensive, we match against either.
-          class_name_with_quote_boundaries = /["|']#{violation.class_name}["|']:/
-          line.match?(class_name_with_quote_boundaries)
+
+          patterns = [
+            /["|']#{violation.class_name}["|']:/,
+            /\? ["|']#{violation.class_name}["|']$/ # for keys that use explicit mapping syntax
+          ]
+
+          patterns.any? { |p| line.match?(p) }
         end
 
         if class_name_line_number.nil?

data/lib/danger-packwerk/danger_package_todo_yml_changes.rb

@@ -20,9 +20,9 @@ module DangerPackwerk
     BeforeComment = T.type_alias { T.proc.params(violation_diff: ViolationDiff, changed_package_todo_ymls: T::Array[String]).void }
     DEFAULT_BEFORE_COMMENT = T.let(->(violation_diff, changed_package_todo_ymls) {}, BeforeComment)
     DEFAULT_VIOLATION_TYPES = T.let([
-                                      DEPENDENCY_VIOLATION_TYPE,
-                                      PRIVACY_VIOLATION_TYPE
-                                    ], T::Array[String])
+      DEPENDENCY_VIOLATION_TYPE,
+      PRIVACY_VIOLATION_TYPE
+    ].freeze, T::Array[String])
 
     sig do
       params(
@@ -47,7 +47,7 @@ module DangerPackwerk
       git_filesystem = Private::GitFilesystem.new(git: git, root: root_path || '')
       changed_package_todo_ymls = (git_filesystem.modified_files + git_filesystem.added_files + git_filesystem.deleted_files).grep(PACKAGE_TODO_PATTERN)
 
-      violation_diff = get_violation_diff(violation_types, root_path: root_path)
+      violation_diff = DangerPackageTodoYmlChanges.get_violation_diff(violation_types, git: git, root_path: root_path)
 
       before_comment.call(
         violation_diff,
@@ -74,10 +74,11 @@ module DangerPackwerk
     sig do
       params(
         violation_types: T::Array[String],
+        git: Danger::DangerfileGitPlugin,
         root_path: T.nilable(String)
       ).returns(ViolationDiff)
     end
-    def get_violation_diff(violation_types, root_path: nil)
+    def self.get_violation_diff(violation_types, git:, root_path: nil)
       git_filesystem = Private::GitFilesystem.new(git: git, root: root_path || '')
 
       added_violations, removed_violations = Private::TodoYmlChanges.get_reference_offenses(

data/lib/danger-packwerk/danger_packwerk.rb

@@ -23,9 +23,9 @@ module DangerPackwerk
     DEFAULT_FAIL = false
     DEFAULT_FAILURE_MESSAGE = 'Packwerk violations were detected! Please resolve them to unblock the build.'
     DEFAULT_VIOLATION_TYPES = T.let([
-                                      DEPENDENCY_VIOLATION_TYPE,
-                                      PRIVACY_VIOLATION_TYPE
-                                    ], T::Array[String])
+      DEPENDENCY_VIOLATION_TYPE,
+      PRIVACY_VIOLATION_TYPE
+    ].freeze, T::Array[String])
 
     class CommentGroupingStrategy < ::T::Enum
       enums do

data/lib/danger-packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module DangerPackwerk
-  VERSION = '0.14.2'
+  VERSION = '0.14.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-packwerk
 version: !ruby/object:Gem::Version
-  version: 0.14.2
+  version: 0.14.4
 platform: ruby
 authors:
 - Gusto Engineers
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-01 00:00:00.000000000 Z
+date: 2024-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: packs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: packwerk
   requirement: !ruby/object:Gem::Requirement
@@ -140,30 +154,30 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.26.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.26.0
 - !ruby/object:Gem::Dependency
   name: rubocop-sorbet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: sorbet
   requirement: !ruby/object:Gem::Requirement
@@ -224,7 +238,7 @@ metadata:
   source_code_uri: https://github.com/rubyatscale/danger-packwerk
   changelog_uri: https://github.com/rubyatscale/danger-packwerk/releases
   allowed_push_host: https://rubygems.org
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -239,8 +253,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.5.9
+signing_key:
 specification_version: 4
 summary: Danger plugin for packwerk.
 test_files: []