danger-packwerk 0.11.2 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b21585a689a72d9bed5c5c4f0abaacb415bb47f5bdafd9e90ceef64c02c8b9d9
-  data.tar.gz: 65d9f6a5663f32cedf9410b8704276b52813e1178fbdf35d99489df94f5128b9
+  metadata.gz: 88dd6cf3e1597ce88a505eaa638404b5ec37733adbfd08c121d2ea1718ff4c80
+  data.tar.gz: 37c3d43dfba549cab2d536fd38a0ad080968d5277f21ac6a9c7fadb2100dbdec
 SHA512:
-  metadata.gz: 82fbed5f62d302eb36517a847ae8d449ff002cb294d832f5ab7dd2f1394a1b170d2c67ac8fbfd7bdf01b6a36585bad2267e9c533a17b54419d8b5abeec028193
-  data.tar.gz: 96067d721e7ae8d8273a135839c8d5b9e795592f525bb8cd050e0253ed9036304ace783c9dcf5dc196eac835cb535063fd9facf90f72a7046403272847926d26
+  metadata.gz: ee1bb1ca1f19f6a47d3766bd823bf83a7c8d8c5441e703aec6e8404d036cf02be80d00f6ab9feceb03d791d603497216bb9a7834b2454a947b07c6ef89276869
+  data.tar.gz: 2c0802e7bb7ce6100fcc63d27ded9071fea2e3661cc0cd622188581f4056f44110a61bf1e0936a43ca5baeca33d02d2abe65c4eb35debe9291739d00cd0f8e38

data/lib/danger-packwerk/check/default_formatter.rb

@@ -38,7 +38,7 @@ module DangerPackwerk
         constant_source_package = T.must(ParsePackwerk.all.find { |p| p.name == constant_source_package_name })
         constant_source_package_ownership_info = Private::OwnershipInformation.for_package(constant_source_package, org_name)
 
-        disclaimer = 'Before you run `bin/packwerk update-deprecations`, check out these quick suggestions:'
+        disclaimer = 'Before you run `bin/packwerk update-todo`, check out these quick suggestions:'
         referencing_code_in_right_pack = "- Does the code you are writing live in the right pack?\n  - If not, try `bin/packs move packs/destination_pack #{referencing_file}`"
         referenced_code_in_right_pack = "- Does #{constant_name} live in the right pack?\n  - If not, try `bin/packs move packs/destination_pack #{constant_location}`"
         dependency_violation_message = "- Do we actually want to depend on #{constant_source_package_name}?\n  - If so, try `bin/packs add_dependency #{referencing_file_pack} #{constant_source_package_name}`\n  - If not, what can we change about the design so we do not have to depend on #{constant_source_package_name}?"

data/lib/danger-packwerk/private.rb

@@ -14,7 +14,7 @@ module DangerPackwerk
     def self.constant_resolver
       @constant_resolver = T.let(@constant_resolver, T.nilable(ConstantResolver))
       @constant_resolver ||= begin
-        load_paths = Packwerk::ApplicationLoadPaths.extract_relevant_paths(Dir.pwd, 'test')
+        load_paths = Packwerk::RailsLoadPaths.for(Dir.pwd, environment: 'test')
         ConstantResolver.new(
           root_path: Dir.pwd,
           load_paths: T.unsafe(load_paths).keys

data/lib/danger-packwerk/update/default_formatter.rb

@@ -28,7 +28,7 @@ module DangerPackwerk
 
         package_referring_to_constant_owner = Private::OwnershipInformation.for_package(referencing_file_pack, org_name)
 
-        disclaimer = 'We noticed you ran `bin/packwerk update-deprecations`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.'
+        disclaimer = 'We noticed you ran `bin/packwerk update-todo`. Check out [the docs](https://github.com/Shopify/packwerk/blob/main/RESOLVING_VIOLATIONS.md) to see other ways to resolve violations.'
         pluralized_violation = offenses.count > 1 ? 'these violations' : 'this violation'
         request_to_add_context = "- Could you add some context as a reply here about why we needed to add #{pluralized_violation}?\n"
 

data/lib/danger-packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module DangerPackwerk
-  VERSION = '0.11.2'
+  VERSION = '0.13.0'
 end

data/sorbet/rbi/gems/{packwerk@2.2.1-7428f23e243a4a172ddb4e28021a732e2c9abc1a.rbi → packwerk@2.2.1-e998ef65194de398f0baaf03a0ba33390b30351e.rbi}

@@ -9,50 +9,6 @@ module Packwerk
   extend ::ActiveSupport::Autoload
 end
 
-# Extracts the load paths from the analyzed application so that we can map constant names to paths.
-#
-# source://packwerk//lib/packwerk/application_load_paths.rb#8
-module Packwerk::ApplicationLoadPaths
-  class << self
-    # source://packwerk//lib/packwerk/application_load_paths.rb#22
-    sig { returns(T::Hash[::String, ::Module]) }
-    def extract_application_autoload_paths; end
-
-    # source://packwerk//lib/packwerk/application_load_paths.rb#13
-    sig { params(root: ::String, environment: ::String).returns(T::Hash[::String, ::Module]) }
-    def extract_relevant_paths(root, environment); end
-
-    # source://packwerk//lib/packwerk/application_load_paths.rb#32
-    sig do
-      params(
-        all_paths: T::Hash[::String, ::Module],
-        bundle_path: ::Pathname,
-        rails_root: ::Pathname
-      ).returns(T::Hash[::Pathname, ::Module])
-    end
-    def filter_relevant_paths(all_paths, bundle_path: T.unsafe(nil), rails_root: T.unsafe(nil)); end
-
-    # source://packwerk//lib/packwerk/application_load_paths.rb#43
-    sig do
-      params(
-        load_paths: T::Hash[::Pathname, ::Module],
-        rails_root: ::Pathname
-      ).returns(T::Hash[::String, ::Module])
-    end
-    def relative_path_strings(load_paths, rails_root: T.unsafe(nil)); end
-
-    private
-
-    # source://packwerk//lib/packwerk/application_load_paths.rb#63
-    sig { params(paths: T::Hash[T.untyped, ::Module]).void }
-    def assert_load_paths_present(paths); end
-
-    # source://packwerk//lib/packwerk/application_load_paths.rb#50
-    sig { params(root: ::String, environment: ::String).void }
-    def require_application(root, environment); end
-  end
-end
-
 # Checks the structure of the application and its packwerk configuration to make sure we can run a check and deliver
 # correct results.
 #
@@ -1697,6 +1653,50 @@ end
 # source://packwerk//lib/packwerk/package_set.rb#8
 Packwerk::PathSpec = T.type_alias { T.any(::String, T::Array[::String]) }
 
+# Extracts the load paths from the analyzed application so that we can map constant names to paths.
+#
+# source://packwerk//lib/packwerk/rails_load_paths.rb#10
+module Packwerk::RailsLoadPaths
+  class << self
+    # source://packwerk//lib/packwerk/rails_load_paths.rb#15
+    sig { params(root: ::String, environment: ::String).returns(T::Hash[::String, ::Module]) }
+    def for(root, environment:); end
+
+    private
+
+    # source://packwerk//lib/packwerk/rails_load_paths.rb#65
+    sig { params(paths: T::Hash[T.untyped, ::Module]).void }
+    def assert_load_paths_present(paths); end
+
+    # source://packwerk//lib/packwerk/rails_load_paths.rb#26
+    sig { returns(T::Hash[::String, ::Module]) }
+    def extract_application_autoload_paths; end
+
+    # source://packwerk//lib/packwerk/rails_load_paths.rb#36
+    sig do
+      params(
+        all_paths: T::Hash[::String, ::Module],
+        bundle_path: ::Pathname,
+        rails_root: ::Pathname
+      ).returns(T::Hash[::Pathname, ::Module])
+    end
+    def filter_relevant_paths(all_paths, bundle_path: T.unsafe(nil), rails_root: T.unsafe(nil)); end
+
+    # source://packwerk//lib/packwerk/rails_load_paths.rb#47
+    sig do
+      params(
+        load_paths: T::Hash[::Pathname, ::Module],
+        rails_root: ::Pathname
+      ).returns(T::Hash[::String, ::Module])
+    end
+    def relative_path_strings(load_paths, rails_root: T.unsafe(nil)); end
+
+    # source://packwerk//lib/packwerk/rails_load_paths.rb#52
+    sig { params(root: ::String, environment: ::String).void }
+    def require_application(root, environment); end
+  end
+end
+
 # A reference from a file in one package to a constant that may be defined in a different package.
 #
 # source://packwerk//lib/packwerk/reference.rb#6

data/sorbet/tapioca/require.rb

@@ -1,2 +1,4 @@
 require 'packwerk'
 require 'danger'
+# This triggers the autoload in packwerk so types for this constant are defined
+Packwerk::RailsLoadPaths

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-packwerk
 version: !ruby/object:Gem::Version
-  version: 0.11.2
+  version: 0.13.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-16 00:00:00.000000000 Z
+date: 2022-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_ownership
@@ -260,7 +260,7 @@ files:
 - sorbet/rbi/gems/nokogiri@1.13.8.rbi
 - sorbet/rbi/gems/octokit@5.6.1.rbi
 - sorbet/rbi/gems/open4@1.3.4.rbi
-- sorbet/rbi/gems/packwerk@2.2.1-7428f23e243a4a172ddb4e28021a732e2c9abc1a.rbi
+- sorbet/rbi/gems/packwerk@2.2.1-e998ef65194de398f0baaf03a0ba33390b30351e.rbi
 - sorbet/rbi/gems/parallel@1.22.1.rbi
 - sorbet/rbi/gems/parse_packwerk@0.16.0.rbi
 - sorbet/rbi/gems/parser@3.1.2.1.rbi