danger-packwerk 0.1.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8789235e049c26367bdf6a909d22646d76b44adb350fb35e777d2be40ec0e14a
-  data.tar.gz: 1bd02af0c72f377ad0a7982681fe9bfdb8bc6e4550fdb6b756ee8e9840cba27b
+  metadata.gz: 4e6b4d9d18458e1ac591a9679d82f6ec6840e8f7b971792134610270a1697777
+  data.tar.gz: c8a1833019c24d48d8c5c5d55d36d1730a88f33effa0b10bdc63d7c7d470d70e
 SHA512:
-  metadata.gz: 3839e46d7a89a4dbb7dcee0957be8d891a9e151d29485f06e8a53ab21a92af7a7a1a2d4c09da48030e6c95040956c6e4f92d380a663a57c02b48085fa189ff62
-  data.tar.gz: ddcb0fec757eafe11d18b5c0146202fb3ea6a655087bf3c11534a3f556f85ccf76a945eca3a86683ba37197f9ca22a8fc1ad92049bdd0b7cfd4a80ff73125bdb
+  metadata.gz: e4268804f4def280f10829d6c7832401f26cd1952ca72f92bf3cff9322f188ad03907711c9c3ee6798c852fd8e73f7b6bc1af0ce57a9adc94cf211f7565372b6
+  data.tar.gz: a70daaaa5deca67092e24f5e4923909371f143cdb82081e7c068f4668cfb205290b870448aa9634fb3c74612c11fad28bcd387b1d61c215e8401e3a06abcc207

data/lib/danger-packwerk/basic_reference_offense.rb

@@ -78,7 +78,16 @@ module DangerPackwerk
         # we need to group them. That is -- if `MyPrivateConstant` is both a dependency and a privacy violation AND it occurs in 10 files, that would represent 20 violations.
         # Therefore we will group all of those 20 into one message to the user rather than providing 20 messages.
         #
-        _line, class_name_line_number = deprecated_references_yml_pathname.readlines.each_with_index.find { |line, _index| line.include?(violation.class_name) }
+        _line, class_name_line_number = deprecated_references_yml_pathname.readlines.each_with_index.find do |line, _index|
+          # If you have a class `::MyClass`, then you can get a false match if another constant in the file
+          # is named `MyOtherClass::MyClassThing`. Therefore we include quotes in our match to ensure that we match
+          # the constant and only the constant.
+          # Right now `packwerk` `deprecated_references.yml` files typically use double quotes, but sometimes folks linters change this to single quotes.
+          # To be defensive, we match against either.
+          class_name_with_quote_boundaries = /["|']#{violation.class_name}["|']:/
+          line.match?(class_name_with_quote_boundaries)
+        end
+
         if class_name_line_number.nil?
           debug_info = { class_name: violation.class_name, to_package_name: violation.to_package_name, type: violation.type }
           raise "Unable to find reference to violation #{debug_info} in #{deprecated_references_yml}"

data/lib/danger-packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module DangerPackwerk
-  VERSION = '0.1.1'
+  VERSION = '0.2.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-packwerk
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-20 00:00:00.000000000 Z
+date: 2022-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api