danger-missing_codeowners 1.2.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fcd83e0d8b50b255205c5ecfbceed72c29db635c92fc27d2f2b9420b6ba5a8a6
-  data.tar.gz: 43a2e6402320a69e456f6c19524c8388b2be03195bf25656157fea8840069f66
+  metadata.gz: 4ee614f9e8f6c289b7703b986ab724fa66bb09823f63f0d2958db26bbf314692
+  data.tar.gz: c519cae4557cad087b86f80f42ab4ffb5eb45fef4716e9c52ac4c113bee083a7
 SHA512:
-  metadata.gz: fac672eff7a5197a07065fcfd8ab2c5b7546d4ed33071e2a6d4e00fa6366f8579d9e4fd9af726ba03ac8776c571af6bc02c8d624c24a3ed5792102567821cc97
-  data.tar.gz: b82d354dcc331dc13abb1958374edb8dc72c55a71eb056bd8f1a4f846682101167a17fdb1af9c6576aea3a3d412e357b23c218beb5fad7797e3367865a7c99c2
+  metadata.gz: 25313015ad2565b99b1a91b8d3d62b42f193f0a3e62ceac78188f25569c6df22713c9fe50803bfc0f2c75b5cfc9cbe96a5df9261af1d3132d0a6079380b0d430
+  data.tar.gz: 6adaa343ee28ab37dc60a8855f31572d123ec54392d36e308ea7c46fcbd4a59200c1f7ad18dc0b2b69c83f41bc10138fe052d4894d1b7f9ed7b702c22f3f50c2

data/Gemfile.lock

@@ -1,16 +1,17 @@
 PATH
   remote: .
   specs:
-    danger-missing_codeowners (1.2.0)
+    danger-missing_codeowners (1.2.2)
       danger-plugin-api (~> 1.0)
       pathspec (~> 1.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.4)
+    addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
+    base64 (0.2.0)
     claide (1.1.0)
     claide-plugins (0.9.2)
       cork
@@ -20,31 +21,31 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (9.3.0)
+    danger (9.4.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (>= 0.9.0, < 3.0)
       faraday-http-cache (~> 2.0)
-      git (~> 1.13.0)
+      git (~> 1.13)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
-      octokit (~> 5.0)
+      octokit (>= 4.0)
       terminal-table (>= 1, < 4)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.4.4)
-    faraday (2.7.5)
-      faraday-net_http (>= 2.0, < 3.1)
-      ruby2_keywords (>= 0.0.4)
-    faraday-http-cache (2.5.0)
+    faraday (2.9.0)
+      faraday-net_http (>= 2.0, < 3.2)
+    faraday-http-cache (2.5.1)
       faraday (>= 0.8)
-    faraday-net_http (3.0.2)
+    faraday-net_http (3.1.0)
+      net-http
     ffi (1.15.3)
     formatador (0.3.0)
-    git (1.13.2)
+    git (1.19.1)
       addressable (~> 2.8)
       rchardet (~> 1.8)
     guard (2.18.0)
@@ -72,11 +73,14 @@ GEM
     method_source (1.0.0)
     nap (1.1.0)
     nenv (0.3.0)
+    net-http (0.4.1)
+      uri
     no_proxy_fix (0.1.2)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (5.6.1)
+    octokit (8.1.0)
+      base64
       faraday (>= 1, < 3)
       sawyer (~> 0.9)
     open4 (1.3.4)
@@ -87,7 +91,7 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (5.0.1)
+    public_suffix (5.0.4)
     rainbow (3.0.0)
     rake (10.5.0)
     rb-fsevent (0.11.0)
@@ -121,7 +125,6 @@ GEM
     rubocop-ast (1.8.0)
       parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.5)
     sawyer (0.9.2)
       addressable (>= 2.3.5)
       faraday (>= 0.17.3, < 3)
@@ -130,6 +133,7 @@ GEM
       unicode-display_width (>= 1.1.1, < 3)
     thor (1.1.0)
     unicode-display_width (2.0.0)
+    uri (0.13.0)
     yard (0.9.26)
 
 PLATFORMS

data/lib/missing_codeowners/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MissingCodeowners
-  VERSION = "1.2.0"
+  VERSION = "1.2.2"
 end

data/lib/missing_codeowners/plugin.rb

@@ -116,7 +116,9 @@ module Danger
     end
 
     def find_codeowners_file
-      directories = ["", ".gitlab", ".github", "docs"]
+      return "CODEOWNERS" if File.exist?("CODEOWNERS")
+
+      directories = [".gitlab", ".github", "docs"]
       paths = directories.map { |dir| File.join(dir, "CODEOWNERS") }
       Dir.glob(paths).first || paths.first
     end
@@ -132,7 +134,7 @@ module Danger
         components = line.split(/\s+(@\S+|\S+@\S+)/).reject { |c| c.strip.empty? }
         if line.match(/^\s*((?:#.*)|(?:\[.*)|(?:\^.*))?$/)
           next # Comment, group or empty line
-        elsif components.length < 2
+        elsif components.empty?
           raise "[ERROR] Invalid CODEOWNERS line: '#{line}'"
         else
           pattern = components[0]

data/spec/fixtures/CODEOWNERS

@@ -42,6 +42,9 @@ path\ with\ spaces/ @space-owner
 foo/bar/  @owners
 feature/  @owners
 
+# Empty owners
+empty/owners/
+
 # Code Owners section:
 
 [Database]

data/spec/missing_codeowners_spec.rb

@@ -50,7 +50,8 @@ module Danger
                           "very/nested/lib/source.js",
                           "very/nested/sources/php/source.php",
                           "model/db/",
-                          "sources/something.go"
+                          "sources/something.go",
+                          "empty/owners/foo.py"
                         ])
 
           @my_plugin.verify
@@ -185,19 +186,6 @@ module Danger
           expect(@my_plugin.files_missing_codeowners.length).to eq(1)
         end
       end
-
-      context "and invalid CODEOWNERS file" do
-        before do
-          allow(@my_plugin).to receive(:find_codeowners_file)
-            .and_return("#{File.dirname(__FILE__)}/fixtures/INVALID_CODEOWNERS")
-        end
-
-        it "raises exception with invalid line" do
-          allow(@my_plugin).to receive(:git_modified_files).and_return(["any_file.yml", "any_file.go"])
-
-          expect { @my_plugin.verify }.to raise_error(RuntimeError)
-        end
-      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-missing_codeowners
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.2
 platform: ruby
 authors:
 - andre-alves
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-02 00:00:00.000000000 Z
+date: 2024-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -187,7 +187,6 @@ files:
 - lib/missing_codeowners/gem_version.rb
 - lib/missing_codeowners/plugin.rb
 - spec/fixtures/CODEOWNERS
-- spec/fixtures/INVALID_CODEOWNERS
 - spec/missing_codeowners_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/andre-alves/danger-missing_codeowners
@@ -215,6 +214,5 @@ specification_version: 4
 summary: A Danger plugin for checking if files have owners.
 test_files:
 - spec/fixtures/CODEOWNERS
-- spec/fixtures/INVALID_CODEOWNERS
 - spec/missing_codeowners_spec.rb
 - spec/spec_helper.rb

data/spec/fixtures/INVALID_CODEOWNERS

@@ -1,5 +0,0 @@
-# Example of Invalid CODEOWNERS
-
-*.yml @default-codeowner
-*.go @golang
-invalid.txt group