danger-missing_codeowners 1.1.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e93a3e15840e49e1966b6bfae9e59a8bfff84539b3cc1314e6224fab84464d9
-  data.tar.gz: 9288cb2e4e84f5c5dd09e4d0363f28276e3241d56c509f03075088401124fb4c
+  metadata.gz: 970c2a9802600b8d3b23d23f23810f11d2c5b3490e32c21b1de0dc662f7a094a
+  data.tar.gz: a1ad21324215c762e3a69515f2b9b66281ef3a8955f238a9f9ff0867d3534f0a
 SHA512:
-  metadata.gz: 173a41e2f5fe25c8a953e2bd1dfc78900ee4012604f70692785f8475ffae110e8a7ddb21fc20c0f70dd50093c1102804d46566ad89e401f3fd6198d70c0f50df
-  data.tar.gz: 4e5a963fb0242853a0a0ad88637f05c2e3ae0c8ff69d8b124e403b79cbccecec866b9f23ea37512b0cdd5594e5a1f0ef6e14b79a9dd6c00e2cbc67f6de2ab06f
+  metadata.gz: e9e820fc8a00114fe751122bcbd230fbeab691541b7e83ab5e2541cf558345461ebcf7b88b0b732fc8eed47ce401a66189acbb6620d441123e334bc81261e864
+  data.tar.gz: 3ac47d981dbc81ab5f733de36da6ff872720bd56a1911e02f0b6219554bf6abaee1e33c075d7012b9e26c648779ffbd2cfc6e5ab0f35881acacec536c27347b1

data/Gemfile.lock

@@ -1,16 +1,17 @@
 PATH
   remote: .
   specs:
-    danger-missing_codeowners (1.1.0)
+    danger-missing_codeowners (1.2.1)
       danger-plugin-api (~> 1.0)
       pathspec (~> 1.0.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.4)
+    addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
     ast (2.4.2)
+    base64 (0.2.0)
     claide (1.1.0)
     claide-plugins (0.9.2)
       cork
@@ -20,31 +21,31 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (9.3.0)
+    danger (9.4.3)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (>= 0.9.0, < 3.0)
       faraday-http-cache (~> 2.0)
-      git (~> 1.13.0)
+      git (~> 1.13)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.0)
       no_proxy_fix
-      octokit (~> 5.0)
+      octokit (>= 4.0)
       terminal-table (>= 1, < 4)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.4.4)
-    faraday (2.7.5)
-      faraday-net_http (>= 2.0, < 3.1)
-      ruby2_keywords (>= 0.0.4)
-    faraday-http-cache (2.5.0)
+    faraday (2.9.0)
+      faraday-net_http (>= 2.0, < 3.2)
+    faraday-http-cache (2.5.1)
       faraday (>= 0.8)
-    faraday-net_http (3.0.2)
+    faraday-net_http (3.1.0)
+      net-http
     ffi (1.15.3)
     formatador (0.3.0)
-    git (1.13.2)
+    git (1.19.1)
       addressable (~> 2.8)
       rchardet (~> 1.8)
     guard (2.18.0)
@@ -72,11 +73,14 @@ GEM
     method_source (1.0.0)
     nap (1.1.0)
     nenv (0.3.0)
+    net-http (0.4.1)
+      uri
     no_proxy_fix (0.1.2)
     notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (5.6.1)
+    octokit (8.1.0)
+      base64
       faraday (>= 1, < 3)
       sawyer (~> 0.9)
     open4 (1.3.4)
@@ -87,7 +91,7 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (5.0.1)
+    public_suffix (5.0.4)
     rainbow (3.0.0)
     rake (10.5.0)
     rb-fsevent (0.11.0)
@@ -121,7 +125,6 @@ GEM
     rubocop-ast (1.8.0)
       parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.5)
     sawyer (0.9.2)
       addressable (>= 2.3.5)
       faraday (>= 0.17.3, < 3)
@@ -130,10 +133,12 @@ GEM
       unicode-display_width (>= 1.1.1, < 3)
     thor (1.1.0)
     unicode-display_width (2.0.0)
+    uri (0.13.0)
     yard (0.9.26)
 
 PLATFORMS
   arm64-darwin-21
+  ruby
   x86_64-darwin-20
 
 DEPENDENCIES

data/lib/missing_codeowners/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module MissingCodeowners
-  VERSION = "1.1.0"
+  VERSION = "1.2.1"
 end

data/lib/missing_codeowners/plugin.rb

@@ -59,7 +59,7 @@ module Danger
     #
     # @return  [void]
     #
-    def verify(*opts)
+    def verify(*opts, &block)
       @verify_all_files ||= false
       @max_number_of_files_to_report ||= 100
       @severity ||= "error"
@@ -86,8 +86,12 @@ module Danger
         markdown format_missing_owners_message(@files_missing_codeowners, @max_number_of_files_to_report)
         danger_message = "Add CODEOWNERS rules to match all files."
         @severity == "error" ? (fail danger_message) : (warn danger_message)
+
+        yield @files_missing_codeowners if block
       else
         log "No files missing CODEOWNERS."
+
+        yield [] if block
       end
 
       log "-----"
@@ -112,7 +116,9 @@ module Danger
     end
 
     def find_codeowners_file
-      directories = ["", ".gitlab", ".github", "docs"]
+      return "CODEOWNERS" if File.exist?("CODEOWNERS")
+
+      directories = [".gitlab", ".github", "docs"]
       paths = directories.map { |dir| File.join(dir, "CODEOWNERS") }
       Dir.glob(paths).first || paths.first
     end

data/spec/missing_codeowners_spec.rb

@@ -75,6 +75,26 @@ module Danger
           expect(@my_plugin.files_missing_codeowners.length).to eq(0)
         end
 
+        it "calls the block with an empty array if there are no missing files" do
+          allow(@my_plugin).to receive(:git_modified_files).and_return(["any_file.yml", "any_file.go"])
+
+          @my_plugin.verify do |x|
+            expect(x).to eq []
+          end
+
+          expect(@my_plugin.files_missing_codeowners.length).to eq(0)
+        end
+
+        it "calls the block with the list of missing files if there are missing files" do
+          allow(@my_plugin).to receive(:git_modified_files).and_return(["myfile"])
+
+          @my_plugin.verify do |x|
+            expect(x).to eq ["myfile"]
+          end
+
+          expect(@my_plugin.files_missing_codeowners.length).to eq(1)
+        end
+
         it "fails when there are files without CODEOWNERS rules and severity is error" do
           @my_plugin.verify_all_files = true
           allow(@my_plugin).to receive(:git_all_files).and_return(["app/source.swift", ".swiftlint.yml"])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-missing_codeowners
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.1
 platform: ruby
 authors:
 - andre-alves
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-25 00:00:00.000000000 Z
+date: 2024-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api