danger-logging_lint 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1187c52de797c72b839cbae7bc8cc512edf1a9683befc9fd62a44cfc6bcfb808
-  data.tar.gz: 7b53090e39be08e9961954d453c488bad46a508c08d80e153c6956e9db4b28a4
+  metadata.gz: 9502be7bec98f9ac55351ec4b27e2ecac0140be3974d2be654400338633d3223
+  data.tar.gz: ecdde9f1dcc8c1807733f41aedbbb92e7465ddbc7dfb62b7375f11e52ea3e9a8
 SHA512:
-  metadata.gz: eeb379e0926b80439cbfe92d2c0353720cebc72953c33b0db0000fbdaf1c6fea0276da970d15de34b8fc5fb61cf175acc60b8f87acd03fd6ba8b69a313b23026
-  data.tar.gz: 76e580706ded58ae576c6012ae7e68d6a30cb691dae76b4b3503c63d57959f037255028c81243d95d2c37f5b16769ccba17598095a99eaef172376977f644ff7
+  metadata.gz: 476adf208a82fb33e9b65d48749d7c9b0f267b5dbc46c231cb42027bae840285d264b3056a19740c07fd4e9c06c47ab6c2bd73bb9af2f88bb873fe2ebd27c907
+  data.tar.gz: 4583a38b9c4d22b94cdec222e545714519db132d52a8e526f270b9dc2fe7765bd947623c6a48cf926f8d60cb0d257039b2422cc90cf8efd46fd61532fd44b13f

data/.github/workflows/deploy.yml

@@ -0,0 +1,36 @@
+name: Deploy
+
+on:
+  workflow_dispatch:
+    branches: [ master ]
+
+jobs:
+  test:
+    name: Publish gem
+    runs-on: ubuntu-latest
+    environment: production
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.0'
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rake spec
+      - name: Publish gem
+        uses: dawidd6/action-publish-gem@v1
+        with:
+          api_key: ${{secrets.RUBYGEMS_API_KEY}}
+      - name: Create git tag
+        uses: duderman/gh-gem-tag-action@v1
+        id: release_info
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: xresloader/upload-to-github-release@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          tag_name: ${{ steps.release_info.outputs.tag }}
+          draft: false
+          file: '*.gem'

data/.github/workflows/test.yml

@@ -0,0 +1,24 @@
+name: Test
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    name: Test with Ruby ${{ matrix.ruby }}
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.7', '3.0' ]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run tests
+        run: bundle exec rake spec

data/.gitignore

@@ -2,3 +2,7 @@
 pkg
 .idea/
 .yardoc
+
+coverage/
+.coverage
+coverage.xml

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## Changelog
 
+### Version 0.0.3 (2022-04-22)
+
+- Added deploy and test yaml for github workflow.
+- Added deployment to Readme.
+- Added codecov connection and dependency.
+- Added Readme badges.
+- Remove "Check: " hardcoded ext from warning message.
+- Fixed tests.
+- Updated Gemfile.lock.
+
 ### Version 0.0.2 (2022-04-21)
 
 - Updated `gemspec` (gem) documentation.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-logging_lint (0.0.1)
+    danger-logging_lint (0.0.3)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -15,11 +15,13 @@ GEM
       cork
       nap
       open4 (~> 1.3)
+    codecov (0.5.2)
+      simplecov (>= 0.15, < 0.22)
     coderay (1.1.3)
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (8.5.0)
+    danger (8.6.0)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -35,6 +37,7 @@ GEM
     danger-plugin-api (1.0.0)
       danger (> 2.0)
     diff-lcs (1.5.0)
+    docile (1.4.0)
     faraday (1.10.0)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
@@ -62,7 +65,7 @@ GEM
     faraday-retry (1.0.3)
     ffi (1.15.5)
     formatador (1.1.0)
-    git (1.10.2)
+    git (1.11.0)
       rchardet (~> 1.8)
     guard (2.18.0)
       formatador (>= 0.2.4)
@@ -99,14 +102,14 @@ GEM
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.22.1)
-    parser (3.1.1.0)
+    parser (3.1.2.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    public_suffix (4.0.6)
+    public_suffix (4.0.7)
     rainbow (3.1.1)
-    rake (10.5.0)
+    rake (13.0.6)
     rb-fsevent (0.11.1)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
@@ -126,13 +129,13 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
-    rubocop (1.27.0)
+    rubocop (1.28.1)
       parallel (~> 1.10)
       parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.16.0, < 2.0)
+      rubocop-ast (>= 1.17.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.17.0)
@@ -143,6 +146,12 @@ GEM
       addressable (>= 2.3.5)
       faraday (> 0.8, < 2.0)
     shellany (0.0.1)
+    simplecov (0.21.2)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     thor (1.2.1)
@@ -156,12 +165,13 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 2.0)
+  codecov (~> 0.5.1)
   danger-logging_lint!
   guard (~> 2.14)
   guard-rspec (~> 4.7)
   listen (= 3.0.7)
   pry
-  rake (~> 10.0)
+  rake (>= 12.3.3)
   rspec (~> 3.4)
   rubocop
   yard

data/README.md

@@ -1,4 +1,6 @@
-## logging_lint
+## Logging Lint
+[![Gem Version](https://badge.fury.io/rb/danger-logging_lint.svg)](https://badge.fury.io/rb/danger-logging_lint) [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://github.com/eManPrague/danger-logging_lint/blob/master/LICENSE.txt) [![Test](https://github.com/eManPrague/danger-logging_lint/actions/workflows/test.yml/badge.svg)](https://github.com/eManPrague/danger-logging_lint/actions/workflows/test.yml) [![codecov](https://codecov.io/gh/eManPrague/danger-logging_lint/branch/master/graph/badge.svg?token=Z2RZKYNBVI)](https://codecov.io/gh/eManPrague/danger-logging_lint)
+
 
 This danger plugin can be used to check log lines in modified (added) files. It heavily relies on regex configuration which can be modified to search all kinds of parts of code in the files. Default configuration is set to support [Kotlin eMan Logger Library](https://github.com/eManPrague/logger-ktx). Ex: logInfo { "Info message $var" }.
 
@@ -72,3 +74,7 @@ If all of these checks pass then it will trigger linter on target files (filtere
 3. Run `bundle exec rake spec` to run the tests.
 4. Use `bundle exec guard` to automatically have tests run as you make changes.
 5. Make your changes.
+
+## Deployment
+
+Gem is deployed manually from master branch using [Github Action](https://github.com/eManPrague/danger-logging_lint/actions/workflows/deploy.yml). Make sure you increased the gem version before triggering it.

data/codecov.yml

@@ -0,0 +1,20 @@
+codecov:
+  require_ci_to_pass: yes
+
+coverage:
+  precision: 2
+  round: down
+  range: '70...100'
+
+parsers:
+  gcov:
+    branch_detection:
+      conditional: yes
+      loop: yes
+      method: no
+      macro: no
+
+comment:
+  layout: 'reach,diff,flags,files,footer'
+  behavior: default
+  require_changes: no

data/danger-logging_lint.gemspec

@@ -23,9 +23,10 @@ Gem::Specification.new do |spec|
 
   # General ruby development
   spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", ">= 12.3.3"
 
   # Testing support
+  spec.add_development_dependency 'codecov', '~> 0.5.1'
   spec.add_development_dependency "rspec", "~> 3.4"
 
   # Linting code and docs

data/lib/logging_lint/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LoggingLint
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/logging_lint/plugin.rb

@@ -291,7 +291,7 @@ module Danger
     def compose_warning_text(warning_text)
       return warning_text if warning_description.nil?
 
-      "#{warning_text} Check: #{warning_description}"
+      "#{warning_text} #{warning_description}"
     end
   end
 end

data/spec/logging_lint_spec.rb

@@ -105,7 +105,7 @@ module Danger
         allow(@logging_lint.git).to receive(:added_files).and_return(added_files)
         allow(@logging_lint).to receive(:warning_description).and_return(warning_link)
         @logging_lint.log_lint
-        expect(@dangerfile.status_report[:warnings][0]).to eq("#{warning_text} Check: #{warning_link}")
+        expect(@dangerfile.status_report[:warnings][0]).to eq("#{warning_text} #{warning_link}")
       end
 
       it "Log with variables is warned without link address" do

data/spec/spec_helper.rb

@@ -1,5 +1,11 @@
 # frozen_string_literal: true
 
+require "simplecov"
+SimpleCov.start
+
+require "codecov"
+SimpleCov.formatter = SimpleCov::Formatter::Codecov
+
 require "pathname"
 ROOT = Pathname.new(File.expand_path("..", __dir__))
 $:.unshift("#{ROOT}lib".to_s)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-logging_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - David Sucharda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-21 00:00:00.000000000 Z
+date: 2022-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -40,18 +40,32 @@ dependencies:
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
+- !ruby/object:Gem::Dependency
+  name: codecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -157,6 +171,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/deploy.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
@@ -167,6 +183,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- codecov.yml
 - danger-logging_lint.gemspec
 - lib/danger_logging_lint.rb
 - lib/danger_plugin.rb
@@ -196,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: 'Since logging can be a security issue in some cases (ex: usage in production)