danger-logging_lint 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b4f62fd36901e935296e80d8e6e884604818be116be3731668fd46d9e2f29cf1
-  data.tar.gz: '0518bc5b6aabe4236039303b27e211025458c5870b135789f6311f03918fba5c'
+  metadata.gz: 1187c52de797c72b839cbae7bc8cc512edf1a9683befc9fd62a44cfc6bcfb808
+  data.tar.gz: 7b53090e39be08e9961954d453c488bad46a508c08d80e153c6956e9db4b28a4
 SHA512:
-  metadata.gz: 47ad03a313f30f32a397ff9d0faffa584b758179f8a701b53ed47e78b05657cfcec4d102965f8d045df00c14ada9b34d2750551085970d8d18e312830b197cfa
-  data.tar.gz: 42cd8e9e2872c7f126bb0c6918741b9df60cf171685beb41ee2309c9f3d185b9e444dc31d024281594511cb108e5d199f667785ce709bf88741204d2efda7ac2
+  metadata.gz: eeb379e0926b80439cbfe92d2c0353720cebc72953c33b0db0000fbdaf1c6fea0276da970d15de34b8fc5fb61cf175acc60b8f87acd03fd6ba8b69a313b23026
+  data.tar.gz: 76e580706ded58ae576c6012ae7e68d6a30cb691dae76b4b3503c63d57959f037255028c81243d95d2c37f5b16769ccba17598095a99eaef172376977f644ff7

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+## Changelog
+
+### Version 0.0.2 (2022-04-21)
+
+- Updated `gemspec` (gem) documentation.
+- Fixed warning call.
+- Changed test checks to use `violation_report` instead of `status_report`.
+
+### Version 0.0.1 (2022-04-20)
+
+- Initial version of the library.

data/danger-logging_lint.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["David Sucharda"]
   spec.email         = ["david.sucharda@eman.cz"]
   spec.description   = "Checks logging commands in code."
-  spec.summary       = "Logging might be a security issue that is why this plugin checks files for new/changed logs with variables that might be a security issue and warns them using Danger."
+  spec.summary       = "Since logging can be a security issue in some cases (ex: usage in production) this linter checks for logs with variables and triggers warning for them using Danger."
   spec.homepage      = "https://github.com/eManPrague/danger-logging_lint"
   spec.license       = "MIT"
 

data/lib/logging_lint/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LoggingLint
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/logging_lint/plugin.rb

@@ -230,7 +230,7 @@ module Danger
             if contains_variable(c)
               char_index = $~.offset(0)[0] + line_offset(c)
               line_index = raw_file[0..char_index].lines.count
-              warn(compose_warning_text(warning_text), true, filename, line_index)
+              warn(compose_warning_text(warning_text), file: filename, line: line_index)
             end
           end
         end

data/spec/logging_lint_spec.rb

@@ -118,13 +118,8 @@ module Danger
       # Compares violation lines against danger warning lines. It expects them to be equal.
       #
       def compare_warning_with_lines(violation_lines)
-        warnings = @dangerfile.status_report[:warnings]
-        warning_lines = []
-        warnings.each_with_index do |value, index|
-          if index > 0 && (index + 1) % 4 == 0
-            warning_lines << value
-          end
-        end
+        warnings = @dangerfile.violation_report[:warnings]
+        warning_lines = warnings.map(&:line)
         expect(warning_lines).to eq(violation_lines)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-logging_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - David Sucharda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-04-20 00:00:00.000000000 Z
+date: 2022-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -160,6 +160,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -198,9 +199,8 @@ requirements: []
 rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: Logging might be a security issue that is why this plugin checks files for
-  new/changed logs with variables that might be a security issue and warns them using
-  Danger.
+summary: 'Since logging can be a security issue in some cases (ex: usage in production)
+  this linter checks for logs with variables and triggers warning for them using Danger.'
 test_files:
 - spec/fixtures/IgnoredModifiedFile.txt
 - spec/fixtures/ModifiedFile.kt