danger-lgtm 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2003b650eca71ba9c3c9ac91b86eda29757349c7
-  data.tar.gz: 9d258b59a6f6f0ab638f556ae7b91b7b4cf11563
+  metadata.gz: 6bc0f25e9ef746b8ee1c128835654931a5132527
+  data.tar.gz: 2edec9d0cf6c6239e955b01399bb169a6c17bb61
 SHA512:
-  metadata.gz: 48166fec2e2aa69503e71431839aacb146864505efb2cf26297b9d2fcf36823b9dab78b7b42c94da1dee51a394a44c92de810f91a9ee1fc4419066cc23f4473f
-  data.tar.gz: 2309634a33d3d73baf5a429ac054bbcd4d01f4d27234b7187f336e3fa41d80226569707ddffe9d79e1ad0b4eb2fd8b70db2a3a956e887eac60be632a3180a4f3
+  metadata.gz: c098b0a77f69c05182d694ebb0092a88caf2be72c2e7665f4d11d307cd250592760316b477fc36cac93908c8f2b47b6e0d51d223e4e02abdd3f8b83f2d9dd068
+  data.tar.gz: 1f05eccca2427dbafcb0d1f289be41137f131c3925037b19d706ec0239b00d87ab5fc73b9824b27de54774e0bdb38e3ce3720a952d6d9fd8b9731d720ced3206

data/.travis.yml

@@ -5,8 +5,7 @@ cache:
 
 rvm:
   - 2.0
-  - 2.1.3
   - 2.3.1
 
 script:
-    - bundle exec rake spec
+    - bundle exec rake spec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-lgtm (0.2.0)
+    danger-lgtm (1.0.0)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -19,7 +19,7 @@ GEM
     colored2 (3.1.2)
     cork (0.3.0)
       colored2 (~> 3.1)
-    danger (5.2.2)
+    danger (5.1.1)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
       colored2 (~> 3.1)
@@ -107,8 +107,8 @@ GEM
       faraday (~> 0.8, < 1.0)
     shellany (0.0.1)
     slop (3.6.0)
-    terminal-table (1.8.0)
-      unicode-display_width (~> 1.1, >= 1.1.1)
+    terminal-table (1.7.3)
+      unicode-display_width (~> 1.1.1)
     thor (0.19.4)
     unicode-display_width (1.1.3)
     yard (0.9.8)

data/README.md

@@ -20,6 +20,10 @@ Also you can specify a image url to post with `image_url`
 
     lgtm.check_lgtm image_url: 'https://yourimage'
 
+If you want a https image only, you can use `https_image_only` option
+
+    lgtm.check_lgtm https_image_only: true
+
 ## Development
 
 1. Clone this repo

data/lib/lgtm/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Lgtm
-  VERSION = '0.2.0'.freeze
+  VERSION = '1.0.0'.freeze
 end

data/lib/lgtm/plugin.rb

@@ -16,20 +16,21 @@ module Danger
   # @tags lgtm, github
   #
   class DangerLgtm < Plugin
-    RANDOM_LGTM_POST_URL = 'http://lgtm.in/g'.freeze
+    RANDOM_LGTM_POST_URL = 'https://lgtm.in/g'.freeze
 
     # Check status report, say lgtm if no violations
-    # Generates a `markdown` of a lgtm iamge.
+    # Generates a `markdown` of a lgtm image.
     #
     # @param   [image_url] lgtm image url
+    # @param   [https_image_only] fetching https image only if true
     #
     # @return  [void]
     #
-    def check_lgtm(image_url: nil)
+    def check_lgtm(image_url: nil, https_image_only: false)
       return unless status_report[:errors].length.zero? &&
                     status_report[:warnings].length.zero?
 
-      image_url ||= fetch_image_url
+      image_url ||= fetch_image_url(https_image_only: https_image_only)
 
       markdown(
         markdown_template(image_url)
@@ -38,7 +39,7 @@ module Danger
 
     private
 
-    def fetch_image_url
+    def fetch_image_url(https_image_only: false)
       lgtm_post_url = process_request(RANDOM_LGTM_POST_URL)['location']
 
       lgtm_post_response = process_request(lgtm_post_url) do |req|
@@ -47,7 +48,11 @@ module Danger
 
       lgtm_post = JSON.parse(lgtm_post_response.body)
 
-      lgtm_post['actualImageUrl']
+      url = lgtm_post['actualImageUrl']
+      if https_image_only && URI.parse(url).scheme != 'https'
+        return fetch_image_url(https_image_only: true)
+      end
+      url
     end
 
     def process_request(url)
@@ -57,7 +62,9 @@ module Danger
 
       yield req if block_given?
 
-      Net::HTTP.start(uri.hostname, uri.port) { |http| http.request(req) }
+      Net::HTTP.start(uri.hostname, uri.port, use_ssl: true) do |http|
+        http.request(req)
+      end
     end
 
     def markdown_template(image_url)

data/spec/lgtm_spec.rb

@@ -25,14 +25,17 @@ module Danger
         expect(@dangerfile.status_report[:markdowns].length).to eq(1)
       end
 
-      it 'pick random pic from lgtm.in' do
-        mock = double(
-          :[] => 'https://lgtm.in/p/sSuI4hm0q',
+      def mock(request_url: 'https://lgtm.in/p/sSuI4hm0q',
+               actual_image_url: 'https://example.com/image.jpg')
+        double(
+          :[] => request_url,
           body: JSON.generate(
-            actualImageUrl: 'https://example.com/image.jpg'
+            actualImageUrl: actual_image_url
           )
         )
+      end
 
+      it 'pick random pic from lgtm.in' do
         allow(Net::HTTP).to receive(:start).and_return(mock)
 
         @lgtm.check_lgtm
@@ -41,6 +44,15 @@ module Danger
           .to match(%r{https:\/\/example.com\/image.jpg})
       end
 
+      it 'pick random pic from lgtm.in with https_image_only option' do
+        allow(Net::HTTP).to receive(:start).and_return(mock)
+
+        @lgtm.check_lgtm https_image_only: true
+
+        expect(@dangerfile.status_report[:markdowns][0].message)
+          .to match(%r{https:\/\/example.com\/image.jpg})
+      end
+
       it 'use given url' do
         @lgtm.check_lgtm image_url: 'http://imgur.com/Irk2wyX.jpg'
         expect(@dangerfile.status_report[:markdowns][0].message)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-lgtm
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - leonhartX
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-02 00:00:00.000000000 Z
+date: 2017-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -193,7 +193,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Danger Plugin used to post LGTM iamge when there is no violations