danger-l10nlint 0.0.8 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7fecb0e23bb08a3ec1394c12ad2f3627e269234fb3fb64cf9b80e7e1cfcacdd0
-  data.tar.gz: 74d00f34eb8332c9b58046c9681a65bb92026126f5d1eb4d07198361908912a8
+  metadata.gz: 9a2e571c132ce2d510728cd6d124d77fc9a1e7adfeacdc4cba72a6e8dd79fe15
+  data.tar.gz: 37dcb9eb3104b27c02a47114c86fcfbd320e2ab593522345cbc831a87ac3dc8b
 SHA512:
-  metadata.gz: 12e66784e5a236a5da1b16001278a2158fc0fe3de60b76960bf3bb359ffb42ce5e0778cb0480921d9da5019c017473a0e12ac0e7d35a76a1ae87111dadaa1912
-  data.tar.gz: c67a524440b7bd432a4636014c6b26bcaf36d89d81baaf4a6429587e04028d9c9e1743463af41e79247d6a554a7b1519fafc03aa9d5b038f71fcc9fb7c654fbd
+  metadata.gz: a707a4c598d861019d9f3f1749ed7fa79e8f4c5adb5dde18d2a81feca4dad860679699cd2e0d722cb474d17add7e363f90e634c45144bdc5a0ed0f4a4b78f018
+  data.tar.gz: aa14c486a956bbec5a21bc1233f5dbca89612479db4c44666f7192edae2ede7d8d05b3df87a1bdd907b0649d7a3ea965271c354db3b62b59240cf82eb3a6d57c

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-l10nlint (0.0.8)
+    danger-l10nlint (0.0.10)
       danger-plugin-api (~> 1.0)
 
 GEM

data/Makefile

@@ -0,0 +1,3 @@
+.PHONY: release
+release:
+	bundle exec rake release

data/lib/danger_plugin.rb

@@ -23,33 +23,45 @@ module Danger
   #
   class DangerL10nlint < Plugin
     # The path to L10nLint's execution
+    # @return [String] binary_path
     attr_accessor :binary_path
 
     # The path to L10nLint's configuration file
+    # @return [String] config_file
     attr_accessor :config_file
 
     # Maximum number of issues to be reported.
+    # @return [Integer] max_num_violations
     attr_accessor :max_num_violations
 
     # Provides additional logging diagnostic information.
+    # @return [Boolean] verbose
     attr_accessor :verbose
 
     # Whether we should fail on warnings
+    # @return [Boolean] strict
     attr_accessor :strict
 
     # Warnings found
+    # @return [Array<Hash>] warnings
     attr_accessor :warnings
 
     # Errors found
+    # @return [Array<Hash>] errors
     attr_accessor :errors
 
     # All issues found
+    # @return [Array<Hash>] issues
     attr_accessor :issues
 
+    # Rules for not wanting to make inline comments
+    # @return [Array<String>] rule identifiers
+    attr_accessor :inline_except_rules
+
     # Lints Localizable.strings
     # @return [void]
     #
-    def lint_files(inline_mode: false, fail_on_error: false, additional_l10nlint_args: '')
+    def lint_files(inline_mode: false, fail_on_error: false, additional_l10nlint_args: '', subtitle: '')
       raise 'l10nlint is not installed' unless l10nlint.installed?
 
       config_file_path = config_file
@@ -76,20 +88,39 @@ module Danger
         other_issues_count = issues.count - @max_num_violations if issues.count > @max_num_violations
         issues = issues.take(@max_num_violations)
       end
-      log "Received from L10nLint: #{issues}"
+
+      log "Received issues from L10nLint: #{issues.count}"
 
       # Filter warnings and errors
       @warnings = issues.select { |issue| issue['severity'] == 'warning' }
       @errors = issues.select { |issue| issue['severity'] == 'error' }
 
       if inline_mode
+        # Separate each warnings and errors by inline_except_rules
+        if inline_except_rules
+          markdown_warnings = warnings.select { |issue| inline_except_rules.include?(issue['ruleIdentifier']) }
+          inline_warnings = warnings - markdown_warnings
+          markdown_errors = @errors.select { |issue| inline_except_rules.include?(issue['ruleIdentifier']) }
+          inline_errors = @errors - markdown_errors
+        end
+
         # Report with inline comment
-        send_inline_comment(warnings, strict ? :fail : :warn)
-        send_inline_comment(errors, (fail_on_error || strict) ? :fail : :warn)
+        send_inline_comment(inline_warnings, strict ? :fail : :warn)
+        send_inline_comment(inline_errors, (fail_on_error || strict) ? :fail : :warn)
+
+        if markdown_warnings.count > 0 || markdown_errors.count > 0
+          message = "### L10nLint found issues\n\n".dup
+          message << markdown_issues(markdown_warnings, 'Warnings') unless markdown_warnings.empty?
+          message << markdown_issues(markdown_errors, 'Errors') unless markdown_errors.empty?
+          markdown message
+        end
+
         warn other_issues_message(other_issues_count) if other_issues_count > 0
+
       elsif warnings.count > 0 || errors.count > 0
         # Report if any warning or error
-        message = "### L10nLint found issues\n\n".dup
+        subtitle_in_title = subtitle.empty? '' : "(#{subtitle})"
+        message = "### L10nLint found issues #{subtitle_in_title}\n\n".dup
         message << markdown_issues(warnings, 'Warnings') unless warnings.empty?
         message << markdown_issues(errors, 'Errors') unless errors.empty?
         message << "\n#{other_issues_message(other_issues_count)}" if other_issues_count > 0

data/lib/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module DangerL10nLint
-  VERSION = '0.0.8'
+  VERSION = '0.0.10'
   L10NLINT_VERSION = '0.0.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-l10nlint
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.10
 platform: ruby
 authors:
 - Kazumasa Shimomura
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-07 00:00:00.000000000 Z
+date: 2023-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -168,6 +168,7 @@ files:
 - Gemfile.lock
 - Guardfile
 - LICENSE.txt
+- Makefile
 - README.md
 - Rakefile
 - bin/danger-l10nlint