danger-kover 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d51a8761be717a19d11d215d58100fe5301539ba8c76f40383deddc1f150063b
-  data.tar.gz: d952a4b6a25b113718d10a48d5d42bb59baeb4c66cd2b2fea3a07932e5849ccd
+  metadata.gz: 44a53eb966b795cb6793ffa0d4f2be671a55fc2dd445e35dc473cdcea3d96382
+  data.tar.gz: 5d775bf7df1da1425092d1af297dd021d34a3f29940c3e973de70731361fb67e
 SHA512:
-  metadata.gz: 52392f721abee9a2cd898482c0707f810df876cb0c961975d43c19acd5d1bb0f75cda2aea53d48392334149dd4b0366196266180c6fba7e0736790284024ff96
-  data.tar.gz: 5a2e8efc9eb2f9e549d4f781f972c25de34dc8955301da17b090ce432cc423ecddd6e28419cbd723ff5042eec40e6ceb7d4c8e2c7c5d96846f353ed0a3ac013b
+  metadata.gz: d5de9eeb0965194cbbeadd598e2207808d51290b27ecb9747e9da44d0b61a320e97f033a2bea72822913bd072a44130a03d12a99bd16e40273375e90bdfe6236
+  data.tar.gz: c26878612b9780b6f9046afa40bf2500a1d0067c82fcebbd3393eb83290bdbca225ed29ff0fbd8d6f702f93515fd7583f4e0c71433f5d551b925a42c0015d66c

data/README.md

@@ -54,3 +54,17 @@ This is a fork, based on [Shroud](https://github.com/livefront/danger-shroud).
 3. Run `bundle exec rake spec` to run the tests.
 4. Use `bundle exec guard` to automatically have tests run as you make changes.
 5. Make your changes.
+
+## Publishing
+
+How to build a gem (make sure to update the version):
+
+```
+gem build danger-kover.gemspec
+```
+
+How to publish a gem:
+
+```
+gem push danger-kover-VERSION.gem
+```

data/lib/kover/gem_version.rb

@@ -1,3 +1,3 @@
 module Kover
-  VERSION = "0.0.2".freeze
+  VERSION = "0.0.4".freeze
 end

data/lib/kover/plugin.rb

@@ -60,6 +60,26 @@ module Danger
       @fail_if_under_threshold ||= true
     end
 
+    # Show plugin repository link.
+    # @return [Boolean]
+    attr_accessor :link_repository
+
+    # A getter for `link_repository`, returning `true` by default.
+    # @return [Boolean]
+    def link_repository
+      @link_repository ||= true
+    end
+
+    # Show not found files in report count.
+    # @return [Boolean]
+    attr_accessor :count_not_found
+
+    # A getter for `count_not_found`, returning `true` by default.
+    # @return [Boolean]
+    def count_not_found
+      @count_not_found ||= true
+    end
+
     # Report coverage on diffed files, as well as overall coverage.
     #
     # @param   [String] moduleName
@@ -112,48 +132,54 @@ module Danger
       puts "Here is the touched files coverage hash"
       puts touchedFilesHash
 
-      output = "## 🎯 #{moduleName} Code Coverage: **`#{'%.2f' % coveragePercent}%`**\n"
+      output = "### 🎯 #{moduleName} Code Coverage: **`#{'%.2f' % coveragePercent}%`**\n"
 
       if touchedFilesHash.empty?
-        output << "The new and modified files are not part of the Kover coverage report 👀.\n"
+        output << "The new and updated files are not part of this module coverage report 👀.\n"
       else
-        output << "### Coverage of Modified Files:\n"
+        output << "**Modified files:**\n"
         output << "File | Coverage\n"
         output << ":-----|:-----:\n"
       end
 
-      # go through each file:
+      # Go through each file:
       touchedFilesHash.sort.each do |fileName, coveragePercent|
         output << "`#{fileName}` | **`#{'%.2f' % coveragePercent}%`**\n"
 
-        # warn or fail if under specified file threshold:
-        if (coveragePercent < file_threshold)
-          warningMessage = "Uh oh! #{fileName} is under #{file_threshold}% coverage!"
-          if (fail_if_under_threshold)
-            fail warningMessage
-          else 
-            warn warningMessage
-          end
+        # Check file coverage
+        if (coveragePercent == 0)
+          advise("Oops! #{fileName} does not have any test coverage.")
+        elsif (coveragePercent < file_threshold)
+          advise("Oops! #{fileName} is under #{file_threshold}% coverage.")
         end
       end
 
-      output << "\n"
-      output << "Number of files not found in coverage report: #{fileNamesNotInReport.size}."
-      output << "\n\n"
+      if (count_not_found)
+        output << "\n\n"
+        output << "Number of files not found in coverage report: #{fileNamesNotInReport.size}."
+      end
 
-      output << 'Code coverage by [danger-kover](https://github.com/JCarlosR/danger-kover).'
+      if (link_repository)
+        output << "\n\n"
+        output << 'Code coverage by [danger-kover](https://github.com/JCarlosR/danger-kover).'
+      end
+      
       markdown output
 
-      # warn or fail if total coverage is under specified threshold
-      if (coveragePercent < total_threshold)
-        totalCoverageWarning = "Oops! The project codebase is under #{total_threshold}% coverage."
-        
-        if (fail_if_under_threshold) 
-          fail totalCoverageWarning
-        else 
-          warn totalCoverageWarning
-        end
+      # Check total coverage
+      if (coveragePercent < total_threshold)        
+        advise("Oops! The module #{moduleName} codebase is under #{total_threshold}% coverage.")
       end
     end
+
+    # Warn or fail, depending on the `fail_if_under_threshold` flag.
+    private def advise(message)
+      if (fail_if_under_threshold)
+        fail message
+      else
+        warn message
+      end
+    end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-kover
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - andrewhaisting
@@ -183,6 +183,8 @@ files:
 - README.md
 - Rakefile
 - danger-kover-0.0.1.gem
+- danger-kover-0.0.2.gem
+- danger-kover-0.0.3.gem
 - danger-kover.gemspec
 - images/bannerImage.png
 - lib/danger_plugin.rb