danger-junit 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd37e7d87505b8882f61d0f5a9177d39f8990d6a
-  data.tar.gz: ef98520c2399b83cb9081bb4a84a16ef4c87d7ee
+  metadata.gz: b38b37d5c91b3b94bd40bfd1f992bea06cdf53ff
+  data.tar.gz: e4195e8fec3601f580c1e7002b69a89a0f8e05dc
 SHA512:
-  metadata.gz: 6b102f1eb6e859468b7594d9f91ee05ffed730ac1cd30f44428704d38bc838638bf96708c4e258992566c75086fb32e94831736fdc3bebc90ae13075fa9fcb0e
-  data.tar.gz: 4f5944bc1493db882898df5bb439694c7bdfeb3f44eb3c87c20701acb28241bfe9f2e4064a1bab87f29ac0b6a07edc74370b54f560ffcbce2c4c7099eb013a87
+  metadata.gz: bfce1b8cb7f2e33dc4ccb299ac1d77b6912788c5dd4d32792851cf0ae6ad5d8de58c48d5c68c5aadadea9305796a5b6a3ba48c88cbd37fbec932ea7539491ea1
+  data.tar.gz: 0c7b6bffd9f5f3ab657cc64ceb0a7dd2d40da4347702e6f291861cf775304575e65a92a35976bf9b352171f1859411d95e468e576f8b1e9c37f88ddb074716d1

data/.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 pkg
 .idea/
+danger-junit-fail.xml

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-junit (0.5.0)
+    danger-junit (0.6.0)
       danger (~> 2.0)
       ox (~> 2.0)
 
@@ -10,6 +10,7 @@ GEM
   specs:
     addressable (2.4.0)
     ast (2.3.0)
+    builder (3.2.2)
     claide (1.0.0)
     claide-plugins (0.9.1)
       cork
@@ -93,6 +94,9 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
+    rspec_junit_formatter (0.2.3)
+      builder (< 4)
+      rspec-core (>= 2, < 4, != 2.12.0)
     rubocop (0.42.0)
       parser (>= 2.3.1.1, < 3.0)
       powerpack (~> 0.1)
@@ -122,6 +126,7 @@ DEPENDENCIES
   pry
   rake (~> 10.0)
   rspec (~> 3.4)
+  rspec_junit_formatter (~> 0.2)
   rubocop (~> 0.41)
   yard (~> 0.8)
 

data/README.md

@@ -40,10 +40,27 @@ junit.show_skipped_tests = true
 junit.report</pre>
 </blockquote>
 
+<blockquote>Only show specific parts of your results
+  <pre>
+junit.parse "/path/to/output.xml"
+junit.headers = [:name, :file]
+junit.report</pre>
+</blockquote>
+
+<blockquote>Only show specific parts of your results
+  <pre>
+junit.parse "/path/to/output.xml"
+all_test = junit.tests.map(&:attributes)
+slowest_test = sort_by { |attributes| attributes[:time].to_f }.last
+message "#{slowest_test[:time]} took #{slowest_test[:time]} seconds"</pre>
+</blockquote>
+
 
 
 #### Attributes
 <tr>
+`tests` - All the tests for introspection
+<tr>
 `passes` - An array of XML elements that represent passed tests.
 <tr>
 `failures` - An array of XML elements that represent failed tests.
@@ -53,6 +70,9 @@ junit.report</pre>
 `skipped` - An array of XML elements that represent skipped tests.
 <tr>
 `show_skipped_tests` - An attribute to make the plugin show a warning on skipped tests.
+<tr>
+`headers` - An array of symbols that become the columns of your tests,
+if `nil`, the default, it will be all of the attribues.
 
 
 

data/danger-junit.gemspec

@@ -21,6 +21,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'danger', '~> 2.0'
   spec.add_runtime_dependency 'ox', '~> 2.0'
 
+  # So we can run our specs with junit
+  spec.add_development_dependency "rspec_junit_formatter", "~> 0.2"
+
   # General ruby development
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake', '~> 10.0'

data/lib/junit/gem_version.rb

@@ -1,3 +1,3 @@
 module Junit
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/lib/junit/plugin.rb

@@ -24,10 +24,30 @@ module Danger
   #          junit.show_skipped_tests = true
   #          junit.report
   #
+  # @example Only show specific parts of your results
+  #
+  #          junit.parse "/path/to/output.xml"
+  #          junit.headers = [:name, :file]
+  #          junit.report
+  #
+  # @example Only show specific parts of your results
+  #
+  #          junit.parse "/path/to/output.xml"
+  #          all_test = junit.tests.map(&:attributes)
+  #          slowest_test = sort_by { |attributes| attributes[:time].to_f }.last
+  #          message "#{slowest_test[:time]} took #{slowest_test[:time]} seconds"
+  #
+  #
   # @see  orta/danger-junit, danger/danger, artsy/eigen
   # @tags testing, reporting, junit, rspec, jasmine, jest, xcpretty
   #
   class DangerJunit < Plugin
+
+    # All the tests for introspection
+    #
+    # @return   [Array<Ox::Element>]
+    attr_accessor :tests
+
     # An array of XML elements that represent passed tests.
     #
     # @return   [Array<Ox::Element>]
@@ -53,6 +73,12 @@ module Danger
     # @return   [Bool]
     attr_accessor :show_skipped_tests
 
+    # An array of symbols that become the columns of your tests,
+    # if `nil`, the default, it will be all of the attribues.
+    #
+    # @return   [Array<Symbol>]
+    attr_accessor :headers
+
     # Parses an XML file, which fills all the attributes
     # will `raise` for errors
     # @return   [void]
@@ -64,7 +90,7 @@ module Danger
       @doc = Ox.parse xml_string
 
       suite_root = @doc.nodes.first.value == 'testsuites' ? @doc.nodes.first : @doc
-      tests = suite_root.nodes.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
+      @tests = suite_root.nodes.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
 
       failed_suites = suite_root.nodes.select { |suite| suite[:failures].to_i > 0 || suite[:errors].to_i > 0 }
       failed_tests = failed_suites.map(&:nodes).flatten.select { |node| node.value == 'testcase' }
@@ -90,19 +116,31 @@ module Danger
         message = "### Tests: \n\n"
 
         tests = (failures + errors)
-        keys = tests.first.attributes.keys
+        keys = headers || tests.first.attributes.keys
         attributes = keys.map(&:to_s).map(&:capitalize)
 
-        # Create the header
+        # Create the headers
         message << attributes.join(' | ') + "|\n"
         message << attributes.map { |_| '---' }.join(' | ') + "|\n"
 
+        # Map out the keys to the tests
         tests.each do |test|
-          message << test.attributes.values.join(' | ') + "|\n"
+          row_values = keys.map { |key| test.attributes[key] }.map { |v| auto_link(v) }
+          message << row_values.join(' | ') + "|\n"
         end
 
         markdown message
       end
     end
+
+    private
+
+    def auto_link(value)
+      if File.exist?(value) && defined?(@dangerfile.github)
+        github.html_link value
+      else
+        value
+      end
+    end
   end
 end

data/spec/junit_spec.rb

@@ -49,6 +49,16 @@ module Danger
         expect(output).to include(row)
       end
 
+       it 'shows a known markdown row' do
+        @junit.parse 'spec/fixtures/rspec_fail.xml'
+        @junit.headers = [:time]
+        @junit.report
+
+        output = @junit.status_report[:markdowns].first
+        row = "Time|\n"
+        expect(output).to include(row)
+      end
+
       it 'shows a warning for skipped' do
         @junit.parse 'spec/fixtures/rspec_fail.xml'
         @junit.show_skipped_tests = true
@@ -57,6 +67,19 @@ module Danger
         warnings = @junit.status_report[:warnings].first
         expect(warnings).to eq('Skipped 7 tests.')
       end
+
+      it 'links paths that are files' do
+        allow(@dangerfile.github).to receive(:pr_json).and_return({
+          head: { repo: { html_url: 'https://github.com/thing/thingy' } }
+        })
+        allow(@dangerfile.github).to receive(:head_commit).and_return("hello")
+
+        @junit.parse 'spec/fixtures/danger-junit-fail.xml'
+        @junit.report
+
+        outputs = @junit.status_report[:markdowns].first
+        expect(outputs).to include('github.com/thing/thingy')
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-junit
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Orta Therox
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement