danger-jira_sync 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7ff26d4b151f9e558de29d9966a5327828fc2c0456435bc0d169cb8e02dae778
-  data.tar.gz: 6e8d072fb4f8c71c0742d1b146b89aa207a3ee01d6b9a0b2734c851664101291
+  metadata.gz: 8fce89991967105fa855239f168ddcd39023c05f3a864602c0f73d625fdcf182
+  data.tar.gz: add9884c0ce2306212d0ac502cf20b1ab9f3d1c70d25b1ec14fa884aba97b881
 SHA512:
-  metadata.gz: 3e7b4350be8e9ae5a38334ad30ecc819bf8f729f78d2e5b78217012abb8c31a205bd15c7a4315eb5058652d0c1e854b424fcbf97750c21acd0c19ab7a8081b4a
-  data.tar.gz: f042a95dc596e67c4e9f051ff4262e0f2d7058e5e63ed7844ce5fb591fc26b12038d465d070db7593d99589559ab75b1016c10788bf86ecfc52a88415a7be88d
+  metadata.gz: f9e4d1cf4d8409f002d014e10ab3dabf0c0932c31171b24d3f0b92cb0e6772980ede2f405358cb1cb9ab4c089f9f73e793e76134b91efd4906979c6d91bf2f8a
+  data.tar.gz: e5403bd45a24ff908279a7e4c0f4d3397531318bd87fcca8b5ae2288d33d8fcea9a3eaadf38636789475d3fedb6023f7c1efb9ec5bf4556eb3c585820515aef2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-jira_sync (0.0.3)
+    danger-jira_sync (0.0.4)
       danger-plugin-api (~> 1.0)
       jira-ruby (~> 1.5.0)
 

data/lib/jira_sync/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JiraSync
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/jira_sync/plugin.rb

@@ -76,7 +76,7 @@ module Danger
       return if labels.empty?
 
       create_missing_github_labels(labels)
-      github.api.add_labels_to_an_issue(repo, issue_number, labels)
+      add_labels_to_issue(labels)
 
       labels
     end
@@ -93,6 +93,8 @@ module Danger
 
     def github_labels
       @github_labels ||= github.api.labels(repo)
+    rescue Octokit::Error => e
+      warn "#{e.response_status} Error while retrieving GitHub labels: #{e.message}"
     end
 
     def extract_issue_keys_from_pull_request(key_prefixes)
@@ -126,9 +128,19 @@ module Danger
       missing_labels = labels - github_labels
       missing_labels.each do |label|
         color = SecureRandom.hex(3)
-        github.api.add_label(repo, label, color)
+        begin
+          github.api.add_label(repo, label, color)
+        rescue Octokit::Error => e
+          warn "#{e.response_status} Error while creating GitHub label \"#{label}\" with color \"#{color}\": #{e.message}"
+        end
       end
       missing_labels
     end
+
+    def add_labels_to_issue(labels)
+      github.api.add_labels_to_an_issue(repo, issue_number, labels)
+    rescue Octokit::Error => e
+      warn "#{e.response_status} Error while adding labels [#{labels}] to GitHub issue: #{e.message}"
+    end
   end
 end

data/spec/jira_sync_spec.rb

@@ -124,10 +124,7 @@ RSpec.describe Danger::DangerJiraSync do
       end
 
       context "after calling #configure" do
-        class GitHubAPIMock
-        end
-
-        let(:github_api_mock) { GitHubAPIMock.new }
+        let(:github_api_mock) { Object.new }
 
         before do
           plugin.configure(jira_settings)
@@ -217,6 +214,16 @@ RSpec.describe Danger::DangerJiraSync do
           expect(labels).to include(*pr_title_related_project_keys)
         end
 
+        it "creates no warnings in the default case" do
+          stub_github_api_labelling
+
+          VCR.use_cassette(:default_success, record: :new_episodes) do
+            plugin.autolabel_pull_request(issue_prefixes)
+          end
+
+          expect(dangerfile.status_report[:warnings].count).to eq(0)
+        end
+
         it "creates a warning when a related Jira ticket cannot be fetched" do
           stub_jira_find_issue_404
 
@@ -245,6 +252,78 @@ RSpec.describe Danger::DangerJiraSync do
           expect(issue_warning_count).to eq(1)
         end
 
+        it "creates a warning when it cannot create a github label" do
+          stub_github_api_labelling
+
+          error = Octokit::Error.from_response({
+            method: "POST",
+            url: "https://www.example.com/",
+            status: 422,
+            documentation_url: "https://developer.github.com/v3/issues/labels/#create-a-label",
+            message: <<~HEREDOC
+              resource: Label
+              code: already_exists
+              field: name
+            HEREDOC
+          })
+
+          expect(github_api_mock).to receive(:add_label).and_raise(error)
+          expect(dangerfile.status_report[:warnings].count).to eq(0), "preconditions"
+
+          VCR.use_cassette(:default_success, record: :new_episodes) do
+            plugin.autolabel_pull_request(issue_prefixes)
+          end
+
+          expected_missing_label_count = 1
+          expect(dangerfile.status_report[:warnings].count).to eq(expected_missing_label_count)
+        end
+
+        it "creates a warning when it cannot fetch existing github labels" do
+          stub_github_api_labelling
+
+          error = Octokit::Error.from_response({
+            method: "GET",
+            url: "https://www.example.com/",
+            status: 503,
+            documentation_url: "https://developer.github.com/v3/issues/labels/#create-a-label",
+            message: "Forbidden"
+          })
+
+          expect(github_api_mock).to receive(:add_labels_to_an_issue).and_raise(error)
+          expect(dangerfile.status_report[:warnings].count).to eq(0), "preconditions"
+
+          VCR.use_cassette(:default_success, record: :new_episodes) do
+            plugin.autolabel_pull_request(issue_prefixes)
+          end
+
+          expect(dangerfile.status_report[:warnings].count).to eq(1)
+        end
+
+        it "creates a warning when it cannot add a label to an existing github issue" do
+          stub_github_api_labelling
+
+          error = Octokit::Error.from_response({
+            method: "POST",
+            url: "https://www.example.com/",
+            status: 422,
+            documentation_url: "https://developer.github.com/v3/issues/labels/#create-a-label",
+            message: <<~HEREDOC
+              resource: Label
+              code: already_exists
+              field: name
+            HEREDOC
+          })
+
+          expect(github_api_mock).to receive(:add_label).and_raise(error)
+          expect(dangerfile.status_report[:warnings].count).to eq(0), "preconditions"
+
+          VCR.use_cassette(:default_success, record: :new_episodes) do
+            plugin.autolabel_pull_request(issue_prefixes)
+          end
+
+          expect(dangerfile.status_report[:warnings].count).to eq(1)
+        end
+
         it "adds a label to the github issue for each related jira issue component name" do
           pr_title_related_component_names.each do |component_name|
             expect(github_api_mock).to receive(:add_label).with(anything, component_name, anything).once.and_return(nil)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jira_sync
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Ben Menesini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-27 00:00:00.000000000 Z
+date: 2018-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api