danger-jacoco 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be717547463cb80933a9d0a26dc3c8d54e28ab790ee586f3c85ba008a05a32ac
-  data.tar.gz: 5d4c4871ab84ca86896e9c0bc87d65deb833222772bca6b94e189382402f6309
+  metadata.gz: 98c57cc2ececdda3470143782f1c87943a3f0a08f2931c0aa634444da0d90c69
+  data.tar.gz: 4de9109e706b7fa0f33a3906261535fe6c40e4d6b1580951af6cc1a1d6597e01
 SHA512:
-  metadata.gz: 28114a17c2544c7780a282edc04660756b0b4b3da8a49c87da7ddae43c71fadbf57f1cc7c887430a6bc3b77115be214e46f6116232ddcbe75b47ed9f4701a969
-  data.tar.gz: 4958daa6252fdccaf330c6b752cc1bc51a57cfa4988c72fbf6ef8815472ff11df11e212535a43c2f4a2bf367c7de541647b45f2093c89ad5bb4b1b1fa1204e74
+  metadata.gz: 021aa093d7763cef129b9b3ee73ddb23ca1e29d6565d6b8c74e24ee4071ea55ea8de5452dd16fea5b2aef97fefdb67ce9fd82a20d22b248af58bd37c51df11fa
+  data.tar.gz: 527c5b390bae29e370215cec242586c41adeb16ccd25932a7ab41a03ffd81afaaaf756acf36dd0168f0f86423237ecdfe6a715941a3943a0c514ddab63b5841c

data/.github/workflows/ci.yaml

@@ -8,5 +8,6 @@ jobs:
       - uses: actions/setup-ruby@v1
         with:
           ruby-version: '2.6.x'
+      - run: gem install bundler
       - run: bundle install
       - run: bundle exec rake spec

data/.github/workflows/release.yaml

@@ -10,13 +10,14 @@ jobs:
       - uses: actions/setup-ruby@v1
         with:
           ruby-version: '2.6.x'
+      - run: gem install bundler
       - run: bundle install
       - run: bundle exec rake spec
       - name: setup credentials
         env:
           RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
         run: |
-          mkdir ~/.gem
+          mkdir -p ~/.gem
           echo -e "---\r\n:rubygems_api_key: $RUBYGEMS_API_KEY" > ~/.gem/credentials
           chmod 0600 ~/.gem/credentials
       - run: bundle exec rake release

data/danger-jacoco.gemspec

@@ -22,8 +22,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'nokogiri-happymapper', '~> 0.6'
 
   # General ruby development
-  spec.add_development_dependency 'bundler', '~> 1.16'
-  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
 
   # Testing support
   spec.add_development_dependency 'rspec', '~> 3.7'
@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
 
   # If you want to work on older builds of ruby
-  spec.add_development_dependency 'listen', '3.1.5'
+  spec.add_development_dependency 'listen', '3.2.1'
 
   # This gives you the chance to run a REPL inside your tests
   # via:

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.5'
+  VERSION = '0.1.6'
 end

data/lib/jacoco/plugin.rb

@@ -25,6 +25,7 @@ module Danger
     attr_accessor :files_extension
     attr_accessor :minimum_package_coverage_map
     attr_accessor :minimum_class_coverage_map
+    attr_accessor :fail_no_coverage_data_found
 
     # Initialize the plugin with configured parameters or defaults
     def setup
@@ -61,7 +62,9 @@ module Danger
     # Java => blah/blah/java/slashed_package/Source.java
     # Kotlin => blah/blah/kotlin/slashed_package/Source.kt
     #
-    def report(path, report_url = '', delimiter = %r{\/java\/|\/kotlin\/})
+    def report(path, report_url = '', delimiter = %r{\/java\/|\/kotlin\/}, fail_no_coverage_data_found: true)
+      @fail_no_coverage_data_found = fail_no_coverage_data_found
+
       setup
       classes = classes(delimiter)
 
@@ -89,18 +92,28 @@ module Danger
 
     # It returns a specific class code coverage and an emoji status as well
     def report_class(jacoco_class)
+      report_result = {
+        covered: 'No coverage data found : -',
+        status: ':black_joker:',
+        required_coverage_percentage: 'No coverage data found : -'
+      }
+
       counter = coverage_counter(jacoco_class)
-      coverage = (counter.covered.fdiv(counter.covered + counter.missed) * 100).floor
-      required_coverage = minimum_class_coverage_map[jacoco_class.name]
-      required_coverage = package_coverage(jacoco_class.name) if required_coverage.nil?
-      required_coverage = minimum_class_coverage_percentage if required_coverage.nil?
-      status = coverage_status(coverage, required_coverage)
+      unless counter.nil?
+        coverage = (counter.covered.fdiv(counter.covered + counter.missed) * 100).floor
+        required_coverage = minimum_class_coverage_map[jacoco_class.name]
+        required_coverage = package_coverage(jacoco_class.name) if required_coverage.nil?
+        required_coverage = minimum_class_coverage_percentage if required_coverage.nil?
+        status = coverage_status(coverage, required_coverage)
+
+        report_result = {
+          covered: coverage,
+          status: status,
+          required_coverage_percentage: required_coverage
+        }
+      end
 
-      {
-        covered: coverage,
-        status: status,
-        required_coverage_percentage: required_coverage
-      }
+      report_result
     end
 
     # it returns the most suitable coverage by package name to class or nil
@@ -149,7 +162,14 @@ module Danger
       branch_counter = counters.detect { |e| e.type.eql? 'BRANCH' }
       line_counter = counters.detect { |e| e.type.eql? 'LINE' }
       counter = branch_counter.nil? ? line_counter : branch_counter
-      raise "No coverage data found for #{jacoco_class.name}" if counter.nil?
+
+      if counter.nil?
+        no_coverage_data_found_message = "No coverage data found for #{jacoco_class.name}"
+
+        raise no_coverage_data_found_message if @fail_no_coverage_data_found.class == TrueClass
+
+        warn no_coverage_data_found_message
+      end
 
       counter
     end

data/spec/fixtures/output_b.xml

@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.0//EN"
+        "report.dtd">
+<report name="test_report">
+  <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
+  <package name="com/example">
+    <class name="com/example/CachedRepository">
+      <method name="&lt;init&gt;" desc="()V" line="17">
+        <counter type="INSTRUCTION" missed="0" covered="11"/>
+        <counter type="COMPLEXITY" missed="0" covered="1"/>
+        <counter type="METHOD" missed="0" covered="1"/>
+      </method>
+      <counter type="INSTRUCTION" missed="0" covered="46"/>
+      <counter type="COMPLEXITY" missed="5" covered="7"/>
+      <counter type="METHOD" missed="0" covered="7"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+    </class>
+    <sourcefile name="CachedRepository.java">
+      <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
+      <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
+      <counter type="INSTRUCTION" missed="2" covered="98"/>
+      <counter type="COMPLEXITY" missed="2" covered="11"/>
+      <counter type="METHOD" missed="2" covered="11"/>
+      <counter type="CLASS" missed="2" covered="4"/>
+    </sourcefile>
+    <counter type="INSTRUCTION" missed="80" covered="324"/>
+    <counter type="COMPLEXITY" missed="11" covered="39"/>
+    <counter type="METHOD" missed="9" covered="37"/>
+    <counter type="CLASS" missed="2" covered="10"/>
+  </package>
+  <counter type="INSTRUCTION" missed="39399" covered="19321"/>
+  <counter type="COMPLEXITY" missed="5517" covered="1444"/>
+  <counter type="METHOD" missed="3382" covered="1120"/>
+  <counter type="CLASS" missed="491" covered="370"/>
+</report>

data/spec/jacoco_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 # rubocop:disable LineLength
-
+# rubocop:disable ModuleLength
 # rubocop:disable BlockLength
 
 require File.expand_path('spec_helper', __dir__)
@@ -122,9 +122,46 @@ module Danger
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| [`com/example/CachedRepository`](http://test.com/com.example/CachedRepository.html) | 50% | 80% | :warning: |')
       end
+
+      it 'When option "fail_no_coverage_data_found" is set to optionally fail, it doesn\'t fail the execution' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report(path_a, fail_no_coverage_data_found: true) }.to_not raise_error(RuntimeError)
+      end
+
+      it 'When option "fail_no_coverage_data_found" is not set, the execution fails on empty data' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report path_a }.to raise_error(RuntimeError)
+      end
+
+      it 'When option "fail_no_coverage_data_found" is set to optionally fail, the execution fails on empty data' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report path_a, fail_no_coverage_data_found: true }.to raise_error(RuntimeError)
+      end
+
+      it 'When option "fail_no_coverage_data_found" is set to optionally warn (not fail), the execution doesn\'t fail on empty data' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report path_a, fail_no_coverage_data_found: false }.to_not raise_error(RuntimeError)
+      end
     end
   end
 end
 
 # rubocop:enable LineLength
+# rubocop:enable ModuleLength
 # rubocop:enable BlockLength

data/spec/spec_helper.rb

@@ -18,6 +18,8 @@ RSpec.configure do |config|
   config.tty = true
 end
 
+RSpec::Expectations.configuration.on_potential_false_positives = :nothing
+
 require 'danger_plugin'
 
 # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Anton Malinskiy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-19 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.5
+        version: 3.2.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.5
+        version: 3.2.1
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -198,6 +198,7 @@ files:
 - lib/jacoco/plugin.rb
 - lib/jacoco/sax_parser.rb
 - spec/fixtures/output_a.xml
+- spec/fixtures/output_b.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/Malinskiy/danger-jacoco
@@ -225,5 +226,6 @@ specification_version: 4
 summary: A longer description of danger-jacoco.
 test_files:
 - spec/fixtures/output_a.xml
+- spec/fixtures/output_b.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb