danger-jacoco 0.1.3 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bbe04fa92db358efe7b876a9cc4a96ba345fed7f
-  data.tar.gz: 4ee1125c139adce7f13e98ff8233a1ddae339640
+SHA256:
+  metadata.gz: e27bdd91acf2d25a2fa8f0eb6e0a07e5375f6864d831d8ca3883437db5d95bd3
+  data.tar.gz: 4f5bfaf1bdecdf96e99044f0f63db762f52adbea608654b334f85e80588d3ae5
 SHA512:
-  metadata.gz: 3b781beccdd7e277ed4a6296864ea3e1fb56315aa0bb636ae4e0002b758cd0dc5f55702e0c0380f4007501f1a87ff405e7c460cb349fd02eacba7c3d52f49acf
-  data.tar.gz: c3708a9d043202c10748711683cfefddab20808eec536c2790a3f56ec463f47b306224fa6303f8c5d54174fc8e31ca38083629c5116ea2293a5fca66f71f3e63
+  metadata.gz: 873ab75273b2c8cdefcd3fe3fb524e5fe2173debfa4cc96c44a0b8a5ec5c2de3d8e0a4c89107467d2abff3976d6e7244fd14fa7c5e0fed6bbad6b0c3e25e2b53
+  data.tar.gz: ac8dba5b3af75092aa7e483f5d0fdde9780df01aa5f38cbc3b6f9f71cc29f182d8bf50398425991900b976406c32f16923cda9acbfb6c7c49287ed7f6f06d32c

data/.github/dependabot.yml

@@ -0,0 +1,20 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: weekly
+    time: "19:00"
+  open-pull-requests-limit: 10
+  ignore:
+  - dependency-name: listen
+    versions:
+    - 3.4.1
+    - 3.5.0
+  - dependency-name: rubocop
+    versions:
+    - 1.10.0
+    - 1.11.0
+    - 1.12.0
+    - 1.8.1
+    - 1.9.1

data/.github/workflows/ci.yaml

@@ -0,0 +1,13 @@
+name: ci
+on: [push]
+jobs:
+  test:
+    runs-on: ubuntu-18.04
+    steps:
+      - uses: actions/checkout@v1
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: '2.6.x'
+      - run: gem install bundler
+      - run: bundle install
+      - run: bundle exec rake spec

data/.github/workflows/release.yaml

@@ -0,0 +1,23 @@
+name: deploy-release
+on:
+  push:
+    tags: '*'
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: '2.6.x'
+      - run: gem install bundler
+      - run: bundle install
+      - run: bundle exec rake spec
+      - name: setup credentials
+        env:
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+        run: |
+          mkdir -p ~/.gem
+          echo -e "---\r\n:rubygems_api_key: $RUBYGEMS_API_KEY" > ~/.gem/credentials
+          chmod 0600 ~/.gem/credentials
+      - run: bundle exec rake release

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in danger-jacoco.gemspec

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A guardfile for making Danger Plugins
 # For more info see https://github.com/guard/guard#readme
 

data/README.md

@@ -15,9 +15,16 @@ Add
 
 ```ruby
 jacoco.minimum_project_coverage_percentage = 50 # default 0
+jacoco.minimum_package_coverage_map = { # optional (default is empty)
+  'com/package/' => 55,
+  'com/package/more/specific/' => 15
+}
+jacoco.minimum_class_coverage_map = { # optional (default is empty)
+  'com/package/more/specific/ClassName' => 15
+}
 jacoco.minimum_class_coverage_percentage = 75 # default 0
 jacoco.files_extension = [".java"] # default [".kt", ".java"]
-jacoco.report "path/to/jacoco.xml"
+jacoco.report("path/to/jacoco.xml", "http://jacoco-html-reports/")
 ```
 
 to your `Dangerfile` 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'

data/danger-jacoco.gemspec

@@ -1,43 +1,45 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'jacoco/gem_version.rb'
+require 'jacoco/gem_version'
 
 Gem::Specification.new do |spec|
   spec.name          = 'danger-jacoco'
   spec.version       = Jacoco::VERSION
   spec.authors       = ['Anton Malinskiy']
   spec.email         = ['anton@malinskiy.com']
-  spec.description   = %q{A short description of danger-jacoco.}
-  spec.summary       = %q{A longer description of danger-jacoco.}
+  spec.description   = 'A short description of danger-jacoco.'
+  spec.summary       = 'A longer description of danger-jacoco.'
   spec.homepage      = 'https://github.com/Malinskiy/danger-jacoco'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
+  spec.required_ruby_version = '>= 2.6'
 
   spec.add_runtime_dependency 'danger-plugin-api', '~> 1.0'
   spec.add_runtime_dependency 'nokogiri-happymapper', '~> 0.6'
 
   # General ruby development
-  spec.add_development_dependency 'bundler', '~> 1.16'
-  spec.add_development_dependency 'rake', '~> 12.3'
+  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
 
   # Testing support
   spec.add_development_dependency 'rspec', '~> 3.7'
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.51"
-  spec.add_development_dependency "yard", "~> 0.9"
+  spec.add_development_dependency 'rubocop', '~> 1.14'
+  spec.add_development_dependency 'yard', '~> 0.9'
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
 
   # If you want to work on older builds of ruby
-  spec.add_development_dependency 'listen', '3.1.5'
+  spec.add_development_dependency 'listen', '3.5.1'
 
   # This gives you the chance to run a REPL inside your tests
   # via:

data/lib/danger_jacoco.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'jacoco/gem_version'

data/lib/danger_plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'jacoco/plugin'
 
 require 'jacoco/dom_parser'

data/lib/jacoco/dom_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Jacoco
   # DOM parser for Jacoco report
   class DOMParser

data/lib/jacoco/gem_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Jacoco
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.1.8'
 end

data/lib/jacoco/model/class.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 require 'jacoco/model/counter'
 require 'jacoco/model/method'

data/lib/jacoco/model/counter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 
 module Jacoco

data/lib/jacoco/model/group.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 require 'jacoco/model/group'
 require 'jacoco/model/package'

data/lib/jacoco/model/line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 require 'jacoco/model/counter'
 require 'jacoco/model/method'

data/lib/jacoco/model/method.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 require 'jacoco/model/counter'
 

data/lib/jacoco/model/package.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 require 'jacoco/model/class'
 require 'jacoco/model/sourcefile'

data/lib/jacoco/model/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 require 'jacoco/model/session_info'
 

data/lib/jacoco/model/session_info.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 
 module Jacoco

data/lib/jacoco/model/sourcefile.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'happymapper'
 
 module Jacoco

data/lib/jacoco/plugin.rb

@@ -1,21 +1,36 @@
+# frozen_string_literal: true
+
 require 'jacoco/sax_parser'
 
 module Danger
+  # Verify code coverage inside your projects
+  # This is done using the jacoco output
+  # Results are passed out as a table in markdown
+  #
+  # @example Verify coverage
+  #          jacoco.minimum_project_coverage_percentage = 50
+  #
+  # @example Verify coverage per package
+  #          jacoco.minimum_package_coverage_map = { # optional (default is empty)
+  #           'com/package/' => 55,
+  #           'com/package/more/specific/' => 15
+  #          }
   #
   # @see  Anton Malinskiy/danger-jacoco
   # @tags jacoco, coverage, java, android, kotlin
   #
-  class DangerJacoco < Plugin
-    attr_accessor :minimum_project_coverage_percentage
-    attr_accessor :minimum_class_coverage_percentage
-    attr_accessor :files_extension
-    attr_accessor :minimum_class_coverage_map
+  class DangerJacoco < Plugin # rubocop:disable Metrics/ClassLength
+    attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage, :files_extension,
+                  :minimum_package_coverage_map, :minimum_class_coverage_map, :fail_no_coverage_data_found, :title
 
+    # Initialize the plugin with configured parameters or defaults
     def setup
       @minimum_project_coverage_percentage = 0 unless minimum_project_coverage_percentage
       @minimum_class_coverage_percentage = 0 unless minimum_class_coverage_percentage
+      @minimum_package_coverage_map = {} unless minimum_package_coverage_map
       @minimum_class_coverage_map = {} unless minimum_class_coverage_map
       @files_extension = ['.kt', '.java'] unless files_extension
+      @title = 'JaCoCo' unless title
     end
 
     # Parses the xml output of jacoco to Ruby model classes
@@ -30,6 +45,7 @@ module Danger
     # This is a fast report based on SAX parser
     #
     # @path path to the xml output of jacoco
+    # @report_url URL where html report hosted
     # @delimiter git.modified_files returns full paths to the
     # changed files. We need to get the class from this path to check the
     # Jacoco report,
@@ -43,7 +59,9 @@ module Danger
     # Java => blah/blah/java/slashed_package/Source.java
     # Kotlin => blah/blah/kotlin/slashed_package/Source.kt
     #
-    def report(path, delimiter = %r{\/java\/|\/kotlin\/})
+    def report(path, report_url = '', delimiter = %r{/java/|/kotlin/}, fail_no_coverage_data_found: true)
+      @fail_no_coverage_data_found = fail_no_coverage_data_found
+
       setup
       classes = classes(delimiter)
 
@@ -52,10 +70,10 @@ module Danger
 
       total_covered = total_coverage(path)
 
-      report_markdown = "### JaCoCO Code Coverage #{total_covered[:covered]}% #{total_covered[:status]}\n"
-      report_markdown << "| Class | Covered | Meta | Status |\n"
-      report_markdown << "|:---:|:---:|:---:|:---:|\n"
-      class_coverage_above_minimum = markdown_class(parser, report_markdown)
+      report_markdown = "### #{title} Code Coverage #{total_covered[:covered]}% #{total_covered[:status]}\n"
+      report_markdown += "| Class | Covered | Meta | Status |\n"
+      report_markdown += "|:---|:---:|:---:|:---:|\n"
+      class_coverage_above_minimum = markdown_class(parser, report_markdown, report_url)
       markdown(report_markdown)
 
       report_fails(class_coverage_above_minimum, total_covered)
@@ -71,17 +89,49 @@ module Danger
 
     # It returns a specific class code coverage and an emoji status as well
     def report_class(jacoco_class)
+      report_result = {
+        covered: 'No coverage data found : -',
+        status: ':black_joker:',
+        required_coverage_percentage: 'No coverage data found : -'
+      }
+
       counter = coverage_counter(jacoco_class)
-      coverage = (counter.covered.fdiv(counter.covered + counter.missed) * 100).floor
-      required_coverage = minimum_class_coverage_map[jacoco_class.name]
+      unless counter.nil?
+        coverage = (counter.covered.fdiv(counter.covered + counter.missed) * 100).floor
+        required_coverage = required_class_coverage(jacoco_class)
+        status = coverage_status(coverage, required_coverage)
+
+        report_result = {
+          covered: coverage,
+          status: status,
+          required_coverage_percentage: required_coverage
+        }
+      end
+
+      report_result
+    end
+
+    # Determines the required coverage for the class
+    def required_class_coverage(jacoco_class)
+      key = minimum_class_coverage_map.keys.detect { |k| jacoco_class.name.match(k) } || jacoco_class.name
+      required_coverage = minimum_class_coverage_map[key]
+      required_coverage = package_coverage(jacoco_class.name) if required_coverage.nil?
       required_coverage = minimum_class_coverage_percentage if required_coverage.nil?
-      status = coverage_status(coverage, required_coverage)
+      required_coverage
+    end
 
-      {
-        covered: coverage,
-        status: status,
-        required_coverage_percentage: required_coverage
-      }
+    # it returns the most suitable coverage by package name to class or nil
+    def package_coverage(class_name)
+      path = class_name
+      package_parts = class_name.split('/')
+      package_parts.reverse_each do |item|
+        size = item.size
+        path = path[0...-size]
+        coverage = minimum_package_coverage_map[path]
+        path = path[0...-1] unless path.empty?
+        return coverage unless coverage.nil?
+      end
+      nil
     end
 
     # it returns an emoji for coverage status
@@ -116,7 +166,14 @@ module Danger
       branch_counter = counters.detect { |e| e.type.eql? 'BRANCH' }
       line_counter = counters.detect { |e| e.type.eql? 'LINE' }
       counter = branch_counter.nil? ? line_counter : branch_counter
-      raise "No coverage data found for #{jacoco_class.name}" if counter.nil?
+
+      if counter.nil?
+        no_coverage_data_found_message = "No coverage data found for #{jacoco_class.name}"
+
+        raise no_coverage_data_found_message if @fail_no_coverage_data_found.instance_of?(TrueClass)
+
+        warn no_coverage_data_found_message
+      end
 
       counter
     end
@@ -135,11 +192,12 @@ module Danger
     end
     # rubocop:enable Style/SignalException
 
-    def markdown_class(parser, report_markdown)
+    def markdown_class(parser, report_markdown, report_url)
       class_coverage_above_minimum = true
       parser.classes.each do |jacoco_class| # Check metrics for each classes
         rp = report_class(jacoco_class)
-        ln = "| `#{jacoco_class.name}` | #{rp[:covered]}% | #{rp[:required_coverage_percentage]}% | #{rp[:status]} |\n"
+        rl = report_link(jacoco_class.name, report_url)
+        ln = "| #{rl} | #{rp[:covered]}% | #{rp[:required_coverage_percentage]}% | #{rp[:status]} |\n"
         report_markdown << ln
 
         class_coverage_above_minimum &&= rp[:covered] >= rp[:required_coverage_percentage]
@@ -147,5 +205,14 @@ module Danger
 
       class_coverage_above_minimum
     end
+
+    def report_link(class_name, report_url)
+      if report_url.empty?
+        "`#{class_name}`"
+      else
+        report_filepath = "#{class_name.gsub(%r{/(?=[^/]*/.)}, '.')}.html"
+        "[`#{class_name}`](#{report_url + report_filepath})"
+      end
+    end
   end
 end

data/lib/jacoco/sax_parser.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require 'nokogiri'
 
 module Jacoco
   # Sax parser for quickly finding class elements in Jacoco report
   class SAXParser < Nokogiri::XML::SAX::Document
-    attr_accessor :class_names
-    attr_accessor :classes
+    attr_accessor :class_names, :classes
 
     def initialize(classes)
+      super()
       @class_names      = classes
       @classes          = []
       @current_class    = nil
@@ -38,14 +40,13 @@ module Jacoco
     def start_class(attrs)
       @subelement_index = 0
 
-      if @class_names.include?(Hash[attrs]['name'])
-        c              = Jacoco::Class.new
-        c.name         = Hash[attrs]['name']
-        c.counters     = []
-        @current_class = c
-        @classes.push c
-      elsif @current_class.nil?
-      end
+      return unless @class_names.include?(Hash[attrs]['name'])
+
+      c              = Jacoco::Class.new
+      c.name         = Hash[attrs]['name']
+      c.counters     = []
+      @current_class = c
+      @classes.push c
     end
 
     def characters(string); end

data/spec/fixtures/output_b.xml

@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.0//EN"
+        "report.dtd">
+<report name="test_report">
+  <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
+  <package name="com/example">
+    <class name="com/example/CachedRepository">
+      <method name="&lt;init&gt;" desc="()V" line="17">
+        <counter type="INSTRUCTION" missed="0" covered="11"/>
+        <counter type="COMPLEXITY" missed="0" covered="1"/>
+        <counter type="METHOD" missed="0" covered="1"/>
+      </method>
+      <counter type="INSTRUCTION" missed="0" covered="46"/>
+      <counter type="COMPLEXITY" missed="5" covered="7"/>
+      <counter type="METHOD" missed="0" covered="7"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+    </class>
+    <sourcefile name="CachedRepository.java">
+      <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
+      <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
+      <counter type="INSTRUCTION" missed="2" covered="98"/>
+      <counter type="COMPLEXITY" missed="2" covered="11"/>
+      <counter type="METHOD" missed="2" covered="11"/>
+      <counter type="CLASS" missed="2" covered="4"/>
+    </sourcefile>
+    <counter type="INSTRUCTION" missed="80" covered="324"/>
+    <counter type="COMPLEXITY" missed="11" covered="39"/>
+    <counter type="METHOD" missed="9" covered="37"/>
+    <counter type="CLASS" missed="2" covered="10"/>
+  </package>
+  <counter type="INSTRUCTION" missed="39399" covered="19321"/>
+  <counter type="COMPLEXITY" missed="5517" covered="1444"/>
+  <counter type="METHOD" missed="3382" covered="1120"/>
+  <counter type="CLASS" missed="491" covered="370"/>
+</report>

data/spec/jacoco_spec.rb

@@ -1,16 +1,21 @@
-require File.expand_path("../spec_helper", __FILE__)
+# frozen_string_literal: true
 
-module Danger
+# rubocop:disable Layout/LineLength
+# rubocop:disable Metrics/ModuleLength
+# rubocop:disable Metrics/BlockLength
+
+require File.expand_path('spec_helper', __dir__)
 
+module Danger
   describe Danger::DangerJacoco do
-    it "should be a plugin" do
+    it 'should be a plugin' do
       expect(Danger::DangerJacoco.new(nil)).to be_a Danger::Plugin
     end
 
     #
     # You should test your custom attributes and methods here
     #
-    describe "with Dangerfile" do
+    describe 'with Dangerfile' do
       before do
         @dangerfile = testing_dangerfile
         @my_plugin = @dangerfile.jacoco
@@ -20,27 +25,154 @@ module Danger
 
         allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
         allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
+      end
+
+      it :report do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
+
+        @my_plugin.report path_a
 
+        expect(@dangerfile.status_report[:errors]).to eq(['Total coverage of 32.9%. Improve this to at least 50%',
+                                                          'Class coverage is below minimum. Improve to at least 0%'])
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 32.9% :warning:')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Meta | Status |')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('|:---|:---:|:---:|:---:|')
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 100% | :warning: |')
       end
 
+      it 'test regex class coverage' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
-      it :report do
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_class_coverage_map = { '.*Repository' => 60 }
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 60% | :warning: |')
+      end
+
+      it 'test with package coverage' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_package_coverage_map = { 'com/example/' => 70 }
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 70% | :warning: |')
+      end
+
+      it 'test with bigger overlapped package coverage' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_package_coverage_map = {
+          'com/example/' => 70,
+          'com/' => 90
+        }
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 70% | :warning: |')
+      end
+
+      it 'test with lower overlapped package coverage' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_package_coverage_map = {
+          'com/example/' => 77,
+          'com/' => 30
+        }
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 77% | :warning: |')
+      end
+
+      it 'test with overlapped package coverage and bigger class coverage' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_package_coverage_map = {
+          'com/example/' => 77,
+          'com/' => 30
+        }
+        @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 100% | :warning: |')
+      end
+
+      it 'test with overlapped package coverage and lowwer class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
         @my_plugin.minimum_project_coverage_percentage = 50
-        @my_plugin.minimum_class_coverage_map = { "com/example/CachedRepository" => 100}
+        @my_plugin.minimum_package_coverage_map = {
+          'com/example/' => 90,
+          'com/' => 85
+        }
+        @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 80 }
 
         @my_plugin.report path_a
 
-        expect(@dangerfile.status_report[:errors]).to eq(["Total coverage of 32.9%. Improve this to at least 50%",
-                                                          "Class coverage is below minimum. Improve to at least 0%"])
-        expect(@dangerfile.status_report[:markdowns][0].message).to include("### JaCoCO Code Coverage 32.9% :warning:")
-        expect(@dangerfile.status_report[:markdowns][0].message).to include("| Class | Covered | Meta | Status |")
-        expect(@dangerfile.status_report[:markdowns][0].message).to include("|:---:|:---:|:---:|:---:|")
-        expect(@dangerfile.status_report[:markdowns][0].message).to include("| `com/example/CachedRepository` | 50% | 100% | :warning: |")
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 80% | :warning: |')
+      end
+
+      it 'adds a link to report' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        @my_plugin.report(path_a, 'http://test.com/')
 
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| [`com/example/CachedRepository`](http://test.com/com.example/CachedRepository.html) | 50% | 80% | :warning: |')
       end
 
+      it 'When option "fail_no_coverage_data_found" is set to optionally fail, it doesn\'t fail the execution' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report(path_a, fail_no_coverage_data_found: true) }.to_not raise_error(RuntimeError)
+      end
+
+      it 'When option "fail_no_coverage_data_found" is not set, the execution fails on empty data' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report path_a }.to raise_error(RuntimeError)
+      end
+
+      it 'When option "fail_no_coverage_data_found" is set to optionally fail, the execution fails on empty data' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report path_a, fail_no_coverage_data_found: true }.to raise_error(RuntimeError)
+      end
+
+      it 'When option "fail_no_coverage_data_found" is set to optionally warn (not fail), the execution doesn\'t fail on empty data' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_b.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        expect { @my_plugin.report path_a, fail_no_coverage_data_found: false }.to_not raise_error(RuntimeError)
+      end
     end
   end
 end
+
+# rubocop:enable Layout/LineLength
+# rubocop:enable Metrics/ModuleLength
+# rubocop:enable Metrics/BlockLength

data/spec/spec_helper.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
-$LOAD_PATH.unshift((ROOT + 'lib').to_s)
-$LOAD_PATH.unshift((ROOT + 'spec').to_s)
+ROOT = Pathname.new(File.expand_path('..', __dir__))
+$LOAD_PATH.unshift("#{ROOT}lib".to_s)
+$LOAD_PATH.unshift("#{ROOT}spec".to_s)
 
 require 'bundler/setup'
 require 'pry'
@@ -16,6 +18,8 @@ RSpec.configure do |config|
   config.tty = true
 end
 
+RSpec::Expectations.configuration.on_potential_false_positives = :nothing
+
 require 'danger_plugin'
 
 # These functions are a subset of https://github.com/danger/danger/blob/master/spec/spec_helper.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.8
 platform: ruby
 authors:
 - Anton Malinskiy
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-10-26 00:00:00.000000000 Z
+date: 2021-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '1.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.51'
+        version: '1.14'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +142,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.5
+        version: 3.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.1.5
+        version: 3.5.1
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -171,9 +171,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
+- ".github/workflows/ci.yaml"
+- ".github/workflows/release.yaml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -196,13 +198,14 @@ files:
 - lib/jacoco/plugin.rb
 - lib/jacoco/sax_parser.rb
 - spec/fixtures/output_a.xml
+- spec/fixtures/output_b.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/Malinskiy/danger-jacoco
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -210,19 +213,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: A longer description of danger-jacoco.
 test_files:
 - spec/fixtures/output_a.xml
+- spec/fixtures/output_b.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb

data/.travis.yml

@@ -1,12 +0,0 @@
-language: ruby
-cache:
-  directories:
-    - bundle
-
-rvm:
-  - 2.0
-  - 2.1.3
-  - 2.3.1
-
-script:
-    - bundle exec rake spec