danger-jacoco 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bbe04fa92db358efe7b876a9cc4a96ba345fed7f
-  data.tar.gz: 4ee1125c139adce7f13e98ff8233a1ddae339640
+  metadata.gz: 41f06316cc4d1805a8a86dbd4957500b059b1a96
+  data.tar.gz: f03bd63af127ad7b93e4e284602451e6307e6f34
 SHA512:
-  metadata.gz: 3b781beccdd7e277ed4a6296864ea3e1fb56315aa0bb636ae4e0002b758cd0dc5f55702e0c0380f4007501f1a87ff405e7c460cb349fd02eacba7c3d52f49acf
-  data.tar.gz: c3708a9d043202c10748711683cfefddab20808eec536c2790a3f56ec463f47b306224fa6303f8c5d54174fc8e31ca38083629c5116ea2293a5fca66f71f3e63
+  metadata.gz: 472aaa07a8b9592fd940054882f52d03207cdc45a9d4703bda6fe087fd03f0da54a5409f0a2f8f1437cdb9b58b675a06ffbc97c8cb325a69c47275c51e7644e4
+  data.tar.gz: da9c29738c04da81dde72eda8320209339dbbb4b2f9a6f91cf4a61ae9f283439182fd64c8b2aa4a5e7a05716300d523c5e619815bcc7b7a10ba2d1d47ebaf8d6

data/README.md

@@ -17,7 +17,7 @@ Add
 jacoco.minimum_project_coverage_percentage = 50 # default 0
 jacoco.minimum_class_coverage_percentage = 75 # default 0
 jacoco.files_extension = [".java"] # default [".kt", ".java"]
-jacoco.report "path/to/jacoco.xml"
+jacoco.report("path/to/jacoco.xml", "http://jacoco-html-reports/")
 ```
 
 to your `Dangerfile` 

data/lib/jacoco/gem_version.rb

@@ -1,3 +1,3 @@
 module Jacoco
-  VERSION = '0.1.3'.freeze
+  VERSION = '0.1.4'.freeze
 end

data/lib/jacoco/plugin.rb

@@ -30,6 +30,7 @@ module Danger
     # This is a fast report based on SAX parser
     #
     # @path path to the xml output of jacoco
+    # @report_url URL where html report hosted
     # @delimiter git.modified_files returns full paths to the
     # changed files. We need to get the class from this path to check the
     # Jacoco report,
@@ -43,7 +44,7 @@ module Danger
     # Java => blah/blah/java/slashed_package/Source.java
     # Kotlin => blah/blah/kotlin/slashed_package/Source.kt
     #
-    def report(path, delimiter = %r{\/java\/|\/kotlin\/})
+    def report(path, report_url = '', delimiter = %r{\/java\/|\/kotlin\/})
       setup
       classes = classes(delimiter)
 
@@ -54,8 +55,8 @@ module Danger
 
       report_markdown = "### JaCoCO Code Coverage #{total_covered[:covered]}% #{total_covered[:status]}\n"
       report_markdown << "| Class | Covered | Meta | Status |\n"
-      report_markdown << "|:---:|:---:|:---:|:---:|\n"
-      class_coverage_above_minimum = markdown_class(parser, report_markdown)
+      report_markdown << "|:---|:---:|:---:|:---:|\n"
+      class_coverage_above_minimum = markdown_class(parser, report_markdown, report_url)
       markdown(report_markdown)
 
       report_fails(class_coverage_above_minimum, total_covered)
@@ -135,11 +136,12 @@ module Danger
     end
     # rubocop:enable Style/SignalException
 
-    def markdown_class(parser, report_markdown)
+    def markdown_class(parser, report_markdown, report_url)
       class_coverage_above_minimum = true
       parser.classes.each do |jacoco_class| # Check metrics for each classes
         rp = report_class(jacoco_class)
-        ln = "| `#{jacoco_class.name}` | #{rp[:covered]}% | #{rp[:required_coverage_percentage]}% | #{rp[:status]} |\n"
+        rl = report_link(jacoco_class.name, report_url)
+        ln = "| #{rl} | #{rp[:covered]}% | #{rp[:required_coverage_percentage]}% | #{rp[:status]} |\n"
         report_markdown << ln
 
         class_coverage_above_minimum &&= rp[:covered] >= rp[:required_coverage_percentage]
@@ -147,5 +149,15 @@ module Danger
 
       class_coverage_above_minimum
     end
+
+    def report_link(class_name, report_url)
+      if report_url.empty?
+          "`#{class_name}`"
+      else 
+          report_filepath = class_name.gsub(/\/(?=[^\/]*\/.)/, '.') + ".html"
+          "[`#{class_name}`](#{report_url + report_filepath})"
+      end
+    end
+
   end
 end

data/spec/jacoco_spec.rb

@@ -36,11 +36,23 @@ module Danger
                                                           "Class coverage is below minimum. Improve to at least 0%"])
         expect(@dangerfile.status_report[:markdowns][0].message).to include("### JaCoCO Code Coverage 32.9% :warning:")
         expect(@dangerfile.status_report[:markdowns][0].message).to include("| Class | Covered | Meta | Status |")
-        expect(@dangerfile.status_report[:markdowns][0].message).to include("|:---:|:---:|:---:|:---:|")
+        expect(@dangerfile.status_report[:markdowns][0].message).to include("|:---|:---:|:---:|:---:|")
         expect(@dangerfile.status_report[:markdowns][0].message).to include("| `com/example/CachedRepository` | 50% | 100% | :warning: |")
 
       end
 
+      it 'adds a link to report' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_project_coverage_percentage = 50
+
+        @my_plugin.report(path_a, 'http://test.com/')
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include("| [`com/example/CachedRepository`](http://test.com/com.example/CachedRepository.html) | 50% | 80% | :warning: |")
+
+      end
+    
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Anton Malinskiy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-26 00:00:00.000000000 Z
+date: 2019-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api