danger-jacoco 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 371b0dde165ac428614147067f7e6afb770a5612
-  data.tar.gz: 8ca1e6cdcee1c395c4627c6a41254ea80b64a43c
+  metadata.gz: bbe04fa92db358efe7b876a9cc4a96ba345fed7f
+  data.tar.gz: 4ee1125c139adce7f13e98ff8233a1ddae339640
 SHA512:
-  metadata.gz: d216754af4136b642921a1bae373a437e97cf0f99326be3260d8b77bfa02aa94735eab6077f0cc1721d57e2fea6e917f7c6effec83c4cfe94d1f04f9650ec411
-  data.tar.gz: 02f1ffc71d5eac688733f5165f6cf9152df4542d4f29d2f3ad20b3ddb635b964f9bf05124c211998fe75073cd625fb01506dde6600d36280510e3003246946dd
+  metadata.gz: 3b781beccdd7e277ed4a6296864ea3e1fb56315aa0bb636ae4e0002b758cd0dc5f55702e0c0380f4007501f1a87ff405e7c460cb349fd02eacba7c3d52f49acf
+  data.tar.gz: c3708a9d043202c10748711683cfefddab20808eec536c2790a3f56ec463f47b306224fa6303f8c5d54174fc8e31ca38083629c5116ea2293a5fca66f71f3e63

data/lib/jacoco/gem_version.rb

@@ -1,3 +1,3 @@
 module Jacoco
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.1.3'.freeze
 end

data/lib/jacoco/plugin.rb

@@ -9,10 +9,12 @@ module Danger
     attr_accessor :minimum_project_coverage_percentage
     attr_accessor :minimum_class_coverage_percentage
     attr_accessor :files_extension
+    attr_accessor :minimum_class_coverage_map
 
     def setup
       @minimum_project_coverage_percentage = 0 unless minimum_project_coverage_percentage
       @minimum_class_coverage_percentage = 0 unless minimum_class_coverage_percentage
+      @minimum_class_coverage_map = {} unless minimum_class_coverage_map
       @files_extension = ['.kt', '.java'] unless files_extension
     end
 
@@ -71,11 +73,14 @@ module Danger
     def report_class(jacoco_class)
       counter = coverage_counter(jacoco_class)
       coverage = (counter.covered.fdiv(counter.covered + counter.missed) * 100).floor
-      status = coverage_status(coverage, minimum_class_coverage_percentage)
+      required_coverage = minimum_class_coverage_map[jacoco_class.name]
+      required_coverage = minimum_class_coverage_percentage if required_coverage.nil?
+      status = coverage_status(coverage, required_coverage)
 
       {
         covered: coverage,
-        status: status
+        status: status,
+        required_coverage_percentage: required_coverage
       }
     end
 
@@ -128,15 +133,16 @@ module Danger
 
       fail("Class coverage is below minimum. Improve to at least #{minimum_class_coverage_percentage}%")
     end
+    # rubocop:enable Style/SignalException
 
     def markdown_class(parser, report_markdown)
       class_coverage_above_minimum = true
       parser.classes.each do |jacoco_class| # Check metrics for each classes
         rp = report_class(jacoco_class)
-        ln = "| `#{jacoco_class.name}` | #{rp[:covered]}% | #{minimum_class_coverage_percentage}% | #{rp[:status]} |\n"
+        ln = "| `#{jacoco_class.name}` | #{rp[:covered]}% | #{rp[:required_coverage_percentage]}% | #{rp[:status]} |\n"
         report_markdown << ln
 
-        class_coverage_above_minimum &&= rp[:covered] >= minimum_class_coverage_percentage
+        class_coverage_above_minimum &&= rp[:covered] >= rp[:required_coverage_percentage]
       end
 
       class_coverage_above_minimum

data/spec/fixtures/output_a.xml

@@ -3,7 +3,7 @@
 <report name="test_report">
   <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
   <package name="com/example">
-    <class name="com/example/MemoryCache">
+    <class name="com/example/CachedRepository">
       <method name="&lt;init&gt;" desc="()V" line="17">
         <counter type="INSTRUCTION" missed="0" covered="11"/>
         <counter type="LINE" missed="0" covered="5"/>
@@ -12,18 +12,19 @@
       </method>
       <counter type="INSTRUCTION" missed="0" covered="46"/>
       <counter type="LINE" missed="0" covered="14"/>
-      <counter type="COMPLEXITY" missed="0" covered="7"/>
+      <counter type="COMPLEXITY" missed="5" covered="7"/>
       <counter type="METHOD" missed="0" covered="7"/>
       <counter type="CLASS" missed="0" covered="1"/>
+      <counter type="BRANCH" missed="2" covered="2" />
     </class>
     <sourcefile name="CachedRepository.java">
       <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
       <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
-      <counter type="INSTRUCTION" missed="0" covered="98"/>
-      <counter type="LINE" missed="0" covered="19"/>
-      <counter type="COMPLEXITY" missed="0" covered="11"/>
-      <counter type="METHOD" missed="0" covered="11"/>
-      <counter type="CLASS" missed="0" covered="4"/>
+      <counter type="INSTRUCTION" missed="2" covered="98"/>
+      <counter type="LINE" missed="2" covered="19"/>
+      <counter type="COMPLEXITY" missed="2" covered="11"/>
+      <counter type="METHOD" missed="2" covered="11"/>
+      <counter type="CLASS" missed="2" covered="4"/>
     </sourcefile>
     <counter type="INSTRUCTION" missed="80" covered="324"/>
     <counter type="BRANCH" missed="4" covered="4"/>

data/spec/jacoco_spec.rb

@@ -1,13 +1,46 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path("../spec_helper", __FILE__)
 
-module Jacoco
-  describe Jacoco::DOMParser do
-    path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+module Danger
+
+  describe Danger::DangerJacoco do
+    it "should be a plugin" do
+      expect(Danger::DangerJacoco.new(nil)).to be_a Danger::Plugin
+    end
+
+    #
+    # You should test your custom attributes and methods here
+    #
+    describe "with Dangerfile" do
+      before do
+        @dangerfile = testing_dangerfile
+        @my_plugin = @dangerfile.jacoco
+
+        modified_files = ['src/java/com/example/CachedRepository.java']
+        added_files = ['src/java/Blah.java']
+
+        allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
+        allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
 
-    describe 'read xml' do
-      it 'reads report' do
-        Jacoco::DOMParser.read_path(path_a)
       end
+
+
+      it :report do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 50
+        @my_plugin.minimum_class_coverage_map = { "com/example/CachedRepository" => 100}
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:errors]).to eq(["Total coverage of 32.9%. Improve this to at least 50%",
+                                                          "Class coverage is below minimum. Improve to at least 0%"])
+        expect(@dangerfile.status_report[:markdowns][0].message).to include("### JaCoCO Code Coverage 32.9% :warning:")
+        expect(@dangerfile.status_report[:markdowns][0].message).to include("| Class | Covered | Meta | Status |")
+        expect(@dangerfile.status_report[:markdowns][0].message).to include("|:---:|:---:|:---:|:---:|")
+        expect(@dangerfile.status_report[:markdowns][0].message).to include("| `com/example/CachedRepository` | 50% | 100% | :warning: |")
+
+      end
+
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Anton Malinskiy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-14 00:00:00.000000000 Z
+date: 2018-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api