danger-jacoco 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e8caafe32ed85b587ff05493d8787e293aaad3eb
-  data.tar.gz: fded83a5dbdae6209dd1986b761b9c861d6ccd01
+  metadata.gz: df5403f35daa0b6089984099c9aa4e6457f21a40
+  data.tar.gz: e487698753b72030f1be8d2ea20021f25c690c74
 SHA512:
-  metadata.gz: 7b91364232e571798fe45bf8b0911bd09fca607b3e6e1ca04a384052bdedd4b206251694cac69d376c9240633b72a5af119b31271be8411f1fa35199b83cdf42
-  data.tar.gz: 144d396fad44caa4ddc756139861a14bda5b3ee2f336772abaf7ff55a960bea795fe06fdf00abbaf3157d744e9f3b9a94bd96f99a272ef105f4482eceeb52323
+  metadata.gz: b661f9d21c87564e0693be598152a0d1b06f1579d28b3b19e679c304682498c1ad74e0f4729cfb474a904be7369078e24da9649830ad21b84e32026c84cc631e
+  data.tar.gz: 50b915a03189ebc3830ab5f6afb852862e35f72da0b63f4b70e39b1d0e0f427b4c70123212cc31a5da08dbfbf4c425bf97d5790eb071671e4c2a4e9bbff5d923

data/lib/jacoco/gem_version.rb

@@ -1,3 +1,3 @@
 module Jacoco
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/lib/jacoco/plugin.rb

@@ -53,14 +53,10 @@ module Danger
       report_markdown = "### JaCoCO Code Coverage #{total_covered[:covered]}% #{total_covered[:status]}\n"
       report_markdown << "| Class | Covered | Meta | Status |\n"
       report_markdown << "|:---:|:---:|:---:|:---:|\n"
-      markdown_class(parser, report_markdown)
+      class_coverage_above_minimum = markdown_class(parser, report_markdown)
       markdown(report_markdown)
 
-      return if total_covered[:covered] >= minimum_project_coverage_percentage
-
-      # fail danger if total coveraged is smaller than minimum_project_coverage_percentage
-      covered = total_covered[:covered]
-      raise("Total coverage of #{covered}%. Improve this to as least #{minimum_project_coverage_percentage} %")
+      report_fails(class_coverage_above_minimum, total_covered)
     end
 
     # Select modified and added files in this PR
@@ -113,12 +109,30 @@ module Danger
 
     private
 
+    # rubocop:disable Style/SignalException
+    def report_fails(class_coverage_above_minimum, total_covered)
+      if total_covered[:covered] < minimum_project_coverage_percentage
+        # fail danger if total coverage is smaller than minimum_project_coverage_percentage
+        covered = total_covered[:covered]
+        fail("Total coverage of #{covered}%. Improve this to at least #{minimum_project_coverage_percentage}%")
+      end
+
+      return if class_coverage_above_minimum
+
+      fail("Class coverage is below minimum. Improve to at least #{minimum_class_coverage_percentage}%")
+    end
+
     def markdown_class(parser, report_markdown)
+      class_coverage_above_minimum = true
       parser.classes.each do |jacoco_class| # Check metrics for each classes
         rp = report_class(jacoco_class)
         ln = "| `#{jacoco_class.name}` | #{rp[:covered]}% | #{minimum_class_coverage_percentage}% | #{rp[:status]} |\n"
         report_markdown << ln
+
+        class_coverage_above_minimum &&= rp[:covered] >= minimum_class_coverage_percentage
       end
+
+      class_coverage_above_minimum
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Anton Malinskiy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-04 00:00:00.000000000 Z
+date: 2018-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -175,7 +175,6 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - Guardfile
 - LICENSE.txt
 - README.md