danger-jacoco-instacart 0.1.15 → 0.1.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0dd4a48316de722878c9a9a93259094c27b8ac841391399eb11bfec956379fee
-  data.tar.gz: 8d0f4f5cdaa727efd0d6edcc119790661bc9c63b1e28a16d3fce4adc7f6239ba
+  metadata.gz: 3b3e380696d9d2e8ce64b52d20baa6c09aa53259133e6b256769929e68b1d32b
+  data.tar.gz: b33b2c86616b7f93aeda7a669a3b27882a08b6a38205895636da62ae73e3a022
 SHA512:
-  metadata.gz: b8eb83937c2a0cf5b1fad92fa98c160d9cc481793b3eeb51f1b8a71239ecc8cd0bcd4b5f6d32fc093c5b01a4cfba9e4bd119b66e13ebd58d797ca9486e3a3e72
-  data.tar.gz: 14567a96d7cb741c17a5dbaff165ee9bc6dd09b3e293319c644081938a20c7f6bcfe363cb34d9370f0a1b637fb8d89788f8d00632b2c164e628c510821330b3b
+  metadata.gz: 2ae620e33819d2e1ce7a13b3e2633071e5564ac3fe01a201b429f32364b47069fae9cb28e736f7f8a23bf94c03552d82171473df4561c070e79ff86cdcb3dd8e
+  data.tar.gz: 4e18673c11b8147510fcf5e1456b11145b8632d32de75005fcd3702e71515284ea219389ae41e4e61932d7f472454ee119d9167b4000df88ce18c664407f01ec

data/.rubocop.yml

@@ -1,4 +1,4 @@
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 Metrics/MethodLength:
   Max: 20

data/README.md

@@ -35,5 +35,11 @@ to your `Dangerfile`
 1. Clone this repo
 2. Run `bundle install` to setup dependencies.
 3. Run `bundle exec rake spec` to run the tests.
+4. Run `bundle exec rubocop -A` to fix in-place what's fixable
 4. Use `bundle exec guard` to automatically have tests run as you make changes.
 5. Make your changes.
+
+### How to release new version
+1. Bump version in `lib/jacoco/gem_version.rb - X.Y.Z`
+2. `rake build`
+3. `gem push pkg/danger-jacoco-instacart-X.Y.Z.gem` 

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.15'
+  VERSION = '0.1.17'
 end

data/lib/jacoco/plugin.rb

@@ -105,14 +105,61 @@ module Danger
 
     def classes(delimiter)
       class_to_file_path_hash = {}
-      files_to_check.select { |file| files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
-                    .each do |file| # "src/java/com/example/CachedRepository.java"
-                      classname = file.split('.').first.split(delimiter)[1] # "com/example/CachedRepository"
-                      class_to_file_path_hash[classname] = file
-                    end
+      # Initialize files_extension if it's nil
+      @files_extension = ['.kt', '.java'] if @files_extension.nil?
+
+      filtered_files_to_check.each do |file| # "src/java/com/example/CachedRepository.java"
+        # Get the package path
+        package_path = file.split('.').first.split(delimiter)[1] # "com/example/CachedRepository"
+        next unless package_path
+
+        # Add the primary class (filename-based class)
+        class_to_file_path_hash[package_path] = file
+
+        # For Kotlin files, we need to look for multiple classes/interfaces in the same file
+        add_kotlin_declarations(file, package_path, class_to_file_path_hash) if file.end_with?('.kt')
+      end
       class_to_file_path_hash
     end
 
+    # Returns files that match the configured file extensions
+    def filtered_files_to_check
+      files_to_check.select { |file| @files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
+    end
+
+    # Scans a Kotlin file for additional class/interface declarations and adds them to the hash
+    def add_kotlin_declarations(file, package_path, class_to_file_path_hash)
+      return unless File.exist?(file)
+
+      file_content = File.read(file)
+
+      # Kotlin compiles top-level functions (e.g. @Composable funs) into a `<FileNameKt>` class.
+      # Always register it — the SAX parser skips it silently if it's absent from the XML.
+      parts = package_path.split('/')
+      kt_class_path = (parts[0..-2] + ["#{parts[-1]}Kt"]).join('/')
+      class_to_file_path_hash[kt_class_path] = file
+
+      # Look for class and interface declarations in the file
+      # Regex catches class/interface/object declarations with modifiers and generics
+      regex = /\b(?:(?:data|sealed|abstract|open|internal|private|protected|public|inline)\s+)*
+               (?:class|interface|object)\s+([A-Za-z0-9_]+)(?:<.*?>)?/x
+      declarations = file_content.scan(regex).flatten
+
+      # For each additional class/interface found (excluding the one matching the filename)
+      declarations.each do |class_name|
+        # Skip if it matches the primary class name (already added)
+        next if package_path.end_with?("/#{class_name}")
+
+        # Create full class path by replacing the last part with the class name
+        parts = package_path.split('/')
+        parts[-1] = class_name
+        additional_class_path = parts.join('/')
+
+        # Add to hash
+        class_to_file_path_hash[additional_class_path] = file
+      end
+    end
+
     # It returns a specific class code coverage and an emoji status as well
     def report_class(jacoco_class, file_path)
       report_result = {

data/spec/fixtures/output_g.xml

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.0//EN"
+        "report.dtd">
+<report name="test_report">
+  <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
+  <package name="com/example">
+    <class name="com/example/TopLevelFunctionsKt">
+      <counter type="INSTRUCTION" missed="5" covered="15"/>
+      <counter type="LINE" missed="1" covered="4"/>
+      <counter type="COMPLEXITY" missed="1" covered="3"/>
+      <counter type="METHOD" missed="1" covered="3"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+    </class>
+    <sourcefile name="TopLevelFunctions.kt">
+      <counter type="INSTRUCTION" missed="5" covered="15"/>
+      <counter type="LINE" missed="1" covered="4"/>
+      <counter type="COMPLEXITY" missed="1" covered="3"/>
+      <counter type="METHOD" missed="1" covered="3"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+    </sourcefile>
+    <counter type="INSTRUCTION" missed="5" covered="15"/>
+    <counter type="BRANCH" missed="0" covered="0"/>
+    <counter type="LINE" missed="1" covered="4"/>
+    <counter type="COMPLEXITY" missed="1" covered="3"/>
+    <counter type="METHOD" missed="1" covered="3"/>
+    <counter type="CLASS" missed="0" covered="1"/>
+  </package>
+  <counter type="INSTRUCTION" missed="5" covered="15"/>
+  <counter type="BRANCH" missed="0" covered="0"/>
+  <counter type="LINE" missed="1" covered="4"/>
+  <counter type="COMPLEXITY" missed="1" covered="3"/>
+  <counter type="METHOD" missed="1" covered="3"/>
+  <counter type="CLASS" missed="0" covered="1"/>
+</report>

data/spec/jacoco_spec.rb

@@ -384,6 +384,110 @@ module Danger
           expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 55% | :warning: |')
         end
       end
+
+      it 'detects top-level Kotlin functions file via the generated Kt-suffixed class' do
+        path_g = "#{File.dirname(__FILE__)}/fixtures/output_g.xml"
+
+        kotlin_file_path = 'src/kotlin/com/example/TopLevelFunctions.kt'
+        kotlin_file_content = <<~KOTLIN
+          package com.example
+
+          @Composable
+          fun FirstComposable() {}
+
+          @Composable
+          fun SecondComposable() {}
+        KOTLIN
+
+        allow(File).to receive(:exist?).and_call_original
+        allow(File).to receive(:exist?).with(kotlin_file_path).and_return(true)
+        allow(File).to receive(:read).and_call_original
+        allow(File).to receive(:read).with(kotlin_file_path).and_return(kotlin_file_content)
+
+        @my_plugin.files_to_check = [kotlin_file_path]
+        @my_plugin.minimum_project_coverage_percentage = 0
+        @my_plugin.minimum_class_coverage_percentage = 80
+        @my_plugin.minimum_composable_class_coverage_percentage = 80
+
+        class_file_hash = @my_plugin.classes(%r{/kotlin/})
+        expect(class_file_hash.keys).to include('com/example/TopLevelFunctionsKt')
+
+        @my_plugin.report path_g
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/TopLevelFunctionsKt` | 75% | 80% | :warning: |')
+      end
+
+      it 'test with kotlin multiples classes in same file' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        # Mock the Kotlin file with multiple classes
+        kotlin_file_path = 'src/kotlin/com/example/MultiClass.kt'
+        kotlin_file_content = <<~KOTLIN
+          package com.example
+
+          class MultiClass {
+            // some code
+          }
+
+          data class DataClass(val property: String) {
+            // some code
+          }
+
+          sealed class SealedClass {
+            // some code
+          }
+
+          private class PrivateClass {
+            // some code
+          }
+
+          abstract class AbstractClass {
+            // some code
+          }
+
+          class GenericClass<T> {
+            // some code
+          }
+
+          interface SomeInterface {
+            // some code
+          }
+
+          object SingletonObject {
+            // some code
+          }
+        KOTLIN
+
+        allow(File).to receive(:exist?).and_call_original
+        allow(File).to receive(:exist?).with(kotlin_file_path).and_return(true)
+        allow(File).to receive(:read).and_call_original
+        allow(File).to receive(:read).with(kotlin_file_path).and_return(kotlin_file_content)
+
+        @my_plugin.files_to_check = [kotlin_file_path]
+        @my_plugin.minimum_project_coverage_percentage = 0 # Avoid project coverage errors
+
+        # Use a block to capture the key-value pairs passed to classes
+        expect { |b| @my_plugin.classes(%r{/kotlin/}).each(&b) }.to yield_control.at_least(8).times
+
+        # Call report
+        @my_plugin.report path_a
+
+        # Check the class-to-file hash from SAXParser
+        class_file_hash = @my_plugin.classes(%r{/kotlin/})
+        expect(class_file_hash.keys).to include('com/example/MultiClass')
+        expect(class_file_hash.keys).to include('com/example/DataClass')
+        expect(class_file_hash.keys).to include('com/example/SealedClass')
+        expect(class_file_hash.keys).to include('com/example/PrivateClass')
+        expect(class_file_hash.keys).to include('com/example/AbstractClass')
+        expect(class_file_hash.keys).to include('com/example/GenericClass')
+        expect(class_file_hash.keys).to include('com/example/SomeInterface')
+        expect(class_file_hash.keys).to include('com/example/SingletonObject')
+
+        # All keys should map to the same file path
+        class_file_hash.each_value do |file_path|
+          expect(file_path).to eq(kotlin_file_path)
+        end
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -29,7 +29,6 @@ require 'danger_plugin'
 # it comes with an extra function `.string` which will
 # strip all ANSI colours from the string.
 
-# rubocop:disable Lint/NestedMethodDefinition
 def testing_ui
   @output = StringIO.new
   def @output.winsize
@@ -42,7 +41,6 @@ def testing_ui
   end
   cork
 end
-# rubocop:enable Lint/NestedMethodDefinition
 
 # Example environment (ENV) that would come from
 # running a PR on TravisCI

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco-instacart
 version: !ruby/object:Gem::Version
-  version: 0.1.15
+  version: 0.1.17
 platform: ruby
 authors:
 - Anton Malinskiy
 - Alexander Bezverhni
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-06-21 00:00:00.000000000 Z
+date: 2026-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -211,13 +211,14 @@ files:
 - spec/fixtures/output_d.xml
 - spec/fixtures/output_e.xml
 - spec/fixtures/output_f.xml
+- spec/fixtures/output_g.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/alexanderbezverhni/danger-jacoco
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -232,8 +233,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.5.3
+signing_key:
 specification_version: 4
 summary: A longer description of danger-jacoco.
 test_files:
@@ -243,5 +244,6 @@ test_files:
 - spec/fixtures/output_d.xml
 - spec/fixtures/output_e.xml
 - spec/fixtures/output_f.xml
+- spec/fixtures/output_g.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb