danger-jacoco-instacart 0.1.12.SNAPSHOT.1 → 0.1.12.SNAPSHOT.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b68f00cbed8e16eb566459431cfb6d296b84b2fec8b87f5e07cb40e513b08b1c
-  data.tar.gz: a14e683220953972e2ee3fa84ff6f4fd795c60701c8108d187a24f710b10eced
+  metadata.gz: 4ff75e66844360f83e9ccff23b81dd5af28d2d373f212caa3275501b4164ea9d
+  data.tar.gz: e93ad8c6350b8935f7ead4660945a58530d893ee44ade1e13b681d0dc3a07c0c
 SHA512:
-  metadata.gz: 0a8ed5dfd7cf494b6e1ceb45f87d06d8666e6f92ec1e31b73a75bdf00a2cc209c67854d3d0eee1eb367b4311ac280a22115fb075d904538f611ccb44ac94d5e7
-  data.tar.gz: 6c2cc47baf7fea31de40f60b531a442a5daad3460b2ecf6360dc6e1860077a4888fff6e9e071c0d4775c87224533e66edf1483586418220953762ed76621399a
+  metadata.gz: 92409828a407f2d31d6990af3fe3a6cb35e95824800b972e71c6ea6ed9e70679206058791fa9754a1ca342ebed7ee68514bfd258f27013d3b219e1c1245f7906
+  data.tar.gz: 69a151c0b3491bcff7546769c9055b0e52a3caa187be0196682b665bfb6a94c33f0fe05165a057f066da22a551801529a488e839bcfb559d461d0e3c0d07e4cf

data/.yardoc/checksums

@@ -1,6 +1,6 @@
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/danger_jacoco.rb 38229d934b3315bb2a5a4eec18eb65f3c54d304f
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 4109fe221b49a7d872a2d1bebf772583ed7c4437
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb 17233d007f6187a47676390d6499ab5c7cb3a2b8
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 1c81f68cb95296bfd592c1b57e0f2e6341f56b55
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb e99030c6a408c1bc77962b844d74c324daecad40
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/sax_parser.rb 370e2799f8dbdf7d642c820214e6ea84c30c9cb0
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/counter.rb 368f4a9811617b7a174ddf837a8fac49a4bc32a6
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/report.rb 7cf45ee71ff347a130320f6190ddb25525c7095d

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.12.SNAPSHOT.1'
+  VERSION = '0.1.12.SNAPSHOT.2'
 end

data/lib/jacoco/plugin.rb

@@ -23,7 +23,7 @@ module Danger
     attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage,
                   :minimum_composable_class_coverage_percentage, :only_check_new_files, :files_extension,
                   :minimum_package_coverage_map, :minimum_class_coverage_map, :fail_no_coverage_data_found,
-                  :title, :class_column_title, :subtitle_success, :subtitle_failure
+                  :title, :class_column_title, :subtitle_success, :subtitle_failure, :file_to_create_on_failure
 
     # Initialize the plugin with configured parameters or defaults
     def setup
@@ -31,6 +31,7 @@ module Danger
       setup_texts
       @only_check_new_files = false unless only_check_new_files
       @files_extension = ['.kt', '.java'] unless files_extension
+      @file_to_create_on_failure = 'danger_jacoco_failure_status_file.txt' unless file_to_create_on_failure
     end
 
     # Initialize the plugin with configured optional texts
@@ -227,29 +228,28 @@ module Danger
 
     # rubocop:disable Style/SignalException
     def report_fails(class_coverage_above_minimum, total_covered)
-      total_failure_message = ''
       if total_covered[:covered] < minimum_project_coverage_percentage
         # fail danger if total coverage is smaller than minimum_project_coverage_percentage
         covered = total_covered[:covered]
-        total_failure_message = "Total coverage of #{covered}%." \
-                                " Improve this to at least #{minimum_project_coverage_percentage}%"
-        fail(total_failure_message)
-        # rubocop:disable Lint/UnreachableCode (rubocop mistakenly thinks that raise is unreachable since priorly called "fail" raises by itself, but in fact "fail" is caught and handled)
-        raise CoverageRequirementsNotMetError, total_failure_message if class_coverage_above_minimum
+        fail("Total coverage of #{covered}%. Improve this to at least #{minimum_project_coverage_percentage}%")
+        # rubocop:disable Lint/UnreachableCode (rubocop mistakenly thinks that this line is unreachable since priorly called "fail" raises an error, but in fact "fail" is caught and handled)
+        create_status_file_on_failure if class_coverage_above_minimum
         # rubocop:enable Lint/UnreachableCode
       end
 
       return if class_coverage_above_minimum
 
-      class_failure_message = 'Class coverage is below minimum.' \
-                              " Improve to at least #{minimum_class_coverage_percentage}%"
-      fail(class_failure_message)
-      # rubocop:disable Lint/UnreachableCode (rubocop mistakenly thinks that raise is unreachable since priorly called "fail" raises by itself, but in fact "fail" is caught and handled)
-      raise CoverageRequirementsNotMetError, "#{total_failure_message}. #{class_failure_message}"
+      fail("Class coverage is below minimum. Improve to at least #{minimum_class_coverage_percentage}%")
+      # rubocop:disable Lint/UnreachableCode (rubocop mistakenly thinks that this line is unreachable since priorly called "fail" raises an error, but in fact "fail" is caught and handled)
+      create_status_file_on_failure
       # rubocop:enable Lint/UnreachableCode
     end
     # rubocop:enable Style/SignalException
 
+    def create_status_file_on_failure
+      File.open(file_to_create_on_failure, 'w') {}
+    end
+
     def markdown_class(parser, report_markdown, report_url, class_to_file_path_hash)
       class_coverage_above_minimum = true
       parser.classes.each do |jacoco_class| # Check metrics for each classes
@@ -275,10 +275,3 @@ module Danger
     end
   end
 end
-
-# Exception that is being thrown when any of the coverage requirements aren't met
-class CoverageRequirementsNotMetError < StandardError
-  def initialize(msg = 'Coverage requirements not met')
-    super
-  end
-end

data/spec/jacoco_spec.rb

@@ -25,6 +25,7 @@ module Danger
 
         allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
         allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
+        allow(File).to receive(:open).and_call_original
       end
 
       it :report do
@@ -33,7 +34,7 @@ module Danger
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%. Class coverage is below minimum. Improve to at least 0%/)
+        @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:errors]).to eq(['Total coverage of 32.9%. Improve this to at least 50%',
                                                           'Class coverage is below minimum. Improve to at least 0%'])
@@ -43,13 +44,44 @@ module Danger
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 100% | :warning: |')
       end
 
+      it 'creates supplied status file upon failure' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 100
+        @my_plugin.minimum_class_coverage_percentage = 60
+        @my_plugin.file_to_create_on_failure = 'kmm.txt'
+
+        expect(File).to receive(:open).with('kmm.txt', 'w')
+        @my_plugin.report path_a
+      end
+
+      it 'creates default status file upon failure' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 60
+
+        expect(File).to receive(:open).with('danger_jacoco_failure_status_file.txt', 'w')
+        @my_plugin.report path_a
+      end
+
+      it 'does _not_ create status file upon success' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 40
+        @my_plugin.file_to_create_on_failure = 'kmm.txt'
+
+        expect(File).to_not receive(:open).with('kmm.txt', 'w')
+        @my_plugin.report path_a
+      end
+
       it 'test regex class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_class_coverage_map = { '.*Repository' => 60 }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%. Class coverage is below minimum. Improve to at least 0%/)
+        @my_plugin.report path_a
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 60% | :warning: |')
       end
 
@@ -59,7 +91,8 @@ module Danger
         @my_plugin.minimum_project_coverage_percentage = 50
         @my_plugin.minimum_package_coverage_map = { 'com/example/' => 70 }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%/)
+        @my_plugin.report path_a
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 70% | :warning: |')
       end
 
@@ -72,7 +105,8 @@ module Danger
           'com/' => 90
         }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%/)
+        @my_plugin.report path_a
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 70% | :warning: |')
       end
 
@@ -85,7 +119,8 @@ module Danger
           'com/' => 30
         }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%/)
+        @my_plugin.report path_a
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 77% | :warning: |')
       end
 
@@ -99,7 +134,8 @@ module Danger
         }
         @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 100 }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%/)
+        @my_plugin.report path_a
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 100% | :warning: |')
       end
 
@@ -113,7 +149,8 @@ module Danger
         }
         @my_plugin.minimum_class_coverage_map = { 'com/example/CachedRepository' => 80 }
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%/)
+        @my_plugin.report path_a
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 80% | :warning: |')
       end
 
@@ -150,7 +187,7 @@ module Danger
         @my_plugin.minimum_class_coverage_percentage = 70
         @my_plugin.only_check_new_files = true
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Class coverage is below minimum. Improve to at least 70%/)
+        @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('### JaCoCo Code Coverage 55.59% :white_check_mark:')
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| Class | Covered | Required | Status |')
@@ -165,7 +202,8 @@ module Danger
         @my_plugin.minimum_class_coverage_percentage = 80
         @my_plugin.minimum_project_coverage_percentage = 50
 
-        expect { @my_plugin.report(path_a, 'http://test.com/') }.to raise_error(CoverageRequirementsNotMetError, /Total coverage of 32.9%. Improve this to at least 50%. Class coverage is below minimum. Improve to at least 80%/)
+        @my_plugin.report(path_a, 'http://test.com/')
+
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| [`com/example/CachedRepository`](http://test.com/com.example/CachedRepository.html) | 50% | 80% | :warning: |')
       end
 
@@ -227,7 +265,7 @@ module Danger
         @my_plugin.minimum_project_coverage_percentage = 30
         @my_plugin.minimum_class_coverage_percentage = 60
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Class coverage is below minimum. Improve to at least 60%/)
+        @my_plugin.report path_a
 
         expected = "### JaCoCo Code Coverage 32.9% :white_check_mark:\n"
         expected += "#### There are classes that do not meet coverage requirement :warning:\n"
@@ -261,7 +299,7 @@ module Danger
         @my_plugin.minimum_class_coverage_percentage = 60
         @my_plugin.subtitle_failure = 'Too bad :('
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Class coverage is below minimum. Improve to at least 60%/)
+        @my_plugin.report path_a
 
         expected = "### JaCoCo Code Coverage 32.9% :white_check_mark:\n"
         expected += "#### Too bad :(\n"
@@ -304,7 +342,7 @@ module Danger
 
         @my_plugin.minimum_class_coverage_percentage = 50
 
-        expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Class coverage is below minimum. Improve to at least 50%/)
+        @my_plugin.report path_a
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 42% | 50% | :warning: |')
       end
@@ -349,7 +387,7 @@ module Danger
           @my_plugin.minimum_class_coverage_percentage = 55
           @my_plugin.minimum_composable_class_coverage_percentage = 45
 
-          expect { @my_plugin.report(path_a) }.to raise_error(CoverageRequirementsNotMetError, /Class coverage is below minimum. Improve to at least 55%/)
+          @my_plugin.report path_a
 
           expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 55% | :warning: |')
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco-instacart
 version: !ruby/object:Gem::Version
-  version: 0.1.12.SNAPSHOT.1
+  version: 0.1.12.SNAPSHOT.2
 platform: ruby
 authors:
 - Anton Malinskiy