danger-jacoco-instacart 0.1.10 → 0.1.12.SNAPSHOT.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9360d314e746b8e23358b48545351a54693c9878bc1d50372e05e5993cd4436d
-  data.tar.gz: 2a07dd89fe99cf04811be5f2f5d7363cf6a08181bd397ffa99f2a235e2377f89
+  metadata.gz: 4ff75e66844360f83e9ccff23b81dd5af28d2d373f212caa3275501b4164ea9d
+  data.tar.gz: e93ad8c6350b8935f7ead4660945a58530d893ee44ade1e13b681d0dc3a07c0c
 SHA512:
-  metadata.gz: 83392c62d27ccb28bfb4b345dc87e11e8f595e558c0339c50b592860c648b09c02e0a0830bb40f57fb1298f3f2c01b74fbfaa050892b15a3e62f66ce7f46d6ff
-  data.tar.gz: f64fc4aade681283072b6acc84c33ae9b2ecec84f0dec1d4bc19bcbc437a85e75175bf3d216a5fbad75e33fb8df8bf44a514380217eae4e99e825af8b8130d01
+  metadata.gz: 92409828a407f2d31d6990af3fe3a6cb35e95824800b972e71c6ea6ed9e70679206058791fa9754a1ca342ebed7ee68514bfd258f27013d3b219e1c1245f7906
+  data.tar.gz: 69a151c0b3491bcff7546769c9055b0e52a3caa187be0196682b665bfb6a94c33f0fe05165a057f066da22a551801529a488e839bcfb559d461d0e3c0d07e4cf

data/.yardoc/checksums

@@ -1,6 +1,6 @@
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/danger_jacoco.rb 38229d934b3315bb2a5a4eec18eb65f3c54d304f
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb fc0b799df58ae240e5bc7ee0aeab413449d1b49f
-/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb faba0fa9900efd1df07bebd0571c4c9f02129b61
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/gem_version.rb 1c81f68cb95296bfd592c1b57e0f2e6341f56b55
+/Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/plugin.rb e99030c6a408c1bc77962b844d74c324daecad40
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/sax_parser.rb 370e2799f8dbdf7d642c820214e6ea84c30c9cb0
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/counter.rb 368f4a9811617b7a174ddf837a8fac49a4bc32a6
 /Users/alexanderbezverhni/workspace/junk/danger-jacoco/lib/jacoco/model/report.rb 7cf45ee71ff347a130320f6190ddb25525c7095d

data/lib/jacoco/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jacoco
-  VERSION = '0.1.10'
+  VERSION = '0.1.12.SNAPSHOT.2'
 end

data/lib/jacoco/plugin.rb

@@ -20,9 +20,10 @@ module Danger
   # @tags jacoco, coverage, java, android, kotlin
   #
   class DangerJacoco < Plugin # rubocop:disable Metrics/ClassLength
-    attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage, :only_check_new_files,
-                  :files_extension, :minimum_package_coverage_map, :minimum_class_coverage_map,
-                  :fail_no_coverage_data_found, :title, :class_column_title, :subtitle_success, :subtitle_failure
+    attr_accessor :minimum_project_coverage_percentage, :minimum_class_coverage_percentage,
+                  :minimum_composable_class_coverage_percentage, :only_check_new_files, :files_extension,
+                  :minimum_package_coverage_map, :minimum_class_coverage_map, :fail_no_coverage_data_found,
+                  :title, :class_column_title, :subtitle_success, :subtitle_failure, :file_to_create_on_failure
 
     # Initialize the plugin with configured parameters or defaults
     def setup
@@ -30,6 +31,7 @@ module Danger
       setup_texts
       @only_check_new_files = false unless only_check_new_files
       @files_extension = ['.kt', '.java'] unless files_extension
+      @file_to_create_on_failure = 'danger_jacoco_failure_status_file.txt' unless file_to_create_on_failure
     end
 
     # Initialize the plugin with configured optional texts
@@ -44,6 +46,7 @@ module Danger
     def setup_minimum_coverages
       @minimum_project_coverage_percentage = 0 unless minimum_project_coverage_percentage
       @minimum_class_coverage_percentage = 0 unless minimum_class_coverage_percentage
+      @minimum_composable_class_coverage_percentage = 0 unless minimum_composable_class_coverage_percentage
       @minimum_package_coverage_map = {} unless minimum_package_coverage_map
       @minimum_class_coverage_map = {} unless minimum_class_coverage_map
     end
@@ -79,9 +82,10 @@ module Danger
       @fail_no_coverage_data_found = fail_no_coverage_data_found
 
       setup
-      classes = classes(delimiter)
+      class_to_file_path_hash = classes(delimiter)
+      classnames = class_to_file_path_hash.keys
 
-      parser = Jacoco::SAXParser.new(classes)
+      parser = Jacoco::SAXParser.new(classnames)
       Nokogiri::XML::SAX::Parser.new(parser).parse(File.open(path))
 
       total_covered = total_coverage(path)
@@ -90,7 +94,7 @@ module Danger
       report_markdown = header
       report_markdown += "| #{class_column_title} | Covered | Required | Status |\n"
       report_markdown += "|:---|:---:|:---:|:---:|\n"
-      class_coverage_above_minimum = markdown_class(parser, report_markdown, report_url)
+      class_coverage_above_minimum = markdown_class(parser, report_markdown, report_url, class_to_file_path_hash)
       subtitle = class_coverage_above_minimum ? subtitle_success : subtitle_failure
       report_markdown.insert(header.length, "#### #{subtitle}\n")
       markdown(report_markdown)
@@ -104,12 +108,17 @@ module Danger
     def classes(delimiter)
       git = @dangerfile.git
       affected_files = only_check_new_files ? git.added_files : git.added_files + git.modified_files
+      class_to_file_path_hash = {}
       affected_files.select { |file| files_extension.reduce(false) { |state, el| state || file.end_with?(el) } }
-                    .map { |file| file.split('.').first.split(delimiter)[1] }
+                    .each do |file| # "src/java/com/example/CachedRepository.java"
+                      classname = file.split('.').first.split(delimiter)[1] # "com/example/CachedRepository"
+                      class_to_file_path_hash[classname] = file
+                    end
+      class_to_file_path_hash
     end
 
     # It returns a specific class code coverage and an emoji status as well
-    def report_class(jacoco_class)
+    def report_class(jacoco_class, file_path)
       report_result = {
         covered: 'No coverage data found : -',
         status: ':black_joker:',
@@ -119,7 +128,7 @@ module Danger
       counter = coverage_counter(jacoco_class)
       unless counter.nil?
         coverage = (counter.covered.fdiv(counter.covered + counter.missed) * 100).floor
-        required_coverage = required_class_coverage(jacoco_class)
+        required_coverage = required_class_coverage(jacoco_class, file_path)
         status = coverage_status(coverage, required_coverage)
 
         report_result = {
@@ -133,13 +142,19 @@ module Danger
     end
 
     # Determines the required coverage for the class
-    def required_class_coverage(jacoco_class)
+    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/CyclomaticComplexity
+    def required_class_coverage(jacoco_class, file_path)
       key = minimum_class_coverage_map.keys.detect { |k| jacoco_class.name.match(k) } || jacoco_class.name
       required_coverage = minimum_class_coverage_map[key]
+      includes_composables = File.read(file_path).include? '@Composable' if File.exist?(file_path)
+      required_coverage = minimum_composable_class_coverage_percentage if required_coverage.nil? && includes_composables
       required_coverage = package_coverage(jacoco_class.name) if required_coverage.nil?
       required_coverage = minimum_class_coverage_percentage if required_coverage.nil?
       required_coverage
     end
+    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/CyclomaticComplexity
 
     # it returns the most suitable coverage by package name to class or nil
     def package_coverage(class_name)
@@ -184,10 +199,8 @@ module Danger
     private
 
     def coverage_counter(jacoco_class)
-      counters = jacoco_class.counters
-      branch_counter = counters.detect { |e| e.type.eql? 'BRANCH' }
-      line_counter = counters.detect { |e| e.type.eql? 'LINE' }
-      counter = branch_counter.nil? ? line_counter : branch_counter
+      all_class_counters = jacoco_class.counters
+      counter = class_counter(all_class_counters)
 
       if counter.nil?
         no_coverage_data_found_message = "No coverage data found for #{jacoco_class.name}"
@@ -200,24 +213,48 @@ module Danger
       counter
     end
 
+    def class_counter(all_class_counters)
+      instruction_counter = all_class_counters.detect { |e| e.type.eql? 'INSTRUCTION' }
+      branch_counter = all_class_counters.detect { |e| e.type.eql? 'BRANCH' }
+      line_counter = all_class_counters.detect { |e| e.type.eql? 'LINE' }
+      if !instruction_counter.nil?
+        instruction_counter
+      elsif !branch_counter.nil?
+        branch_counter
+      else
+        line_counter
+      end
+    end
+
     # rubocop:disable Style/SignalException
     def report_fails(class_coverage_above_minimum, total_covered)
       if total_covered[:covered] < minimum_project_coverage_percentage
         # fail danger if total coverage is smaller than minimum_project_coverage_percentage
         covered = total_covered[:covered]
         fail("Total coverage of #{covered}%. Improve this to at least #{minimum_project_coverage_percentage}%")
+        # rubocop:disable Lint/UnreachableCode (rubocop mistakenly thinks that this line is unreachable since priorly called "fail" raises an error, but in fact "fail" is caught and handled)
+        create_status_file_on_failure if class_coverage_above_minimum
+        # rubocop:enable Lint/UnreachableCode
       end
 
       return if class_coverage_above_minimum
 
       fail("Class coverage is below minimum. Improve to at least #{minimum_class_coverage_percentage}%")
+      # rubocop:disable Lint/UnreachableCode (rubocop mistakenly thinks that this line is unreachable since priorly called "fail" raises an error, but in fact "fail" is caught and handled)
+      create_status_file_on_failure
+      # rubocop:enable Lint/UnreachableCode
     end
     # rubocop:enable Style/SignalException
 
-    def markdown_class(parser, report_markdown, report_url)
+    def create_status_file_on_failure
+      File.open(file_to_create_on_failure, 'w') {}
+    end
+
+    def markdown_class(parser, report_markdown, report_url, class_to_file_path_hash)
       class_coverage_above_minimum = true
       parser.classes.each do |jacoco_class| # Check metrics for each classes
-        rp = report_class(jacoco_class)
+        file_path = class_to_file_path_hash[jacoco_class.name]
+        rp = report_class(jacoco_class, file_path)
         rl = report_link(jacoco_class.name, report_url)
         ln = "| #{rl} | #{rp[:covered]}% | #{rp[:required_coverage_percentage]}% | #{rp[:status]} |\n"
         report_markdown << ln

data/spec/fixtures/output_a.xml

@@ -10,7 +10,7 @@
         <counter type="COMPLEXITY" missed="0" covered="1"/>
         <counter type="METHOD" missed="0" covered="1"/>
       </method>
-      <counter type="INSTRUCTION" missed="0" covered="46"/>
+      <counter type="INSTRUCTION" missed="46" covered="46"/>
       <counter type="LINE" missed="0" covered="14"/>
       <counter type="COMPLEXITY" missed="5" covered="7"/>
       <counter type="METHOD" missed="0" covered="7"/>

data/spec/fixtures/output_b.xml

@@ -9,7 +9,6 @@
         <counter type="COMPLEXITY" missed="0" covered="1"/>
         <counter type="METHOD" missed="0" covered="1"/>
       </method>
-      <counter type="INSTRUCTION" missed="0" covered="46"/>
       <counter type="COMPLEXITY" missed="5" covered="7"/>
       <counter type="METHOD" missed="0" covered="7"/>
       <counter type="CLASS" missed="0" covered="1"/>
@@ -17,7 +16,6 @@
     <sourcefile name="CachedRepository.java">
       <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
       <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
-      <counter type="INSTRUCTION" missed="2" covered="98"/>
       <counter type="COMPLEXITY" missed="2" covered="11"/>
       <counter type="METHOD" missed="2" covered="11"/>
       <counter type="CLASS" missed="2" covered="4"/>

data/spec/fixtures/output_c.xml

@@ -10,7 +10,7 @@
         <counter type="COMPLEXITY" missed="0" covered="1"/>
         <counter type="METHOD" missed="0" covered="1"/>
       </method>
-      <counter type="INSTRUCTION" missed="0" covered="46"/>
+      <counter type="INSTRUCTION" missed="46" covered="46"/>
       <counter type="LINE" missed="0" covered="14"/>
       <counter type="COMPLEXITY" missed="5" covered="7"/>
       <counter type="METHOD" missed="0" covered="7"/>
@@ -41,7 +41,7 @@
         <counter type="COMPLEXITY" missed="0" covered="1"/>
         <counter type="METHOD" missed="0" covered="1"/>
       </method>
-      <counter type="INSTRUCTION" missed="0" covered="36"/>
+      <counter type="INSTRUCTION" missed="18" covered="36"/>
       <counter type="LINE" missed="0" covered="12"/>
       <counter type="COMPLEXITY" missed="5" covered="8"/>
       <counter type="METHOD" missed="0" covered="9"/>

data/spec/fixtures/output_d.xml

@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.0//EN"
+        "report.dtd">
+<report name="test_report">
+  <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
+  <package name="com/example">
+    <class name="com/example/CachedRepository">
+      <method name="&lt;init&gt;" desc="()V" line="17">
+        <counter type="INSTRUCTION" missed="0" covered="11"/>
+        <counter type="COMPLEXITY" missed="0" covered="1"/>
+        <counter type="METHOD" missed="0" covered="1"/>
+      </method>
+      <counter type="INSTRUCTION" missed="46" covered="118"/>
+      <counter type="LINE" missed="1" covered="14"/>
+      <counter type="COMPLEXITY" missed="5" covered="7"/>
+      <counter type="METHOD" missed="0" covered="7"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+      <counter type="BRANCH" missed="2" covered="3" />
+    </class>
+    <sourcefile name="CachedRepository.java">
+      <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
+      <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
+      <counter type="COMPLEXITY" missed="2" covered="11"/>
+      <counter type="METHOD" missed="2" covered="11"/>
+      <counter type="CLASS" missed="2" covered="4"/>
+    </sourcefile>
+    <counter type="INSTRUCTION" missed="80" covered="324"/>
+    <counter type="COMPLEXITY" missed="11" covered="39"/>
+    <counter type="METHOD" missed="9" covered="37"/>
+    <counter type="CLASS" missed="2" covered="10"/>
+  </package>
+  <counter type="INSTRUCTION" missed="39399" covered="19321"/>
+  <counter type="COMPLEXITY" missed="5517" covered="1444"/>
+  <counter type="METHOD" missed="3382" covered="1120"/>
+  <counter type="CLASS" missed="491" covered="370"/>
+</report>

data/spec/fixtures/output_e.xml

@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.0//EN"
+        "report.dtd">
+<report name="test_report">
+  <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
+  <package name="com/example">
+    <class name="com/example/CachedRepository">
+      <method name="&lt;init&gt;" desc="()V" line="17">
+        <counter type="INSTRUCTION" missed="0" covered="11"/>
+        <counter type="COMPLEXITY" missed="0" covered="1"/>
+        <counter type="METHOD" missed="0" covered="1"/>
+      </method>
+      <counter type="LINE" missed="1" covered="14"/>
+      <counter type="COMPLEXITY" missed="5" covered="7"/>
+      <counter type="METHOD" missed="0" covered="7"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+      <counter type="BRANCH" missed="4" covered="3" />
+    </class>
+    <sourcefile name="CachedRepository.java">
+      <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
+      <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
+      <counter type="COMPLEXITY" missed="2" covered="11"/>
+      <counter type="METHOD" missed="2" covered="11"/>
+      <counter type="CLASS" missed="2" covered="4"/>
+    </sourcefile>
+    <counter type="INSTRUCTION" missed="80" covered="324"/>
+    <counter type="COMPLEXITY" missed="11" covered="39"/>
+    <counter type="METHOD" missed="9" covered="37"/>
+    <counter type="CLASS" missed="2" covered="10"/>
+  </package>
+  <counter type="INSTRUCTION" missed="39399" covered="19321"/>
+  <counter type="COMPLEXITY" missed="5517" covered="1444"/>
+  <counter type="METHOD" missed="3382" covered="1120"/>
+  <counter type="CLASS" missed="491" covered="370"/>
+</report>

data/spec/fixtures/output_f.xml

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?><!DOCTYPE report PUBLIC "-//JACOCO//DTD Report 1.0//EN"
+        "report.dtd">
+<report name="test_report">
+  <sessioninfo id="test-id" start="1480057517395" dump="1480057526412"/>
+  <package name="com/example">
+    <class name="com/example/CachedRepository">
+      <method name="&lt;init&gt;" desc="()V" line="17">
+        <counter type="INSTRUCTION" missed="0" covered="11"/>
+        <counter type="COMPLEXITY" missed="0" covered="1"/>
+        <counter type="METHOD" missed="0" covered="1"/>
+      </method>
+      <counter type="LINE" missed="1" covered="14"/>
+      <counter type="COMPLEXITY" missed="5" covered="7"/>
+      <counter type="METHOD" missed="0" covered="7"/>
+      <counter type="CLASS" missed="0" covered="1"/>
+    </class>
+    <sourcefile name="CachedRepository.java">
+      <line nr="16" mi="0" ci="2" mb="0" cb="0"/>
+      <line nr="17" mi="0" ci="3" mb="0" cb="0"/>
+      <counter type="COMPLEXITY" missed="2" covered="11"/>
+      <counter type="METHOD" missed="2" covered="11"/>
+      <counter type="CLASS" missed="2" covered="4"/>
+    </sourcefile>
+    <counter type="INSTRUCTION" missed="80" covered="324"/>
+    <counter type="COMPLEXITY" missed="11" covered="39"/>
+    <counter type="METHOD" missed="9" covered="37"/>
+    <counter type="CLASS" missed="2" covered="10"/>
+  </package>
+  <counter type="INSTRUCTION" missed="39399" covered="19321"/>
+  <counter type="COMPLEXITY" missed="5517" covered="1444"/>
+  <counter type="METHOD" missed="3382" covered="1120"/>
+  <counter type="CLASS" missed="491" covered="370"/>
+</report>

data/spec/jacoco_spec.rb

@@ -25,6 +25,7 @@ module Danger
 
         allow(@dangerfile.git).to receive(:modified_files).and_return(modified_files)
         allow(@dangerfile.git).to receive(:added_files).and_return(added_files)
+        allow(File).to receive(:open).and_call_original
       end
 
       it :report do
@@ -43,6 +44,36 @@ module Danger
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 100% | :warning: |')
       end
 
+      it 'creates supplied status file upon failure' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_project_coverage_percentage = 100
+        @my_plugin.minimum_class_coverage_percentage = 60
+        @my_plugin.file_to_create_on_failure = 'kmm.txt'
+
+        expect(File).to receive(:open).with('kmm.txt', 'w')
+        @my_plugin.report path_a
+      end
+
+      it 'creates default status file upon failure' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 60
+
+        expect(File).to receive(:open).with('danger_jacoco_failure_status_file.txt', 'w')
+        @my_plugin.report path_a
+      end
+
+      it 'does _not_ create status file upon success' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 40
+        @my_plugin.file_to_create_on_failure = 'kmm.txt'
+
+        expect(File).to_not receive(:open).with('kmm.txt', 'w')
+        @my_plugin.report path_a
+      end
+
       it 'test regex class coverage' do
         path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
 
@@ -295,6 +326,72 @@ module Danger
 
         expect(@dangerfile.status_report[:markdowns][0].message).to include('| New files | Covered | Required | Status |')
       end
+
+      it 'instruction coverage takes over all the rest coverages for classes' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_d.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 50
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 71% | 50% | :white_check_mark: |')
+      end
+
+      it 'branch coverage takes over line coverage for classes, when instruction coverage is not available' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_e.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 50
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 42% | 50% | :warning: |')
+      end
+
+      it 'line coverage takes over for classes, when both instruction coverage and branch coverage are not available' do
+        path_a = "#{File.dirname(__FILE__)}/fixtures/output_f.xml"
+
+        @my_plugin.minimum_class_coverage_percentage = 50
+
+        @my_plugin.report path_a
+
+        expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 93% | 50% | :white_check_mark: |')
+      end
+
+      describe 'with CachedRepository containing @Composable annotation' do
+        before do
+          allow(File).to receive(:exist?).with('src/java/com/example/CachedRepository.java').and_return(true)
+          allow(File).to receive(:read).with('src/java/com/example/CachedRepository.java').and_return('package com.kevin.mia.mikaela class Vika { @Composable fun someUiWidget() {} }')
+        end
+
+        it 'applies minimum_composable_class_coverage_percentage' do
+          path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+          @my_plugin.minimum_class_coverage_percentage = 55
+          @my_plugin.minimum_composable_class_coverage_percentage = 45
+
+          @my_plugin.report path_a
+
+          expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 45% | :white_check_mark: |')
+        end
+      end
+
+      describe 'with CachedRepository _not_ containing @Composable annotation' do
+        before do
+          allow(File).to receive(:exist?).with('src/java/com/example/CachedRepository.java').and_return(true)
+          allow(File).to receive(:read).with('src/java/com/example/CachedRepository.java').and_return('package com.kevin.mia.mikaela class Vika { fun main() {} }')
+        end
+
+        it 'does not apply minimum_composable_class_coverage_percentage' do
+          path_a = "#{File.dirname(__FILE__)}/fixtures/output_a.xml"
+
+          @my_plugin.minimum_class_coverage_percentage = 55
+          @my_plugin.minimum_composable_class_coverage_percentage = 45
+
+          @my_plugin.report path_a
+
+          expect(@dangerfile.status_report[:markdowns][0].message).to include('| `com/example/CachedRepository` | 50% | 55% | :warning: |')
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-jacoco-instacart
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.12.SNAPSHOT.2
 platform: ruby
 authors:
 - Anton Malinskiy
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-24 00:00:00.000000000 Z
+date: 2022-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -208,6 +208,9 @@ files:
 - spec/fixtures/output_a.xml
 - spec/fixtures/output_b.xml
 - spec/fixtures/output_c.xml
+- spec/fixtures/output_d.xml
+- spec/fixtures/output_e.xml
+- spec/fixtures/output_f.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/alexanderbezverhni/danger-jacoco
@@ -225,9 +228,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.1.2
 signing_key: 
@@ -237,5 +240,8 @@ test_files:
 - spec/fixtures/output_a.xml
 - spec/fixtures/output_b.xml
 - spec/fixtures/output_c.xml
+- spec/fixtures/output_d.xml
+- spec/fixtures/output_e.xml
+- spec/fixtures/output_f.xml
 - spec/jacoco_spec.rb
 - spec/spec_helper.rb