danger-ios_version_change 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a3c642c9a5bcebbf4dc0e46539485292f87e2b67
-  data.tar.gz: bbcb141e85319ac865ae3585f2ef264fa55a53cc
+SHA256:
+  metadata.gz: 2645f1de3d4e8d2c245e6303d72feb01434be32faa98f3a59837e9b33eb08139
+  data.tar.gz: 13d0bd35e9211988669dd039c1e18fff7f19159dcbaccdb619ba54a64073760f
 SHA512:
-  metadata.gz: 7fbb75d98296c3e440b5a51ac510ceea2c7e7d273a3a5d23961ddbd706a48b85525766d3dbd0966b4c2c5f0b099180dc085d0f08c5b0dcbcf892c2307f7fe796
-  data.tar.gz: 3ad2b3e26a3eadc900b487245a04210538811066bab47c55e0e959320a73ec561a2e4c6a928cd18bc300796fe0041046ddbff0e04dee172c11a03e057da7388a
+  metadata.gz: 5cf11ca626ccf4027f41ea0186dda2ff80f5720f941011aaddf90278124072c05492549a6eee9f9103b063850df779d5f21feccfe37c2789ac25621e266d8360
+  data.tar.gz: c1cafd9e2584cad7e78699818f04639ca6cda815e099979c00979339a8370848185f001ae00475fb8fd86d26ab9e622847eabac13359e99acf366354af091fbc

data/.circleci/config.yml

@@ -16,6 +16,14 @@ jobs:
         key: Gemfile-{{ checksum "Gemfile.lock" }}
         paths:
           - vendor/bundle
+  danger:
+    docker:
+      - image: dantoml/danger:latest
+    steps:
+      - checkout
+      - run: ./assert_danger_running_on_pr.sh
+      - run: bundle install
+      - run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && danger || echo "Skipping Danger for External Contributor" && exit 1'
   test-lint:
     working_directory: ~/code
     docker:
@@ -46,11 +54,7 @@ jobs:
       - run:
           name: Bundle Install
           command: bundle install --path vendor/bundle
-      - run: gem build danger-ios_version_change.gemspec; mkdir output-gems; mv danger-ios_version_change*.gem output-gems/
-      - persist_to_workspace:
-          root: output-gems
-          paths:
-            - danger-ios_version_change*.gem
+      - run: gem build danger-ios_version_change.gemspec
   deploy:
     working_directory: ~/code
     docker:
@@ -68,13 +72,12 @@ jobs:
       - run:
           name: Create rubygems credientials file
           command: mkdir ~/.gem; printf "%s\n%s " "---" ":rubygems_api_key:" > ~/.gem/credentials; printf $RUBYGEMS_KEY >> ~/.gem/credentials;chmod 0600 ~/.gem/credentials
-      - attach_workspace:
-          at: output-gems
-      - run: gem push output-gems/danger-ios_version_change-*.gem
+      - run: gem build danger-ios_version_change.gemspec; gem push danger-ios_version_change*.gem
 workflows:
   version: 2
   test-lint:
     jobs:
+      - danger
       - dependencies
       - test-lint:
           requires:

data/Dangerfile

@@ -0,0 +1,6 @@
+if github.branch_for_base == "master"
+  diff = git.diff_for_file("lib/ios_version_change/gem_version.rb")
+  if !diff
+    fail 'You did not update the gem version.'
+  end
+end

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    danger-ios_version_change (0.1.0)
+    danger-ios_version_change (0.1.4)
       danger-plugin-api (~> 1.0)
+      git
 
 GEM
   remote: https://rubygems.org/

data/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,3 @@
+- [ ] Update `lib/ios_version_change/gem_version.rb` to latest version. Bump it! 
+- [ ] Tests all pass. 
+- [ ] After merge, make a git tag release. 

data/assert_danger_running_on_pr.sh

@@ -0,0 +1,4 @@
+if [[ -z "${CI_PULL_REQUESTS}" ]]; then
+  echo -e "\033[31merror: Danger requires a pull request to function correctly\033[0m"
+  exit 1
+fi

data/lib/ios_version_change/gem_version.rb

@@ -1,3 +1,3 @@
 module IosVersionChange
-  VERSION = "0.1.3".freeze
+  VERSION = "0.1.4".freeze
 end

data/lib/ios_version_change/plugin.rb

@@ -18,6 +18,13 @@ module Danger
       "ios_version_change"
     end
 
+    def initialize(dangerfile)
+      super(dangerfile)
+      raise unless dangerfile.env.scm.class == Danger::GitRepo
+
+      @git = dangerfile.env.scm
+    end
+
     # Ignore. Pass the git diff string here to see if the version string has been updated. Use `ios_version_change.assert_version_changed("ProjectName/Info.plist")` instead as it's more convenient sending the path to the Info.plist file.
     # @return [void]
     def assert_version_changed_diff(git_diff_string)
@@ -48,8 +55,7 @@ module Danger
         return # rubocop:disable UnreachableCode
       end
 
-      git = Git.open(Dir.pwd)
-      git_diff_string = git.diff[info_plist_file_path].patch
+      git_diff_string = @git.diff[info_plist_file_path].patch
       assert_version_changed_diff(git_diff_string)
     end
   end

data/spec/ios_version_change_spec.rb

@@ -2,10 +2,6 @@ require File.expand_path("../spec_helper", __FILE__)
 
 module Danger
   describe Danger::DangerIosVersionChange do
-    it "should be a plugin" do
-      expect(Danger::DangerIosVersionChange.new(nil)).to be_a Danger::Plugin
-    end
-
     #
     # You should test your custom attributes and methods here
     #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-ios_version_change
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Levi Bostian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2017-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
@@ -175,14 +175,17 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- Dangerfile
 - Gemfile
 - Gemfile.lock
 - Guardfile
 - LICENSE.txt
+- PULL_REQUEST_TEMPLATE.md
 - README.md
 - README_footer.md
 - README_header.md
 - Rakefile
+- assert_danger_running_on_pr.sh
 - danger-ios_version_change.gemspec
 - lib/danger_ios_version_change.rb
 - lib/danger_plugin.rb
@@ -213,7 +216,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Assert your iOS project has changed it's version number in the XCode project.