danger-iblinter 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0baf75368108ddea857f6488eb5ffe335684602d3b536b0c3a156ebf4e62684
-  data.tar.gz: 9195b9a5dd0b940c822d7ff8814b5581685f8c75fe6ce243baa6d4eb8120d1fb
+  metadata.gz: aa96840e7a75d39b61f6752ecc22aae644507303a7d11e2e8947f29bef446c76
+  data.tar.gz: e806d6bd3b8f9e1d278ad78f538e01f9c643910575b1a2e06a7ed843a293029e
 SHA512:
-  metadata.gz: 39b02ae54f23390ac9f1b16328a334c5b663c110157dfab486a6a2885ff4b4bd3fb417419e53c4f6406c493a99a65fb988da7e74b08cc28063dff380a785ab6c
-  data.tar.gz: 58aa98104a0775d453c2f6242575e172b2266670cd5c6ea4c7975aeaa39c9f78697858dc3195ae92da8c689da79d753147526c865a951c4261c8459422b12f18
+  metadata.gz: cbf6b3764524e7a6db35f0536a20438d6bd437f5008d815dc907bdcaf974f413320104dc8f3ecead27cdfc06e97fbc51f10eb2acba5aaa48e9ec4ba677ffc3da
+  data.tar.gz: 01bd524e489a2f76b22894b2f65b5b8a243d3a081fef2ffe078326a5b8f2d46dcd61550b33dc0f0969ae695b160c1fad43f6214bb5b68a814c7476ec0edbed57

data/.travis.yml

@@ -4,9 +4,7 @@ cache:
     - bundle
 
 rvm:
-  - 2.0
-  - 2.1.3
   - 2.3.1
 
 script:
-    - bundle exec rake spec
+    - bundle exec rake spec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-iblinter (0.0.1)
+    danger-iblinter (0.0.2)
       danger-plugin-api (~> 1.0)
 
 GEM

data/README.md

@@ -1,11 +1,13 @@
 # Danger IBLinter
 
+[![Build Status](https://travis-ci.org/IBDecodable/danger-ruby-iblinter.svg?branch=master)](https://travis-ci.org/IBDecodable/danger-ruby-iblinter)
+
 A danger plugin for IBLinter.
 
 ## Installation
 
 ```ruby
-gem 'danger-swiftlint'
+gem 'danger-iblinter'
 ```
 
 This plugin requires `iblinter` executable binary.

data/danger-iblinter.gemspec

@@ -5,7 +5,7 @@ require 'iblinter/gem_version.rb'
 
 Gem::Specification.new do |spec|
   spec.name          = 'danger-iblinter'
-  spec.version       = IBLinter::VERSION
+  spec.version       = Iblinter::VERSION
   spec.authors       = ['Yuta Saito']
   spec.email         = ['kateinoigakukun@gmail.com']
   spec.description   = %q{A danger plugin for linting Interface Builder files with IBLinter.}

data/lib/iblinter/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
-module IBLinter
-  VERSION = "0.0.1"
+module Iblinter
+  VERSION = "0.0.2"
 end

data/lib/iblinter/iblinter.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-class IBLinter
+class IBLinterRunner
   def initialize(binary_path)
     @binary_path = binary_path
   end
@@ -10,8 +10,9 @@ class IBLinter
   end
 
   def lint(path, options)
+    command = lint_command(options)
     Dir.chdir path
-    JSON.parse(run(lint_command(options)))
+    JSON.parse(run(command))
   end
 
   def lint_command(options)

data/lib/iblinter/plugin.rb

@@ -14,7 +14,7 @@ module Danger
   # @see  IBDecodable/IBLinter
   # @tags swift
   #
-  class DangerIBLinter < Plugin
+  class DangerIblinter < Plugin
     # The path to IBLinter"s execution
     # @return  [void]
     attr_accessor :binary_path
@@ -23,7 +23,7 @@ module Danger
     # @return   [void]
     #
     def lint(path = Dir.pwd, fail_on_warning: false, inline_mode: true, options: {})
-      raise "iblinter is not installed" unless File.exist? @binary_path
+      raise "iblinter is not installed" unless iblinter_installed?
 
       issues = iblinter.lint(path, options)
       return if issues.empty?
@@ -49,13 +49,21 @@ module Danger
     end
 
     # Instantiate iblinter
-    # @return     [IBLinter]
+    # @return     [IBLinterRunner]
     def iblinter
-      IBLinter.new(@binary_path)
+      IBLinterRunner.new(@binary_path)
     end
 
     private
 
+    def iblinter_installed?
+      if !@binary_path.nil? && File.exist?(@binary_path)
+        return true
+      end
+
+      !`which iblinter`.empty?
+    end
+
     def markdown_issues(results, heading, emoji)
       message = "#### #{heading}\n\n"
 

data/spec/iblinter_spec.rb

@@ -3,12 +3,12 @@
 require File.expand_path("spec_helper", __dir__)
 require_relative "../lib/iblinter/iblinter"
 
-describe IBLinter do
+describe IBLinterRunner do
   it "command arguments works" do
     binary_path = File.absolute_path "path/to/binary"
     options = {}
     cmd = "#{binary_path} lint --reporter json"
-    iblinter = IBLinter.new(binary_path)
+    iblinter = IBLinterRunner.new(binary_path)
     expect(iblinter.lint_command(options)).to eq cmd
   end
 end

data/spec/plugin_spec.rb

@@ -3,9 +3,9 @@
 require File.expand_path("spec_helper", __dir__)
 
 module Danger
-  describe Danger::DangerIBLinter do
+  describe Danger::DangerIblinter do
     it "should be a plugin" do
-      expect(Danger::DangerIBLinter.new(nil)).to be_a Danger::Plugin
+      expect(Danger::DangerIblinter.new(nil)).to be_a Danger::Plugin
     end
 
     describe "with Dangerfile" do
@@ -20,7 +20,7 @@ module Danger
       end
 
       it "inline comment works with relative path" do
-        linter = IBLinter.new("/path/to/binary")
+        linter = IBLinterRunner.new("/path/to/binary")
         allow(linter).to receive(:lint) do
           JSON.parse(File.read(File.dirname(__FILE__) + "/support/fixtures/iblinter.json"))
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: danger-iblinter
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Yuta Saito