danger-dangermattic 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20a5e57d91cc796def3533c72a3a674ea494356982fa78015ccc016ce19b61c9
-  data.tar.gz: 376d14c60ba7aadc6107b4a6de9a40dc968a658a0fe326aaad208866bf4583e9
+  metadata.gz: ad580440b78f9c9bd16790cb679c1a38a2ab32f22e9936f12e88398cef578a9f
+  data.tar.gz: ca179653e7759647821a2653f659ff04d56d38ce725993a31454f493180f1ffa
 SHA512:
-  metadata.gz: 10ed4e5e5772cc7631470fe591c79004a5a237ddaffb6c708204d4823a204f15cc068530c5e8b05bc0f150577037f93bcb675a93ae47eb4c71a5d1b245e658fe
-  data.tar.gz: 06c85ea386f290706300db05c3a07439859bda94d025a6dd9bab9068786a2040b247c09c8d1314c31f44c09d07e5aded50434d3092c55aeca1ff9fce2aad78d2
+  metadata.gz: a30553a0ff163ac72fa5492fc6db0047bf8e7569241a8cdce1de71bf8e8224703a271ca32afe0947ba61a751bcfbb048ed744c22e527513a2d0ae26adbd40ef0
+  data.tar.gz: f7657a8e47f25a63169a0e965a067792df749ee3fd8468199744dff509083f8b292da4475bef161bd38edcfe3acbf1c747e7a929d24136b3cd59bce0130e408c

data/CHANGELOG.md

@@ -20,6 +20,12 @@ _None_
 
 _None_
 
+## 1.2.4
+
+### Internal Changes
+
+- `pr_size_checker` and `manifest_pr_checker`: optimize performance for large PRs [#103]
+
 ## 1.2.3
 
 ### Bug Fixes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-dangermattic (1.2.3)
+    danger-dangermattic (1.2.4)
       danger (~> 9.4)
       danger-plugin-api (~> 1.0)
       danger-rubocop (~> 0.13)

data/lib/dangermattic/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dangermattic
-  VERSION = '1.2.3'
+  VERSION = '1.2.4'
 end

data/lib/dangermattic/plugins/manifest_pr_checker.rb

@@ -115,13 +115,19 @@ module Danger
     private
 
     def check_manifest_lock_updated(file_name:, lock_file_name:, instruction:, report_type: :warning)
+      all_files = git_utils.all_changed_files
+
       # Find all the modified manifest files
-      manifest_modified_files = git_utils.all_changed_files.select { |f| File.basename(f) == file_name }
+      manifest_modified_files = all_files.select { |f| File.basename(f) == file_name }
+
+      # Build a hash mapping directory -> set of basenames for O(1) lookup
+      files_by_dir = all_files.group_by { |f| File.dirname(f) }
+                              .transform_values { |files| files.to_set { |f| File.basename(f) } }
 
       # For each manifest file, check if the corresponding lockfile (in the same dir) was also modified
       manifest_modified_files.each do |manifest_file|
-        lockfile_modified = git_utils.all_changed_files.any? { |f| File.dirname(f) == File.dirname(manifest_file) && File.basename(f) == lock_file_name }
-        next if lockfile_modified
+        manifest_dir = File.dirname(manifest_file)
+        next if files_by_dir[manifest_dir]&.include?(lock_file_name)
 
         message = format(MESSAGE, manifest_file, lock_file_name, instruction)
         reporter.report(message: message, type: report_type)
@@ -129,11 +135,10 @@ module Danger
     end
 
     def check_manifest_lock_updated_strict(manifest_path:, manifest_lock_path:, instruction:, report_type: :warning)
-      manifest_modified = git_utils.all_changed_files.include?(manifest_path)
-      return unless manifest_modified
+      all_files_set = git_utils.all_changed_files.to_set
 
-      lockfile_modified = git_utils.all_changed_files.include?(manifest_lock_path)
-      return if lockfile_modified
+      return unless all_files_set.include?(manifest_path)
+      return if all_files_set.include?(manifest_lock_path)
 
       message = format(MESSAGE, manifest_path, File.basename(manifest_lock_path), instruction)
       reporter.report(message: message, type: report_type)

data/lib/dangermattic/plugins/pr_size_checker.rb

@@ -76,13 +76,12 @@ module Danger
     def insertions_size(file_selector: nil)
       return danger.git.insertions unless file_selector
 
-      filtered_files = git_utils.all_changed_files.select(&file_selector)
+      # Only check added and modified files - deleted files have 0 insertions
+      filtered_files = git_utils.added_and_modified_files.select(&file_selector)
 
       filtered_files.sum do |file|
-        # stats for a file in the GitHub API might be nil, making `info_for_file()` crash
-        next 0 if danger.git.diff.stats[:files][file].nil?
-
-        danger.git.info_for_file(file)&.[](:insertions).to_i
+        # Use cached stats directly instead of calling info_for_file for each file
+        danger.git.diff.stats[:files][file]&.[](:insertions).to_i
       end
     end
 
@@ -97,10 +96,8 @@ module Danger
       filtered_files = git_utils.all_changed_files.select(&file_selector)
 
       filtered_files.sum do |file|
-        # stats for a file in the GitHub API might be nil, making `info_for_file()` crash
-        next 0 if danger.git.diff.stats[:files][file].nil?
-
-        danger.git.info_for_file(file)&.[](:deletions).to_i
+        # Use cached stats directly instead of calling info_for_file for each file
+        danger.git.diff.stats[:files][file]&.[](:deletions).to_i
       end
     end
 
@@ -115,10 +112,11 @@ module Danger
       filtered_files = git_utils.all_changed_files.select(&file_selector)
 
       filtered_files.sum do |file|
-        # stats for a file in the GitHub API might be nil, making `info_for_file()` crash
-        next 0 if danger.git.diff.stats[:files][file].nil?
+        # Use cached stats directly instead of calling info_for_file for each file
+        stats = danger.git.diff.stats[:files][file]
+        next 0 unless stats
 
-        danger.git.info_for_file(file)&.[](:deletions).to_i + danger.git.info_for_file(file)&.[](:insertions).to_i
+        stats[:deletions].to_i + stats[:insertions].to_i
       end
     end
   end

data/spec/pr_size_checker_spec.rb

@@ -146,19 +146,20 @@ module Danger
             allow(@plugin.git).to receive_messages(added_files: [added_config, added_file], modified_files: [modified_file1, modified_file2, added_test_file, modified_strings], deleted_files: [deleted_file1, deleted_test_file, deleted_strings, deleted_file2])
 
             allow(@plugin.git).to receive(:diff).and_return(instance_double(Git::Diff))
-            expected_files = { added_test_file => {}, added_config => {}, added_file => {}, modified_file1 => {}, modified_file2 => {}, modified_strings => {}, deleted_file1 => {}, deleted_file2 => {}, deleted_test_file => {}, deleted_strings => {} }
+            # Populate stats hash directly with insertions/deletions data for the optimized code path
+            expected_files = {
+              added_test_file => { insertions: 201 },
+              added_config => { insertions: 311 },
+              added_file => { insertions: 13 },
+              modified_file1 => { insertions: 127, deletions: 159 },
+              modified_file2 => { insertions: 43, deletions: 37 },
+              modified_strings => { insertions: 432, deletions: 297 },
+              deleted_file1 => { deletions: 246 },
+              deleted_file2 => { deletions: 493 },
+              deleted_test_file => { deletions: 222 },
+              deleted_strings => { deletions: 593 }
+            }
             allow(@plugin.git.diff).to receive(:stats).and_return({ files: expected_files })
-
-            allow(@plugin.git).to receive(:info_for_file).with(added_test_file).and_return({ insertions: 201 })
-            allow(@plugin.git).to receive(:info_for_file).with(added_config).and_return({ insertions: 311 })
-            allow(@plugin.git).to receive(:info_for_file).with(added_file).and_return({ insertions: 13 })
-            allow(@plugin.git).to receive(:info_for_file).with(modified_file1).and_return({ insertions: 127, deletions: 159 })
-            allow(@plugin.git).to receive(:info_for_file).with(modified_file2).and_return({ insertions: 43, deletions: 37 })
-            allow(@plugin.git).to receive(:info_for_file).with(modified_strings).and_return({ insertions: 432, deletions: 297 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_file1).and_return({ deletions: 246 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_file2).and_return({ deletions: 493 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_test_file).and_return({ deletions: 222 })
-            allow(@plugin.git).to receive(:info_for_file).with(deleted_strings).and_return({ deletions: 593 })
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-dangermattic
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Automattic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-25 00:00:00.000000000 Z
+date: 2025-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger